Re: [Patch v2 02/11] s5p-mfc: Adding initial support for MFC v10.10

2017-03-19 Thread Smitha T Murthy
On Wed, 2017-03-15 at 14:52 -0500, Rob Herring wrote: > On Fri, Mar 03, 2017 at 02:37:07PM +0530, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > Signed-off-by: Smitha T Murthy > >

cron job: media_tree daily build: ERRORS

2017-03-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Mar 20 05:00:15 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build git

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Mauro Carvalho Chehab
Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: > On Sun, 2017-03-19 at 13:58 -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 17 Mar 2017 17:34:36 -0700 > > Eric Anholt escreveu: > > > > > Mauro Carvalho Chehab writes: > > > > > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > > > Mi

Re: [PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 03:21:37PM -0700, Steve Longerbeam wrote: > > > On 03/19/2017 03:49 AM, Russell King wrote: > >Add support for enumerating frame sizes and frame intervals from the > >first subdev via the V4L2 interfaces. > > > >Signed-off-by: Russell King > >--- > > drivers/staging/medi

Re: [PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:49 AM, Russell King wrote: Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-capture.c | 62 +++ 1 file changed, 62 insertio

Re: [PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:49 AM, Russell King wrote: Add frame size and frame interval enumeration to CSI. CSI can scale the image independently horizontally and vertically by a factor of two, which enumerates to four different frame sizes. CSI can also drop frames, resulting in frame rate reduction,

Re: [PATCH 2/4] media: imx: allow bayer pixel formats to be looked up

2017-03-19 Thread Steve Longerbeam
This is good too, but if it's all right with you I would prefer to squash this with the "redo pixel format enumeration and negotiation" patch, to keep the patch count down. Steve On 03/19/2017 03:48 AM, Russell King wrote: Allow imx_media_find_format() to look up bayer formats, which is requi

Re: [PATCH 1/4] media: imx-media-csi: fix v4l2-compliance check

2017-03-19 Thread Steve Longerbeam
Looks good to me. Steve On 03/19/2017 03:48 AM, Russell King wrote: v4l2-compliance was failing with: fail: v4l2-test-formats.cpp(1076): cap->timeperframe.numerator == 0 || cap->timeperframe.denominator == 0 test VIDIOC_G/S_PARM: FAIL Fix this. Signed-off-

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 gstv4l2object.c:3811:gst_v4l2_object_get_caps: pro

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Are we re

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: > On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: > >Right now, CSI doesn't do that - it only looks at the width, height, > >code, and field. > > Correct, there is currently no propagation of the colorimetry > parameters (co

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 11:51 AM, Russell King - ARM Linux wrote: On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: Right now, CSI doesn't do that - it only looks at the width, height, code, and field. Correct, there is currently

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 10:54:22AM -0700, Steve Longerbeam wrote: > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: > >On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > >>Right, imx-media-capture.c (the "standard" v4l2 user interface module) > >>is not implementing V

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: Right, imx-media-capture.c (the "standard" v4l2 user interface module) is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only return the single frame size t

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 13:58 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Mar 2017 17:34:36 -0700 > Eric Anholt escreveu: > > > Mauro Carvalho Chehab writes: > > > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > > Michael Zoran escreveu: > > > > > > > On Wed, 2017-03-15 at 22:08 -0300, Mauro Ca

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 17:34:36 -0700 Eric Anholt escreveu: > Mauro Carvalho Chehab writes: > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > Michael Zoran escreveu: > > > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: > >> > >> > No, I didn't. Thanks! Applied it but, unfortunatel

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a écrit : > > > > In practice, I have the impression there is a fair reason why > > framerate > > enumeration isn't implemented (considering there is only 1 valid > > rate). > > That's actually completely incorrect. > > With the ca

[PATCH] [media] dvb-frontends/cxd2841er: define symbol_rate_min/max in T/C fe-ops

2017-03-19 Thread Daniel Scheller
From: Daniel Scheller Fixes "w_scan -f c" complaining with This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org) Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Russell King - ARM Linux
On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > From: Philipp Zabel > > The csi_try_crop call in set_fmt should compare the cropping rectangle > to the currently set input format, not to the previous input format. Are we really sure that the cropping support is implemented co

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 05:00:08PM +0200, Vladimir Zapolskiy wrote: > On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: > >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, > >> analysed it

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Vladimir Zapolskiy
On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines, incl

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 10:33:25AM -0400, Nicolas Dufresne wrote: > Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a > écrit : > > > > > > In practice, I have the impression there is a fair reason why > > > framerate > > > enumeration isn't implemented (considering there is only

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 14:21 +, Russell King - ARM Linux a écrit : > > Can it be a point of failure? > > There's a good reason why I dumped a full debug log using > GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard ba

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 09:55 +, Russell King - ARM Linux a écrit : > 2) would it also make sense to allow gstreamer's v4l2src to try > setting >    a these parameters, and only fail if it's unable to set it?  IOW, > if >    I use: > > gst-launch-1.0 v4l2src device=/dev/video10 ! \ >   

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: > There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard bayer2rgb plugin. > > Please don't blame

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 03:57:56PM +0200, Vladimir Zapolskiy wrote: > Hi Russell, > > On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > >> Can you share your gstreamer pipeline? For now, until > >> VIDIOC_ENUM_FRAMESIZES

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Vladimir Zapolskiy
Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame rate

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-19 Thread Pavel Machek
On Fri 2017-03-17 11:42:03, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good look at t

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > >gstv4l2object.c:3811:gst_v4l2_object_get_caps: probed caps: > >video/x-bayer, format=(string)rggb, fram

[PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-19 Thread Russell King
Add frame size and frame interval enumeration to CSI. CSI can scale the image independently horizontally and vertically by a factor of two, which enumerates to four different frame sizes. CSI can also drop frames, resulting in frame rate reduction, so enumerate the resulting possible output frame

[PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-19 Thread Russell King
Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-capture.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/staging/media/imx/imx-

[PATCH 2/4] media: imx: allow bayer pixel formats to be looked up

2017-03-19 Thread Russell King
Allow imx_media_find_format() to look up bayer formats, which is required to support frame size and interval enumeration. Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-capture.c | 11 ++- drivers/staging/media/imx/imx-media-utils.c | 6 +++--- drivers/staging/med

[PATCH 1/4] media: imx-media-csi: fix v4l2-compliance check

2017-03-19 Thread Russell King
v4l2-compliance was failing with: fail: v4l2-test-formats.cpp(1076): cap->timeperframe.numerator == 0 || cap->timeperframe.denominator == 0 test VIDIOC_G/S_PARM: FAIL Fix this. Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 4 +++-

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > Right, imx-media-capture.c (the "standard" v4l2 user interface module) > is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only > return the single frame size that the pipeline has configured (the mbus > format of t

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 08:41:14PM -0400, Nicolas Dufresne wrote: > Along with the norm fallback, GStreamer could could also consider the > currently set framerate as returned by VIDIOC_G_PARM. At the same time, > implementing that enumeration shall be straightforward, and will make a > large amoun