cron job: media_tree daily build: ERRORS

2017-03-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 10 05:00:20 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build git

[PATCH 2/3] staging: vpfe_mc_capture: Clean up tests if NULL returned on failure

2017-03-09 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- driver

[PATCH 1/3] staging: atomisp_fops: Clean up tests if NULL returned on failure

2017-03-09 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- driver

[PATCH 3/3] staging: lirc_zilog: Clean up tests if NULL returned on failure

2017-03-09 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- driver

[PATCH 0/3] staging: media: Clean up tests if NULL returned on failure

2017-03-09 Thread simran singhal
This patch series tests if functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. simran singhal (3): staging: atomisp_fops: Clean up tests if NULL returned on failure staging: vpfe_mc_capture: Clean up tests if NULL returned on failure stag

[PATCH v5 00/39] i.MX Media Driver

2017-03-09 Thread Steve Longerbeam
In version 5: - ov5640: renamed "pwdn-gpios" to "powerdown-gpios" - ov5640: add mutex lock around the subdev op entry points. - ov5640: don't attempt to program the new mode in ov5640_set_fmt(). Instead set a new flag, pending_mode_change, and program the new mode at s_stream() if flag is se

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-09 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a/Documentati

[PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- .../bindings/media/video-multiplexer.txt | 59 ++ 1 file changed, 59 insertions(+) crea

[PATCH v5 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-03-09 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 6d7bf64..d28a

[PATCH v5 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-03-09 Thread Steve Longerbeam
Adds the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-

[PATCH v5 06/39] ARM: dts: imx6qdl: add capture-subsystem device

2017-03-09 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++

[PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-09 Thread Steve Longerbeam
There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for erratum ERR006687, to wake-up the ARM cores on normal RX and TX packet done events. So we need to remove the h/w workaround to support the OV5642. The

[PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

2017-03-09 Thread Steve Longerbeam
Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt dif

[PATCH v5 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in front of IPU1 CSI0 and IPU

[PATCH v5 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-03-09 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index 21dea5

[PATCH v5 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-03-09 Thread Steve Longerbeam
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes avai

[PATCH v5 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-03-09 Thread Steve Longerbeam
The reset pin to the port expander chip (MAX7310) is controlled by a gpio, so define a reset-gpios property to control it. There are three MAX7310's on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for their reset. Since all can't acquire the same pin, assign it to max7310_b, tha

[PATCH v5 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-03-09 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58 1 file changed, 58 i

[PATCH v5 14/39] add mux and video interface bridge entity functions

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h| 6 ++ 2 files changed,

[PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

2017-03-09 Thread Steve Longerbeam
Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or output device has signaled a new frame is ready before a previous frame has completed reception or transmission. This usually indicates a DMA read/write channel is having trouble gaining bus access. Signed-off-by: Steve Longerbeam

[PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-09 Thread Steve Longerbeam
If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function v4l2_subdev_link_validate_frame_interval() to verify this. This function can be called in a subdevice's media_entity_operations or v4l2_subdev_pad_ops link_validate ca

[PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-09 Thread Steve Longerbeam
Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is outside the nominal frame interval by some tolerance value. Signed-off-by: Steve Longerbeam --- Do

[PATCH v5 19/39] [media] add Omnivision OV5640 sensor driver

2017-03-09 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5640.c |

[PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-09 Thread Steve Longerbeam
v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l2-mc.h | 25 +

[PATCH v5 20/39] platform: add video-multiplexer subdevice driver

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The subdevice passes through frame interval and mbus configuration of the active input to the output side. Signed-off-by: Sascha Hauer Signed-off-b

[PATCH v5 23/39] media: Add i.MX media core driver

2017-03-09 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 560 drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 + drivers/staging/media/imx/Kc

[PATCH v5 25/39] media: imx: Add CSI subdev driver

2017-03-09 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1311 +

[PATCH v5 24/39] media: imx: Add Capture Device Interface

2017-03-09 Thread Steve Longerbeam
This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from various sources: - directly from CSI for capturing unconverted images directly from camera sensors. - from the IC pre-process encode task. - from the IC pre-process viewfinder task.

[PATCH v5 29/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-03-09 Thread Steve Longerbeam
Enable i.MX v4l2 media staging driver. For video capture on i.MX, the video multiplexer subdev is required. On the SabreAuto, the ADV7180 video decoder is required along with i2c-mux-gpio. The Sabrelite and SabreSD require the OV5640 and the SabreLite requires PWM clocks for the OV5640. Increase m

[PATCH v5 22/39] media: Add userspace header file for i.MX

2017-03-09 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 21 + 2 files

[PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

2017-03-09 Thread Steve Longerbeam
Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild index

[PATCH v5 26/39] media: imx: Add VDIC subdev driver

2017-03-09 Thread Steve Longerbeam
This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve L

[PATCH v5 28/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-03-09 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 689 + 2 files changed, 690 ins

[PATCH v5 31/39] media: imx: csi: add support for bayer formats

2017-03-09 Thread Steve Longerbeam
From: Russell King Bayer formats must be treated as generic data and passthrough mode must be used. Add the correct setup for these formats. Signed-off-by: Russell King - added check to csi_link_validate() to verify that destination is IDMAC output pad when passthrough conditions exist: bay

[PATCH v5 30/39] media: imx: add support for bayer formats

2017-03-09 Thread Steve Longerbeam
From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-utils.c | 68 +

[PATCH v5 33/39] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-09 Thread Steve Longerbeam
From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 level for handling this part of the negotiation. Signed-off-b

[PATCH v5 32/39] media: imx: csi: fix crop rectangle changes in set_fmt

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel The cropping rectangle was being modified by the output pad's set_fmt, which is the wrong pad to do this. The crop rectangle should not be modified by the output pad set_fmt. It instead should be reset to the full input frame when the input pad format is set. The output pad s

[PATCH v5 35/39] media: imx: csi/fim: add support for frame intervals

2017-03-09 Thread Steve Longerbeam
From: Russell King Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 46 +-- drivers/s

[PATCH v5 34/39] media: imx: csi: add __csi_get_fmt

2017-03-09 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 61 --- 1 file changed, 47 insertio

[PATCH v5 39/39] media: imx: propagate sink pad formats to source pads

2017-03-09 Thread Steve Longerbeam
As part of this, separate format try code from *_set_fmt() into *_try_fmt(), so that the latter function can be used to propagate a legal format from sink to source. This also reduces subsequent bloat in *_set_fmt(). imx-ic-prp never needed separate formats for sink and source pads, so propagation

[PATCH v5 36/39] media: imx: redo pixel format enumeration and negotiation

2017-03-09 Thread Steve Longerbeam
The previous API and negotiation of mbus codes and pixel formats was broken, and has been completely redone. The negotiation of media bus codes should be as follows: CSI: sink pad direct src pad IDMAC src pad - RGB (any)IPU RGB

[PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 +-- 1 file c

[PATCH v5 37/39] media: imx: csi: add frame skipping support

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 125 -- 1 fil

[PATCH v5 27/39] media: imx: Add IC subdev drivers

2017-03-09 Thread Steve Longerbeam
This is a set of three media entity subdevice drivers for the i.MX Image Converter: - Pre-process Router: Takes input frames from CSI0, CSI1, or VDIC. Two output pads enable either or both of the preprocess tasks below. If the input is from one of the CSIs, both proprocess task links can be

[PATCH v5 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-03-09 Thread Steve Longerbeam
The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than a

Re: [media] omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode

2017-03-09 Thread Fengguang Wu
On Fri, Mar 03, 2017 at 10:48:38PM +0100, Pavel Machek wrote: Hi! [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10 next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] Yes, the patch is against Sakar

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-09 Thread Steve Longerbeam
On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote: On 03/04/2017 02:56 AM, Sakari Ailus wrote: That's a bit of a special situation --- still there are alike conditions on existing hardware. You should return the buffers

Re: [kbuild-all] [media] omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode

2017-03-09 Thread Ye Xiaolong
On 03/03, Pavel Machek wrote: >Hi! > >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.10 next-20170303] >> [if your patch is applied to the wrong git tree, please drop us a note to >> help improve the system] >> > >Yes, the patch is against Sakari's ccp2 branch.

[PATCH v1 5/7] staging: gc2235: Remove multiple assignments

2017-03-09 Thread simran singhal
Remove multiple assignments by factorizing them. Problem found using checkpatch.pl CHECK: multiple assignments should be avoided Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/med

[PATCH v1 7/7] staging: gc2235: Do not use multiple blank lines

2017-03-09 Thread simran singhal
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/

[PATCH v1 6/7] staging: gc2235: Use x instead of x != NULL

2017-03-09 Thread simran singhal
Use x instead of x != NULL . This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/

[PATCH v1 4/7] staging: gc2235: Remove blank line before '}' and after '{' braces

2017-03-09 Thread simran singhal
Remove unneeded blank lines preceding/following '}' and '{' braces, as pointed out by checkpatch. This patch addresses the following checkpatch checks: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: simran s

[PATCH v1 3/7] staging: gc2235: Replace NULL with "!"

2017-03-09 Thread simran singhal
Use ! in comparison tests using "==NULL" rather than moving the "==NULL" to the right side of the test. Addesses multiple instances of the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: simran singhal --- drivers/staging/media/

[PATCH v1 2/7] staging: gc2235: Add blank line after a declaration

2017-03-09 Thread simran singhal
Add blank line after a declaration. Problem found using checkpatch. This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 7 +++ 1 file changed, 7 inse

[PATCH v1 1/7] staging: gc2235: Remove unnecessary typecast of c90 int constant

2017-03-09 Thread simran singhal
This patch removes unnecessary typecast of c90 int constant. WARNING: Unnecessary typecast of c90 int constant Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c

[PATCH v1 0/7] staging: gc2235: Multiple checkpatch issues

2017-03-09 Thread simran singhal
v1: -change the subject of all the patches of the patch-series simran singhal (7): staging: gc2235: Remove unnecessary typecast of c90 int constant staging: gc2235: Add blank line after a declaration staging: gc2235: Replace NULL with "!" staging: gc2235: Remove blank line before '}' an

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Ismael Luceno
On 08/Mar/2017 21:59, Andrey Utkin wrote: > Signed-off-by: Andrey Utkin > Signed-off-by: Andrey Utkin > > Please welcome Anton who is now in charge of solo6x10 and tw5864 support > and development in Bluecherry company, I have sent out to him the > hardware samples I possessed. (We will prepare

Re: [PATCH v2] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Ismael Luceno
On 09/Mar/2017 17:46, Anton Sviridenko wrote: > v2: removed var dbg_buf_cnt, left-over from debugging > > Fixes warning that appears in dmesg after closing V4L2 userspace > application that plays video from the display device > (first device from V4L2 device nodes provided by solo, usually /dev/v

Re: [PATCHv3 05/15] ov7670: add devicetree support

2017-03-09 Thread Sakari Ailus
Hi Hans, On Mon, Mar 06, 2017 at 03:56:06PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add DT support. Use it to get the reset and pwdn pins (if there are any). > Tested with one sensor requiring reset/pwdn and one sensor that doesn't > have reset/pwdn pins. If I read the datasheet rig

Re: [PATCHv3 04/15] ov7670: get xclk

2017-03-09 Thread Sakari Ailus
Hi Hans, On Mon, Mar 06, 2017 at 03:56:05PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Get the clock for this sensor. > > Signed-off-by: Hans Verkuil > --- > drivers/media/i2c/ov7670.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/media/i2c/ov7670.c

[PATCH] [media] coda: fix warnings when compiling with 64 bits

2017-03-09 Thread Mauro Carvalho Chehab
drivers/media/platform/coda/coda-common.c: In function ‘coda_alloc_aux_buf’: ./include/linux/kern_levels.h:4:18: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */

[PATCH 3/3] [media] coda: get rid of unused vars

2017-03-09 Thread Mauro Carvalho Chehab
Some vars are not used, as warned by gcc: drivers/media/platform/coda/coda-common.c: In function 'coda_buf_is_end_of_stream': drivers/media/platform/coda/coda-common.c:816:20: warning: variable 'src_vq' set but not used [-Wunused-but-set-variable] struct vb2_queue *src_vq;

[PATCH 2/3] Revert "[media] coda/imx-vdoa: constify structs"

2017-03-09 Thread Mauro Carvalho Chehab
We can't constify struct platform_driver. This reverts commit d2fe28feaee147e5e6e7bc68857f9bd7f6ad. Reported-by: Russell King Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/coda/imx-vdoa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/medi

[PATCH v5] media: platform: Renesas IMR driver

2017-03-09 Thread Sergei Shtylyov
From: Konstantin Kozhevnikov The image renderer, or the distortion correction engine, is a drawing processor with a simple instruction system capable of referencing video capture data or data in an external memory as the 2D texture data and performing texture mapping and drawing with respect to a

[PATCH 1/3] [media] platform: compile VIDEO_CODA with COMPILE_TEST

2017-03-09 Thread Mauro Carvalho Chehab
Currently, IMX_VDOA and VIDEO_CODA only builds on ARCH_MXC. That prevented me to build-test the driver, causing a bad patch to be applied, and to see other warnings on this driver. Reported-by: Russell King Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/Kconfig | 2 +- 1 file

Re: [PATCHv3 01/15] ov7670: document device tree bindings

2017-03-09 Thread Sakari Ailus
Hi Hans, On Mon, Mar 06, 2017 at 03:56:02PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add binding documentation and add that file to the MAINTAINERS entry. > > Signed-off-by: Hans Verkuil > --- > .../devicetree/bindings/media/i2c/ov7670.txt | 44 > ++ > MA

Re: [PATCHv3 03/15] ov7670: fix g/s_parm

2017-03-09 Thread Sakari Ailus
Hi Hans, On Mon, Mar 06, 2017 at 03:56:04PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Drop unnecesary memset. Drop the unnecessary extendedmode check and > set the V4L2_CAP_TIMEPERFRAME capability. > > Signed-off-by: Hans Verkuil > --- > drivers/media/i2c/ov7670.c | 4 +--- > 1 file

[PATCH] docs-rst: Don't use explicit Makefile rules to build SVG and DOT files

2017-03-09 Thread Mauro Carvalho Chehab
Now that we have an extension to handle images, use it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/Makefile | 47 +- Documentation/media/intro.rst | 6 +-- Documentation/media/uapi/dvb/intro.rst | 6 +-

[PATCH RFC] dvb: af9035.c: Logilink vg0022a to device id table

2017-03-09 Thread Andreas Kemnade
Ths adds the logilink VG00022a dvb-t dongle to the device table. The dongle contains (checked by removing the case) IT9303 SI2168 214730 The result is in cold state: usb 1-6: new high-speed USB device number 15 using xhci_hcd usb 1-6: New USB device found, idVendor=1d19, idProduct=0100 usb 1

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-09 Thread Laura Abbott
On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > 2017-03-06 17:04 GMT+01:00 Daniel Vetter : >> On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >>> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >>> No one gave a thing about android in upstream, so Greg KH just dum

Re: [PATCH] staging: media: Remove parentheses from return arguments

2017-03-09 Thread Greg KH
On Fri, Mar 03, 2017 at 10:31:39PM +0530, simran singhal wrote: > The sematic patch used for this is: > @@ > identifier i; > constant c; > @@ > return > - ( > \(i\|-i\|i(...)\|c\) > - ) > ; > > Signed-off-by: simran singhal > Acked-by: Julia Lawall > --- > .../media/atomisp/pci/atomisp2/c

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-09 Thread Greg KH
On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > This patch removes unnecessary typecast of c90 int constant. > > WARNING: Unnecessary typecast of c90 int constant > > Signed-off-by: simran singhal > --- > drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- > 1 file changed,

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-09 Thread Hans Verkuil
On 09/03/17 16:15, Jose Abreu wrote: > Hi Hans, > > > Thanks for the review! > > > On 09-03-2017 12:29, Hans Verkuil wrote: >> On 07/03/17 17:48, Jose Abreu wrote: >>> HDMI Receivers receive video modes which, according to >>> CEA specification, can have different frames per second >>> (fps) va

[PATCH 1/1] docs-rst: media: Document refcount field in struct dvb_frontend

2017-03-09 Thread Sakari Ailus
The refcount field was added to the struct but it was not documented. Document it. Signed-off-by: Sakari Ailus --- drivers/media/dvb-core/dvb_frontend.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-core/dvb_frontend.h b/drivers/media/dvb-core/dvb_frontend.h index 4829

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-09 Thread Jose Abreu
Hi Hans, Thanks for the review! On 09-03-2017 12:29, Hans Verkuil wrote: > On 07/03/17 17:48, Jose Abreu wrote: >> HDMI Receivers receive video modes which, according to >> CEA specification, can have different frames per second >> (fps) values. >> >> This patch introduces a helper function in

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-09 Thread Jose Abreu
Hi Neil, On 08-03-2017 12:12, Neil Armstrong wrote: > > Hi Jose, > > It seems here that we only have the RGB444<->YUV444 8bit tables, from the > Amlogic > source I have the following for 10bit, 12bit and 16bit for itu601 : > > static const u16 csc_coeff_rgb_out_eitu601_10b[3][4] = { > { 0x

[GIT PULL FOR v4.12] Miscellaneous fixes

2017-03-09 Thread Hans Verkuil
All small stuff. Regards, Hans The following changes since commit 700ea5e0e0dd70420a04e703ff264cc133834cba: Merge tag 'v4.11-rc1' into patchwork (2017-03-06 06:49:34 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.12c for you to fet

[PATCH v2] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Anton Sviridenko
v2: removed var dbg_buf_cnt, left-over from debugging Fixes warning that appears in dmesg after closing V4L2 userspace application that plays video from the display device (first device from V4L2 device nodes provided by solo, usually /dev/video0 when no other V4L2 devices are present). Encoder de

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Anton Sviridenko
On Thu, Mar 09, 2017 at 12:55:35PM +0100, Hans Verkuil wrote: > > + dbg_buf_cnt++; > > Left-over from debugging? This variable doesn't exist in the mainline code, so > this patch doesn't compile. > > Regards, > > Hans Exactly, left-over from debugging, thank you. Going to resubm

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

2017-03-09 Thread Hans Verkuil
On 07/03/17 17:48, Jose Abreu wrote: > HDMI Receivers receive video modes which, according to > CEA specification, can have different frames per second > (fps) values. > > This patch introduces a helper function in the media core > which can calculate the expected video mode fps given the > pixel

Re: [PATCH 00/10] ARM: davinci: add vpif display support

2017-03-09 Thread Hans Verkuil
On 09/03/17 12:00, Bartosz Golaszewski wrote: > 2017-03-09 11:53 GMT+01:00 Hans Verkuil : >> On 07/02/17 17:41, Bartosz Golaszewski wrote: >>> The following series adds support for v4l2 display on da850-evm with >>> a UI board in device tree boot mode. >> >> As far as I could tell from the comments

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-09 Thread walter harms
Am 09.03.2017 11:57, schrieb Hans Verkuil: > Hi Songjun, > > On 08/03/17 03:25, Wu, Songjun wrote: >> Hi Colin, >> >> Thank you for your comment. >> It is a bug, will be fixed in the next patch. > > Do you mean that you will provide a new patch for this? Is there anything > wrong with this patc

[PATCH 1/1] v4l: Document the practice of symmetrically calling s_power(dev, 0/1)

2017-03-09 Thread Sakari Ailus
The caller must always call the s_power() op symmetrically powering the device on and off. This is the practice albeit it was not documented. A lot of sub-device drivers rely on it, so document it accordingly. Signed-off-by: Sakari Ailus --- include/media/v4l2-subdev.h | 6 -- 1 file changed

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Hans Verkuil
On 08/03/17 18:47, Anton Sviridenko wrote: > Fixes warning that appears in dmesg after closing V4L2 userspace > application that plays video from the display device > (first device from V4L2 device nodes provided by solo, usually /dev/video0 > when no other V4L2 devices are present). Encoder device

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-09 Thread Colin Ian King
On 09/03/17 11:49, walter harms wrote: > > > Am 09.03.2017 11:57, schrieb Hans Verkuil: >> Hi Songjun, >> >> On 08/03/17 03:25, Wu, Songjun wrote: >>> Hi Colin, >>> >>> Thank you for your comment. >>> It is a bug, will be fixed in the next patch. >> >> Do you mean that you will provide a new patc

[PATCH 8/9] docs-rst: media: Switch documentation to V4L2 fwnode API

2017-03-09 Thread Sakari Ailus
Instead of including the V4L2 OF header in ReST documentation, use the V4L2 fwnode header instead. Signed-off-by: Sakari Ailus --- This goes before patch "[PATCH 8/8] v4l: Remove V4L2 OF framework in favour of V4L2 fwnode framework". Documentation/media/kapi/v4l2-core.rst | 2 +- Documentati

Re: [PATCH] staging/atomisp: Add support for the Intel IPU v2

2017-03-09 Thread Alan Cox
> Before moving firmware-dependent drivers out of staging, please send the > firmware files to linux-firmware ML. The firmware files come with the system. They may have system dependant components and it's also not clear that they can be put in linux- firmware for licensing reasons. They are howev

Re: [PATCH 00/10] ARM: davinci: add vpif display support

2017-03-09 Thread Hans Verkuil
On 07/02/17 17:41, Bartosz Golaszewski wrote: > The following series adds support for v4l2 display on da850-evm with > a UI board in device tree boot mode. As far as I could tell from the comments this patch series will see a second version, so I am marking it as 'Changes Requested' in patchwork.

Re: [PATCH 00/10] ARM: davinci: add vpif display support

2017-03-09 Thread Bartosz Golaszewski
2017-03-09 11:53 GMT+01:00 Hans Verkuil : > On 07/02/17 17:41, Bartosz Golaszewski wrote: >> The following series adds support for v4l2 display on da850-evm with >> a UI board in device tree boot mode. > > As far as I could tell from the comments this patch series will see a > second version, so I

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-09 Thread Hans Verkuil
Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: > Hi Colin, > > Thank you for your comment. > It is a bug, will be fixed in the next patch. Do you mean that you will provide a new patch for this? Is there anything wrong with this patch? It seems reasonable to me. Regards, Hans > >

[PATCH 1/1] docs-rst: Make the CSI-2 bus initialisation documentation match reality

2017-03-09 Thread Sakari Ailus
Update the CSI-2 bus documentation to tell that the LP-11 mode is not mandatory as there are transmitters that cannot be explicitly set to LP-11 mode. Instead, say that this what the transmitter drivers shall do if possible. Signed-off-by: Sakari Ailus --- Documentation/media/kapi/csi2.rst | 9 +

[GIT PULL FOR v4.12] Make v4l2_device_register_subdev_nodes() safer

2017-03-09 Thread Sakari Ailus
Hi Mauro, Just one patch from Sebastian this time --- calling v4l2_device_register_subdev_nodes() multiple times lead to memory leaks and memory corruption. Make it safer. Please pull. The following changes since commit 700ea5e0e0dd70420a04e703ff264cc133834cba: Merge tag 'v4.11-rc1' into pat

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-09 Thread Benjamin Gaignard
2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed

Re: [PATCH 1/1] docs-rst: media: Push CEC documentation under CEC section

2017-03-09 Thread Hans Verkuil
On 09/03/17 10:40, Sakari Ailus wrote: > The CEC documentation added two sections on the main media kAPI level. > There should be only one. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans > --- > Documentation/media/kapi/cec-core.rst | 7 ++- > 1 file changed

[PATCH 1/1] docs-rst: media: Push CEC documentation under CEC section

2017-03-09 Thread Sakari Ailus
The CEC documentation added two sections on the main media kAPI level. There should be only one. Signed-off-by: Sakari Ailus --- Documentation/media/kapi/cec-core.rst | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Documentation/media/kapi/cec-core.rst b/Documentation

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
On 03/09/2017 10:26 AM, Reshetova, Elena wrote: > >> On 03/09/2017 08:18 AM, Reshetova, Elena wrote: On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a refer

RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Reshetova, Elena
> On 03/09/2017 08:18 AM, Reshetova, Elena wrote: > >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > >>> refcount_t type and corresponding API should be > >>> used instead of atomic_t when the variable is used as > >>> a reference counter. This allows to avoid accidental > >>>

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
On 03/09/2017 08:18 AM, Reshetova, Elena wrote: >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: >>> refcount_t type and corresponding API should be >>> used instead of atomic_t when the variable is used as >>> a reference counter. This allows to avoid accidental >>> refcounter o