Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

2017-02-22 Thread Marek Szyprowski
Hi Shuah, On 2017-02-22 19:07, Shuah Khan wrote: On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: To complete DMA memory configuration for MFC device, allocation of the firmware buffer is needed, because some parameters are dependant on its base address. Till now, this has been handle

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-22 Thread Sumit Semwal
Hi Marek, On 23 February 2017 at 00:37, Daniel Vetter wrote: > On Tue, Feb 21, 2017 at 4:08 PM, Christian König > wrote: >> Am 21.02.2017 um 15:55 schrieb Marek Szyprowski: >>> >>> Dear All, >>> >>> On 2017-02-21 15:37, Marek Szyprowski wrote: Hi Christian, On 2017-02-21 14:5

cron job: media_tree daily build: ERRORS

2017-02-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Feb 23 05:00:35 CET 2017 media-tree git hash:e6b377dbbb944d5e3ceef4e5d429fc5c841e3692 media_build git

Re: Looking more details and reasons for using orig_add_limit.

2017-02-22 Thread Laurent Pinchart
Hi Mauro, On Wednesday 22 Feb 2017 17:25:41 Mauro Carvalho Chehab wrote: > Em Wed, 22 Feb 2017 21:53:08 +0200 Laurent Pinchart escreveu: > > On Tuesday 21 Feb 2017 06:20:58 Sodagudi Prasad wrote: > >> Hi mchehab/linux-media, > >> > >> It is not clear why KERNEL_DS was set explicitly here. In this

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-22 Thread Steve Longerbeam
On 02/22/2017 04:06 PM, Steve Longerbeam wrote: On 02/17/2017 03:06 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static void csi2_dphy_init(struct csi2_dev *csi2) +{ +/* +

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-22 Thread Steve Longerbeam
On 02/17/2017 03:06 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static void csi2_dphy_init(struct csi2_dev *csi2) +{ + /* +* FIXME: 0x14 is derived from a fixed D-P

Re: [PATCH v4 17/36] media: Add userspace header file for i.MX

2017-02-22 Thread Steve Longerbeam
On 02/16/2017 03:33 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +/* + * events from the subdevs + */ +#define V4L2_EVENT_IMX_CLASS V4L2_EVENT_PRIVATE_START +#define V4L2_EVENT_IMX_NFB4EOF(V4L2_EVENT_IMX_CLASS + 1) +#define V4L2_EVENT_IM

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-22 Thread Steve Longerbeam
Hi Philipp, On 02/16/2017 03:32 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: The previous API and negotiation of mbus codes and pixel formats was broken, and has been completely redone. The negotiation of media bus codes should be as follows: CSI: sink

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-22 Thread Steve Longerbeam
On 02/22/2017 03:38 PM, Steve Longerbeam wrote: On 02/17/2017 03:38 AM, Philipp Zabel wrote: On Fri, 2017-02-17 at 11:06 +, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-22 Thread Steve Longerbeam
On 02/17/2017 03:38 AM, Philipp Zabel wrote: On Fri, 2017-02-17 at 11:06 +, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static void csi2_dphy_init(struct csi2_dev *csi2) +{ +

[PATCH] [media] rc: raw decoder for keymap protocol is not loaded on register

2017-02-22 Thread Sean Young
When the protocol is set via the sysfs protocols attribute, the decoder is loaded. However, when it is not when a device is first plugged in or registered. Fixes: acc1c3c ("[media] media: rc: load decoder modules on-demand") Signed-off-by: Sean Young Cc: # v4.5+ --- drivers/media/rc/rc-main.c

Re: Bug: decoders referenced in kernel rc-keymaps not loaded on boot

2017-02-22 Thread Sean Young
On Tue, Feb 21, 2017 at 11:52:24PM +0100, Matthias Reichl wrote: > On Tue, Feb 21, 2017 at 07:34:39PM +, Sean Young wrote: > > On Tue, Feb 21, 2017 at 07:49:29PM +0100, Matthias Reichl wrote: > > > There seems to be a bug in on-demand loading of IR protocol decoders. > > > > > > After bootup t

[PATCH] [media] tm6000: Fix resource freeing in 'tm6000_prepare_isoc()'

2017-02-22 Thread Christophe JAILLET
'usb_free_urb(urb)' is a no-op, because urb is known to be NULL. It is likelly that releasing resources allocated by 'tm6000_alloc_urb_buffers()' just a few lines above is expected here. This has been spotted by the following coccinelle script: @@ expression ret, x, e; identifier f; @@ * if (

Re: Looking more details and reasons for using orig_add_limit.

2017-02-22 Thread Mauro Carvalho Chehab
Em Wed, 22 Feb 2017 21:53:08 +0200 Laurent Pinchart escreveu: > Hi Prasad, > > On Tuesday 21 Feb 2017 06:20:58 Sodagudi Prasad wrote: > > Hi mchehab/linux-media, > > > > It is not clear why KERNEL_DS was set explicitly here. In this path > > video_usercopy() gets called and it > > copies the

Re: [PATCH 2/3] [media] tc358743: Add OF device ID table

2017-02-22 Thread Mats Randgaard (matrandg)
CC: Philipp Zabel who added device tree support to this driver Regards, Mats Randgaard On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote: The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Thibault Saunier
On 02/22/2017 05:03 PM, Nicolas Dufresne wrote: Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : On 02/22/2017 03:06 PM, Hans Verkuil wrote: On 02/22/2017 05:05 AM, Thibault Saunier wrote: Hello, On 02/21/2017 11:19 PM, Hans Verkuil wrote: On 02/21/2017 11:20 AM, Thib

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Nicolas Dufresne
Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > On 02/22/2017 03:06 PM, Hans Verkuil wrote: > > > > On 02/22/2017 05:05 AM, Thibault Saunier wrote: > > > Hello, > > > > > > > > > On 02/21/2017 11:19 PM, Hans Verkuil wrote: > > > > On 02/21/2017 11:20 AM, Thibault Saunier

Re: Looking more details and reasons for using orig_add_limit.

2017-02-22 Thread Mauro Carvalho Chehab
HI Sodagudi, Em Tue, 21 Feb 2017 06:20:58 -0800 Sodagudi Prasad escreveu: > Hi mchehab/linux-media, > > It is not clear why KERNEL_DS was set explicitly here. In this path > video_usercopy() gets called and it > copies the “struct v4l2_buffer” struct to user space stack memory. > > Can you

Re: Dead code in v4l2-mem2mem.c?

2017-02-22 Thread Laurent Pinchart
Hi Shaobo, On Monday 20 Feb 2017 12:49:18 Shaobo wrote: > Hi Laurent, > > I'd like to. It sounds interesting and useful to me. Could you give me some > pointers about how to audit drivers? It's pretty simple, you need to check all functions that call get_queue_ctx() and follow the call stacks u

Re: Looking more details and reasons for using orig_add_limit.

2017-02-22 Thread Laurent Pinchart
Hi Prasad, On Tuesday 21 Feb 2017 06:20:58 Sodagudi Prasad wrote: > Hi mchehab/linux-media, > > It is not clear why KERNEL_DS was set explicitly here. In this path > video_usercopy() gets called and it > copies the “struct v4l2_buffer” struct to user space stack memory. > > Can you please shar

Re: v4l2: Adding support for multiple MIPI CSI-2 virtual channels

2017-02-22 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 22 Feb 2017 18:54:20 Guennadi Liakhovetski wrote: > On Tue, 21 Feb 2017, Ajay kumar wrote: > > On Fri, Feb 17, 2017 at 7:27 PM, Thomas Axelsson wrote: > >> Hi, > >> > >> I have a v4l2_subdev that provides multiple MIPI CSI-2 Virtual > >> Channels. I want to configure eac

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-22 Thread Sergei Shtylyov
Hello! On 02/22/2017 05:25 PM, Rob Herring wrote: From: Konstantin Kozhevnikov The image renderer light extended 4 (IMR-LX4) or the distortion correction engine is a drawing processor with a simple instruction system capable of referencing data on an external memory as 2D texture data and pe

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-22 Thread Daniel Vetter
On Tue, Feb 21, 2017 at 4:08 PM, Christian König wrote: > Am 21.02.2017 um 15:55 schrieb Marek Szyprowski: >> >> Dear All, >> >> On 2017-02-21 15:37, Marek Szyprowski wrote: >>> >>> Hi Christian, >>> >>> On 2017-02-21 14:59, Christian König wrote: Am 21.02.2017 um 14:21 schrieb Marek Szy

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Thibault Saunier
On 02/22/2017 03:06 PM, Hans Verkuil wrote: On 02/22/2017 05:05 AM, Thibault Saunier wrote: Hello, On 02/21/2017 11:19 PM, Hans Verkuil wrote: On 02/21/2017 11:20 AM, Thibault Saunier wrote: Use colorspace provided by the user as we are only doing scaling and color encoding conversion, we

Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

2017-02-22 Thread Shuah Khan
On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: > To complete DMA memory configuration for MFC device, allocation of the > firmware buffer is needed, because some parameters are dependant on its base > address. Till now, this has been handled in the s5p_mfc_alloc_firmware() > function. Th

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Hans Verkuil
On 02/22/2017 05:05 AM, Thibault Saunier wrote: > Hello, > > > On 02/21/2017 11:19 PM, Hans Verkuil wrote: >> >> On 02/21/2017 11:20 AM, Thibault Saunier wrote: >>> Use colorspace provided by the user as we are only doing scaling and >>> color encoding conversion, we won't be able to transform

Re: v4l2: Adding support for multiple MIPI CSI-2 virtual channels

2017-02-22 Thread Guennadi Liakhovetski
Hi, On Tue, 21 Feb 2017, Ajay kumar wrote: > Hi Everyone, > > On Fri, Feb 17, 2017 at 7:27 PM, Thomas Axelsson > wrote: > > Hi, > > > > I have a v4l2_subdev that provides multiple MIPI CSI-2 Virtual > > Channels. I want to configure each virtual channel individually (e.g. > > set_fmt), but th

Re: [PATCH v4 12/36] add mux and video interface bridge entity functions

2017-02-22 Thread Steve Longerbeam
On 02/19/2017 01:28 PM, Pavel Machek wrote: On Wed 2017-02-15 18:19:14, Steve Longerbeam wrote: From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam This is slightly "interesting" format of changelog. Normally

Re: [PATCH v2 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

2017-02-22 Thread Shuah Khan
On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: > Internal MFC driver device structure contains two pointers to devices used > for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the > mem_dev[] array and use defines for accessing particular banks. This will > help to si

[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could c

[PATCH 2/3] [media] tc358743: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could c

[PATCH 3/3] [media] si4713: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could c

Re: [PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-22 Thread Nicolas Dufresne
Le mercredi 22 février 2017 à 10:10 -0300, Thibault Saunier a écrit : > Hello, > > On 02/22/2017 06:29 AM, Andrzej Hajda wrote: > > On 21.02.2017 20:20, Thibault Saunier wrote: > > > It is required by the standard that the field order is set by the > > > driver. > > > > > > Signed-off-by: Thibaul

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-22 Thread Ramiro Oliveira
Hi Vladimir On 2/22/2017 11:39 AM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/22/2017 12:57 PM, Ramiro Oliveira wrote: >> Hi Vladimir >> >> On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: >>> Hi Sakari, >>> >>> On 02/21/2017 11:48 PM, Sakari Ailus wrote: Hi, Vladimir! How do

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-22 Thread Rob Herring
On Sat, Feb 11, 2017 at 11:02:01PM +0300, Sergei Shtylyov wrote: > From: Konstantin Kozhevnikov > > The image renderer light extended 4 (IMR-LX4) or the distortion correction > engine is a drawing processor with a simple instruction system capable of > referencing data on an external memory as 2

Re: [PATCH v6 2/9] doc: DT: venus: binding document for Qualcomm video driver

2017-02-22 Thread Rob Herring
On Wed, Feb 22, 2017 at 3:25 AM, Stanimir Varbanov wrote: > Hi Rob, > > On 02/22/2017 02:09 AM, Rob Herring wrote: >> On Tue, Feb 07, 2017 at 03:10:17PM +0200, Stanimir Varbanov wrote: >>> Add binding document for Venus video encoder/decoder driver >>> >>> Cc: Rob Herring >>> Cc: devicet...@vger.

[PATCH] media: vpif: request enable-gpios

2017-02-22 Thread Bartosz Golaszewski
This change is needed to make vpif capture work on the da850-evm board where the capture function must be selected on the UI expander. Signed-off-by: Bartosz Golaszewski --- drivers/media/platform/davinci/vpif_capture.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/pla

Re: [PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-22 Thread Thibault Saunier
Hello, On 02/22/2017 06:29 AM, Andrzej Hajda wrote: On 21.02.2017 20:20, Thibault Saunier wrote: It is required by the standard that the field order is set by the driver. Signed-off-by: Thibault Saunier --- Changes in v5: - Just adapt the field and never error out. Changes in v4: None Chan

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Thibault Saunier
Hello, On 02/21/2017 11:19 PM, Hans Verkuil wrote: On 02/21/2017 11:20 AM, Thibault Saunier wrote: Use colorspace provided by the user as we are only doing scaling and color encoding conversion, we won't be able to transform the colorspace itself and the colorspace won't mater in that operati

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-22 Thread Vladimir Zapolskiy
On 02/22/2017 12:51 PM, Ramiro Oliveira wrote: > Hi Zakari, > > On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: >>> Hi Vladimir, >>> >>> Thank you for your feedback >>> >>> On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: Hi Ra

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-22 Thread Vladimir Zapolskiy
Hi Ramiro, On 02/22/2017 12:57 PM, Ramiro Oliveira wrote: > Hi Vladimir > > On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: >> Hi Sakari, >> >> On 02/21/2017 11:48 PM, Sakari Ailus wrote: >>> Hi, Vladimir! >>> >>> How do you do? :-) >> >> deferring execution of boring tasks by doing code review

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-22 Thread Ramiro Oliveira
Hi Vladimir On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: > Hi Sakari, > > On 02/21/2017 11:48 PM, Sakari Ailus wrote: >> Hi, Vladimir! >> >> How do you do? :-) > > deferring execution of boring tasks by doing code review :) > >> On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy w

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-22 Thread Ramiro Oliveira
Hi Zakari, On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: >> Hi Vladimir, >> >> Thank you for your feedback >> >> On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: >>> Hi Ramiro, >>> >>> please find some review comments below. >>> >>>

Re: [PATCH v2 17/19] [media] lirc: implement reading scancode

2017-02-22 Thread Sean Young
> help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Sean-Young/Teach-lirc-how-to-send-and-receive-scancodes/20170222-073718 > base: git://linuxtv.org/media_tree.git master > config: i386-randconfig-x015-201708 (attached as .config) > compiler

Re: [PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-22 Thread Andrzej Hajda
On 21.02.2017 20:20, Thibault Saunier wrote: > It is required by the standard that the field order is set by the > driver. > > Signed-off-by: Thibault Saunier > > --- > > Changes in v5: > - Just adapt the field and never error out. > > Changes in v4: None > Changes in v3: > - Do not check values i

Re: [PATCH v6 2/9] doc: DT: venus: binding document for Qualcomm video driver

2017-02-22 Thread Stanimir Varbanov
Hi Rob, On 02/22/2017 02:09 AM, Rob Herring wrote: > On Tue, Feb 07, 2017 at 03:10:17PM +0200, Stanimir Varbanov wrote: >> Add binding document for Venus video encoder/decoder driver >> >> Cc: Rob Herring >> Cc: devicet...@vger.kernel.org >> Signed-off-by: Stanimir Varbanov >> --- >> Changes sin