Re: odd kernel messages when running v4l2-compliance

2017-01-25 Thread Niklas Söderlund
On 2017-01-25 21:38:05 +0100, Hans Verkuil wrote: > On 01/25/2017 08:15 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > I have noticed an odd printout when running v4l2-compliance while > > testing the rcar-vin driver. When testing (v4l2-compliance -d 0) on > > ARM64 I see the following message

cron job: media_tree daily build: WARNINGS

2017-01-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jan 26 05:00:19 CET 2017 media-tree git hash:40eca140c404505c09773d1c6685d818cb55ab1a media_build git

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-25 Thread Steve Longerbeam
On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: From: Philipp Zabel [snip] +config VIDEO_MULTIPLEXER + tristate "Video Multiplexer" + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver

Re: odd kernel messages when running v4l2-compliance

2017-01-25 Thread Hans Verkuil
On 01/25/2017 08:15 PM, Niklas Söderlund wrote: > Hi Hans, > > I have noticed an odd printout when running v4l2-compliance while > testing the rcar-vin driver. When testing (v4l2-compliance -d 0) on > ARM64 I see the following messages: > > [ 1411.016069] compat_ioctl32: unexpected VIDIOC_FMT1

odd kernel messages when running v4l2-compliance

2017-01-25 Thread Niklas Söderlund
Hi Hans, I have noticed an odd printout when running v4l2-compliance while testing the rcar-vin driver. When testing (v4l2-compliance -d 0) on ARM64 I see the following messages: [ 1411.016069] compat_ioctl32: unexpected VIDIOC_FMT1 type 0 [ 1411.022981] compat_ioctl32: unexpected VIDIOC_FMT1 t

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-25 Thread Steve Longerbeam
On 01/20/2017 06:48 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: + + /* cached control settings */ + int ctrl_cache[OV5640_MAX_CONTROLS]; This is just duplicating the cached value in the control framework. I think this can be dropped. done, see below.

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-25 Thread Mauro Carvalho Chehab
I won't be doing a review on it yet... I'll try to do it on the next version. Just a quick notice: Em Wed, 25 Jan 2017 15:03:46 +0200 Sakari Ailus escreveu: > > + * Copyright (C) 2016 Helen Koike F. > > 2017 might be used now. Please keep 2016 as the year you did the initial development. It

[GIT PULL FOR v4.11] Add et8ek8 driver

2017-01-25 Thread Sakari Ailus
Hi Mauro, This pull request adds the sensor et8ek8 driver which is used on the Nokia N900. Please pull. The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a: [media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200) are available in the git repository at:

Re: [PATCH] mark myself as mainainer for camera on N900

2017-01-25 Thread Sakari Ailus
Hi Sebastian and Pavel, On Wed, Dec 28, 2016 at 12:57:21AM +0100, Sebastian Reichel wrote: > Hi, > > On Tue, Dec 27, 2016 at 09:59:23PM +0100, Pavel Machek wrote: > > Mark and Sakari as maintainers for Nokia N900 camera pieces. > > ^^^ missing me after Mark. Otherwise Mark looks like a name :) >

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-25 Thread Sakari Ailus
Hi Helen, My apologies for the long review time! Please see my comments below. On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote: > From: Helen Fornazier > > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor node

Re: [media] uvcvideo: support for contiguous DMA buffers

2017-01-25 Thread Sakari Ailus
Hi Vincent, On Wed, Jan 11, 2017 at 12:36:24PM +, Vincent ABRIOU wrote: > Hi Sakari, > > On 01/11/2017 12:03 PM, Sakari Ailus wrote: > > Hi Vincent, > > > > On Mon, Jan 09, 2017 at 03:49:00PM +, Vincent ABRIOU wrote: > >> > >> > >> On 01/09/2017 04:37 PM, Laurent Pinchart wrote: > >>> Hi

Re: [PATCH] v4l2-ctrls.c: add NULL check

2017-01-25 Thread Sakari Ailus
On Wed, Jan 25, 2017 at 08:38:07AM +0100, Hans Verkuil wrote: > Check that the control whose events we want to delete is still there. > > Normally this will always be the case, but I am not 100% certain if there > aren't > any corner cases when a device is forcibly unbound. > > In any case, this

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-25 Thread Sakari Ailus
Hi Mauro, On Tue, Jan 24, 2017 at 08:49:02AM -0200, Mauro Carvalho Chehab wrote: > Hi Sakari, > > Just returned this week from vacations. I'm reading my long e-mail backlog, > starting from my main inbox... > > Em Mon, 2 Jan 2017 09:53:49 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > >

Re: [PATCH] media: platform: constify vb2_ops structures

2017-01-25 Thread Lad, Prabhakar
Hi, Thanks for the patch. On Sat, Jan 21, 2017 at 9:29 AM, Bhumika Goyal wrote: > Declare vb2_ops structures as const as they are only stored in > the ops field of a vb2_queue structure. This field is of type > const, so vb2_ops structures having same properties can be made > const too. > Done u

Re: [RFC simple allocator v1 0/2] Simple allocator

2017-01-25 Thread Laura Abbott
On 01/23/2017 09:35 AM, Daniel Vetter wrote: On Fri, Jan 20, 2017 at 04:32:29PM +0100, Benjamin Gaignard wrote: The goal of this RFC is to understand if a common ioctl for specific memory regions allocations is needed/welcome. Obviously it will not replace allocation done in linux kernel framew