[v4l-utils PATCH v1.3 2/2] media-ctl: Print information related to a single entity

2016-09-14 Thread Sakari Ailus
Add a possibility to printing all information related to a given entity by using both -p and -e options. This may be handy sometimes if only a single entity is of interest and there are many entities. Signed-off-by: Sakari Ailus --- utils/media-ctl/media-ctl.c | 32 ++

Re: [v4l-utils PATCH v1.2 2/2] media-ctl: Print information related to a single entity

2016-09-14 Thread Sakari Ailus
On 09/15/16 01:05, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Wednesday 14 Sep 2016 17:29:39 Sakari Ailus wrote: >> Add a possibility to printing all information related to a given entity by >> using both -p and -e options. This may be handy sometimes if only a singl

[PATCH -next] [media] vivid: fix error return code in vivid_create_instance()

2016-09-14 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the memory or workqueue alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/vivid/vivid-core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff -

cron job: media_tree daily build: WARNINGS

2016-09-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Sep 15 04:00:16 CEST 2016 git branch: test git hash: c3b809834db8b1a8891c7ff873a216eac119628d gcc versi

[PATCH -next] [media] pxa_camera: remove duplicated include from pxa_camera.c

2016-09-14 Thread Wei Yongjun
From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- drivers/media/platform/pxa_camera.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index 1bce7eb..2d68b80 100644 --- a/drivers/media/platfo

[PATCH -next] [media] pxa_camera: fix error return code in pxa_camera_probe()

2016-09-14 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENODEV from dma_request_slave_channel_compat() error handling case instead of 0, as done elsewhere in this function. Also fix to release resources in v4l2_clk_register() error handling. Signed-off-by: Wei Yongjun --- drivers/media/platform/pxa_camer

Re: [v4l-utils PATCH v1.2 2/2] media-ctl: Print information related to a single entity

2016-09-14 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Wednesday 14 Sep 2016 17:29:39 Sakari Ailus wrote: > Add a possibility to printing all information related to a given entity by > using both -p and -e options. This may be handy sometimes if only a single > entity is of interest and there are many entities.

[Patch] media: i2c: tvp514x: Reported mbus format should be MEDIA_BUS_FMT_UYVY8_2X8

2016-09-14 Thread Benoit Parrot
The advertised V4L2 pixel format and Media Bus code don't match. The current media bud code advertised is MEDIA_BUS_FMT_YUYV8_2X8 which does not reflect what the encoder actually outputs. This encoder generate MEDIA_BUS_FMT_UYVY8_2X8 so advertise as such. Signed-off-by: Benoit Parrot --- drivers

Re: [PATCH 11/13] v4l: vsp1: Determine partition requirements for scaled images

2016-09-14 Thread Laurent Pinchart
Hi Niklas, On Wednesday 14 Sep 2016 21:27:33 Niklas Söderlund wrote: > On 2016-09-14 02:17:04 +0300, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > The partition algorithm needs to determine the capabilities of each > > entity in the pipeline to identify the correct maximum partition w

Re: [PATCH 02/13] v4l: vsp1: Protect against race conditions between get and set format

2016-09-14 Thread Laurent Pinchart
Hi Niklas, Thank you for the review. On Wednesday 14 Sep 2016 20:23:18 Niklas Söderlund wrote: > On 2016-09-14 02:16:55 +0300, Laurent Pinchart wrote: > > The subdev userspace API isn't serialized in the core, serialize access > > to formats and selection rectangles in the driver. > > > > Signed

Re: [PATCH 02/13] v4l: vsp1: Protect against race conditions between get and set format

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 20:23:17 +0200, Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your patch. > > On 2016-09-14 02:16:55 +0300, Laurent Pinchart wrote: > > The subdev userspace API isn't serialized in the core, serialize access > > to formats and selection rectangles in the driver. > > > > Sign

Re: [PATCH 14/13] v4l: vsp1: Fix spinlock in mixed IRQ context function

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:29:08 +0300, Laurent Pinchart wrote: > The wpf_configure() function can be called both from IRQ and non-IRQ > contexts, use spin_lock_irqsave(). > > Signed-off-by: Laurent Pinchart Acked-by: Niklas Söderlund > --- > drivers/media/platform/vsp1/vsp1_wpf.c | 5 +++-- > 1 file c

Re: [PATCH 11/13] v4l: vsp1: Determine partition requirements for scaled images

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:17:04 +0300, Laurent Pinchart wrote: > From: Kieran Bingham > > The partition algorithm needs to determine the capabilities of each > entity in the pipeline to identify the correct maximum partition width. > > Extend the vsp1 entity operations to provide a max_width operation an

lening

2016-09-14 Thread QUALITY LOAN SERVICE CORPORATION
Goede dag,    We zijn QUALITY LENING Service Corporation het geven van leningen via e-mail advertentie. Wij bieden verschillende soorten van leningen of projecten leningen (korte en lange termijn leningen, persoonlijke leningen, leningen aan bedrijven etc.) met 3% rente. We geven leninge

Re: [PATCH 08/13] v4l: vsp1: Pass parameter type to entity configuration operation

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:17:01 +0300, Laurent Pinchart wrote: > Replace the current boolean parameter (full / !full) with an explicit > enum. > > - VSP1_ENTITY_PARAMS_INIT for parameters to be configured at pipeline > initialization time only (V4L2 stream on or DRM atomic update) > - VSP1_ENTITY_PARAMS_

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:16:59 +0300, Laurent Pinchart wrote: > Cropping on the WPF sink pad restricts the left and top coordinates to > 0-255. The same result can be obtained by cropping on the RPF without > any such restriction, this feature isn't useful. Disable it. > > Signed-off-by: Laurent Pinchart

Re: [PATCH 05/13] v4l: vsp1: Use DFE instead of FRE for frame end

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:16:58 +0300, Laurent Pinchart wrote: > From: Kieran Bingham > > The DFE and FRE interrupts are both fired at frame completion, as each > display list processes a single frame. This won't be true anymore when > using image partitioning, switch to DFE in preparation. > > Signed-of

Re: [PATCH 03/13] v4l: vsp1: Ensure pipeline locking in resume path

2016-09-14 Thread Niklas Söderlund
On 2016-09-14 02:16:56 +0300, Laurent Pinchart wrote: > From: Kieran Bingham > > The vsp1_pipeline_ready() and vsp1_pipeline_run() functions must be > called with the pipeline lock held, fix the resume code path. > > Signed-off-by: Kieran Bingham > Signed-off-by: Laurent Pinchart Acked-by: Ni

Re: [PATCH 02/13] v4l: vsp1: Protect against race conditions between get and set format

2016-09-14 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2016-09-14 02:16:55 +0300, Laurent Pinchart wrote: > The subdev userspace API isn't serialized in the core, serialize access > to formats and selection rectangles in the driver. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_b

[v4l-utils PATCH v1.2 2/2] media-ctl: Print information related to a single entity

2016-09-14 Thread Sakari Ailus
Add a possibility to printing all information related to a given entity by using both -p and -e options. This may be handy sometimes if only a single entity is of interest and there are many entities. Signed-off-by: Sakari Ailus --- Fixed the commit message as well. utils/media-ctl/media-ctl.c

[v4l-utils PATCH v1.1 2/2] media-ctl: Print information related to a single entity

2016-09-14 Thread Sakari Ailus
Add an optional argument to the -p option that allows printing all information related to a given entity. This may be handy sometimes if only a single entity is of interest and there are many entities. Signed-off-by: Sakari Ailus --- utils/media-ctl/media-ctl.c | 33 +++--

Re: [PATCH v2 2/4] add stih-cec driver

2016-09-14 Thread Benjamin Gaignard
Fixed and tested, thanks. I will wait for any others comments before send a v3. Regards, Benjamin 2016-09-14 14:58 GMT+02:00 Hans Verkuil : > Hi Benjamin, > > Just one comment: > > On 09/14/2016 01:24 PM, Benjamin Gaignard wrote: >> This patch implement CEC driver for stih4xx platform. >> Driver

Re: [PATCH v2 2/4] add stih-cec driver

2016-09-14 Thread Hans Verkuil
Hi Benjamin, Just one comment: On 09/14/2016 01:24 PM, Benjamin Gaignard wrote: > This patch implement CEC driver for stih4xx platform. > Driver compliance has been test with cec-ctl and > cec-compliance tools. > > Signed-off-by: Benjamin Gaignard > --- > drivers/staging/media/Kconfig

Re: [PATCH v6 0/6] Add MT8173 MDP Driver

2016-09-14 Thread Hans Verkuil
Hi Minghsiu, v6 looks good, but I get these warnings when compiling it for i686: linux-git-i686: WARNINGS /home/hans/work/build/media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c: In function 'mtk_mdp_vpu_handle_init_ack': /home/hans/work/build/media-git/drivers/media/platform/mtk-mdp/mtk_m

Re: [PATCH V2] [media] staging/media/cec: fix coding style error

2016-09-14 Thread Hans Verkuil
Hi Richard, I'm sorry, but I won't take this patch. The overruns are small and breaking up the lines does not improve readability IMHO. If you are looking for some other source code to fix coding style issues, then this would be a good candidate: drivers/media/common/saa7146/ Cleaning that up

Re: [PATCH v2 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

2016-09-14 Thread Hans Verkuil
Hi Tiffany, On 09/09/2016 05:48 PM, Tiffany Lin wrote: > Add V4L2_PIX_FMT_MT21C documentation > > Signed-off-by: Tiffany Lin > --- > Documentation/media/uapi/v4l/pixfmt-reserved.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-reser

[PATCH v2 4/4] add maintainer for stih-cec driver

2016-09-14 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0bbe4b1..f541117 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10281,6 +10281,13 @@ S: Maintained F: Documentation/devicetree/bindings/serial/ F:

[PATCH v2 3/4] add stih-cec driver into DT

2016-09-14 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- arch/arm/boot/dts/stih407-family.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index d294e82..9f88086 100644 --- a/arch/arm/boot/dts/stih407-family.dtsi +++

[PATCH v2 1/4] bindings for stih-cec driver

2016-09-14 Thread Benjamin Gaignard
Add bindings documentation for stih-cec driver. Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/media/stih-cec.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/stih-cec.txt diff --git a/Documentati

[PATCH v2 2/4] add stih-cec driver

2016-09-14 Thread Benjamin Gaignard
This patch implement CEC driver for stih4xx platform. Driver compliance has been test with cec-ctl and cec-compliance tools. Signed-off-by: Benjamin Gaignard --- drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/st-cec/Kconfig

[PATCH v2 0/4] STIH CEC driver

2016-09-14 Thread Benjamin Gaignard
version 2: - fix typo in comments - in DT move stih-cec driver from stih410.dtsi to stih407-family.dtsi Those patches implement HDMI CEC driver for stih4xx SoCs. I have used media_tree/fixes and the lastest v4l-utils branch. The compliance tools have been run with the following sequence: cec-ct

Re: [STLinux Kernel] [PATCH 3/4] add stih-cec driver into DT

2016-09-14 Thread Peter Griffin
Hi Benjamin, On Wed, 14 Sep 2016, Benjamin Gaignard wrote: > Signed-off-by: Benjamin Gaignard > --- > arch/arm/boot/dts/stih410.dtsi | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi > index 18ed1ad..440c4bd 1

[PATCH 4/4] add maintainer for stih-cec driver

2016-09-14 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0bbe4b1..f541117 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10281,6 +10281,13 @@ S: Maintained F: Documentation/devicetree/bindings/serial/ F:

[PATCH 2/4] add stih-cec driver

2016-09-14 Thread Benjamin Gaignard
This patch implement CEC driver for stih4xx platform. Driver compliance has been test with cec-ctl and cec-compliance tools. Signed-off-by: Benjamin Gaignard --- drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/st-cec/Kconfig

[PATCH 3/4] add stih-cec driver into DT

2016-09-14 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- arch/arm/boot/dts/stih410.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi index 18ed1ad..440c4bd 100644 --- a/arch/arm/boot/dts/stih410.dtsi +++ b/arch/arm/boot/dts/stih410.

[PATCH 1/4] bindings for stih-cec driver

2016-09-14 Thread Benjamin Gaignard
Add bindings documentation for stih-cec driver. Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/media/stih-cec.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/stih-cec.txt diff --git a/Documentati

[PATCH 0/4] STIH CEC driver

2016-09-14 Thread Benjamin Gaignard
Those patches implement HDMI CEC driver for stih4xx SoCs. I have used media_tree/fixes and the lastest v4l-utils branch. The compliance tools have been run with the following sequence: cec-ctl --tuner -p 1.0.0.0 cec-compliance -A and cec-follower running in a separate shell Compliance logs: cec-c

Re: [PATCH 04/13] v4l: vsp1: Repair race between frame end and qbuf handler

2016-09-14 Thread Kieran Bingham
On 14/09/16 00:16, Laurent Pinchart wrote: > From: Kieran Bingham > > The frame-end function releases and completes the buffers on the input > and output entities of the pipe before marking the pipe->state as > 'STOPPED'. This introduces a race whereby with the pipe->state still > 'RUNNING', a QB