On Tue, 21 Jun 2016 08:38:57 +0200,
Richard Cochran wrote:
>
> On Tue, Jun 21, 2016 at 07:54:32AM +0200, Takashi Iwai wrote:
> > > I still would appreciate an answer to my other questions, though...
> >
> > Currently HD-audio (both ASoC and legacy ones) are the only drivers
> > providing the link
On Tue, Jun 21, 2016 at 07:54:32AM +0200, Takashi Iwai wrote:
> > I still would appreciate an answer to my other questions, though...
>
> Currently HD-audio (both ASoC and legacy ones) are the only drivers
> providing the link timestamp. In the recent code, it's PCM
> get_time_info ops, so you ca
On 06/20/2016 10:38 PM, Dave Stevenson wrote:
> Hi Hans.
>
> On 20/06/16 18:03, Hans Verkuil wrote:
>> On 06/20/2016 06:20 PM, Sakari Ailus wrote:
>>> The 10-bit packed raw bayer format documented that the data of the first
>>> pixel of a four-pixel group was found in the first byte and the two
>>
On Mon, 20 Jun 2016 17:21:26 +0200,
Richard Cochran wrote:
>
> On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote:
> > Where is this "audio_time" program of which you speak?
>
> Never mind, found it in alsa-lib.
>
> I still would appreciate an answer to my other questions, though...
"Andrew F. Davis" writes:
> When CONFIG_LGUEST is not set make will still descend into the lguest
> directory but nothing will be built. This produces unneeded build
> artifacts and messages in addition to slowing the build. Fix this here.
>
> Signed-off-by: Andrew F. Davis
> ---
> drivers/Makef
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Jun 21 04:00:24 CEST 2016
git branch: test
git hash: 59f0bc11848f8f3242bc1fefae670e745929cd7b
gcc versi
On 2016年06月20日 18:06, Henrik Austad wrote:
On Sun, Jun 19, 2016 at 11:45:47PM +0900, Takashi Sakamoto wrote:
(remove C.C. to lkml. This is not so major feature.)
On Jun 19 2916 07:45, Henrik Austad wrote:
snip
802.1Q gives you low latency through the network, but more importantly, no
dropped
Hi Mathias,
On 19 June 2016 at 18:01, Mathias Krause wrote:
> This small series is the v2 of the patch posted initially here:
>
> http://www.spinics.net/lists/linux-media/msg101347.html
>
> It not only fixes the type mix-up and addresses Daniel's remark (patch 1),
> it also smoothes out the err
Hi Hans.
On 20/06/16 18:03, Hans Verkuil wrote:
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
The 10-bit packed raw bayer format documented that the data of the first
pixel of a four-pixel group was found in the first byte and the two
highest bits of the fifth byte. This was not entirely correct.
Some systems use 'gpio_led_register_device' to make an in-memory copy of
their LED device table so the original can be removed as .init.rodata.
When the LED subsystem is not enabled source in the led directory is not
built and so this function may be undefined. Fix this here.
Signed-off-by: Andrew
Hi Pali,
On Sat, Jun 18, 2016 at 05:37:33PM +0200, Pali Rohár wrote:
> On Saturday 18 June 2016 17:22:59 Pavel Machek wrote:
> > > +/*
> > > + *
> > > + * Stingray sensor mode settings for Scooby
> > > + *
> > > + *
> > > + */
> >
> > I'd fix it to normal comment style... and possibly remove it.
Hi Pavel,
On Fri, Jun 17, 2016 at 07:12:14PM +0200, Pavel Machek wrote:
> Hi!
>
> > First, I re-did pipeline setup in python, it seems slightly less hacky
> > then in shell.
> >
> > I tried to modify fcam-dev to work with the new interface, but was not
> > successful so far. I can post patches i
Now that we have fetch_inc() we can stop using inc_return() - 1.
These are very similar to the existing OP-RETURN primitives we already
have, except they return the value of the atomic variable _before_
modification.
Cc: Hans Verkuil
Cc: Andy Walls
Cc: linux-media@vger.kernel.org
Signed-off-by:
Allow reconfiguration of the look-up table and processing mode at
runtime.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_clu.c | 41 +-
drivers/media/platform/vsp1/vsp1_clu.h | 4
2 files changed, 30 insertions(+), 15 deletions(-)
dif
Allow reconfiguration of the look-up table at runtime.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_lut.c | 25 +++--
drivers/media/platform/vsp1/vsp1_lut.h | 3 +++
2 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platfo
The metadata buffer type is used to transfer metadata between userspace
and kernelspace through a V4L2 buffers queue. It comes with a new
metadata capture capability and format description.
Signed-off-by: Laurent Pinchart
---
Documentation/DocBook/media/v4l/dev-meta.xml | 93 +++
Hello,
Here's my current set of pending VSP1 patches, based on top of the
"[PATCH v2 00/13] R-Car VSP improvements for v4.7 - Round 2" series. For
convenience I've pushed the patches and their dependencies to
git://linuxtv.org/pinchartl/media.git vsp1/flip
The series contains new feature
We don't need to walk the pipeline when propagating the alpha value as
all the information needed for propagation is already available from the
pipeline structure.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.c | 42 +++--
drivers/media/pl
Allow reconfiguration of the alpha value at runtime.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_rpf.c | 21 -
drivers/media/platform/vsp1/vsp1_rwpf.c | 2 --
drivers/media/platform/vsp1/vsp1_rwpf.h | 3 +++
drivers/media/platform/vsp1/vsp1_wpf.c
The structures are never modified, make them const.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_bru.c | 4 ++--
drivers/media/platform/vsp1/vsp1_clu.c | 4 ++--
drivers/media/platform/vsp1/vsp1_hgo.c | 4 ++--
drivers/media/platform/vsp1/vsp1_histo.c | 2 +-
driver
The device is stopped when STREAMOFF is called on the last video node in
the pipeline. This results in possible memory corruption and/or crashes,
as userspace could free buffers while the hardware is still writing to
them, and the frame completion interrupt handler could try to access
buffers that
Replace the custom ioctl with a V4L2 control in order to standardize the
API.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_lut.c | 76 +++---
drivers/media/platform/vsp1/vsp1_lut.h | 6 +--
include/uapi/linux/vsp1.h | 34 -
The CLU processing block is a 2D/3D lookup table that converts the input
three color component data into desired three color components using a
lookup table.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/Makefile | 2 +-
drivers/media/platform/vsp1/vsp1.h| 3 +
Vertical flipping is available on both Gen2 and Gen3, while horizontal
flipping is only available on Gen3.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1.h | 2 +
drivers/media/platform/vsp1/vsp1_drv.c | 15 ++--
drivers/media/platform/vsp1/vsp1_regs.h | 7 ++
dr
The intensity control reused the V4L2_CID_CONTRAST control ID by
mistake. Fix it by using an ID from the device-specific IDs range.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_sru.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platfor
Controls are applied to the hardware in the configure operation of the
VSP entities, which is only called when starting the video stream. To
enable runtime modification of controls we need to call the configure
operations for every frame. Doing so is currently not safe, as most
parameters shouldn't
Check the entity pointer instead of the feature flag to see if the
entity is available before creating related links. The two methods are
currently equivalent, but will differ in the future as we implement
support for ignoring some of the entities present in the hardware.
Signed-off-by: Laurent Pi
The vsp1_pipeline wq field is a wait queue, not a work queue. Fix the
comment accordingly.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_pipe.h
b/drivers/media/plat
The LIF is only used when feeding the VSP output to the DU. The only way
to do so is by controlling the VSP directly from the DU driver and
disabling the VSP userspace API. There is thus no need to create a LIF
entity when the userspace API is enabled, as it can't be used in that
case.
Signed-off-
Freeing a fragment requires freeing DMA coherent memory, which can be
performed with interrupts disabled as per the DMA mapping API contract.
The fragments can't thus be freed synchronously when a display list is
recycled. Instead, move the fragments to a garbage list and use a work
queue to run th
The format is used on the R-Car VSP1 video queues that carry
1-D histogram statistics data.
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
---
.../DocBook/media/v4l/pixfmt-meta-vsp1-hgo.xml | 307 +
Documentation/DocBook/media/v4l/pixfmt.xml | 9 +
driv
The HGO is never used in the DRM pipeline, there is thus no need to
create an HGO entity when the userspace API is disabled.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/
The HGO is a Histogram Generator One-Dimension. It computes per-channel
histograms over a configurable region of the image with optional
subsampling.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/Kconfig| 1 +
drivers/media/platform/vsp1/Makefile | 2 +
drivers/
Initialize the function field of all subdev entities instantiated by the
driver. This gets rids of multiple warnings printed by the media
controller core.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_bru.c| 3 ++-
drivers/media/platform/vsp1/vsp1_entity.c | 3 ++-
dri
The media device doesn't need to be exposed to userspace when the VSP is
fully controlled by the DU driver. Don't register it in that case.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_drv.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --gi
Add composer, pixel formatter, pixel encoding converter and scaler
functions.
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verkuil
Acked-by: Sakari Ailus
---
Documentation/DocBook/media/v4l/media-types.xml | 55 +
include/uapi/linux/media.h | 9 +
The video statistics function describes entities such as video histogram
engines or 3A statistics engines.
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verkuil
Acked-by: Sakari Ailus
---
Documentation/DocBook/media/v4l/media-types.xml | 9 +
include/uapi/linux/media.h
The LUT mutex isn't initialized when creating the LUT, fix it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_lut.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_lut.c
b/drivers/media/platform/vsp1/vsp1_lut.c
index 2c367cb9755c..9a2
Hi Hans,
On Fri, Jun 17, 2016 at 06:21:05PM +0200, Hans Verkuil wrote:
> On 05/05/2016 01:06 AM, Sakari Ailus wrote:
> > Instead of checking for a strict size for the IOCTL arguments, place
> > minimum and maximum limits.
> >
> > As an additional bonus, IOCTL handlers will be able to check whethe
On Fri 2016-06-17 19:12:14, Pavel Machek wrote:
> Hi!
>
> > First, I re-did pipeline setup in python, it seems slightly less hacky
> > then in shell.
> >
> > I tried to modify fcam-dev to work with the new interface, but was not
> > successful so far. I can post patches if someone is interested
>
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> The 10-bit packed raw bayer format documented that the data of the first
> pixel of a four-pixel group was found in the first byte and the two
> highest bits of the fifth byte. This was not entirely correct. The two
> bits in the fifth byte are the two
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> The number of high order bits in samples was documented to be 6 for 12-bit
> data. This is clearly wrong, fix it.
>
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Hans
> ---
> Documentation/DocBook/media/v4l/pixfmt-srggb12.xml | 2 +
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> - Explicitly state that the most significant n bits are zeroed on 10 and
> 12 bpp formats.
> - Remove extra comma from the last entry of the format list
> - Add a missing colon before a list
>
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
The 10-bit packed raw bayer format documented that the data of the first
pixel of a four-pixel group was found in the first byte and the two
highest bits of the fifth byte. This was not entirely correct. The two
bits in the fifth byte are the two lowest bits. The second pixel occupies
the second by
On 20 June 2016 at 15:31, Daniel Vetter wrote:
> On Sun, Jun 19, 2016 at 02:31:31PM +0200, Mathias Krause wrote:
>> [...]
>> With no users left, we can remove dma_buf_debugfs_create_file().
>>
>> While at it, simplify the error handling in dma_buf_init_debugfs()
>> slightly.
>>
>> Signed-off-by: M
From: Jouni Ukkonen
The codes will be called:
MEDIA_BUS_FMT_SBGGR14_1X14
MEDIA_BUS_FMT_SGBRG14_1X14
MEDIA_BUS_FMT_SGRBG14_1X14
MEDIA_BUS_FMT_SRGGB14_1X14
Signed-off-by: Jouni Ukkonen
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/DocBook
Hi all,
These patches fix and add new raw bayer format definitions. 12-bit packed
V4L2 format definition is added as well as definitions of 14-bit media bus
codes as well as unpacked and packed V4L2 formats.
No driver uses them right now, yet they're common formats needed by newer
devices that us
The formats added by this patch are:
V4L2_PIX_FMT_SBGGR14
V4L2_PIX_FMT_SGBRG14
V4L2_PIX_FMT_SGRBG14
V4L2_PIX_FMT_SRGGB14
Signed-off-by: Jouni Ukkonen
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/pixfmt-srggb14.xml | 91
These formats are compressed 14-bit raw bayer formats with four different
pixel orders. They are similar to 10-bit variants. The formats added by
this patch are
V4L2_PIX_FMT_SBGGR14P
V4L2_PIX_FMT_SGBRG14P
V4L2_PIX_FMT_SGRBG14P
V4L2_PIX_FMT_SRGGB14P
Signed-off-by: S
- Explicitly state that the most significant n bits are zeroed on 10 and
12 bpp formats.
- Remove extra comma from the last entry of the format list
- Add a missing colon before a list
Signed-off-by: Sakari Ailus
---
Documentation/DocBook/media/v4l/pixfmt-srggb10.xml | 5 +++--
Documentation/
These formats are compressed 12-bit raw bayer formats with four different
pixel orders. They are similar to 10-bit variants. The formats added by
this patch are
V4L2_PIX_FMT_SBGGR12P
V4L2_PIX_FMT_SGBRG12P
V4L2_PIX_FMT_SGRBG12P
V4L2_PIX_FMT_SRGGB12P
Signed-off-by: S
On 06/20/2016 06:18 PM, Nick Dyer wrote:
> On 20/06/2016 17:09, Hans Verkuil wrote:
>> On 06/17/2016 04:16 PM, Nick Dyer wrote:
>>> @@ -2325,11 +2344,20 @@ static int mxt_vidioc_querycap(struct file *file,
>>> void *priv,
>>> static int mxt_vidioc_enum_input(struct file *file, void *priv,
>>>
The number of high order bits in samples was documented to be 6 for 12-bit
data. This is clearly wrong, fix it.
Signed-off-by: Sakari Ailus
---
Documentation/DocBook/media/v4l/pixfmt-srggb12.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/p
On 06/17/2016 04:16 PM, Nick Dyer wrote:
> Function 54 implements access to various RMI4 diagnostic features.
>
> This patch adds support for retrieving this data. It registers a V4L2
> device to output the data to user space.
>
> Signed-off-by: Nick Dyer
> ---
> drivers/input/rmi4/Kconfig
On 20/06/2016 17:09, Hans Verkuil wrote:
> On 06/17/2016 04:16 PM, Nick Dyer wrote:
>> @@ -2325,11 +2344,20 @@ static int mxt_vidioc_querycap(struct file *file,
>> void *priv,
>> static int mxt_vidioc_enum_input(struct file *file, void *priv,
>> struct v4l2_input *
On 06/17/2016 04:16 PM, Nick Dyer wrote:
> There are different datatypes available from a maXTouch chip. Add
> support to retrieve reference data as well.
>
> Signed-off-by: Nick Dyer
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 58
>
> 1 file changed, 51
On 06/20/2016 06:03 PM, Sakari Ailus wrote:
> Hi Hans,
>
> Hans Verkuil wrote:
>> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>>> The formats added by this patch are:
>>>
>>> V4L2_PIX_FMT_SBGGR14
>>> V4L2_PIX_FMT_SGBRG14
>>> V4L2_PIX_FMT_SGRBG14
>>> V4L2_PIX_FMT_SRGGB14
>>>
>>> Sig
Hi Hans,
Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> The formats added by this patch are:
>>
>> V4L2_PIX_FMT_SBGGR14
>> V4L2_PIX_FMT_SGBRG14
>> V4L2_PIX_FMT_SGRBG14
>> V4L2_PIX_FMT_SRGGB14
>>
>> Signed-off-by: Jouni Ukkonen
>> Signed-off-by: Sakari Ail
When building with "make W=1", we get multiple harmless build warnings
for the vpfe driver:
drivers/staging/media/davinci_vpfe/dm365_resizer.c:241:1: error: 'static' is
not at beginning of declaration [-Werror=old-style-declaration]
drivers/staging/media/davinci_vpfe/dm365_resizer.c: In function
C libraries with 64-bit time_t use an incompatible format for
struct omap3isp_stat_data. This changes the kernel code to
support either version, by moving over the normal handling
to the 64-bit variant, and adding compatiblity code to handle
the old binary format with the existing ioctl command cod
On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote:
> Where is this "audio_time" program of which you speak?
Never mind, found it in alsa-lib.
I still would appreciate an answer to my other questions, though...
Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubs
Hi Hans,
Thanks for the review!
Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> These formats are compressed 12-bit raw bayer formats with four different
>> pixel orders. They are similar to 10-bit variants. The formats added by
>> this patch are
>>
>> V4L2_PIX_FMT_SBGGR
Hi Hans,
Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> The 10-bit packed raw bayer format documented that the data of the first
>> pixel of a four-pixel group was found in the first byte and the two
>> highest bits of the fifth byte. This was not entirely correct. The two
>>
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> These formats are compressed 14-bit raw bayer formats with four different
> pixel orders. They are similar to 10-bit variants. The formats added by
> this patch are
>
> V4L2_PIX_FMT_SBGGR14P
> V4L2_PIX_FMT_SGBRG14P
> V4L2_PIX_FMT_SGRB
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> From: Jouni Ukkonen
>
> The codes will be called:
>
> MEDIA_BUS_FMT_SBGGR14_1X14
> MEDIA_BUS_FMT_SGBRG14_1X14
> MEDIA_BUS_FMT_SGRBG14_1X14
> MEDIA_BUS_FMT_SRGGB14_1X14
>
> Signed-off-by: Jouni Ukkonen
> Signed-off-by: Sakari
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> These formats are compressed 12-bit raw bayer formats with four different
> pixel orders. They are similar to 10-bit variants. The formats added by
> this patch are
>
> V4L2_PIX_FMT_SBGGR12P
> V4L2_PIX_FMT_SGBRG12P
> V4L2_PIX_FMT_SGRB
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> The formats added by this patch are:
>
> V4L2_PIX_FMT_SBGGR14
> V4L2_PIX_FMT_SGBRG14
> V4L2_PIX_FMT_SGRBG14
> V4L2_PIX_FMT_SRGGB14
>
> Signed-off-by: Jouni Ukkonen
> Signed-off-by: Sakari Ailus
> ---
> Documentation/DocBook/
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> The 10-bit packed raw bayer format documented that the data of the first
> pixel of a four-pixel group was found in the first byte and the two
> highest bits of the fifth byte. This was not entirely correct. The two
> bits in the fifth byte are the two
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> The number of high order bits in samples was documented to be 6 for 12-bit
> data. This is clearly wrong, fix it.
>
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Thanks,
Hans
> ---
> Documentation/DocBook/media/v4l/pixfmt-srggb12.
Card/scan works fine picking up non-HD. Never getting any HD channels.
UK based. STB picks up all channels fine. Transponder details from
Astra-28.2E dvb-s, and matches BBC details.
On latest clone of master git repo, using only BBCHD transponder:
# Transponder 50
[CHANNEL]
DELIVERY_SYSTEM
On Mon, Jun 20, 2016 at 02:47:23PM +0200, Ricardo Ribalda Delgado wrote:
> After all the code refactoring, vb2_internal_dqbuf is only called by
> vb2_dqbuf.
>
> Since the function it is very simple, there is no need to have two
> functions.
>
> Signed-off-by: Ricardo Ribalda Delgado
Hi, Ricardo
On Mon, 20 Jun 2016 09:45:26 -0400
Rob Clark wrote:
> On Mon, Jun 20, 2016 at 8:37 AM, Pekka Paalanen wrote:
> > On Fri, 17 Jun 2016 11:44:34 -0400
> > Rob Clark wrote:
> >
> >> On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen
> >> wrote:
> >> > On Fri, 17 Jun 2016 08:26:04 -0400
> >> > Ro
On Mon, Jun 20, 2016 at 8:37 AM, Pekka Paalanen wrote:
> On Fri, 17 Jun 2016 11:44:34 -0400
> Rob Clark wrote:
>
>> On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen wrote:
>> > On Fri, 17 Jun 2016 08:26:04 -0400
>> > Rob Clark wrote:
>> >
>> >> On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen
>
On Sun, Jun 19, 2016 at 02:31:31PM +0200, Mathias Krause wrote:
> There is only a single user of dma_buf_debugfs_create_file() and that
> one got the function pointer cast wrong. With that one fixed, there is
> no need to have a wrapper for debugfs_create_file(), just call it
> directly.
>
> With
On Sun, Jun 19, 2016 at 02:31:29PM +0200, Mathias Krause wrote:
> The callback function dma_buf_describe() returns an int not void so the
> function pointer cast in dma_buf_show() is wrong. dma_buf_describe() can
> also fail when acquiring the mutex gets interrupted so always returning
> 0 in dma_b
After all the code refactoring, vb2_internal_dqbuf is only called by
vb2_dqbuf.
Since the function it is very simple, there is no need to have two
functions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-v4l2.c | 39 ++--
1 file changed
The comment was referencing the wrong function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/videobuf2-core.c
index 633fc
According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF:
V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or
VIDIOC_DQBUF it is always cleared ...
Unfortunately, it seems that videobuf2 keeps it set after DQBUF. This
can be tested with vivid and dev_debug:
[257604.338082]
After all the code refactoring, vb2_internal_dqbuf is only called by
vb2_dqbuf.
Since the function it is very simple, there is no need to have
two functions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-v4l2.c | 14 +-
1 file changed, 5 insertions(+),
After all the code refactoring, vb2_internal_dqbuf is only called by
vb2_dqbuf.
Since the function it is very simple, there is no need to have two
functions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-v4l2.c | 27 +++
1 file changed, 11
On 06/20/2016 02:30 PM, Ricardo Ribalda Delgado wrote:
According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF:
V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or
VIDIOC_DQBUF it is always cleared ...
Unfortunately, it seems that videobuf2 keeps it set after DQBUF. This
On Fri, 17 Jun 2016 11:44:34 -0400
Rob Clark wrote:
> On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen wrote:
> > On Fri, 17 Jun 2016 08:26:04 -0400
> > Rob Clark wrote:
> >
> >> On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen
> >> wrote:
> >> > On Thu, 16 Jun 2016 10:40:51 -0400
> >> > Ro
On Mon, Jun 20, 2016 at 02:18:38PM +0200, Richard Cochran wrote:
> Documentation/sound/alsa/timestamping.txt says:
Examples of typestamping with HDaudio:
1. DMA timestamp, no compensation for DMA+analog delay
$ ./audio_time -p --ts_type=1
Where is this "audio_time" program of which you
According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF:
V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or
VIDIOC_DQBUF it is always cleared ...
Unfortunately, it seems that videobuf2 keeps it set after DQBUF. This
can be tested with vivid and dev_debug:
[257604.338082]
The comment was referencing the wrong function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/videobuf2-core.c
index 633fc
After all the code refactoring, vb2_internal_dqbuf is only called by
vb2_dqbuf.
Since the function it is very simple, there is no need to have
two functions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/videobuf2-v4l2.c | 14 +-
1 file changed, 5 insertions(+),
According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF and
QBUF:
V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or
VIDIOC_DQBUF it is always cleared ..
This patch implements this check.
Signed-off-by: Ricardo Ribalda Delgado
---
Hello Hans!
Maybe you do not want to
On Mon, Jun 20, 2016 at 01:08:27PM +0200, Pierre-Louis Bossart wrote:
> The ALSA API provides support for 'audio' timestamps (playback/capture rate
> defined by audio subsystem) and 'system' timestamps (typically linked to
> TSC/ART) with one option to take synchronized timestamps should the hardwa
On 06/17/2016 04:16 PM, Nick Dyer wrote:
> Some touch controllers send out raw touch data in a similar way to a
> greyscale frame grabber. Add a new device type for these devices.
>
> Use a new device prefix v4l-touch for these devices, to stop generic
> capture software from treating them as webc
Hi Hans-
On 20/06/2016 12:00, Hans Verkuil wrote:
> On 06/17/2016 04:16 PM, Nick Dyer wrote:
>> This will be used for output of raw touch delta data. This format is
>> used by Atmel maXTouch (atmel_mxt_ts) and also Synaptics RMI4.
>>
>> Signed-off-by: Nick Dyer
>> ---
>> Documentation/DocBook/me
On Mon, Jun 20, 2016 at 01:08:27PM +0200, Pierre-Louis Bossart wrote:
>
> >Presentation time is either set by
> >a) Local sound card performing capture (in which case it will be 'capture
> > time')
> >b) Local media application sending a stream accross the network
> > (time when the sample sho
Presentation time is either set by
a) Local sound card performing capture (in which case it will be 'capture
time')
b) Local media application sending a stream accross the network
(time when the sample should be played out remotely)
c) Remote media application streaming data *to* host, in
On 06/17/2016 04:16 PM, Nick Dyer wrote:
> This will be used for output of raw touch delta data. This format is
> used by Atmel maXTouch (atmel_mxt_ts) and also Synaptics RMI4.
>
> Signed-off-by: Nick Dyer
> ---
> Documentation/DocBook/media/v4l/pixfmt-ys16.xml | 79
> +
On 20/06/16 11:16, Gary Bisson wrote:
Jack, All,
On Mon, Jun 20, 2016 at 10:44:44AM +0100, Jack Mitchell wrote:
I've tried that patch have a some comments:
- When applied, no capture shows up any more, instead I have two m2m
v4l2 devices [1].
- OV5640 Mipi is assigned the same address as
On 06/20/2016 12:12 PM, Ricardo Ribalda Delgado wrote:
> Good catch :)
>
> I will prepare the new version. Btw, can I also merge
> vb2_internal_dqbuf and vb2_dqbuf in one function? Seems a bit
> overkilled that split.
No, that's not possible. vb2_internal_dqbuf is used in the threading
code to im
Jack, All,
On Mon, Jun 20, 2016 at 10:44:44AM +0100, Jack Mitchell wrote:
>
> > I've tried that patch have a some comments:
> > - When applied, no capture shows up any more, instead I have two m2m
> > v4l2 devices [1].
> > - OV5640 Mipi is assigned the same address as OV5642, therefore both
>
On 20/06/16 10:33, Gary Bisson wrote:
Steve, Jack, All,
On Fri, Jun 17, 2016 at 12:01:41PM -0700, Steve Longerbeam wrote:
On 06/17/2016 08:18 AM, Gary Bisson wrote:
Steve, All,
On Thu, Jun 16, 2016 at 10:32:31AM +0200, Gary Bisson wrote:
Steve, All,
On Tue, Jun 14, 2016 at 03:49:15PM -07
Good catch :)
I will prepare the new version. Btw, can I also merge
vb2_internal_dqbuf and vb2_dqbuf in one function? Seems a bit
overkilled that split.
Regarding v42l_compliance... I can take care of that if you dare :)
Best regards!
On Mon, Jun 20, 2016 at 11:53 AM, Hans Verkuil wrote:
> On
On 06/20/2016 11:01 AM, Ricardo Ribalda Delgado wrote:
> According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF:
>
> V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or
> VIDIOC_DQBUF it is always cleared ...
>
> Unfortunately, it seems that videobuf2 keeps it set after D
Steve, Jack, All,
On Fri, Jun 17, 2016 at 12:01:41PM -0700, Steve Longerbeam wrote:
>
> On 06/17/2016 08:18 AM, Gary Bisson wrote:
> > Steve, All,
> >
> > On Thu, Jun 16, 2016 at 10:32:31AM +0200, Gary Bisson wrote:
> > > Steve, All,
> > >
> > > On Tue, Jun 14, 2016 at 03:49:15PM -0700, Steve L
1 - 100 of 105 matches
Mail list logo
