cron job: media_tree daily build: WARNINGS

2015-08-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 22 04:00:16 CEST 2015 git branch: test git hash: 3a6b0605c73d1d695f6d4e49289deaa3fa3e73ee gcc versi

Re: [PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Mike Isely
The code you've added is carefully checking the return pointer from pvr2_hdw_get_ctrl_v4l() yet the original code did not operate this way. The result is that now there's this "unbalanced" effect where it appears that the validity of the pvr2_ctrl instance is only checked on one side of the i

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 18:09:31 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 20:54:29 +0300 Laurent Pinchart escreveu: > > On Friday 21 August 2015 07:19:21 Mauro Carvalho Chehab wrote: > >> Em Fri, 21 Aug 2015 04:32:51 +0300 Laurent Pinchart escreveu: > >>> On Wednesday 19 Augus

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 18:01:31 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 20:51:10 +0300 Laurent Pinchart escreveu: > > On Friday 21 August 2015 07:09:44 Mauro Carvalho Chehab wrote: > >> Em Fri, 21 Aug 2015 04:10:03 +0300 Laurent Pinchart escreveu: > >>> On Wednesday 19 Augus

Re: [PATCH] v4l: omap3isp: Enable driver compilation with COMPILE_TEST

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 17:45:15 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 21:09:17 +0300 Laurent Pinchart escreveu: > > The omap3isp driver can't be compiled on non-ARM platforms but has no > > compile-time dependency on OMAP. Drop the OMAP dependency when > > COMPILE_TEST is

Re: [PATCH v2 09/21] ARM: pxa: magician: Add OV9640 camera support

2015-08-21 Thread Petr Cvek
Dne 21.8.2015 v 19:36 Robert Jarzmik napsal(a): > I shrunk a bit the mailing list. > > Arnd Bergmann writes: > >> On Friday 21 August 2015 00:39:30 Petr Cvek wrote: >>> Dne 20.8.2015 v 22:26 Arnd Bergmann napsal(a): On Thursday 20 August 2015 21:48:20 Robert Jarzmik wrote: > Petr Cvek

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 20:54:29 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 07:19:21 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 04:32:51 +0300 Laurent Pinchart escreveu: > > > On Wednesday 19 August 2015 08:01:54 Mauro Carvalho Chehab wrote: > > > > It helps

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 20:51:10 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 07:09:44 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 04:10:03 +0300 Laurent Pinchart escreveu: > > > On Wednesday 19 August 2015 08:01:50 Mauro Carvalho Chehab wrote: > > >> As entitie

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 21:11:57 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 14:45:35 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 20:27:19 +0300 Laurent Pinchart escreveu: > > > On Friday 21 August 2015 05:42:29 Mauro Carvalho Chehab wrote: > > >> Em Fri, 21 Au

Re: [PATCH] v4l: omap3isp: Enable driver compilation with COMPILE_TEST

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 21:09:17 +0300 Laurent Pinchart escreveu: > The omap3isp driver can't be compiled on non-ARM platforms but has no > compile-time dependency on OMAP. Drop the OMAP dependency when > COMPILE_TEST is set. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/Kconf

[PATCH] [media] i2c: fix platform_no_drv_owner.cocci warnings

2015-08-21 Thread kbuild test robot
drivers/media/i2c/tc358743.c:1960:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Geert Uytterhoeven Signed-off-by: Fengguang Wu --- tc358743.c |1

[linux-next:master 7080/10086] drivers/media/i2c/tc358743.c:1960:3-8: No need to set .owner here. The core will do it.

2015-08-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 1ef981bcd18de26dc78bc79f092d6f4bb25e0e8f commit: 5cc596c66fe7c725ec049ae2093e7242034c97d6 [7080/10086] [media] i2c: Make all i2c devices visible if COMPILE_TEST=y coccinelle warnings: (new ones prefixed by >

Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: > After adding the format check in try_fmt()/set_fmt(), we don't need any > format check in configure_geometry(). So make configure_geometry() as > void type. > > Signed-off-by: Josh Wu > --- > > Changes in v3:

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 14:45:35 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 20:27:19 +0300 Laurent Pinchart escreveu: > > On Friday 21 August 2015 05:42:29 Mauro Carvalho Chehab wrote: > >> Em Fri, 21 Aug 2015 03:40:48 +0300 Laurent Pinchart escreveu: > >> > On Wednesday 19 Augu

[PATCH] v4l: omap3isp: Enable driver compilation with COMPILE_TEST

2015-08-21 Thread Laurent Pinchart
The omap3isp driver can't be compiled on non-ARM platforms but has no compile-time dependency on OMAP. Drop the OMAP dependency when COMPILE_TEST is set. Signed-off-by: Laurent Pinchart --- drivers/media/platform/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 07:19:21 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 04:32:51 +0300 Laurent Pinchart escreveu: > > On Wednesday 19 August 2015 08:01:54 Mauro Carvalho Chehab wrote: > > > It helps to check if the media controller is doing the > > > right thing with the obj

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 07:09:44 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 04:10:03 +0300 Laurent Pinchart escreveu: > > On Wednesday 19 August 2015 08:01:50 Mauro Carvalho Chehab wrote: > >> As entities are graph elements, let's embed media_gobj > >> on it. That ensures an uni

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 20:27:19 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Friday 21 August 2015 05:42:29 Mauro Carvalho Chehab wrote: > > Em Fri, 21 Aug 2015 03:40:48 +0300 Laurent Pinchart escreveu: > > > On Wednesday 19 August 2015 08:01:48 Mauro Carvalho Chehab wrote: > > > > Instead o

[PATCHv2] DocBook/device-drivers: Add drivers/media core stuff

2015-08-21 Thread Mauro Carvalho Chehab
There are lots of docbook marks at the media subsystem, but those aren't used. Add the core headers/code in order to start generating docs. --- WARNING: Please notice that, while this doesn't cause any error, still there are lots of warnings to be fixed: http://pastebin.com/Ld916dFi An

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-21 Thread Laurent Pinchart
Hi Mauro, On Friday 21 August 2015 05:42:29 Mauro Carvalho Chehab wrote: > Em Fri, 21 Aug 2015 03:40:48 +0300 Laurent Pinchart escreveu: > > On Wednesday 19 August 2015 08:01:48 Mauro Carvalho Chehab wrote: > > > Instead of accessing directly entity.id, let's create a macro, > > > as this field wi

[PATCH RFC] DocBook/device-drivers: Add drivers/media core stuff

2015-08-21 Thread Mauro Carvalho Chehab
There are lots of docbook marks at the media subsystem, but those aren't used. Add the core headers/code in order to start generating docs. === WARNING: === Please notice that the output is currently broken: http://pastebin.com/JcXsqcVH Before applying this one, we need to fix t

[GIT PULL for v4.2] media fixes

2015-08-21 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.2-3 For some fixes: - a regression fix at the videobuf2 core driver; - Fix error handling at mantis probing code; - Revert the IR encode patches, as the API is no

[PATCH] [media] DocBook: fix an unbalanced tag

2015-08-21 Thread Mauro Carvalho Chehab
The got lost on some change at the DVB docbook, making the tag unbalanced and causing a warning. Fix it. Signed-off-by: Mauro Carvalho Chehab diff --git a/Documentation/DocBook/media/dvb/intro.xml b/Documentation/DocBook/media/dvb/intro.xml index d30751338493..51db15648099 100644 --- a/Documen

Bugs reporting

2015-08-21 Thread Anton Tinchev
Hi, can you point me where is usually reported the bugs with the cards firmware and/or drivers. The combination is Cine S2 v6.5 with Duoflex S2 V4. The miniDiSEqC (AB) is not working on the Duoflex S2 V4. Is not board fault, same behavior have all cards i tested - about 20 Duoflex and 8 Cine mo

[PATCH v2 05/10] media/v4l2-core: struct struct v4l2_ext_controls param which

2015-08-21 Thread Ricardo Ribalda Delgado
Support for new field which on v4l2_ext_controls, used to get the default value of one or more controls. Signed-off-by: Ricardo Ribalda Delgado --- I missed a ;... sorry about that drivers/media/v4l2-core/v4l2-ctrls.c | 34 +- 1 file changed, 29 insertions(+), 5

[PATCH] saa7164: convert to the control framework

2015-08-21 Thread Hans Verkuil
Convert this driver to the control framework. Note that the VBI device nodes have no controls as there is nothing to control. Signed-off-by: Hans Verkuil --- Steve, can you test this patch? For some reason my saa7164 isn't seen anymore on the PCIe bus, so I can't test it myself :-( This patch g

Re: WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90()

2015-08-21 Thread Laura Abbott
On 08/21/2015 03:21 AM, poma wrote: On 10.08.2015 23:26, poma wrote: [ cut here ] WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90() Modules linked in: mxl5007t af9013 ... dvb_usb_af9015(+) ... dvb_usb_v2 dvb_core rc_core ... CPU

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Hans Verkuil
On 08/21/2015 03:03 PM, Thierry Reding wrote: > On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: >> NVIDIA Tegra processor contains a powerful Video Input (VI) hardware >> controller which can support up to 6 MIPI CSI camera sensors. >> >> This patch adds a V4L2 media controller and captur

[PATCH v2 04/10] media/core: Replace ctrl_class with which

2015-08-21 Thread Ricardo Ribalda Delgado
Replace the obsolete field ctrl_class with "which". Make sure it not used in future modules by commenting out the field with ifndef __KERNEL_ . The field cannot be simply removed because that would be change on the kenel API to the userspace (and we don't like that). Signed-off-by: Ricardo Ribal

[PATCH v2 03/10] media/v4l2-compat-ioctl32: Simple stylechecks

2015-08-21 Thread Ricardo Ribalda Delgado
The next patches on the serie need this modifications to pass clean checkpath.pl. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32

[PATCH v2 00/10] Support getting default values from any control

2015-08-21 Thread Ricardo Ribalda Delgado
Integer controls provide a way to get their default/initial value, but any other control (p_u32, p_u8.) provide no other way to get the initial value than unloading the module and loading it back. *What is the actual problem? I have a custom control with WIDTH integer values. Every value repre

[PATCH v2 01/10] videodev2.h: Fix typo in comment

2015-08-21 Thread Ricardo Ribalda Delgado
Referenced file has moved Signed-off-by: Ricardo Ribalda Delgado --- include/uapi/linux/videodev2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 3228fbebcd63..72fa3e490e30 100644 --- a/include/uapi/linux

[PATCH v2 06/10] usb/uvc: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/uvc/uvc_v4l2.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/media/us

[PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v2 05/10] media/v4l2-core: struct struct v4l2_ext_controls param which

2015-08-21 Thread Ricardo Ribalda Delgado
Support for new field which on v4l2_ext_controls, used to get the default value of one or more controls. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v2 08/10] media/pci/saa7164-encoder Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/pci/saa7164/saa7164-encoder.c | 55 - 1 file changed, 31 insertions(+), 24 deletions(-) d

[PATCH v2 10/10] Docbook: media: Document changes on struct v4l2_ext_controls

2015-08-21 Thread Ricardo Ribalda Delgado
Vidioc-g-ext-ctrls can now be used to get the default value of the controls. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/DocBook/media/v4l/v4l2.xml | 9 + .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 22 ++ 2 files changed, 31 insertion

[PATCH v2 09/10] media/pci/saa7164-vbi Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/pci/saa7164/saa7164-vbi.c | 57 +++-- 1 file changed, 33 insertions(+), 24 deletions(-) d

[PATCH v2 02/10] videodev2.h: Extend struct v4l2_ext_controls

2015-08-21 Thread Ricardo Ribalda Delgado
So it can be used to get the default value of a control. Without this change it is not possible to get get the default value of array controls. Signed-off-by: Ricardo Ribalda Delgado --- include/uapi/linux/videodev2.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/in

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Thierry Reding
On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: > NVIDIA Tegra processor contains a powerful Video Input (VI) hardware > controller which can support up to 6 MIPI CSI camera sensors. > > This patch adds a V4L2 media controller and capture driver to support > Tegra VI hardware. It's verif

[linux-next:master 7080/10086] drivers/media/i2c/s5k4ecgx.c:346:2: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int'

2015-08-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 1ef981bcd18de26dc78bc79f092d6f4bb25e0e8f commit: 5cc596c66fe7c725ec049ae2093e7242034c97d6 [7080/10086] [media] i2c: Make all i2c devices visible if COMPILE_TEST=y config: mn10300-allyesconfig (attached as .con

Re: [PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Hans Verkuil
On 08/21/2015 02:03 PM, Andrzej Hajda wrote: > Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u > is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have > different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running > on arm64 ker

[PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Andrzej Hajda
Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running on arm64 kernel. The patch fixes it. Using compat_s64 allows to r

[linux-next:master 7079/10086] drivers/media/dvb-frontends/or51132.c:140:2: warning: format '%Zd' expects argument of type 'signed size_t', but argument 2 has type 'size_t'

2015-08-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 1ef981bcd18de26dc78bc79f092d6f4bb25e0e8f commit: 6df34051d8bd8807c873e1bb92b905e370ff3f5b [7079/10086] [media] dvb-frontends: Make all DVB Frontends visible if COMPILE_TEST=y config: mn10300-allyesconfig (atta

Re: [PATCH 8/8] Docbook: media: Document changes on struct v4l2_ext_controls

2015-08-21 Thread Hans Verkuil
On 08/21/2015 11:29 AM, Ricardo Ribalda Delgado wrote: > Vidioc-g-ext-ctrls can now be used to get the default value of the > controls. > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/DocBook/media/v4l/v4l2.xml | 9 + > Documentation/DocBook/media/v4l/vidi

Re: [RFC PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Hans Verkuil
On 08/21/2015 11:50 AM, Andrzej Hajda wrote: > Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u > is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have > different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running > on arm64 ker

Re: [PATCH v6 6/8] [media] media: add messages when media device gets (un)registered

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 04:35:04 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:53 Mauro Carvalho Chehab wrote: > > We can only free the media device after being sure that no > > graph object is used. > > media_device_release() is cu

Re: WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90()

2015-08-21 Thread poma
On 10.08.2015 23:26, poma wrote: > > [ cut here ] > WARNING: CPU: 1 PID: 813 at kernel/module.c:291 > module_assert_mutex_or_preempt+0x49/0x90() > Modules linked in: mxl5007t af9013 ... dvb_usb_af9015(+) ... dvb_usb_v2 > dvb_core rc_core ... > CPU: 1 PID: 813 Comm: system

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 04:32:51 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:54 Mauro Carvalho Chehab wrote: > > It helps to check if the media controller is doing the > > right thing with the object creation and removal. > > > >

Re: [PATCH 3/8] media/v4l2-core: struct struct v4l2_ext_controls param which

2015-08-21 Thread Hans Verkuil
On 08/21/2015 11:29 AM, Ricardo Ribalda Delgado wrote: > Support for new field which on v4l2_ext_controls, used to get the > default value of one or more controls. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 35 ++- >

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 04:10:03 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:50 Mauro Carvalho Chehab wrote: > > As entities are graph elements, let's embed media_gobj > > on it. That ensures an unique ID for entities that can be >

Re: [PATCH v6 2/8] [media] media: add a common struct to be embed on media graph objects

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 04:02:57 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:49 Mauro Carvalho Chehab wrote: > > Due to the MC API proposed changes, we'll need to have an unique > > object ID for all graph objects, and have some sh

[RFC PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Andrzej Hajda
Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running on arm64 kernel. The patch fixes it. Signed-off-by: Andrzej Hajd

[PATCH 0/8] Support getting default values from any control

2015-08-21 Thread Ricardo Ribalda Delgado
Integer controls provide a way to get their default/initial value, but any other control (p_u32, p_u8.) provide no other way to get the initial value than unloading the module and loading it back. *What is the actual problem? I have a custom control with WIDTH integer values. Every value repre

[PATCH 2/8] videodev2.h: Extend struct v4l2_ext_controls

2015-08-21 Thread Ricardo Ribalda Delgado
So it can be used to get the default value of a control. Without this change it is not possible to get get the default value of array controls. Signed-off-by: Ricardo Ribalda Delgado --- include/uapi/linux/videodev2.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/in

[PATCH 1/8] videodev2.h: Fix typo in comment

2015-08-21 Thread Ricardo Ribalda Delgado
Referenced file has moved Signed-off-by: Ricardo Ribalda Delgado --- include/uapi/linux/videodev2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 3228fbebcd63..72fa3e490e30 100644 --- a/include/uapi/linux

[PATCH 8/8] Docbook: media: Document changes on struct v4l2_ext_controls

2015-08-21 Thread Ricardo Ribalda Delgado
Vidioc-g-ext-ctrls can now be used to get the default value of the controls. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/DocBook/media/v4l/v4l2.xml | 9 + Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 14 ++ 2 files changed, 23 insertion

[PATCH 3/8] media/v4l2-core: struct struct v4l2_ext_controls param which

2015-08-21 Thread Ricardo Ribalda Delgado
Support for new field which on v4l2_ext_controls, used to get the default value of one or more controls. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH 4/8] usb/uvc: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/uvc/uvc_v4l2.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/media/us

[PATCH 5/8] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 7/8] media/pci/saa7164-vbi Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/pci/saa7164/saa7164-vbi.c | 57 +++-- 1 file changed, 33 insertions(+), 24 deletions(-) d

[PATCH 6/8] media/pci/saa7164-encoder Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Ricardo Ribalda Delgado
This driver does not use the control infrastructure. Add support for the new field which on structure v4l2_ext_controls Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/pci/saa7164/saa7164-encoder.c | 55 - 1 file changed, 31 insertions(+), 24 deletions(-) d

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Hans Verkuil
Hi Bryan, Thanks for contributing this driver, very much appreciated. I do have some comments below, basically about the same things we discussed privately before. On 08/21/2015 02:51 AM, Bryan Wu wrote: > NVIDIA Tegra processor contains a powerful Video Input (VI) hardware > controller which ca

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-21 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2015 03:40:48 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:48 Mauro Carvalho Chehab wrote: > > Instead of accessing directly entity.id, let's create a macro, > > as this field will be moved into a common struct la

Re: [PATCH v6 2/8] [media] media: add a common struct to be embed on media graph objects

2015-08-21 Thread Hans Verkuil
On 08/21/2015 03:02 AM, Laurent Pinchart wrote: > Hi Mauro, > > Thank you for the patch. > > On Wednesday 19 August 2015 08:01:49 Mauro Carvalho Chehab wrote: >> +/* Enums used internally at the media controller to represent graphs */ >> + >> +/** >> + * enum media_gobj_type - type of a graph ele

[PATCH v3 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-21 Thread Josh Wu
In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register and just set part of it. So just set up this register directly makes things simpler. Currently only support YUV format from camera sensor.

[PATCH v3 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-21 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu Reviewed-by: L

[PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Josh Wu
After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Changes in v3: - check the whether format is supported, if no then return a default format. - misc changes accordi

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-21 Thread Hans Verkuil
On 08/21/2015 02:15 AM, Laurent Pinchart wrote: > Hi Javier, > > On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: >> On 08/20/2015 08:37 PM, Laurent Pinchart wrote: >>> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: The struct media_entity does not have