Hi Sakari,
Thank you for the patch.
On Wednesday 20 May 2015 01:41:43 Sebastian Reichel wrote:
> Hi Sakari,
>
> On Wed, May 20, 2015 at 02:08:05AM +0300, Sakari Ailus wrote:
> > The async notifier was registered before the v4l2_device was registered
> > and before the notifier callbacks were set
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed May 20 04:00:21 CEST 2015
git branch: test
git hash: 9cae84b32dd52768cf2fd2fcb214c3f570676c4b
gcc versi
On 05/16, Mikko Perttunen wrote:
> On 05/15/2015 06:40 PM, Boris Brezillon wrote:
> >Hi Stephen,
> >
> >Adding Mikko in the loop (after all, he was the one complaining about
> >this signed long limitation in the first place, and I forgot to add
> >him in the Cc list :-/).
>
> I think I got it thro
Hi Sakari,
On Wed, May 20, 2015 at 02:08:05AM +0300, Sakari Ailus wrote:
> The async notifier was registered before the v4l2_device was registered and
> before the notifier callbacks were set. This could lead to missing the
> bound() and complete() callbacks and to attempting to spin_lock() and
>
The async notifier was registered before the v4l2_device was registered and
before the notifier callbacks were set. This could lead to missing the
bound() and complete() callbacks and to attempting to spin_lock() and
uninitialised spin lock.
Also fix unregistering the async notifier in the case of
Signed-off-by: Sakari Ailus
---
drivers/leds/leds-max77693.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-max77693.c b/drivers/leds/leds-max77693.c
index fecd0ed..bd12744 100644
--- a/drivers/leds/leds-max77693.c
+++ b/drivers/leds/leds-max77693.c
Signed-off-by: Sakari Ailus
---
drivers/leds/leds-aat1290.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index c656a2d..71bf6bb 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -5
V4L2 async sub-devices are currently matched (OF case) based on the struct
device_node pointer in struct device. LED devices may have more than one
LED, and in that case the OF node to match is not directly the device's
node, but a LED's node.
Signed-off-by: Laurent Pinchart
Signed-off-by: Sakari
If CONFIG_V4L2_FLASH_LED_CLASS wasn't defined, v4l2_flash_init() and
v4l2_flash_release() were empty macros. This will lead to compiler warnings
in form of unused variables if the variables are not used for other
purposes.
Instead, implement v4l2_flash_init() and v4l2_flash_release() as static
inl
Hi Jacek, Mauro, others,
The first patch in this set adds the of_node pointer to struct v4l2_subdev
in order to match an async sub-device based on an explicit OF node instead
of the device's OF node, where the former is typically a child of the
latter.
Mauro: would you be ok with this patch going
The V4L2 sub-device node's dev will thus refer to the physical device, not
the LED flash device node. Also matching against device_node is possible in
cases where the LED flash controller drives multiple LEDs.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-flash.c | 10 ++
This patch changes rc-core to use the kernel facilities that are already
available for handling unique numbers instead of rolling its own bitmap
stuff.
Signed-off-by: David Härdeman
Tested-by: Stefan Lippers-Hollmann
---
drivers/media/rc/rc-ir-raw.c |2 +-
drivers/media/rc/rc-main.c | 4
The input_dev is already gone when the rc device is being unregistered
so checking for its presence only means that no remove uevent will be
generated.
Cc: sta...@kernel.org
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/driv
The first two patches are fixups that should be uncontroversial.
The third patch is another take on a similar patch already submitted by Sean.
The fourth patch is another cleanup that should be applied before we look
at implementing scancodes in the set/get keycode ioctls.
---
David Härdeman (4
The LIRC protocol was always a bad fit and if we're ever going to expose
protocol numbers in a user-space API, it'd be better to get rid of the
LIRC "protocol" first.
The sysfs API is kept backwards compatible by always listing the lirc
protocol as present and enabled.
Signed-off-by: David Härdem
On Thu, May 14, 2015 at 01:51:23PM -0300, Mauro Carvalho Chehab wrote:
>Em Thu, 19 Mar 2015 21:50:15 +
>Sean Young escreveu:
>
>> Since the lirc bridge is not a decoder we can remove its protocol. The
>> keymap existed only to select the protocol.
>
>This changes the userspace interface, as no
On Thu, May 14, 2015 at 06:24:46PM -0300, Mauro Carvalho Chehab wrote:
>Em Mon, 06 Apr 2015 13:26:18 +0200
>David Härdeman escreveu:
>
>> Introduce a list of "kernel" ir protocols (e.g. "sony12" instead of "sony")
>> and extend the set-key command to ir-keytable to allow for a mapping of the
>> fo
On Thu, May 14, 2015 at 05:29:29PM -0300, Mauro Carvalho Chehab wrote:
>Em Thu, 02 Apr 2015 12:18:55 +0200
>David Härdeman escreveu:
>
>> This patch changes rc-core to use the kernel facilities that are already
>> available for handling unique numbers instead of rolling its own bitmap
>> stuff.
>>
On Tue, Mar 31, 2015 at 08:48:06PM +0300, Antti Seppälä wrote:
>From: James Hogan
>
>Add a callback to raw ir handlers for encoding and modulating a scancode
>to a set of raw events. This could be used for transmit, or for
>converting a wakeup scancode filter to a form that is more suitable for
>r
This changes the keymap back to the state before commit 616a4b83
and changes the driver to use full NEC32 scancodes following the
instructions provided by Malcolm Priestley .
Signed-off-by: David Härdeman
---
drivers/media/rc/keymaps/rc-lme2510.c | 132
drivers
The coda tracing code causes lots of warnings like
In file included from /git/arm-soc/include/trace/define_trace.h:90:0,
from /git/arm-soc/drivers/media/platform/coda/trace.h:203,
from /git/arm-soc/drivers/media/platform/coda/coda-bit.c:34:
/git/arm-soc/include/tr
'struct timeval last_tv' is used to get the time of last signal change
and 'struct timeval last_intr_tv' is used to get the time of last UART
interrupt.
32-bit systems using 'struct timeval' will break in the year 2038, so we
have to replace that code with more appropriate types.
Here struct timeva
On Tue, May 19, 2015 at 07:00:50PM +0300, Antti Palosaari wrote:
> I am also against that kind of simplifications. Even it reduces line
> or two, it makes code more inconsistent, which means you have to
> make extra thinking when reading that code. I prefer similar
> repeating patterns as much as p
From: "Lad, Prabhakar"
the bus_type needs to be determined only on the hsync/vsync flags,
this patch fixes the above by moving the check just after hsync/vsync
flags are being set.
Reported-by: Nikhil Devshatwar
Signed-off-by: Lad, Prabhakar
---
drivers/media/v4l2-core/v4l2-of.c | 9 +
Hi Arnd,
Thanks for the patch.
On Tue, May 19, 2015 at 1:39 PM, Arnd Bergmann wrote:
> The newly added ov2659 driver uses the v4l2 subdev API, but
> can be enabled even when that API is not part of the kernel,
> resulting in this build error:
>
> media/i2c/ov2659.c: In function 'ov2659_get_fmt':
On Tue, May 19, 2015 at 12:00 PM, Mauro Carvalho Chehab
wrote:
> Some USB drivers have a logic at the VB buffer handling like:
> if (in_interrupt())
> BUG();
> Use, instead:
> BUG_ON(in_interrupt());
>
> Btw, this logic looks weird on my eyes. We should convert them
Hi Mauro,
Thanks for the patch.
On Thu, May 14, 2015 at 11:27 PM, Mauro Carvalho Chehab
wrote:
> The subdev API is optional. No driver should depend on it.
>
> Avoid compilation breakages if subdev API is not selected:
>
> drivers/media/i2c/ov2659.c: In function ‘ov2659_get_fmt’:
> drivers/media
Thanks, for the patch.
Acked-by: Benoit Parrot
Arnd Bergmann wrote on Tue [2015-May-19 14:39:12 +0200]:
> The newly added ov2659 driver uses the v4l2 subdev API, but
> can be enabled even when that API is not part of the kernel,
> resulting in this build error:
>
> media/i2c/ov2659.c: In funct
On 05/19/2015 03:17 PM, Michael Büsch wrote:
On Tue, 19 May 2015 08:05:56 -0400 (EDT)
Federico Simoncelli wrote:
diff --git a/drivers/media/dvb-frontends/lgs8gxx.c
b/drivers/media/dvb-frontends/lgs8gxx.c
index 3c92f36ea5c7..9b0166cdc7c2 100644
--- a/drivers/media/dvb-frontends/lgs8gxx.c
+++ b/d
On Tue, 19 May 2015 08:05:56 -0400 (EDT)
Federico Simoncelli wrote:
> > diff --git a/drivers/media/dvb-frontends/lgs8gxx.c
> > b/drivers/media/dvb-frontends/lgs8gxx.c
> > index 3c92f36ea5c7..9b0166cdc7c2 100644
> > --- a/drivers/media/dvb-frontends/lgs8gxx.c
> > +++ b/drivers/media/dvb-frontends/l
The newly added ov2659 driver uses the v4l2 subdev API, but
can be enabled even when that API is not part of the kernel,
resulting in this build error:
media/i2c/ov2659.c: In function 'ov2659_get_fmt':
media/i2c/ov2659.c:1054:8: error: implicit declaration of function
'v4l2_subdev_get_try_format'
Hi Mauro,
On Tue, 19 May 2015 08:23:36 -0300 Mauro Carvalho Chehab
wrote:
> As reported by smatch:
> drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
> drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but
> not used [-Wunused-but-set-variable]
On Tue, 19 May 2015 12:25:19 +0100 Jemma Denson
wrote:
> On 19/05/15 11:57, Mauro Carvalho Chehab wrote:
> >
> >> The only thing left now is moving UCB & BER over to DVBv5 stats - we
> >> haven't got anything close to any specs for this demod so I'm struggling
> >> to work out how to handle the c
- Original Message -
> From: "Mauro Carvalho Chehab"
> To: "Linux Media Mailing List"
> Cc: "Mauro Carvalho Chehab" , "Mauro Carvalho
> Chehab" , "Lars-Peter
> Clausen" , "Michael Buesch" , "Antti
> Palosaari" , "Hans Verkuil"
> , "Sakari Ailus" , "Ondrej
> Zary" ,
> "Ramakrishnan Muth
On 19/05/15 11:57, Mauro Carvalho Chehab wrote:
The only thing left now is moving UCB & BER over to DVBv5 stats - we
haven't got anything close to any specs for this demod so I'm struggling
to work out how to handle the counter increment.
It's not helped by my signal not being marginal enough t
As reported by smatch:
drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but
not used [-Wunused-but-set-variable]
int ret, ficus;
^
The values written by cx24120 are never checked. So, remove
drivers/media/dvb-frontends/cx24120.c:1182:5: warning: no previous prototype
for 'cx24120_init' [-Wmissing-prototypes]
int cx24120_init(struct dvb_frontend *fe)
^
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/dvb-frontends/cx24120.c
b/drivers/media/dvb-frontends/cx24120
Use const on the static data, as gcc may optimize better the
code. Also, would prevent that some code would override the
data there.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/dvb-frontends/cx24120.c
b/drivers/media/dvb-frontends/cx24120.c
index 2dcd93f63408..2b3f83d5b997 1
Hi Sean,
I'm taking over this patch series from Kamil for the time being with his
permission (he's switching jobs and moving house so he can't spend any time
on this for a while).
On 05/13/15 13:10, Sean Young wrote:
> On Mon, May 04, 2015 at 07:32:59PM +0200, Kamil Debski wrote:
>> From: Hans Ve
Some USB drivers have a logic at the VB buffer handling like:
if (in_interrupt())
BUG();
Use, instead:
BUG_ON(in_interrupt());
Btw, this logic looks weird on my eyes. We should convert them
to use VB2, in order to avoid those crappy things.
Signed-off-by: Mauro Car
If the last thing we do in a function is to call another
function and then return its value, we don't need to store
the returned code into some ancillary var.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/dvb-frontends/lgs8gxx.c
b/drivers/media/dvb-frontends/lgs8gxx.c
index 3c
Em Fri, 15 May 2015 16:18:07 +0100
Jemma Denson escreveu:
> Hi Mauro,
>
> On 15/05/15 15:24, Mauro Carvalho Chehab wrote:
> >> Of course. Jemma and me (mainly Jemma) are progressing and might be
> >> able to resubmit everything this weekend.
> > Good! Thanks for the good work!
> >
> > Mauro
>
>
Add support for a 16 bit wide greyscale format.
Signed-off-by: Ricardo Ribalda Delgado
---
This is the first time that I do something with OpenGL, please take a
good review of this patch before merging.
It has been tested with vivid and an nvidia-glx driver (propietary)
utils/qv4l2/capture-win-
Add support for a 16 bit wide greyscale format in big endian.
Signed-off-by: Ricardo Ribalda Delgado
---
This patch needs to be applied after the headers have been updated
to support Y16_BE. It is scheduled for 4.2.
It has been tested with vivid and an nvidia-glx driver (propietary)
utils/qv4l2
struct timeval uses a 32-bit seconds representation which will
overflow in the year 2038 and beyond. This patch replaces
the usage of struct timeval with ktime_t which is a 64-bit
timestamp and is year 2038 safe.
This patch is part of a larger attempt to remove all instances
of 32-bit timekeeping v
45 matches
Mail list logo
