Re: [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-06 Thread Stephen Boyd
On 04/30, Boris Brezillon wrote: > Clock rates are stored in an unsigned long field, but ->round_rate() > (which returns a rounded rate from a requested one) returns a long > value (errors are reported using negative error codes), which can lead > to long overflow if the clock rate exceed 2Ghz. >

Re: [PATCH] sta2x11: use monotonic timestamp

2015-05-06 Thread Hans Verkuil
On 05/07/2015 08:22 AM, Hans Verkuil wrote: > V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is > affected by daylight savings time. > Signed-off-by: Hans Verkuil > diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c > b/drivers/media/pci/sta2x11/sta2x11_vip.c > i

Re: [PATCH] rcar-vin: use monotonic timestamps

2015-05-06 Thread Hans Verkuil
On 05/07/2015 08:26 AM, Hans Verkuil wrote: > Even though the rcar-vin driver tells userspace that it will give a monotonic > timestamp, it is actually using gettimeofday. Replace this with a proper > monotonic timestamp. It was clearly too early in the day for me, but here is my Signed-off-by: S

Re: [PATCH] sta2x11: use monotonic timestamp

2015-05-06 Thread Hans Verkuil
Added Federico to the CC-list. On 05/07/2015 08:22 AM, Hans Verkuil wrote: > V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is > affected by daylight savings time. > > diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c > b/drivers/media/pci/sta2x11/sta2x11_vip.c >

[PATCH] rcar-vin: use monotonic timestamps

2015-05-06 Thread Hans Verkuil
Even though the rcar-vin driver tells userspace that it will give a monotonic timestamp, it is actually using gettimeofday. Replace this with a proper monotonic timestamp. diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c index 35deed8..b64df

[PATCH] sta2x11: use monotonic timestamp

2015-05-06 Thread Hans Verkuil
V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time. diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c b/drivers/media/pci/sta2x11/sta2x11_vip.c index d384a6b..59b3a36 100644 --- a/drivers/media/pci/sta2x11/sta2x11_vip.c +++ b/driver

cron job: media_tree daily build: ERRORS

2015-05-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 7 04:00:15 CEST 2015 git branch: test git hash: 1555f3bf5cc172e7d23c2b8db10d656d15bec13e gcc versi

Re: Mystique SaTiX-S2 Sky V2 USB (DVBSKY S960 clone) - Linux driver.

2015-05-06 Thread Steve
Hi, thanks for your help so far... It's taken a few days - but I've now tried a variety of things without arriving at any resolution. Prior to posting, I had not downloaded any firmware. I placed the firmware from http://www.dvbsky.net/download/linux/dvbsky-firmware.tar.gz into /lib/firmwar

Re: [Y2038] [PATCH v4 06/10] cec: add HDMI CEC framework: y2038 question

2015-05-06 Thread Arnd Bergmann
On Wednesday 06 May 2015 17:58:01 Hans Verkuil wrote: > > On 05/04/2015 12:14 PM, Arnd Bergmann wrote: > > On Monday 04 May 2015 09:42:36 Hans Verkuil wrote: > >> Ping! (Added Arnd to the CC list) > > > > Hi Hans, > > > > sorry I missed this the first time > > > >> On 04/27/2015 09:40 AM, Hans

Re: [Y2038] [PATCH v4 06/10] cec: add HDMI CEC framework: y2038 question

2015-05-06 Thread Hans Verkuil
Hi Arnd, On 05/04/2015 12:14 PM, Arnd Bergmann wrote: > On Monday 04 May 2015 09:42:36 Hans Verkuil wrote: >> Ping! (Added Arnd to the CC list) > > Hi Hans, > > sorry I missed this the first time > >> On 04/27/2015 09:40 AM, Hans Verkuil wrote: >>> Added the y2038 mailinglist since I would like

[GIT PULL] mem2mem changes for v4.2

2015-05-06 Thread Kamil Debski
The following changes since commit 1555f3bf5cc172e7d23c2b8db10d656d15bec13e: [media] saa7164: fix compiler warning (2015-05-01 09:09:58 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-4.2 for you to fetch changes up to 4fd781a3dfeac6b98e8aabfbba

Re: [PATCH v3] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-06 Thread Emil Velikov
Hi Kamil, There are a couple of bits that I've missed out previously. All but the missing install of libgencec.pc are general cleanups. On 6 May 2015 at 13:37, Kamil Debski wrote: > --- /dev/null > +++ b/.gitignore > @@ -0,0 +1,26 @@ > +/ar-lib You can drop this (see the configure.ac note). >

Re: [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

2015-05-06 Thread Jan Kara
On Wed 06-05-15 12:46:42, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of > >hand made mapping of virtual address to physical address. Also the > >function leaked page reference from get_user_pages() so fix

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-05-06 Thread Jan Kara
On Wed 06-05-15 12:47:35, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). > >This removes the knowledge about vmas and mmap_sem locking from exynos > >driver. Also it fixes a problem that the function has

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

2015-05-06 Thread Jan Kara
On Wed 06-05-15 12:45:51, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Provide new function get_vaddr_frames(). This function maps virtual > >addresses from given start and fills given array with page frame numbers of > >the corresponding pages. If given start belongs to a n

Re: [PATCH 3/4] Wrap LFS64 functions only if __GLIBC__

2015-05-06 Thread Hans Petter Selasky
On 05/05/15 14:34, Mauro Carvalho Chehab wrote: I'm afraid that removing the above would break for FreeBSD, as I think it also uses glibc, but not 100% sure. So, either we should get an ack from Hans Peter, or you should change the tests to: #if linux && __GLIBC__ Hi, Linux might be

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Daniel Vetter
On Wed, May 06, 2015 at 11:19:21AM +0200, Thierry Reding wrote: > On Wed, May 06, 2015 at 10:35:52AM +0200, Daniel Vetter wrote: > > On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: > > > > First what is Secure Data Path ? SDP is a set of hardware features to > > > > garanty >

[PATCH v3] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-06 Thread Kamil Debski
Add the libGenCEC library. It was designed to act as an interface between the generic CEC kernel API and userspace applications. It provides a simple interface for applications and an example application that can be used to test the CEC functionality. Signed-off-by: Kamil Debski --- Hi, This is

RE: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-06 Thread Kamil Debski
Hi Emil, From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Tuesday, May 05, 2015 5:03 PM > > Hi Kamil, > > It seems that you've only incorporated the libgencec.pc suggestion. > Did you change your mind about the others, found out something funny > with them (if so can you let me know wh

Re: [PATCH] Driver for Toshiba TC358743 HDMI to CSI-2 bridge

2015-05-06 Thread Hans Verkuil
Hi Mats, Here is one more: On 05/06/15 11:27, matra...@cisco.com wrote: > From: Mats Randgaard > > The driver is tested on our hardware and all the implemented features > works as expected. > > Missing features: > - CEC support > - HDCP repeater support > - IR support > > Signed-off-by: Mats

Re: ov2659: "error: implicit declaration of function ‘v4l2_subdev_get_try_format’"

2015-05-06 Thread Daniel Wagner
On 05/06/2015 01:27 PM, Daniel Wagner wrote: > Hi, > > I got this doing a randconfig on v4.1-rc2 Since this hits me all the time I did following hack which is probably completely stupid but hey it works :) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 6f30ea7..8b05681

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Rob Clark
On Wed, May 6, 2015 at 4:35 AM, Daniel Vetter wrote: > On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: >> > First what is Secure Data Path ? SDP is a set of hardware features to >> > garanty >> > that some memories regions could only be read and/or write by specific >> > har

Re: [RFCv2 PATCH 0/8] Add VIDIOC_SUBDEV_QUERYCAP and use MEDIA_IOC_DEVICE_INFO

2015-05-06 Thread Mauro Carvalho Chehab
Em Wed, 06 May 2015 12:50:31 +0200 Hans Verkuil escreveu: > On 05/06/15 11:30, Mauro Carvalho Chehab wrote: > > Em Wed, 06 May 2015 08:57:15 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> This patch series adds the VIDIOC_SUBDEV_QUERYCAP ioctl for v4l-subdev > >> devic

ov2659: "error: implicit declaration of function ‘v4l2_subdev_get_try_format’"

2015-05-06 Thread Daniel Wagner
Hi, I got this doing a randconfig on v4.1-rc2 CC [M] drivers/media/i2c/ov2659.o drivers/media/i2c/ov2659.c: In function ‘ov2659_get_fmt’: drivers/media/i2c/ov2659.c:1054:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’ [-Werror=implicit-function-declaration] mf = v4l

Re: [PATCH] Driver for Toshiba TC358743 HDMI to CSI-2 bridge

2015-05-06 Thread Hans Verkuil
Hi Mats, I have a few comments, see below: On 05/06/15 11:27, matra...@cisco.com wrote: > From: Mats Randgaard > > The driver is tested on our hardware and all the implemented features > works as expected. > > Missing features: > - CEC support > - HDCP repeater support > - IR support > > Sign

Re: [RFCv2 PATCH 0/8] Add VIDIOC_SUBDEV_QUERYCAP and use MEDIA_IOC_DEVICE_INFO

2015-05-06 Thread Hans Verkuil
On 05/06/15 11:30, Mauro Carvalho Chehab wrote: > Em Wed, 06 May 2015 08:57:15 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> This patch series adds the VIDIOC_SUBDEV_QUERYCAP ioctl for v4l-subdev >> devices >> as discussed during the ELC in San Jose and as discussed here: >> >> h

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-05-06 Thread Vlastimil Babka
On 05/06/2015 09:28 AM, Jan Kara wrote: Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_se

Re: [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

2015-05-06 Thread Vlastimil Babka
On 05/06/2015 09:28 AM, Jan Kara wrote: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of hand made mapping of virtual address to physical address. Also the function leaked page reference from get_user_pages() so fix that by properly release the reference when omap_vout_buff

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

2015-05-06 Thread Vlastimil Babka
On 05/06/2015 09:28 AM, Jan Kara wrote: Provide new function get_vaddr_frames(). This function maps virtual addresses from given start and fills given array with page frame numbers of the corresponding pages. If given start belongs to a normal vma, the function grabs reference to each of the pag

[PATCH v3 3/3] media: atmel-isi: remove mck back compatiable code as it's not need

2015-05-06 Thread Josh Wu
The master clock should handled by sensor itself. Signed-off-by: Josh Wu Acked-by: Laurent Pinchart --- Changes in v3: - remove useless definition: ISI_DEFAULT_MCLK_FREQ Changes in v2: - totally remove clock_start()/clock_stop() as they are optional. drivers/media/platform/soc_camera/atmel-i

[PATCH v3 2/3] media: atmel-isi: add runtime pm support

2015-05-06 Thread Josh Wu
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral clock). And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need access ISI registers. In the meantime, as clock_start()/clock_stop() is used to control the mclk not ISI peripheral clock. So move this to start[st

[PATCH v3 1/3] media: atmel-isi: remove the useless code which disable isi

2015-05-06 Thread Josh Wu
To program ISI control register, the pixel clock should be enabled. So without pixel clock (from sensor) enabled, disable ISI controller is not make sense. So this patch remove those code. Signed-off-by: Josh Wu --- Changes in v3: None Changes in v2: - this file is new added. drivers/media/pla

[PATCH v3 0/3] media: atmel-isi: rework on the clock part and add runtime pm support

2015-05-06 Thread Josh Wu
This patch series fix the peripheral clock code and enable runtime pm support. Also it clean up the code which is for the compatiblity of mck. Changes in v3: - remove useless definition: ISI_DEFAULT_MCLK_FREQ Changes in v2: - this file is new added. - merged v1 two patch into one. - use runtime_p

Re: [RFCv2 PATCH 0/8] Add VIDIOC_SUBDEV_QUERYCAP and use MEDIA_IOC_DEVICE_INFO

2015-05-06 Thread Mauro Carvalho Chehab
Em Wed, 06 May 2015 08:57:15 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > This patch series adds the VIDIOC_SUBDEV_QUERYCAP ioctl for v4l-subdev devices > as discussed during the ELC in San Jose and as discussed here: > > http://www.spinics.net/lists/linux-media/msg88009.html > > It

[PATCH] Driver for Toshiba TC358743 HDMI to CSI-2 bridge

2015-05-06 Thread matrandg
From: Mats Randgaard The driver is tested on our hardware and all the implemented features works as expected. Missing features: - CEC support - HDCP repeater support - IR support Signed-off-by: Mats Randgaard --- MAINTAINERS|6 + drivers/media/i2c/Kconfig

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Benjamin Gaignard
I agree that the best solution is to have a generic dmabuf allocator but no only for secure use cases. If we create a memory allocator dedicated to security it means that userland will be responsible to use it or not depending of the context which may change while the pipeline/graph is already run

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Thierry Reding
On Wed, May 06, 2015 at 10:35:52AM +0200, Daniel Vetter wrote: > On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: > > > First what is Secure Data Path ? SDP is a set of hardware features to > > > garanty > > > that some memories regions could only be read and/or write by specif

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Hans Verkuil
On 05/06/15 10:35, Daniel Vetter wrote: > On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: >>> First what is Secure Data Path ? SDP is a set of hardware features to >>> garanty >>> that some memories regions could only be read and/or write by specific >>> hardware >>> IPs. You

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Benjamin Gaignard
2015-05-05 18:54 GMT+02:00 One Thousand Gnomes : >> First what is Secure Data Path ? SDP is a set of hardware features to garanty >> that some memories regions could only be read and/or write by specific >> hardware >> IPs. You can imagine it as a kind of memory firewall which grant/revoke >> acce

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Daniel Vetter
On Wed, May 06, 2015 at 03:50:13AM +0300, Laurent Pinchart wrote: > On Tuesday 05 May 2015 09:27:52 Christoph Hellwig wrote: > > On Tue, May 05, 2015 at 05:39:57PM +0200, Benjamin Gaignard wrote: > > > Since few months I'm looking for Linaro to how do Secure Data Path (SPD). > > > I have tried and

Re: [RFC] How implement Secure Data Path ?

2015-05-06 Thread Daniel Vetter
On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: > > First what is Secure Data Path ? SDP is a set of hardware features to > > garanty > > that some memories regions could only be read and/or write by specific > > hardware > > IPs. You can imagine it as a kind of memory firewa

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

2015-05-06 Thread Jan Kara
Provide new function get_vaddr_frames(). This function maps virtual addresses from given start and fills given array with page frame numbers of the corresponding pages. If given start belongs to a normal vma, the function grabs reference to each of the pages to pin them in memory. If start belongs

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

2015-05-06 Thread Jan Kara
Currently vb2 core acquires mmap_sem just around call to __qbuf_userptr(). However since commit f035eb4e976ef5 (videobuf2: fix lockdep warning) it isn't necessary to acquire it so early as we no longer have to drop queue mutex before acquiring mmap_sem. So push acquisition of mmap_sem down into .ge

[PATCH 8/9] media: vb2: Remove unused functions

2015-05-06 Thread Jan Kara
Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 114 --

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

2015-05-06 Thread Jan Kara
Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmalloc.c |

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

2015-05-06 Thread Jan Kara
Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 21

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

2015-05-06 Thread Jan Kara
Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 97 +- 1 file changed, 15 insertions(+), 82 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-cor

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-05-06 Thread Jan Kara
Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers/

[PATCH 0/9 v4] Helper to abstract vma handling in media layer

2015-05-06 Thread Jan Kara
Hello, Sorry for a quick resend but the missing vmalloc include in mm/gup.c is annoying for archs that need it and I was also told to extend CC list a bit. I'm sending the fourth version of my patch series to abstract vma handling from the various media drivers. After this patch set drivers h

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

2015-05-06 Thread Jan Kara
Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of hand made mapping of virtual address to physical address. Also the function leaked page reference from get_user_pages() so fix that by properly release the reference when omap_vout_buffer_release() is called. Signed-off-by: Ja

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

2015-05-06 Thread Jan Kara
Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 58 ++ include/media/videobuf2-memops.h