Re: [PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped

One more question: cx23885-dvb.c (and maybe others) contains a couple of instances of si2168_config.ts_mode = SI2168_TS_PARALLEL; and si2168_config.ts_mode = SI2168_TS_SERIAL; But you don't patch them with si2168_config.ts_clock_gapped = true; Is this intentional? Kind regards, Tycho Op 23-

Re: Missing additional V4L2 caps in cx18

Hi Laura, Thanks for the report. I've made a patch and CC-ed you on it. The TS and IDX streams are internal (i.e., they do not map to a V4L2 device node), but the PCM stream isn't, and that's the one causing the warning. Regards, Hans On 04/23/2015 07:57 PM, Laura Abbott wrote: > Hi, >

[PATCH] cx18: add missing caps for the PCM video device

The cx18 PCM video device didn't have any capabilities set, which caused a warnings in the v4l2 core: [6.229393] [ cut here ] [6.229414] WARNING: CPU: 1 PID: 593 at drivers/media/v4l2-core/v4l2-ioctl.c:1025 v4l_querycap+0x41/0x70 [videodev]() [6.229415] Modul

Re: [PATCH] [media] vivid: add 1080p capture at 2 fps and 5 fps to webcam emulation

Hi Philipp, Thank you for the patch, but I have one question: On 04/23/2015 03:52 PM, Philipp Zabel wrote: > Use the VIVID_WEBCAM_SIZES constant where appropriate and add a 1920x1080 > pixel > frame size setting with frame rates of 2 fps and 5 fps. Why add both 2 and 5 fps? Is there a reason wh

Re: [PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped

Hi Olli, in saa716x_budget.c I've also got (for TBS6285) si2168_config.i2c_adapter = &i2cadapter; si2168_config.fe = &adapter->fe; si2168_config.ts_mode = SI2168_TS_SERIAL; memset(&info, 0, sizeof(struct i2c_board_info)); Should I just add it like this? si2168_config.ts_mode

Re: [PATCH 03/12] si2157: support selection of IF interface

Hi Olli, Em Fri, 24 Apr 2015 00:11:02 +0300 Olli Salonen escreveu: > The chips supported by the si2157 driver have two IF outputs (either > pins 12+13 or pins 9+11). Instead of hardcoding the output to be used > add an option to choose which output shall be used. > > Signed-off-by: Olli Salonen

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Apr 24 04:00:16 CEST 2015 git branch: test git hash: e183201b9e917daf2530b637b2f34f1d5afb934d gcc versi

Re: [PATCH 12/12] rtl2832: add support for GoTView MasterHD 3 USB tuner

On 04/23/2015 11:11 PM, Olli Salonen wrote: GoTView MasterHD 3 is a DVB-T2/C USB 2.0 tuner. It's based on the following components: - USB bridge: RTL2832P (contains also DVB-T demodulator) - Demodulator: Si2168-A30 - Tuner: Si2148-A20 [...] For some reason, the old I2C write method sporadica

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, Jacek Anaszewski wrote: ... >>> +#define call_flash_op(v4l2_flash, op, arg) \ >>> + (has_flash_op(v4l2_flash, >>> op) ? \ >>> + v4l2_flash->ops->op(v4l2_flash, >>> arg) : \ >>> + -EINVAL) >>> + >>> +

[PATCH 12/12] rtl2832: add support for GoTView MasterHD 3 USB tuner

GoTView MasterHD 3 is a DVB-T2/C USB 2.0 tuner. It's based on the following components: - USB bridge: RTL2832P (contains also DVB-T demodulator) - Demodulator: Si2168-A30 - Tuner: Si2148-A20 The demodulator and the tuner will need firmwares. The Si2148 uses Si2158 firmware. Antti has the firmware

[PATCH 08/12] dvbsky: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c index 0f73b1d..57c8c2d 100644 --- a/d

[PATCH 01/12] si2168: add support for gapped clock

Add a parameter in si2168_config to support gapped clock. Signed-off-by: Olli Salonen --- drivers/media/dvb-frontends/si2168.c | 3 +++ drivers/media/dvb-frontends/si2168.h | 3 +++ drivers/media/dvb-frontends/si2168_priv.h | 1 + 3 files changed, 7 insertions(+) diff --git a/drivers/

[PATCH 11/12] rtl28xxu: add I2C read without write

Add support for I2C read operation without a preceeding write. While here, change the error code to EOPNOTSUPP in case an unsupported I2C operation is attempted. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCH 04/12] cx23885: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/pci/cx23885/cx23885-dvb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c index 745caab..37fd013 100644

[PATCH 03/12] si2157: support selection of IF interface

The chips supported by the si2157 driver have two IF outputs (either pins 12+13 or pins 9+11). Instead of hardcoding the output to be used add an option to choose which output shall be used. Signed-off-by: Olli Salonen --- drivers/media/tuners/si2157.c | 4 +++- drivers/media/tuners/si2157.

[PATCH 10/12] em28xx: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/usb/em28xx/em28xx-dvb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index a5b22c5..5b7c7c88 100644 --- a/

[PATCH 09/12] cxusb: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb/cxusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index ffc3704..ab71511 100644 --- a/drivers/media/u

[PATCH 06/12] cx231xx: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/usb/cx231xx/cx231xx-dvb.c index 610d567..66ee161 100644 -

[PATCH 07/12] af9035: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/af9035.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c index 80a29f5..7b7f75d 100644 --- a/dri

[PATCH 05/12] smipcie: specify if_port for si2157 devices

Set the if_port parameter for all Si2157-based devices. Signed-off-by: Olli Salonen --- drivers/media/pci/smipcie/smipcie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/smipcie/smipcie.c b/drivers/media/pci/smipcie/smipcie.c index 4115925..143fd78 100644 --- a/drivers/m

[PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped

Change the dvbsky driver to support gapped clock instead of the current hack. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c

[PATCH 2/3] [media] v4l: VIDEOBUF2_DMA_SG should depend on HAS_DMA

If NO_DMA=y: ERROR: "dma_unmap_sg" [drivers/media/v4l2-core/videobuf2-dma-sg.ko] undefined! ERROR: "dma_map_sg" [drivers/media/v4l2-core/videobuf2-dma-sg.ko] undefined! ERROR: "dma_sync_sg_for_cpu" [drivers/media/v4l2-core/videobuf2-dma-sg.ko] undefined! VIDEOBUF2_DMA_SG cannot be e

[PATCH 1/3] [media] v4l: xilinx: VIDEO_XILINX should depend on HAS_DMA

If NO_DMA=y: warning: (VIDEO_XILINX && VIDEO_DM365_VPFE && VIDEO_DT3155 && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: media/v4l2-core/videobuf2-dma-contig

[PATCH 3/3] Input: TOUCHSCREEN_SUR40 should depend on HAS_DMA

If NO_DMA=y: warning: (TOUCHSCREEN_SUR40 && VIDEO_TW68 && VIDEO_CX23885 && VIDEO_CX25821 && VIDEO_CX88 && VIDEO_SAA7134) selects VIDEOBUF2_DMA_SG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) ERROR: "dma_unmap_sg" [drivers/media/v4l2-core/videobuf2-dma-sg.ko] undefined

Missing additional V4L2 caps in cx18

Hi, We received a report of a backtrace from v4l2 with the cx18 module: [6.229393] [ cut here ] [6.229414] WARNING: CPU: 1 PID: 593 at drivers/media/v4l2-core/v4l2-ioctl.c:1025 v4l_querycap+0x41/0x70 [videodev]() [6.229415] Modules linked in: cx18_alsa mxl5

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

On Thu, 23 Apr 2015 10:40:09 +0300 Hi Sakari, Thanks for the review. Sakari Ailus wrote: > Hi Jacek, > > On Wed, Apr 15, 2015 at 08:48:36AM +0200, Jacek Anaszewski wrote: > > This patch adds helper functions for registering/unregistering > > LED Flash class devices as V4L2 sub-devices. The fun

Re: [PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

On Wed, 22 Apr 2015, Arun Ramamurthy wrote: > This patch set adds a new API to get phy by index when multiple > phys are present. This patch is based on discussion with Arnd Bergmann > about dt bindings for multiple phys. > > History: > v1: > - Removed null pointers on Dmitry's suggestion >

Re: [PATCH v4 06/10] cec: add HDMI CEC framework

On 04/23/2015 03:03 PM, Kamil Debski wrote: > From: Hans Verkuil > > The added HDMI CEC framework provides a generic kernel interface for > HDMI CEC devices. > > Signed-off-by: Hans Verkuil > [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] > [k.deb...@samsung.com: Merged Updat

Re: [media-workshop] [DRAFT 1] Linux Media Summit report - March, 26 2015 - San Jose - CA - USA

Hi Mauro, On Thu, 23 Apr 2015 07:40:46 -0300 Mauro Carvalho Chehab wrote: > > What about demod-diversity: demods of some manufacturers can be > > used to combine their demodulated symbols and, due to their > > different antennas and RF-paths, improve the overall reception > > quality. > > > > If

[PATCH] [media] vivid: add 1080p capture at 2 fps and 5 fps to webcam emulation

Use the VIVID_WEBCAM_SIZES constant where appropriate and add a 1920x1080 pixel frame size setting with frame rates of 2 fps and 5 fps. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/vivid-vid-cap.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/

[PATCH v4 08/10] cec: adv7604: add cec support.

From: Hans Verkuil Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: add missing methods cec/io_write_and_or] [k.deb...@samsung.com: change adv7604 to adv76xx in added function

[PATCH v4 09/10] cec: adv7511: add cec support.

From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7511.c | 347 ++- include/media/ad

[PATCH v4 06/10] cec: add HDMI CEC framework

From: Hans Verkuil The added HDMI CEC framework provides a generic kernel interface for HDMI CEC devices. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: Merged Update author commit by Hans Verkuil] [k.deb...@samsung.com: chan

[PATCH v4 05/10] rc: Add HDMI CEC protoctol handling

Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski --- drivers/media/rc/keymaps/Makefile |

[PATCH v4 04/10] HID: add HDMI CEC specific keycodes

Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644 --- a/include/uapi/linux

[PATCH v4 07/10] v4l2-subdev: add HDMI CEC ops

From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a/

[PATCH v4 03/10] dts: exynos4412-odroid*: enable the HDMI CEC device

Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/d

[PATCH v4 01/10] dts: exynos4*: add HDMI CEC pin definition to pinctrl

Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2 files changed, 14 inse

[PATCH v4 02/10] dts: exynos4: add node for the HDMI CEC device

This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index e20cdc2..8776db9 1006

[PATCH v4 00/10] HDMI CEC framework

Hi, This is the fourth version of the HDMI CEC framework. I would like to thank for all the comments and suggestions to the previous versions of this patch. I believe that the code has matured enough to be tagged as PATCH and not RFC as in previous version. This patchset is base on the linux-next

Re: [DRAFT 1] Linux Media Summit report - March, 26 2015 - San Jose - CA - USA

Hi Patrick, Em Thu, 23 Apr 2015 09:06:35 +0200 Patrick Boettcher escreveu: > Hi Mauro, > > I could not participate at your Summit, but may have an input to the > media-controller in DVB - see below. > > > On Wed, 22 Apr 2015 15:31:46 -0300 Mauro Carvalho Chehab > wrote: > > > This is the fi

[PATCH v2 1/4] v4l2-dv-timings: fix rounding error in vsync_bp calculation

Changed the rounding offsets used in vsync_bp calculation in cvt and gtf timings. The results for vsync_bp should now match with results from timing generator spreadsheets for cvt and gtf standards. In the vsync_bp calculation for cvt, always round down the value of (CVT_MIN_VSYNC_BP / h_period_es

[PATCH v2 3/4] v4l2-dv-timings: add sanity checks in cvt,gtf calculations

Wrong values of hfreq and image height can lead to strange timings. Avoid timing calculations for such values. Suggested By: Martin Bugge Cc: Hans Verkuil Cc: Martin Bugge Signed-off-by: Prashant Laddha --- drivers/media/v4l2-core/v4l2-dv-timings.c | 12 1 file changed, 12 inser

fix for rounding errors in cvt/gtf calculation

This is second version of patch series towards fixing rounding errors in cvt,gtf timing calculations. In version 1, the fixes for rounding errors have added on top of patches meant for interlaced support. Based on the feedback from Hans, I have now (in v2), reworked the patches such that, patches

[PATCH v2 4/4] v4l2-dv-timings: replace hsync magic number with a macro

This change will not change timing calculation. In CVT generator spreadsheet the nominal value of hsync (as a percentage of line) is 8 percent. Cc: Hans Verkuil Cc: Martin Bugge Signed-off-by: Prashant Laddha --- drivers/media/v4l2-core/v4l2-dv-timings.c | 3 ++- 1 file changed, 2 insertions(+

[PATCH v2 2/4] v4l2-dv-timings: fix rounding in hblank and hsync calculation

Changed the rounding calculation for hblank and hsync to match it to equations in cvt and gtf standards. In cvt calculation, hsync needs to be rounded down. In gtf calculations, hblank needs to be rounded to nearest multiple of twice the cell granularity and hsync needs to be rounded to the neare

[PATCH] allow buffers allocation with DMABUF memory type

Until now the only way to make the driver allocate buffers and share them using dma_buf was to use V4L2_MEMORY_MMAP memory type. Use of MMAP memory type is a problem because vb2 never call dma_buf_map_attachment() to attach itself while queuing the buffer so dma_buf importer will not know that anot

Re: [PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

Hi, On 23-04-15 01:04, Arun Ramamurthy wrote: This patch set adds a new API to get phy by index when multiple phys are present. This patch is based on discussion with Arnd Bergmann about dt bindings for multiple phys. History: v1: - Removed null pointers on Dmitry's suggestion - Impro

Re: [PATCH v5 06/10] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Wed, Apr 15, 2015 at 08:48:36AM +0200, Jacek Anaszewski wrote: > This patch adds helper functions for registering/unregistering > LED Flash class devices as V4L2 sub-devices. The functions should > be called from the LED subsystem device driver. In case the > support for V4L2 Flash su

Re: [DRAFT 1] Linux Media Summit report - March, 26 2015 - San Jose - CA - USA

On 04/22/15 20:31, Mauro Carvalho Chehab wrote: > This is the first draft for the Linux Media Summit Report. > > Please note that the items 3 to 5 are not in good shape. In special, > nobody took Etherpad notes on item 4. Item 4 was just me presenting on ongoing projects. As far as I remember the

Re: [DRAFT 1] Linux Media Summit report - March, 26 2015 - San Jose - CA - USA

Hi Mauro, I could not participate at your Summit, but may have an input to the media-controller in DVB - see below. On Wed, 22 Apr 2015 15:31:46 -0300 Mauro Carvalho Chehab wrote: > This is the first draft for the Linux Media Summit Report. > > Please note that the items 3 to 5 are not in goo