Re: [git:media_tree/master] [media] Add device tree support to adp1653 flash driver

2015-04-08 Thread Hans Verkuil
Hi Pawel, This driver doesn't compile: On 04/08/2015 10:46 PM, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued at the > http://git.linuxtv.org/cgit.cgi/media_tree.git tree: > > Subject: [media] Add device tree support t

cron job: media_tree daily build: ERRORS

2015-04-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Apr 9 04:00:17 CEST 2015 git branch: test git hash: b6100f10bdc2019a65297d2597c388de2f7dd653 gcc versi

RE: [PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-04-08 Thread Cho KyongHo
Hans, I didn't notice that vb2_put_vma is exported because I don't build modules. I am sorry about bothering you. Mauro, I think it is better to drop my patch out from your tree because I don't think it is not worth to export vm_area_cache_p to use it in vb2_put_vma. Regards, KyongHo -Origi

Re: [PATCH v3 4/4] smiapp: Use v4l2_of_alloc_parse_endpoint()

2015-04-08 Thread Sakari Ailus
Hi Laurent, On Tue, Apr 07, 2015 at 01:10:20PM +0300, Laurent Pinchart wrote: > > @@ -3022,34 +3026,30 @@ static struct smiapp_platform_data > > *smiapp_get_pdata(struct device *dev) dev_dbg(dev, "reset %d, nvm %d, clk > > %d, csi %d\n", pdata->xshutdown, pdata->nvm_size, pdata->ext_clk, > > pdata

Re: [PATCH v3 3/4] v4l: of: Parse variable length properties --- link-frequencies

2015-04-08 Thread Sakari Ailus
Hi Laurent, On Tue, Apr 07, 2015 at 01:02:31PM +0300, Laurent Pinchart wrote: > Hello Sakari, > > Thank you for the patch. Thanks for the review! > On Tuesday 07 April 2015 01:57:31 Sakari Ailus wrote: > > +/* > > + * v4l2_of_free_endpoint() - release resources acquired by > > + * v4l2_of_alloc

Re: [PATCH v3 2/4] v4l: of: Instead of zeroing bus_type and bus field separately, unify this

2015-04-08 Thread Sakari Ailus
On Tue, Apr 07, 2015 at 12:47:56PM +0300, Laurent Pinchart wrote: > Hello Sakari, > > Thank you for the patch. > > On Tuesday 07 April 2015 01:57:30 Sakari Ailus wrote: > > Clean the entire struct starting from bus_type. As more fields are added, no > > changes will be needed in the function to r

Re: [PATCH v3 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint

2015-04-08 Thread Sakari Ailus
Hi Laurent, On Tue, Apr 07, 2015 at 01:11:34PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tuesday 07 April 2015 01:57:29 Sakari Ailus wrote: > > The field is unused. Remove it. > > Do you know what the field was added for in the first place ? Frankly I have

Re: [PATCHv4] [media] saa7164: use an MSI interrupt when available

2015-04-08 Thread Mauro Carvalho Chehab
Hi Brendan, The idea is good, Some comments bellow. Em Sat, 14 Mar 2015 14:27:39 +1100 Brendan McGrath escreveu: > Enhances driver to use an MSI interrupt when available. > > Adds the module option 'enable_msi' (type bool) which by default is > enabled. Can be set to 'N' to disable. > > Fixe

Re: [PATCH] [media] v4l: vb2-memops: use vma slab when vma allocation

2015-04-08 Thread Hans Verkuil
Mauro, Please revert this patch: vm_area_cachep is not exported, so you cannot use this in a module. Cho KyongHo, if you believe that vm_area_cachep should be exported so it can be used here, then please make a patch for that. For the time being though, this patch should be reverted. This patch

Re: [PATCH] CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT also

2015-04-08 Thread Mauro Carvalho Chehab
Em Sun, 15 Feb 2015 22:13:13 + David Howells escreveu: > CONFIG_VIDEO_DEV needs to be enabled by MEDIA_DIGITAL_TV_SUPPORT so that DVB > TV receiver drivers can be enabled. Actually, no. VIDEO_DEV enables the V4L2 core, with is not needed by pure DVB devices. Ok, some drivers are hybrid, and

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Sylwester Nawrocki
Hi Jacek, On 08/04/15 13:58, Jacek Anaszewski wrote: >>> --- a/Documentation/devicetree/bindings/leds/common.txt >>> >> +++ b/Documentation/devicetree/bindings/leds/common.txt >>> >> @@ -29,13 +29,15 @@ Optional properties for child nodes: >>> >>"ide-disk" - LED indicates disk activity >>>

Re: [PATCH] rc: img-ir: Add and enable sys clock for IR

2015-04-08 Thread Mauro Carvalho Chehab
Em Wed, 08 Apr 2015 13:56:14 + Sifan Naeem escreveu: > Hi Mauro, > > I sent you a v2 of this patch on 4th February: > > From: Sifan Naeem > Sent: 04 February 2015 16:48 > To: James Hogan; mche...@osg.samsung.com > Cc: linux-ker...@vger.kernel.org; linux-media@vger.kernel.org; Sifan Naeem >

RE: [PATCH] rc: img-ir: Add and enable sys clock for IR

2015-04-08 Thread Sifan Naeem
Hi Mauro, I sent you a v2 of this patch on 4th February: From: Sifan Naeem Sent: 04 February 2015 16:48 To: James Hogan; mche...@osg.samsung.com Cc: linux-ker...@vger.kernel.org; linux-media@vger.kernel.org; Sifan Naeem Subject: [PATCH v2] rc: img-ir: Add and enable sys clock for img-ir Unfort

Re: [PATCH 1/1] media: Correctly notify about the failed pipeline validation

2015-04-08 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: Hello Sakari, Thank you for the patch. On Thursday 12 February 2015 15:43:11 Sakari Ailus wrote: On the place of the source entity name, the sink entity name was printed. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart and applied to my tree. I

Re: [PATCH 1/1] media: Correctly notify about the failed pipeline validation

2015-04-08 Thread Laurent Pinchart
Hello Sakari, Thank you for the patch. On Thursday 12 February 2015 15:43:11 Sakari Ailus wrote: > On the place of the source entity name, the sink entity name was printed. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart and applied to my tree. It's a bit late for v4.1, can it wai

[GIT PULL FOR v4.1] Misc UVC and OMAP3 ISP patches

2015-04-08 Thread Laurent Pinchart
Hi Mauro, If there's still time to get fixes merged in v4.1, please pull the following changes. The following changes since commit c8c7c44b7cf5ef7163e4bd6aedbdeb6f6031ee3e: [media] s5p-jpeg: Remove some unused functions (2015-04-07 08:15:15 -0300) are available in the git repository at: g

fix for rounding errors in cvt/gtf calculation

2015-04-08 Thread Prashant Laddha
While I was testing cvt / gtf timings against the timings given by standards timing generator spreadsheets, there were differences in results for some of the formats. Those differences could be traced back to the rounding used to compute some of the intermediate values. Following two patches fi

[PATCH 1/2] v4l2-dv-timings: fix rounding error in vsync_bp calculation

2015-04-08 Thread Prashant Laddha
Changed the rounding offsets used in vsync_bp calculation in cvt and gtf timings. The results for vsync_bp should now match with results from timing generator spreadsheets for cvt and gtf standards. In the vsync_bp calculation for cvt, always round down the value of (CVT_MIN_VSYNC_BP / h_period_es

Wonga Loans

2015-04-08 Thread Wonga Express Loan
Wonga Loans Wonga Express Loan Promtion.pdf Description: Adobe PDF document

[PATCH 2/2] v4l2-dv-timings: fix rounding in hblank and hsync calculation

2015-04-08 Thread Prashant Laddha
Changed the rounding calculation for hblank and hsync to match it to equations in standards. Currently hblank and hsync are rounded down. hblank needs to be rounded to nearest multiple of twice the cell granularity. hsync needs to be rounded to nearest multiple of cell granularity. Cc: Hans Verkui

[PATCH] Add support for interlaced format in detect cvt/gtf

2015-04-08 Thread Prashant Laddha
Extended detect_cvt/gtf API to indicate the scan type (interlaced or progressive). In case of interlaced, the vertical front and back porch and vsync values for both (odd,even) fields are considered to derive image height. Populated vsync, verical front, back porch values in bt timing structure for

support for interlaced format in detect cvt/gtf

2015-04-08 Thread Prashant Laddha
While I was working with Hans on adding cvt/gtf modeline calculations in v4l2 utils, we thought that it would be nice to extend the detect cvt/gtf functionality in v4l2-dv-timings to handle interlaced format. Please find the patch for the same. Regards, Prashant -- To unsubscribe from this list:

Re: [PATCH] media: cxd2099: move pre-init values out of init()

2015-04-08 Thread Luis de Bethencourt
On Wed, Apr 08, 2015 at 08:09:03AM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 8 Feb 2015 20:55:36 + > luisbg escreveu: > > > Improve code readability by moving out all pre-init values from the init > > function. > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/staging/medi

Re: [PATCH v4 06/12] of: Add Skyworks Solutions, Inc. vendor prefix

2015-04-08 Thread Sakari Ailus
On Tue, Mar 31, 2015 at 03:52:42PM +0200, Jacek Anaszewski wrote: > Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: devicet...@vger.kernel.org > --- > .../devicetree/bindings/vendor-prefixes.txt|

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Jacek Anaszewski
Hi Sylwester, On 04/08/2015 12:03 PM, Sylwester Nawrocki wrote: Hello, On 31/03/15 15:52, Jacek Anaszewski wrote: Description of flash LEDs related properties was not precise regarding the state of corresponding settings in case a property is missing. Add relevant statements. Removed is also t

Re: [RFC 00/12] TC358743 async subdev and dt support

2015-04-08 Thread Mats Randgaard (matrandg)
Hi Philipp, Hans forwarded this patch series to me now, since I haven't received if for some reason. I will prioritize upstreaming of the driver the next couple of days and create a new RFC. I will also go through your patches and give you feedback! Regards, Mats On 03/30/2015 01:10 PM, Phi

Re: [PATCH 1/1] media: Correctly notify about the failed pipeline validation

2015-04-08 Thread Sakari Ailus
Hi Mauro, Mauro Carvalho Chehab wrote: > Em Thu, 12 Feb 2015 15:43:11 +0200 > Sakari Ailus escreveu: > >> On the place of the source entity name, the sink entity name was printed. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/media/media-entity.c | 6 +++--- >> 1 file changed, 3 insertio

Re: [PATCH] rc: img-ir: Add and enable sys clock for IR

2015-04-08 Thread Mauro Carvalho Chehab
Em Tue, 3 Feb 2015 17:30:29 + Sifan Naeem escreveu: > Gets a handle to the system clock, already described in the binding > document, and calls the appropriate common clock > framework functions to mark it prepared/enabled, the common clock > framework initially enables the clock and doesn't

Re: [PATCH 1/1] media: Correctly notify about the failed pipeline validation

2015-04-08 Thread Mauro Carvalho Chehab
Em Thu, 12 Feb 2015 15:43:11 +0200 Sakari Ailus escreveu: > On the place of the source entity name, the sink entity name was printed. > > Signed-off-by: Sakari Ailus > --- > drivers/media/media-entity.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/med

Re: [PATCH] media: cxd2099: move pre-init values out of init()

2015-04-08 Thread Mauro Carvalho Chehab
Em Sun, 8 Feb 2015 20:55:36 + luisbg escreveu: > Improve code readability by moving out all pre-init values from the init > function. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/media/cxd2099/cxd2099.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Sakari Ailus
Hi Jacek, On Wed, Apr 08, 2015 at 12:23:23PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 04/08/2015 11:11 AM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Wed, Apr 08, 2015 at 10:54:52AM +0200, Jacek Anaszewski wrote: > >>Hi Sakari, > >> > >>On 04/03/2015 02:09 PM, Sakari Ailus wrote: > >>>H

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Pavel Machek
On Wed 2015-04-08 12:03:27, Sylwester Nawrocki wrote: > Hello, > > On 31/03/15 15:52, Jacek Anaszewski wrote: > > Description of flash LEDs related properties was not precise regarding > > the state of corresponding settings in case a property is missing. > > Add relevant statements. > > Removed i

Re: [PATCH v3 0/5] Signalling last decoded frame by V4L2_BUF_FLAG_LAST and -EPIPE

2015-04-08 Thread Pawel Osciak
Hi, On Tue, Apr 7, 2015 at 11:44 PM, Kamil Debski wrote: > Hi, > > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, March 17, 2015 5:09 PM >> >> On 03/17/2015 11:46 AM, Philipp Zabel wrote: >> > Hi, >> > >> > Am Freitag, den 06.03.2015, 11:18 +0100 schrieb Philipp Zabel: >> >> At t

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Jacek Anaszewski
Hi Sakari, On 04/08/2015 11:11 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Apr 08, 2015 at 10:54:52AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 04/03/2015 02:09 PM, Sakari Ailus wrote: Hi Jacek, On Tue, Mar 31, 2015 at 03:52:37PM +0200, Jacek Anaszewski wrote: Description of flash LEDs re

Re: OMAP3 ISP previewer Y10 to UYVY conversion

2015-04-08 Thread Laurent Pinchart
Hi Chris, On Tuesday 07 April 2015 11:45:10 Chris Whittenburg wrote: > On Tue, Apr 7, 2015 at 10:51 AM, Laurent Pinchart wrote: > > I suspect the RGB2RGB conversion matrix to be wrong. The default setting > > is supposed to handle fluorescent lighting. You could try setting the > > RGB2RGB matrix

Re: [PATCH v3 0/5] Signalling last decoded frame by V4L2_BUF_FLAG_LAST and -EPIPE

2015-04-08 Thread Hans Verkuil
On 04/07/15 16:44, Kamil Debski wrote: > Hi, > > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, March 17, 2015 5:09 PM >> >> On 03/17/2015 11:46 AM, Philipp Zabel wrote: >>> Hi, >>> >>> Am Freitag, den 06.03.2015, 11:18 +0100 schrieb Philipp Zabel: At the V4L2 codec API sessi

Re: [PATCH] [media] dmxdev: fix possible race conditions in dvb_dmxdev_buffer_read

2015-04-08 Thread Mauro Carvalho Chehab
Hi, Em Tue, 30 Dec 2014 12:05:34 +0900 Jaedon Shin escreveu: > This patch splits the dvb_dmxdev_buffer_read into dvb_dvr_read and > dvb_demux_read that fixes to unlock mutex before sleeping. > > There are race conditions executing the DMX_ADD_PID and the DMX_REMOVE_PID > in the dvb_demux_do_ioc

[GIT PULL for 4.1] mem2mem changes for 4.1

2015-04-08 Thread Kamil Debski
The following changes since commit c8c7c44b7cf5ef7163e4bd6aedbdeb6f6031ee3e: [media] s5p-jpeg: Remove some unused functions (2015-04-07 08:15:15 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-4.1-v2 for you to fetch changes up to 8dae02ffa32db8

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Sylwester Nawrocki
Hello, On 31/03/15 15:52, Jacek Anaszewski wrote: > Description of flash LEDs related properties was not precise regarding > the state of corresponding settings in case a property is missing. > Add relevant statements. > Removed is also the requirement making the flash-max-microamp > property obli

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Pavel Machek
Hi! > > I think that a board designed so that it can be damaged because of > > software bugs should be considered not eligible for commercial > > use. Hello? It is 2015. Yes, that was nice rule... in 1995 or so :-). > > As I mentioned in the previous message in this subject, the max-microamp > >

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Pavel Machek
On Tue 2015-04-07 18:20:08, Bryan Wu wrote: > On Fri, Apr 3, 2015 at 1:37 PM, Pavel Machek wrote: > > Hi! > > > >> >>+- flash-timeout-us : Timeout in microseconds after which the flash > >> >>+ LED is turned off. If omitted this will default to > >> >>the > >> >>+

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Sakari Ailus
Hi Jacek, On Wed, Apr 08, 2015 at 10:54:52AM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 04/03/2015 02:09 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Tue, Mar 31, 2015 at 03:52:37PM +0200, Jacek Anaszewski wrote: > >>Description of flash LEDs related properties was not precise regarding

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Jacek Anaszewski
Hi Sakari, On 04/03/2015 02:09 PM, Sakari Ailus wrote: Hi Jacek, On Tue, Mar 31, 2015 at 03:52:37PM +0200, Jacek Anaszewski wrote: Description of flash LEDs related properties was not precise regarding the state of corresponding settings in case a property is missing. Add relevant statements.

cron job: media_tree daily build: ERRORS

2015-04-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed 8 Apr 09:01:40 CEST 2015 git branch: test git hash: c8c7c44b7cf5ef7163e4bd6aedbdeb6f6031ee3e gcc versi

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-08 Thread Sakari Ailus
Hi Bryan, Bryan Wu wrote: > On Fri, Apr 3, 2015 at 1:37 PM, Pavel Machek wrote: >> Hi! >> > +- flash-timeout-us : Timeout in microseconds after which the flash > + LED is turned off. If omitted this will default to > the > +maximum timeout allo