cron job: media_tree daily build: WARNINGS

2015-03-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 21 04:00:13 CET 2015 git branch: test git hash: 3d945be05ac1e806af075e9315bc1b3409adae2b gcc versio

[PATCH v1 15/47] [media] media: ivtv: use __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Sadly this driver requires a bit of work in order to use ioremap_wc() on the range currently used for MTRR write-combining. We'd need to ensure two ioremap() calls are done. Annotate this. Cc: Andy Lutomirski Cc: Andy Walls Cc: Suresh Siddha Cc: Venkatesh Pallipadi

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

2015-03-20 Thread Antti Palosaari
On 03/21/2015 01:13 AM, Benjamin Larsson wrote: On 03/19/2015 03:44 PM, Antti Palosaari wrote: Bad news. It does lock for DVB-C now, but DVB-T nor DVB-T2 does not lock. regards Antti I'm getting tired :/. Had the time to test now and the checks is supposed to be negated. if (utmp & 0xA0) { -

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

2015-03-20 Thread Benjamin Larsson
On 03/19/2015 03:44 PM, Antti Palosaari wrote: Bad news. It does lock for DVB-C now, but DVB-T nor DVB-T2 does not lock. regards Antti I'm getting tired :/. Had the time to test now and the checks is supposed to be negated. if (utmp & 0xA0) { -> if (!(utmp & 0xA0)) But as stock dvbv5-scan

[PATCH v1.1 13/15] v4l: of: Read lane-polarities endpoint property

2015-03-20 Thread Sakari Ailus
Add lane_polarities field to struct v4l2_of_bus_mipi_csi2 and write the contents of the lane-polarities property to it. The field tells the polarity of the physical lanes starting from the first one. Any unused lanes are ignored, i.e. only the polarity of the used lanes is specified. Also rework r

[PATCH v1.1 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-03-20 Thread Sakari Ailus
Add lane-polarity property to endpoint nodes. This essentially tells that the order of the differential signal wires is inverted. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- since v1: - Rename lane-polarity property as lane-polarities. Documentation/devicetree/bindings/media/vi

[PATCH v1.1 14/15] omap3isp: Add support for the Device Tree

2015-03-20 Thread Sakari Ailus
Add the ISP device to omap3 DT include file and add support to the driver to use it. Also obtain information on the external entities and the ISP configuration related to them through the Device Tree in addition to the platform data. Signed-off-by: Sakari Ailus --- since v1: - Print endpoint na

Re: [PATCH 14/15] omap3isp: Add support for the Device Tree

2015-03-20 Thread Sakari Ailus
Hi Laurent, Thanks for the review. On Tue, Mar 17, 2015 at 02:48:54AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Monday 16 March 2015 02:26:09 Sakari Ailus wrote: > > Add the ISP device to omap3 DT include file and add support to the driver to > > use it. >

[PATCH v10] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad Prabhakar
From: Benoit Parrot this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot Signed-off-by: Lad, Prabhakar Acked-by: Sakari Ailus --- Changes for v10: Fixed

[PATCH] OMAP3 ISP: Support top and bottom fields

2015-03-20 Thread Tim Nordell
The OMAP3ISP can selectively stream either the top or bottom field by setting the start line vertical field to a high value for the field that one doesn't want to stream. The driver can switch between these utilizing the vertical start feature of the CCDC. Additionally, we need to ensure that the

Re: [RFC v3 5/9] cec: add new driver for cec support.

2015-03-20 Thread Hans Verkuil
Hi Kamil, Once again thank you for continuing this work! I do have some comments, see below. On 03/20/2015 05:52 PM, Kamil Debski wrote: > Add the CEC framework. > > Signed-off-by: Hans Verkuil > [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] > [k.deb...@samsung.com: Merged

Re: [PATCH v3 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Hans Verkuil
On 03/20/2015 06:20 PM, Prashant Laddha wrote: > In addition to v4l2_find_dv_timings_cap(), where timings are searched > against the list of preset timings, the incoming timing from v4l2-ctl > is checked against CVT and GTF standards. If it confirms to be CVT or > GTF, it is treated as valid timi

[PATCH v3 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Prashant Laddha
In addition to v4l2_find_dv_timings_cap(), where timings are searched against the list of preset timings, the incoming timing from v4l2-ctl is checked against CVT and GTF standards. If it confirms to be CVT or GTF, it is treated as valid timing and vivid format is updated with new timings. Cc: Han

[PATCH 4/5] adv: use V4L2_DV_FL_IS_CE_VIDEO instead of V4L2_DV_BT_STD_CEA861.

2015-03-20 Thread Hans Verkuil
From: Hans Verkuil Don't rely on V4L2_DV_BT_STD_CEA861 since that include the 640x480p format, which is an IT format, not CE. Signed-off-by: Hans Verkuil Cc: Martin Bugge Cc: Mats Randgaard --- drivers/media/i2c/ad9389b.c | 10 +- drivers/media/i2c/adv7511.c | 10 +- drivers/

[PATCH 3/5] DocBook media: document the new V4L2_DV_FL_IS_CE_VIDEO flag

2015-03-20 Thread Hans Verkuil
From: Hans Verkuil Document this new flag. Signed-off-by: Hans Verkuil Cc: Martin Bugge Cc: Mats Randgaard --- Documentation/DocBook/media/v4l/vidioc-g-dv-timings.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/DocBook/media/v4l/vidioc-g-dv-timings.xml b/Docum

[PATCH 5/5] vivid: use V4L2_DV_FL_IS_CE_VIDEO instead of V4L2_DV_BT_STD_CEA861.

2015-03-20 Thread Hans Verkuil
From: Hans Verkuil Don't rely on V4L2_DV_BT_STD_CEA861 since that include the 640x480p format, which is an IT format, not CE. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-ctrls.c | 2 +- drivers/media/platform/vivid/vivid-vid-cap.c | 4 ++-- drivers/media/platform/vivid

[PATCH 2/5] videodev2.h/v4l2-dv-timings.h: add V4L2_DV_FL_IS_CE_VIDEO flag

2015-03-20 Thread Hans Verkuil
From: Hans Verkuil In the past the V4L2_DV_BT_STD_CEA861 standard bit was used to determine whether the format is a CE (Consumer Electronics) format or not. However, the 640x480p59.94 format is part of the CEA-861 standard, but it is *not* a CE video format. Add a new flag to make this explicit.

[PATCH 1/5] DocBook media: improve V4L2_DV_FL_HALF_LINE documentation

2015-03-20 Thread Hans Verkuil
From: Hans Verkuil Explicitly specify where the half-line is added or removed in each field. Signed-off-by: Hans Verkuil Cc: Prashant Laddha --- Documentation/DocBook/media/v4l/vidioc-g-dv-timings.xml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/D

[PATCH 0/5] v4l2_dv_timings: add V4L2_DV_FL_IS_CE_VIDEO flag

2015-03-20 Thread Hans Verkuil
This patch series improves the V4L2_DV_FL_HALF_LINE documentation and adds a new V4L2_DV_FL_IS_CE_VIDEO flag to tell whether this particular timing format is a CE video format or not. Previously V4L2_DV_BT_STD_CEA861 was used for that, but that fails with the CEA-861 640x480p49.94 format, which is

Re: [PATCH v2 0/3] OMAP 3 ISP (and N9/N950 primary camera support) dts changes

2015-03-20 Thread Sakari Ailus
On Thu, Mar 19, 2015 at 10:28:44AM -0700, Tony Lindgren wrote: > * Sakari Ailus [150318 16:51]: > > Hi folks, > > > > Since v1, I've rebased the set on Tero Kristo's PRCM / SCM cleanup patchset > > here: > > > > http://www.spinics.net/lists/linux-omap/msg116949.html> > > > > v1 can be found her

[RFC v3 8/9] adv7511: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7511.c | 325 ++- include/media/ad

[RFC v3 9/9] s5p-cec: Add s5p-cec driver

2015-03-20 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski --- drivers/media/platform/Kconfig |7 + drivers/media/platform/Makefile

[RFC v3 7/9] adv7604: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7604.c | 182 +++ 1 file changed,

[RFC v3 3/9] Input: add key codes specific to the HDMI CEC bus

2015-03-20 Thread Kamil Debski
The HDMI CEC bus allows device to communicate with one another. This includes sending remote control key codes. Some of key codes defined in the CEC standard are not defined in the input.h. This patch adds the key codes that are missing. Signed-off-by: Kamil Debski --- include/uapi/linux/input.h

[RFC v3 5/9] cec: add new driver for cec support.

2015-03-20 Thread Kamil Debski
Add the CEC framework. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: Merged Update author commit by Hans Verkuil] [k.deb...@samsung.com: change kthread handling when setting logical address] [k.deb...@samsung.com: code cleanup

[RFC v3 4/9] rc: add a map for devices communicating over the HDMI CEC bus

2015-03-20 Thread Kamil Debski
This patch add a map for devices that communicate over the HDMI CEC bus. Sgined-off-by: Kamil Debski --- drivers/media/rc/keymaps/Makefile |1 + drivers/media/rc/keymaps/rc-cec.c | 144 + drivers/media/rc/rc-main.c|1 + include/media/rc-core.h

[RFC v3 6/9] v4l2-subdev: add cec ops.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a/

[RFC v3 2/9] dts: add s5p-cec to exynos4412-odroidu3

2015-03-20 Thread Kamil Debski
Add support for the s5p-mfc device to the exynos4412-odroidu3.dts. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts

[RFC v3 1/9] dts: add hdmi-cec to to pinctrl definitions

2015-03-20 Thread Kamil Debski
Add entry for hdmi-cec to the pinctrl_1. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index de80b5b.

[RFC v3 0/9] HDMI CEC framework

2015-03-20 Thread Kamil Debski
Hi, First of all - thank you so much for your comments to the two previous versions of this RFC. This is the third version of the HDMI CEC framework patches. In this version I have introduced a promiscuous mode in which all messages are forwarded to the userspace. This is independent of parsing o

Re: [PATCH v2 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Prashant Laddha (prladdha)
On 20/03/15 9:39 pm, "Hans Verkuil" wrote: >Hi Prashant, > >> + >> +h_freq = (u32)bt->pixelclock / total_h_pixel; >> + >> +if (bt->standards == V4L2_DV_BT_STD_CVT) > >This test and the next isn't right. Apologies that I didn't see that >when I reviewed v1. > >The correct test is: > >

[PATCH] vivid-tpg.c: fix wrong Bt.2020 coefficients

2015-03-20 Thread Hans Verkuil
Mistyping 0.2627 as 0.2726 I can understand, but -0.4598 as -0.4629? No idea how I managed that. Anyway, these coefficients are now correct again. Signed-off-by: Hans Verkuil diff --git a/drivers/media/platform/vivid/vivid-tpg.c b/drivers/media/platform/vivid/vivid-tpg.c index 34493f4..1ab5ddb

Re: [PATCH v2 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Hans Verkuil
Hi Prashant, On 03/20/2015 03:48 PM, Prashant Laddha wrote: > In addition to v4l2_find_dv_timings_cap(), where timings are searched > against the list of preset timings, the incoming timing from v4l2-ctl > is checked against CVT and GTF standards. If it confirms to be CVT or > GTF, it is treated a

[PATCH v1 10/11] leds: max77693: add support for V4L2 Flash sub-device

2015-03-20 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers/l

[PATCH v1 09/11] DT: Add documentation for exynos4-is 'flashes' property

2015-03-20 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- .../devicetree/bindings/media/samsung-fimc.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/device

[PATCH v1 08/11] Documentation: leds: Add description of v4l2-flash sub-device

2015-03-20 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 13 + 1 fil

[PATCH v1 11/11] leds: aat1290: add support for V4L2 Flash sub-device

2015-03-20 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers/le

[PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

2015-03-20 Thread Jacek Anaszewski
This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the functions' empty versions will be used

[PATCH v1 05/11] DT: Add documentation for the Skyworks AAT1290

2015-03-20 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- .../devicetree/bindings/leds/leds-aat1290.txt | 70 1 file changed, 70 i

[PATCH v1 04/11] of: Add Skyworks Solutions, Inc. vendor prefix

2015-03-20 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Doc

[PATCH v1 06/11] exynos4-is: Add support for v4l2-flash subdevs

2015-03-20 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing "flashes" DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 36 +

[PATCH v1 03/11] leds: Add driver for AAT1290 current regulator

2015-03-20 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig|

[PATCH v1 02/11] DT: Add documentation for the mfd Maxim max77693

2015-03-20 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi Cc: Bryan Wu Cc: Richard Purdie --- Documentation/devicetre

[PATCH v1 00/11] LED / flash API integration

2015-03-20 Thread Jacek Anaszewski
This is a first non-RFC version of LED / flash API integration series [1]. It is based on linux-next_20150320. == Changes since RFC v13: == - reduced number of patches - some of them have been merged - slightly modified max77693-led device naming - fixed is

[PATCH v1 01/11] leds: Add support for max77693 mfd flash cell

2015-03-20 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski Sig

[PATCH v2 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Prashant Laddha
In addition to v4l2_find_dv_timings_cap(), where timings are searched against the list of preset timings, the incoming timing from v4l2-ctl is checked against CVT and GTF standards. If it confirms to be CVT or GTF, it is treated as valid timing and vivid format is updated with new timings. Cc: Han

Re: [PATCH v9] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Hans Verkuil
Hi Prabhakar, I'm sorry, but I still have some comments for this driver... On 03/20/2015 01:26 PM, Lad Prabhakar wrote: > From: Benoit Parrot > > this patch adds support for omnivision's ov2659 > sensor, the driver supports following features: > 1: Asynchronous probing > 2: DT support > 3: Medi

Re: [PATCH] m88ts2022: Nested loops shouldn't use the same index variable

2015-03-20 Thread Antti Palosaari
On 03/20/2015 03:37 PM, David Howells wrote: There are a pair of nested loops inside m88ts2022_cmd() that use the same index variable, but for different things. Split the variable. Signed-off-by: David Howells Reviewed-by: Antti Palosaari regards Antti --- drivers/media/tuners/m88ts20

[no subject]

2015-03-20 Thread Prashant Laddha
Thanks for your comments Hans. Resubmitting patch with corrections you have suggested. Regards, Prashant -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

[PATCH 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Prashant Laddha
In addition to v4l2_find_dv_timings_cap(), where timings are serached against the list of preset timings, the incoming timing from v4l2-ctl is checked against CVT and GTF standards. If it confirms to be CVT or GTF, it is treated as valid timing and vivid format is updated with new timings. Cc: Han

Re: [PATCH 1/3] v4l2-ctl: Add support for CVT, GTF modeline calculation

2015-03-20 Thread Prashant Laddha (prladdha)
Hello Hans, Thanks for reviewing the patch. On 20/03/15 5:00 pm, "Hans Verkuil" wrote: > >> +if (cvt->interlaced == V4L2_DV_INTERLACED) { >> +cvt->il_vfrontporch = v_fp; >> +cvt->il_vsync = v_sync; >> +cvt->il_vbackporch = v_bp; >> +/* For inte

[PATCH 1/3] v4l2-ctl: Add support for CVT, GTF modeline calculation

2015-03-20 Thread Prashant Laddha
This patch adds support for calculating v4l2_bt_timings based on CVT and GTF standards. The timings are calculated for a given standard, CVT or GTF using a set of parameters- width, height, refresh rate and flags like whether it is an interlaced format, and whether to use reduced blanking. CVT Mod

[PATCH v2 3/5] media/v4l2-ctrls: Add execute flags to write_only controls

2015-03-20 Thread Ricardo Ribalda Delgado
Any control that sets FLAG_WRITE_ONLY should OR it with FLAG_EXECUTE_ON_WRITE. So we can keep the current meaning of WRITE_ONLY. Signed-off-by: Ricardo Ribalda Delgado --- v2: Laurent Pinchart Fix commit message drivers/media/v4l2-core/v4l2-ctrls.c | 9 ++--- 1 file changed, 6 insertions(

Re: [PATCH 3/5] media/v4l2-ctrls: Add execute flags to write_only controls

2015-03-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Thursday 19 March 2015 16:21:24 Ricardo Ribalda Delgado wrote: > Any control that sets FLAG_WRITE_ONLY should OR it with FLAG_ACTION. Do you mean FLAG_EXECUTE_ON_WRITE ? > So we can keep the current meaning of WRITE_ONLY. > > Signed-off-by: Ricardo Riba

[PATCH v2 5/5] media/Documentation: New flag EXECUTE_ON_WRITE

2015-03-20 Thread Ricardo Ribalda Delgado
Document new flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE, and the new behavior of CH_VALUE event on VOLATILE controls. Signed-off-by: Ricardo Ribalda Delgado --- v2: Hans Verkuil Fix documentation (Thanks Hans!) Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 6 +++--- Documentation/DocBook/m

Re: [PATCH 5/5] media/Documentation: New flag EXECUTE_ON_WRITE

2015-03-20 Thread Hans Verkuil
On 03/19/2015 04:21 PM, Ricardo Ribalda Delgado wrote: > Document new flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE, and the new behavior > of CH_VALUE event on VOLATILE controls. > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 --- > Doc

[PATCH v3 4/5] media/v4l2-ctrls: Always execute EXECUTE_ON_WRITE ctrls

2015-03-20 Thread Ricardo Ribalda Delgado
Any control with V4L2_CTRL_FLAG_EXECUTE_ON_WRITE set should return changed == true in cluster_changed. This forces the value to be passed to the driver even if it has not changed. Signed-off-by: Ricardo Ribalda Delgado --- v3: Hans Verkuil Also set ctrl_changed to true when V4L2_CTRL_FLAG_EXECU

Re: [PATCH 4/5] media/v4l2-ctrls: Always execute EXECUTE_ON_WRITE ctrls

2015-03-20 Thread Hans Verkuil
One comment: On 03/19/2015 04:21 PM, Ricardo Ribalda Delgado wrote: > Any control with V4L2_CTRL_FLAG_EXECUTE_ON_WRITE set should return > changed == true in cluster_changed. > > This forces the value to be passed to the driver even if it has not > changed. > > Signed-off-by: Ricardo Ribalda Del

[PATCH v2 2/5] media: New flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE

2015-03-20 Thread Ricardo Ribalda Delgado
Create a new flag that represent controls which its value needs to be passed to the driver even if it has not changed. They typically represent actions, like triggering a flash or clearing an error flag. So writing to such a control means some action is executed. Signed-off-by: Ricardo Ribalda De

[PATCH] m88ts2022: Nested loops shouldn't use the same index variable

2015-03-20 Thread David Howells
There are a pair of nested loops inside m88ts2022_cmd() that use the same index variable, but for different things. Split the variable. Signed-off-by: David Howells --- drivers/media/tuners/m88ts2022.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media

Re: [PATCH 2/5] media: New flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE

2015-03-20 Thread Hans Verkuil
On 03/19/2015 04:21 PM, Ricardo Ribalda Delgado wrote: > Create a new flag that represent controls that represent controls that Double 'that represent controls' :-) > its value needs to be passed to the driver even if it has not changed. > > They typically represent actions, like triggering a

[PATCH v2 4/5] media/v4l2-ctrls: Always execute EXECUTE_ON_WRITE ctrls

2015-03-20 Thread Ricardo Ribalda Delgado
Any control with V4L2_CTRL_FLAG_EXECUTE_ON_WRITE set should return changed == true in cluster_changed. This forces the value to be passed to the driver even if it has not changed. Signed-off-by: Ricardo Ribalda Delgado --- v2: By Sakari Ailus Fix CodeStyle (sorry :S) drivers/media/v4l2-core/v

[PATCH v2 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE

2015-03-20 Thread Ricardo Ribalda Delgado
Volatile controls should not generate CH_VALUE events. Set has_changed to false to prevent this happening. Signed-off-by: Ricardo Ribalda Delgado --- v2: By Sakari Ailus Fix CodeStyle (sorry :S) drivers/media/v4l2-core/v4l2-ctrls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[RFC] Extend struct v4l2_fmtdesc to give more format info

2015-03-20 Thread Hans Verkuil
This is a proposal to extend the information returned by v4l2_fmtdesc (VIDIOC_ENUM_FMT). Especially in combination with my previous RFC PATCH (https://patchwork.linuxtv.org/patch/28877/) this is very easy to fill in correctly in the core, and it will help both drivers and applications. It is v

Re: [PATCH 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE

2015-03-20 Thread Sakari Ailus
Ricardo Ribalda Delgado wrote: Volatile controls should not generate CH_VALUE events. Set has_changed to false to prevent this happening. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/medi

[PATCH v9] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad Prabhakar
From: Benoit Parrot this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot Signed-off-by: Lad, Prabhakar Acked-by: Sakari Ailus --- Changes for v9: a: Drop

[RFC PATCH] v4l2-ioctl: fill in the description for VIDIOC_ENUM_FMT

2015-03-20 Thread Hans Verkuil
The descriptions used in drivers for the formats returned with ENUM_FMT are all over the place. So instead allow the core to fill in the description and flags. This allows drivers to drop the description and flags. If the format is not found in the list, and if the description field is filled in,

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad, Prabhakar
On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram wrote: > On 03/20/2015 05:18 PM, Lad Prabhakar wrote: > >> From: Benoit Parrot >> >> this patch adds support for omnivision's ov2659 >> sensor, the driver supports following features: >> 1: Asynchronous probing >> 2: DT support >> 3: Media controlle

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram
On 03/20/2015 05:18 PM, Lad Prabhakar wrote: From: Benoit Parrot this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot Signed-off-by: Lad, Prabhakar Acked

[PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad Prabhakar
From: Benoit Parrot this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot Signed-off-by: Lad, Prabhakar Acked-by: Sakari Ailus --- Changes for v8: ---

Re: [PATCH 1/3] v4l2-ctl: Add support for CVT, GTF modeline calculation

2015-03-20 Thread Hans Verkuil
Hi Prashant, Thanks for the patch, but I have one small comment: On 03/20/2015 07:33 AM, Prashant Laddha wrote: > This patch adds support for calculating v4l2_bt_timings based on > CVT and GTF standards. The timings are calculated for a given > standard, CVT or GTF using a set of parameters- widt

Re: [PATCH 2/2] vivid: add support to set CVT, GTF timings

2015-03-20 Thread Hans Verkuil
Hi Prashant, Thank you for the patch, but I have some comments below: On 03/20/2015 07:41 AM, Prashant Laddha wrote: > In addition to v4l2_find_dv_timings_cap(), where timings are serached > against the list of preset timings, the incoming timing from v4l2-ctl > is checked against CVT and GTF sta

Re: [RFC PATCH] v4l2: add support for colorspace conversion for video capture

2015-03-20 Thread Hans Verkuil
A follow-up to this RFC: On 03/18/2015 03:13 PM, Hans Verkuil wrote: > For video capture it is the driver that reports the colorspace, Y'CbCr > encoding > and quantization range used by the video, and there is no way to request > something > different, even though many HDTV receivers have some s