Re: [RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

Hi Hans, Thank you for working on this. On Fri, Sep 12, 2014 at 8:59 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This moves dma_(un)map_sg to the prepare/finish memops of videobuf2-dma-sg.c. I agree with Laurent. dma_map and unmap should be done when we alloc (or get) and put a buffer, whi

Re: [RFCv2 PATCH 02/14] vb2-dma-sg: add allocation context to dma-sg

Hi Hans, Thank you for working on this! On Fri, Sep 12, 2014 at 8:59 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Require that dma-sg also uses an allocation context. This is in preparation > for adding prepare/finish memops to sync the memory between DMA and CPU. > > Signed-off-by: Hans Ver

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Sep 14 04:00:14 CEST 2014 git branch: test git hash: f5281fc81e9a0a3e80b78720c5ae2ed06da3bfae gcc versi

Re: Framerate is consistently divided by 2.5

Ah sorry for the confusion. The USB camera was not working on the old kernel of ARM board. After patching the kernel, I can grab images but the framerate is 1/2.5 of expected framerate. The camera works without any issue on my PC (with kernel 3.13) though. On Wed, Sep 10, 2014 at 6:11 PM, Laurent

[PATCH] libdvbv5: fix dvb_fe_dummy()

initialize the parms structure correctly Signed-off-by: André Roth --- lib/libdvbv5/dvb-fe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c index 6745694..f733b27 100644 --- a/lib/libdvbv5/dvb-fe.c +++ b/lib/libdvbv5/dvb-fe.c @@ -43,6 +43,9 @

[PATCH 1/2] libdvbv5: cleanup logging, some memory checks

- use loginfo in hexdump - use C comments - memory checking in desc_sat and desc_service Signed-off-by: André Roth --- lib/include/libdvbv5/desc_service_list.h | 3 +- lib/libdvbv5/descriptors.c | 2 +- lib/libdvbv5/descriptors/desc_sat.c | 12 +--- lib/libdvbv5/descript

[PATCH 2/2] libdvbv5: fix satellite LNBf handling

the LNBf is part of the public structure, remove it from dvb_v5_fe_parms_priv. fix typo for C++. Signed-off-by: André Roth --- lib/include/libdvbv5/dvb-sat.h | 2 +- lib/libdvbv5/dvb-fe-priv.h | 1 - lib/libdvbv5/dvb-sat.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) di

[PATCH] DocBook media: fix wrong prototype

G_EDID is an RW ioctl, so the struct v4l2_edid isn't const. Signed-off-by: Hans Verkuil diff --git a/Documentation/DocBook/media/v4l/vidioc-g-edid.xml b/Documentation/DocBook/media/v4l/vidioc-g-edid.xml index fa91651..6df40db 100644 --- a/Documentation/DocBook/media/v4l/vidioc-g-edid.xml +++ b/

[PATCH] em28xx: remove dead code line from em28xx_audio_setup()

Setting the value of the chip config register to EM28XX_CHIPCFG_AC97 in case of a read error is a leftover from the past which is no longer needed. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 1/4] em28xx: remove some unnecessary fields from struct em28xx_audio_mode

Fields "ac97_feat", "ac97_vendor_id" and "i2s_samplerates" of struct em28xx_audio_mode are used nowhere, except in function em28xx_audio_setup(). So get rid of them and use local variables instead. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-core.c | 14 ++ drive

[PATCH 4/4] em28xx: get rid of structs em28xx_ac97_mode and em28xx_audio_mode

Now that we have enum em28xx_int_audio (none/i2s/ac97), it is no longer necessary to check dev->audio_mode.ac97 to determine the type of internal audio connection. There is also no need to save the type of the detected AC97 chip. So replce the remaining checks of dev->audio_mode.ac97 with equival

[PATCH 2/4] em28xx: simplify usb audio class handling

As far as we know devices can either have audio class or vendor class usb interfaces but not both at the same time. Even if both interface types could be provided by devices at the same time, the current code is totally broken for that case. So clean up and simplify the usb audio class handling by

[PATCH 3/4] em28xx: get rid of field has_audio in struct em28xx_audio_mode

Field has_audio in struct em28xx_audio_mode is used together with value EM28XX_NO_AC97 of field ac97 to determine the internal type of audio (none/i2s/ac97). This makes the code difficult to understand: !dev->audio_mode.has_audio && audio_mode.ac97 == EM28XX_NO_AC97 => no audio !dev->a

Re: v4l2 ioctls

On 09/13/2014 02:37 AM, Shuah Khan wrote: > Mauro/Hans, > > Thanks for both for your replies. I finally have it working with > the following: > > S_INPUT > S_OUTPUT S_OUTPUT is not necessary. It will never be used in combination with a modulator since we don't support TV modulators at all. > S_

[PATCH 0/4] em28xx: clean up the audio variable mess

The audio variables in em28xx are a big mess: - many have misleading names - some are completely unnecessary - some duplicate in parts or even completely the meaning of others - some device features are described by combinations of multiple variables, which makes the code difficult to understand

Re: v4l2_fops - poll and open

On 09/13/2014 02:34 AM, Shuah Khan wrote: > Mauro/Hans, > > It turns out au0828 driver does init tuner from its > v4l2_fops read and poll. If an analog app comes in > and does a read or poll, digital could get disrupted. > Do you recommend adding token access to these?? Yes. read() and poll() are