Re: [PATCH v3 3/3] media: atmel-isi: add primary DT support

2014-07-27 Thread Josh Wu
Hi, Guennadi On 7/27/2014 3:57 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for a prompt update! A couple of minor questions: On Fri, 25 Jul 2014, Josh Wu wrote: This patch add the DT support for Atmel ISI driver. It use the same v4l2 DT interface that defined in video-interfaces.txt. S

[linuxtv-media:master 492/499] drivers/media/usb/cx231xx/cx231xx-dvb.c:163:21: error: variable 'pctv_quatro_stick_1114xx_si2165_config' has initializer but incomplete type

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: 9e49f7c3d67c4db4911d3a62c39fb44b82feaaf7 [492/499] [media] cx231xx: Add digital support for HVR930C-HD model 1114xx config: x86_64-randconfig-hsxa2-07281830 (attached as .config) All error/war

[linuxtv-media:master 491/499] drivers/media/usb/cx231xx/cx231xx-dvb.c:156:21: error: variable 'hauppauge_930C_HD_1113xx_si2165_config' has initializer but incomplete type

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: dd2e7dd20cf482bc2fd989bfbd0354476ae904c2 [491/499] [media] cx231xx: Add digital support for HVR 930c-HD model 1113xx config: x86_64-randconfig-hsxa2-07281830 (attached as .config) All error/wa

cron job: media_tree daily build: ERRORS

2014-07-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Jul 28 04:00:17 CEST 2014 git branch: test git hash: 488046c237f3b78f91046d45662b318cd2415f64 gcc versi

[linuxtv-media:master 489/499] drivers/media/pci/cx23885/cx23885-dvb.c:1490:24: note: in expansion of macro 'dvb_attach'

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: 36efec48e2e6016e05364906720a0ec350a5d768 [489/499] [media] cx23885: Add si2165 support for HVR-5500 config: x86_64-randconfig-hsxa2-07281656 (attached as .config) All warnings: In file inc

[linuxtv-media:master 489/499] drivers/media/pci/cx23885/cx23885-dvb.c:712:21: error: variable 'hauppauge_hvr4400_si2165_config' has initializer but incomplete type

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: 36efec48e2e6016e05364906720a0ec350a5d768 [489/499] [media] cx23885: Add si2165 support for HVR-5500 config: x86_64-randconfig-hsxa1-07281601 (attached as .config) Note: the linuxtv-media/maste

Advice on DVB-S/S2 card and CAM support

2014-07-27 Thread Kaya Saman
Hi, I'm wondering what the best solution for getting satellite working on Linux is? Currently I have a satellite box with CAM module branded by the Satellite TV provider we are with. As I am now migrating everything including TV through my HTPC environment I would also like to link the s

Re: [PATCH 2/3] [media] coda: fix coda_g_selection

2014-07-27 Thread Hans Verkuil
On 07/27/2014 11:32 PM, Nicolas Dufresne wrote: > Le dimanche 27 juillet 2014 à 20:21 +0200, Hans Verkuil a écrit : >> If cropcap returns -EINVAL then that means that the current input or >> output does >> not support cropping (for input) or composing (for output). In that case the >> pixel aspect

[linuxtv-media:master 491/499] drivers/media/usb/cx231xx/cx231xx-dvb.c:736:57: sparse: Using plain integer as NULL pointer

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: dd2e7dd20cf482bc2fd989bfbd0354476ae904c2 [491/499] [media] cx231xx: Add digital support for HVR 930c-HD model 1113xx reproduce: make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefi

Re: [PATCH 2/3] [media] coda: fix coda_g_selection

2014-07-27 Thread Nicolas Dufresne
Le dimanche 27 juillet 2014 à 20:21 +0200, Hans Verkuil a écrit : > If cropcap returns -EINVAL then that means that the current input or > output does > not support cropping (for input) or composing (for output). In that case the > pixel aspect ratio is undefined and you have no way to get hold of

[linuxtv-media:master 489/499] drivers/media/pci/cx23885/cx23885-dvb.c:1494:72: sparse: Using plain integer as NULL pointer

2014-07-27 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0a12830893e8b89e9019848ead054b0f85b3 commit: 36efec48e2e6016e05364906720a0ec350a5d768 [489/499] [media] cx23885: Add si2165 support for HVR-5500 reproduce: make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> dr

Re: em28xx vb2 warnings

2014-07-27 Thread Hans Verkuil
On 07/27/2014 11:17 PM, Frank Schäfer wrote: > > Am 25.07.2014 21:07, schrieb Hans Verkuil: >> On 07/25/2014 06:20 PM, Frank Schäfer wrote: >>> Hi Hans, >>> >>> I'm getting the following warnings with the em28xx driver on streaming stop: >>> >>> [ 7597.346168] WARNING: CPU: 1 PID: 3730 at >>> driv

Re: [PATCH for v3.17] v4l2-ctrls: fix rounding calculation

2014-07-27 Thread Frank Schäfer
Am 26.07.2014 18:02, schrieb Hans Verkuil: > Commit 958c7c7e65 ("[media] v4l2-ctrls: fix corner case in round-to-range > code") broke > controls that use a negative range. > > The cause was a s32/u32 mixup: ctrl->step is unsigned while all others are > signed. So > the result type of the express

Re: em28xx vb2 warnings

2014-07-27 Thread Frank Schäfer
Am 25.07.2014 21:07, schrieb Hans Verkuil: > On 07/25/2014 06:20 PM, Frank Schäfer wrote: >> Hi Hans, >> >> I'm getting the following warnings with the em28xx driver on streaming stop: >> >> [ 7597.346168] WARNING: CPU: 1 PID: 3730 at >> drivers/media/v4l2-core/videobuf2-core.c:2126 >> __vb2_queue

[PATCH] [media] mceusb: select default keytable based on vendor

2014-07-27 Thread Mauro Carvalho Chehab
Some vendors have their on keymap table that are used on all (or almost all) models for that vendor. So, instead of specifying the keymap table per USB ID, let's use the Vendor ID's table by default. At the end, this will mean less code to be added when newer devices for those vendors are added.

Re: [PATCH] cx231xx: add support for newer cx231xx devices

2014-07-27 Thread Mauro Carvalho Chehab
In time: Subject should be, instead: mceusb: add support for newer cx231xx devices Regards, Mauro Em Sun, 27 Jul 2014 17:13:12 -0300 Mauro Carvalho Chehab escreveu: > Add support for the si2165-based cx231xx devices: > [2013:025e] PCTV QuatroStick 522e > [2013:0259] PCTV Qu

[PATCH] cx231xx: add support for newer cx231xx devices

2014-07-27 Thread Mauro Carvalho Chehab
Add support for the si2165-based cx231xx devices: [2013:025e] PCTV QuatroStick 522e [2013:0259] PCTV QuatroStick 521e [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx) They're similar to the already supported: [2040:b130] Hauppauge WinTV 930C-HD (model 1113xx) Sig

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Mauro Carvalho Chehab
Em Sun, 27 Jul 2014 11:59:11 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 27 Jul 2014 11:32:48 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Sun, 27 Jul 2014 10:44:53 -0300 > > Mauro Carvalho Chehab escreveu: > > > > > Em Sun, 27 Jul 2014 11:32:26 +0200 > > > Matthias Schwarzott escrev

[PATCH v3 4/6] cx231xx: handle errors at read_eeprom()

2014-07-27 Thread Mauro Carvalho Chehab
Fix the following warnings: drivers/media/usb/cx231xx/cx231xx-cards.c: In function 'read_eeprom': drivers/media/usb/cx231xx/cx231xx-cards.c:979:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx23

[PATCH v3 5/6] cx231xx: move analog init code to a separate function

2014-07-27 Thread Mauro Carvalho Chehab
That makes easier to understand the code. It would also help to add support for having boards with just digital support on some latter patch, as allowed by some PCB configs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-cards.c | 220 -- 1

[PATCH v3 3/6] cx231xx: use devm_ functions to allocate memory

2014-07-27 Thread Mauro Carvalho Chehab
The initialization is already too complex. Use devm_ functions to make the code simpler and easier to modify. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-cards.c | 43 ++- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/d

[PATCH v3 2/6] cx231xx: Don't let an interface number to go past the array

2014-07-27 Thread Mauro Carvalho Chehab
On some newer boards, like HVR-930C HD, the information at the PCB tables are sometimes higher than the ones actually available on the device. That causes the probing code to go past the interfaces array. Add checks to the interface number before going past the array. Signed-off-by: Mauro Carvalh

[PATCH v3 1/6] cx231xx: Fix the max number of interfaces

2014-07-27 Thread Mauro Carvalho Chehab
The max number of interfaces was read from the wrong descriptor. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-cards.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx

[PATCH v3 6/6] cx231xx: return an error if it can't read PCB config

2014-07-27 Thread Mauro Carvalho Chehab
Instead of using some random value, return an error if the PCB config is not available or doesn't match a know profile Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-cards.c | 6 +- drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c | 10 +++--- drivers/media/usb/

[PATCH v3 0/6] cx231xx: don't OOPS when probe fails

2014-07-27 Thread Mauro Carvalho Chehab
cx231xx relies on a code that detects the possible PCB settings. However, there are several troubles there: 1) The number of interfaces are read from the wrong place; 2) The code doesn't check if the interface is past the data; 3) If the code that read the PCB config fails, it keeps running usi

Re: [PATCH 2/3] [media] coda: fix coda_g_selection

2014-07-27 Thread Hans Verkuil
On 07/27/2014 06:53 PM, Nicolas Dufresne wrote: > > Le Samedi 26 Juillet 2014 12:37 EDT, Philipp Zabel > a écrit: > >> I have tried the GStreamer v4l2videodec element with the coda driver and >> noticed that GStreamer calls VIDIOC_CROPCAP to obtain the pixel aspect >> ratio. This always fails

Re: [PATCH 2/3] [media] coda: fix coda_g_selection

2014-07-27 Thread Nicolas Dufresne
Le Samedi 26 Juillet 2014 12:37 EDT, Philipp Zabel a écrit: > I have tried the GStreamer v4l2videodec element with the coda driver and > noticed that GStreamer calls VIDIOC_CROPCAP to obtain the pixel aspect > ratio. This always fails with -EINVAL because of this issue. Currently > GStreamer

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Mauro Carvalho Chehab
Em Sun, 27 Jul 2014 11:32:48 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 27 Jul 2014 10:44:53 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Sun, 27 Jul 2014 11:32:26 +0200 > > Matthias Schwarzott escreveu: > > > > > > > > Hi Mauro. > > > > > > On 26.07.2014 21:27, Mauro Carvalho Cheh

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Mauro Carvalho Chehab
Em Sun, 27 Jul 2014 10:44:53 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 27 Jul 2014 11:32:26 +0200 > Matthias Schwarzott escreveu: > > > > > Hi Mauro. > > > > On 26.07.2014 21:27, Mauro Carvalho Chehab wrote: > > > Tried to apply your patch series, but there's something wrong on it. > >

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Mauro Carvalho Chehab
Em Sun, 27 Jul 2014 11:32:26 +0200 Matthias Schwarzott escreveu: > > Hi Mauro. > > On 26.07.2014 21:27, Mauro Carvalho Chehab wrote: > > Tried to apply your patch series, but there's something wrong on it. > > > > See the enclosed logs. I suspect that you missed a patch adding the > > proper t

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Isaac Nickaein
Hi Hans, I understand. I will get in touch with the maintainer to see how we can fix this issue. Thank you so much for the help, Isaac On Sun, Jul 27, 2014 at 1:30 PM, Hans Verkuil wrote: > On 07/27/2014 10:42 AM, Isaac Nickaein wrote: >> On Sun, Jul 27, 2014 at 12:56 PM, Hans Verkuil wrote:

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Matthias Schwarzott
Hi Mauro. On 26.07.2014 21:27, Mauro Carvalho Chehab wrote: > Tried to apply your patch series, but there's something wrong on it. > > See the enclosed logs. I suspect that you missed a patch adding the > proper tuner for this device. well, tuner_type is set to TUNER_ABSENT, and for me the oops

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Hans Verkuil
On 07/27/2014 10:42 AM, Isaac Nickaein wrote: > On Sun, Jul 27, 2014 at 12:56 PM, Hans Verkuil wrote: >> No. Whoever maintains that repository applied v4l code from some newer >> kernel without apparently ever testing it. This is really the responsibility >> of maintainer of that repository and is

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Isaac Nickaein
On Sun, Jul 27, 2014 at 12:56 PM, Hans Verkuil wrote: > No. Whoever maintains that repository applied v4l code from some newer > kernel without apparently ever testing it. This is really the responsibility > of maintainer of that repository and is out of our control. > > You need to address your q

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Hans Verkuil
On 07/27/2014 10:18 AM, Isaac Nickaein wrote: > Hi Hans, > > I am using Kernel 3.0.36+ download from this repository: > https://github.com/linux-rockchip/kernel_rockchip > It's a fork of https://github.com/rkchrome/kernel > > I guess I don't need that driver. After disabling it through > menuconf

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Isaac Nickaein
Hi Hans, I am using Kernel 3.0.36+ download from this repository: https://github.com/linux-rockchip/kernel_rockchip It's a fork of https://github.com/rkchrome/kernel I guess I don't need that driver. After disabling it through menuconfig, I get this error: In file included from /root/v4l2/media

Re: "error: redefinition of 'altera_init'" during build on Kernel 3.0.36+

2014-07-27 Thread Hans Verkuil
On 07/27/2014 08:47 AM, Isaac Nickaein wrote: > Hello, > > I get the following error when I try to build the V4L2 on Kernel > 3.0.36+ for ARM architecture: > > /root/v4l2/media_build/v4l/altera.c:2417:5: error: redefinition of > 'altera_init' > int altera_init(struct altera_config *config, cons