Re: [PATCH] media: mx1_camera: Remove driver

On Sun, May 11, 2014 at 10:09:11AM +0400, Alexander Shiyan wrote: > That driver hasn't been really maintained for a long time. It doesn't > compile in any way, it includes non-existent headers, has no users, > and marked as "broken" more than year. Due to these factors, mx1_camera > is now removed

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon May 12 04:00:20 CEST 2014 git branch: test git hash: 393cbd8dc532c1ebed60719da8d379f50d445f28 gcc versi

Re: [patch] [media] Staging: dt3155v4l: set error code on failure

On Friday, May 09, 2014 8:55 PM, Dan Carpenter wrote: > > We should be returning -ENOMEM here instead of success. > > Signed-off-by: Dan Carpenter It looks good. video_device_alloc() calls kzalloc(); thus, when video_device_alloc() returns NULL, '-ENOMEM' should be returned. Reviewed-by: Jingo

Re: [PATCH v2] radio-bcm2048.c: fix wrong overflow check

On Fri, 9 May 2014, Pali Rohár wrote: > > Seems like it's not in linux-next as of today, so I am taking > > it now. Thanks, > > I still do not see this patch in torvalds branch... So what is > needed to include this security buffer overflow patch into > mainline & stable kernels? I picked it u

Re: [PATCH 00/19] em28xx: clean up the main device struct and move sub-module specific data to its own data structs

Hi Hans, Am 09.05.2014 11:04, schrieb Hans Verkuil: > Hi Frank, > > This looks good to me. I do have some comments for future cleanups and I'll > reply to the relevant patches for that. > > However, before I can apply this patch series you need to take a look at my > comments > for this pre-requ

[PATCH 15/19, REBASED] em28xx: move v4l2 user counting fields from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-video.c | 27 +++ drivers/media/usb/em28xx/em28xx.h | 5 +++-- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28x

Re: [PATCH 06/19] em28xx: move video_device structs from struct em28xx to struct v4l2

Am 09.05.2014 11:19, schrieb Hans Verkuil: > On 03/24/2014 08:33 PM, Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer >> --- >> drivers/media/usb/em28xx/em28xx-video.c | 120 >> ++-- >> drivers/media/usb/em28xx/em28xx.h | 7 +- >> 2 files changed, 56 inse

Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

Am 09.05.2014 11:17, schrieb Hans Verkuil: > Some comments for future improvements: > > On 03/24/2014 08:33 PM, Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer >> --- >> drivers/media/usb/em28xx/em28xx-camera.c | 4 +- >> drivers/media/usb/em28xx/em28xx-video.c | 160 >>

[PATCH] em28xx: remove the i2c_set_adapdata() call in em28xx_i2c_register()

It is no longer needed since nobody is calling i2c_get_adapdata() anymore. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c ind

Re: [PATCH 2/5] em28xx: fix i2c_set_adapdata() call in em28xx_i2c_register()

Hi Hans, Am 09.05.2014 10:40, schrieb Hans Verkuil: > Hi Frank, > > I've got a comment about this patch: > > On 03/22/2014 02:01 PM, Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer >> --- >> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >

WinTV-HVR900 - sound ripped/noise with recent kernels

:-) I'm using ArchLinux up-to-date (most recent stable kernels, today: 3.14.3-1). tvtime + sound via: $ sox -G -t alsa hw:1,0 -t alsa Worked for a very long time. Recently (~last month) the sound stopped working. Precisely: the sound seems to be "ripped", with some "noise" or "echo" - numerous sh

Re: Hauppauge 950Q TS capture intermittent lock up

Mauro, Thanks. (Resending in plain text as last email was rejected by email list). I'll look at the patch, and let you know if that helps. I'll send out the application tomorrow as I'm not on my dev machine right now. -Trevor On Sun, May 11, 2014 at 10:58 AM, Mauro Carvalho Chehab wrote: > Hi T

Re: Hauppauge 950Q TS capture intermittent lock up

Hi Trevor, Em Fri, 9 May 2014 11:19:49 -0400 Trevor Anonymous escreveu: > Hello all, > > I have written a simple application to capture RF QAM transport > streams with the Hauppauge 950Q, and save to a file. This is > essentially the same as dvbstream, but with unnecessary stuff removed > (and

[PATCH 10/10] ati_remote: Better default keycodes

This tries to make them more like other remotes, and/or the button labels. Notably, the (>>) button is made KEY_FASTFORWARD, which is the correct opposite of (<<)'s KEY_REVERSE. (It was KEY_FORWARD, something else entirely.) Likewise, KEY_STOP is the Sun keyboard "interrupt program" key; the med

[PATCH 09/10] ati_remote: Add comments to keycode table

A more detailed description of what the buttons look like and their intended function makes it easier for people to maintain this code without access to the hardware. Signed-off-by: George Spelvin --- drivers/media/rc/keymaps/rc-ati-x10.c | 33 +++-- 1 file changed, 2

[PATCH 08/10] ati_remote: Sort buttons in top-to-bottom order

Since numerical order corresponds to top-left-to-bottom-right order on the remote, this makes the table easier to read. Signed-off-by: George Spelvin --- drivers/media/rc/keymaps/rc-ati-x10.c | 57 +-- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git

[PATCH 07/10] ati_remote: Use non-alomic __set_bit

There's no reason to use a LOCK prefix here. Signed-off-by: George Spelvin --- drivers/media/rc/ati_remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c index 69d7912e03..8536eef918 100644 --- a/drivers/media/r

[PATCH 06/10] ati_remote: Merge some duplicate code

The KIND_FILTERED assignment of old_jiffies can't be merged, because it must precede repeat handling. Signed-off-by: George Spelvin --- drivers/media/rc/ati_remote.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/media/rc/ati_remote.c b/driver

[PATCH 04/10] ati_remote: Generalize KIND_ACCEL to accept diagonals

Rather than having special code cases for diagonal mouse movements, extend the general purpose code used for the cardinal directions to handle arbitrary (x,y) deltas. The deltas themselves are stored in translation table's "code" field; this is also progress toward the goal of eliminating the "val

[PATCH 05/10] ati_remote: Shrink the ati_remote_tbl even more

Get rid of the unnecessary "type" and "value" fields. Signed-off-by: George Spelvin --- drivers/media/rc/ati_remote.c | 69 ++- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c in

[PATCH 03/10] ati_remote: Delete superfluous input_sync()

It's not necessary, and since both events happen "at the same time" in response to a single input event, the input device framework prefers not to have it there. (It's not a big deal one way or the other, but deleting cruft is generally a good thing.) Signed-off-by: George Spelvin --- drivers/m

[PATCH 02/10] ati_remote: Shrink ati_remote_tbl structure

The variable types are simply larger than they need to be. Shrink to signed and unsigned chars. Signed-off-by: George Spelvin --- drivers/media/rc/ati_remote.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.

[PATCH 01/10] ati_remote: Check the checksum

An input report is 4 bytes long, but there are only 12 bits of actual payload. The 4 bytes are: data[0] = 0x14 data[1] = data[2] + data[3] + 0xd5 (a checksum byte) data[2] = the raw scancode (plus toggle bit in msbit) data[3] = channel << 4 (the low 4 bits must be zero) Ignore reports with a bad

[PATCH 0/10] drivers/media/rc/ati_remote.c tweaks

Here are a bunch of cleanups to the ati_remote driver that have been sitting in my tree since 2011, and I'm hoping to push upstream. They work fine on my v1 ATI Remote Wonder. Patch 4/10 is the nicest in terms of code deletion, but the others shrink the driver, too. There are some that I'm not s

Re: [PATCH] ARM: i.MX: Remove excess symbols ARCH_MX1, ARCH_MX25 and MACH_MX27

On Sun, May 11, 2014 at 12:50:06PM +0400, Alexander Shiyan wrote: > This patch removes excess symbols ARCH_MX1, ARCH_MX25 and MACH_MX27. > Instead we use SOC_IMX*. > > Signed-off-by: Alexander Shiyan Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kle

[PATCH] ARM: i.MX: Remove excess symbols ARCH_MX1, ARCH_MX25 and MACH_MX27

This patch removes excess symbols ARCH_MX1, ARCH_MX25 and MACH_MX27. Instead we use SOC_IMX*. Signed-off-by: Alexander Shiyan --- arch/arm/mach-imx/Kconfig | 12 arch/arm/mach-imx/devices/Kconfig | 2 +- drivers/media/platform/soc_camera/Kconfig | 2 +- 3 f