Hi Hans,
Thanks for the patch.
On Thu, Apr 17, 2014 at 2:51 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The vb2 core ignores any return code from the stop_streaming op.
> And there really isn't anything it can do anyway in case of an error.
> So change the return type to void and update an
Hi Hans,
On Thu, Apr 17, 2014 at 2:51 PM, Hans Verkuil wrote:
> Split off the removal of the vb2_is_streaming check as requested.
> Note that the davinci drivers still have this unnecessary check, but
> Prabhakar will remove that himself.
>
Yes will post the patch, doping the check for davinci dr
Replace resource handling in the driver with managed device resource.
Signed-off-by: Alexander Shiyan
---
drivers/media/platform/m2m-deinterlace.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/m2m-deinterlace.c
b/drivers/media/platform/m2m-dei
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Apr 18 04:00:14 CEST 2014
git branch: test
git hash: 701b57ee3387b8e3749845b02310b5625fbd8da0
gcc versi
Linux backports [0] backports-v3.15-rc1 is out [1]. Please
go test and see if you can and break things or if see if
we've broken anything so far before a final release in
sync with Linus' releases. As usual development only happens
on the master branch, we'll then carry fixes onto the stable
branch
Linux backports [0] backports-v3.14-1 is out [1]. Thanks for Hauke
for taking the torch while I was in limbo. The release obviously
has all the things that upstream has so there's no point in mentioning
any of that, but new drivers are igb, added by Stefan. This release
also has a new backports-upd
3 new linux backports release are now available based on linux-next
tags next-20140320 [0] next-20140411 [1] and next-20140417 [2]. This
should mean that we can keep things in synch now almost daily, and
drivers can be tested with the latest code as-is on linux-next. We've
shaved off k
Couple of changes to help with backports, both to help with ensuring
drivers use their own namespace.
Luis R. Rodriguez (2):
technisat-usb2: rename led enums to be specific to driver
bt8xx: make driver routines fit into its own namespcae
drivers/media/pci/bt8xx/dst.c | 20 ++
From: "Luis R. Rodriguez"
The current names clash with include/linux/leds.h namespace,
although there is no compile issue currently this does affect
backports. Drivers should also try to avoid generic namespaces
for things like this.
Cc: Mauro Carvalho Chehab
Cc: Felipe Pena
Cc: Michael Krufky
From: "Luis R. Rodriguez"
There is a few conflicts with older symbols on older kernels so we
have to patch this driver when backporting. Instead just make these
routines specific to the driver.
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
Signed-off-by: Luis R. Rodriguez
---
driv
On Mon, Apr 14, 2014 at 10:38 AM, Ben Dooks wrote:
> On 14/04/14 18:14, Bryan Wu wrote:
>>
>> On Thu, Apr 10, 2014 at 2:18 PM, Guennadi Liakhovetski
>> wrote:
>>>
>>> Hi Bryan,
>>>
>>> On Tue, 8 Apr 2014, Bryan Wu wrote:
>>>
Thanks Josh, I think I will take you point and rework my patch agai
Hi Will,
On Monday 14 April 2014 11:27:00 Will Manley wrote:
> On Mon, 14 Apr 2014, at 1:34, Laurent Pinchart wrote:
[snip]
> > Thank you for investigating this, and sorry for the late reply.
> >
> > I still haven't heard back from Logitech on this issue. I've pinged them,
> > they might be bus
On 04/17/2014 02:22 PM, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
Please do not implement locking
primitive directly if at all avoidable. Why can't it use a mutex
embedded in the data area of a devres entry? And if you for some
reason have to implement it dir
Hi Thomas,
On Thursday 17 April 2014 09:53:32 Thomas Pugliese wrote:
> On Thu, 17 Apr 2014, Laurent Pinchart wrote:
> > On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
[snip]
> > > As you had mentioned previously, it should be possible to support both
> > > formats by ignoring the end
Hi Guys,
I've been playing around with this on my Kubuntu 13.10. Apart from the
issue that you know I have of the altera-stapl.ko file arriving in the
wrong directory, I think it's a good basis for moving forwards. What is
the process for including this in the Linux TV baseline?
I feel the
Function del_timer() does not guarantee that timer was really deleted.
If the timer handler is beeing executed at the moment, the function
does nothing. So, we have a race between del_timer() and kfree(), and
it's possible to use already freed memory in the handler.
This is compile-tested only. Pl
On 04/17/2014 02:10 PM, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock().
spin_lock_irqsave(&dev->devres_lock,
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
> On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
> > Operating on the lock should be atomic, which is what devres_update()
> > is doing. It can be simplified as follows by holding devres_lock
> > in devm_token_lock().
> >
> >
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
> Operating on the lock should be atomic, which is what devres_update()
> is doing. It can be simplified as follows by holding devres_lock
> in devm_token_lock().
>
> spin_lock_irqsave(&dev->devres_lock, flags);
> if (tkn_ptr->status == T
Hi Tejun,
On 04/16/2014 03:58 PM, Tejun Heo wrote:
Hello,
Thanks for the review. A brief description of the use-case first.
Token is intended to be used as a large grain lock and once locked,
it can be held in the locked state for long periods of time.
For instance, application will request v
On Thu, 17 Apr 2014, Laurent Pinchart wrote:
> Hi Thomas,
>
> On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
> > On Wed, 16 Apr 2014, Laurent Pinchart wrote:
> > > Hi Thomas,
> > >
> > > (CC'ing the linux-usb mailing list)
> > >
> > > On Tuesday 15 April 2014 16:45:28 Thomas Pugli
On 17/04/14 16:39, Sylwester Nawrocki wrote:
> On 17/04/14 16:13, Laurent Pinchart wrote:
>> > Parse the device tree node to populate platform data. Only the ADV7611
>> > is currently support with DT.
>> >
>> > Cc: devicet...@vger.kernel.org
>> > Cc: Sylwester Nawrocki
>> > Signed-off-by: Laurent
On 17/04/14 16:13, Laurent Pinchart wrote:
> Add support for the hsync-active, vsync-active and pclk-sample
> properties to the DT bindings and control BT.656 mode implicitly.
>
> Cc: devicet...@vger.kernel.org
> Cc: Sylwester Nawrocki
> Signed-off-by: Laurent Pinchart
> Acked-by: Hans Verkuil
Hi Sylwester,
On Thursday 17 April 2014 16:39:29 Sylwester Nawrocki wrote:
> On 17/04/14 16:13, Laurent Pinchart wrote:
> > Parse the device tree node to populate platform data. Only the ADV7611
> > is currently support with DT.
> >
> > Cc: devicet...@vger.kernel.org
> > Cc: Sylwester Nawrocki
>
Hi Laurent,
On 17/04/14 16:13, Laurent Pinchart wrote:
> Parse the device tree node to populate platform data. Only the ADV7611
> is currently support with DT.
>
> Cc: devicet...@vger.kernel.org
> Cc: Sylwester Nawrocki
> Signed-off-by: Laurent Pinchart
> Acked-by: Hans Verkuil
The patch look
Hi Thomas,
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
> On Wed, 16 Apr 2014, Laurent Pinchart wrote:
> > Hi Thomas,
> >
> > (CC'ing the linux-usb mailing list)
> >
> > On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote:
> > > On Tue, 15 Apr 2014, Laurent Pinchart wrote:
> >
Signed-off-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Reviewed-by: Hans Verkuil
---
include/media/v4l2-subdev.h| 4
include/uapi/linux/videodev2.h | 10 --
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subde
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 240 +
include/uapi/linux/v4l2-mediabus.h | 6 +-
2 files changed, 245 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 128 +
include/uapi/linux/v4l2-mediabus.h | 4 +-
2 files changed, 131 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 104 +
include/uapi/linux/v4l2-mediabus.h | 4 +-
2 files changed, 107 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7842.c | 8
1 file changed, 8
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 10 ++
1
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/media/platform/da
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/ad9389b.c | 68 ++-
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/media/i2c/ths8200.c | 12 +
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7511.c | 66 ++-
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/media/i2c/tvp7002.c | 4
1 file changed, 4 in
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 288 +
include/uapi/linux/v4l2-mediabus.h | 6 +-
2 files changed, 293 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/s5p-tv/hdmiphy_drv.c | 8
1 file changed, 8 insertio
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Scott Jiang
---
drivers/media/platform/black
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/staging/media/dav
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7842.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/ad9389b.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/ad9389b.c b/drivers/media/i2c/ad9389b.
From: Lars-Peter Clausen
Signed-off-by: Lars-Peter Clausen
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 338baa4..7358853 10064
The video enum_dv_timings operation is deprecated and unused. Remove it.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/s5p-tv/hdmiphy_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/s5p-tv/hdmiphy_drv.c
b/drivers/media/plat
From: Lars-Peter Clausen
We do not want to modify the info string arrays ever, so no need to
waste stack space for them. While we are at it also make them const.
Signed-off-by: Lars-Peter Clausen
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 8 ++
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/media/i2c/ths8200.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/ths8200.c b/
Validate the pad field in the core code whenever specified.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
.../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++
.../DocBook/media/v4l/vidioc-enum-dv-timings.xml | 30 +-
drivers/media/v4
Wrapping the #define's at a 80 columns boundary just obfuscates the
code. Don't do that.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Sakari Ailus
---
include/uapi/linux/v4l2-subdev.h | 33 +
1 file changed, 13 insertions(+), 20 deletions(
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7511.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.
From: Lars-Peter Clausen
The file is using u8 which is defined in linux/types.h.
Signed-off-by: Lars-Peter Clausen
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
include/media/adv7604.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/media/adv7604.h b/include/med
Control operations are handled by the control framework and the subdev
control handlers are never called directly. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c/a
The subdev EDID ioctls receive a pad field that must reference an
existing pad and an EDID field that must point to a buffer. Validate
both fields in the core code instead of duplicating validation in all
drivers.
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
Reviewed-by: Hans Verkuil
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
---
drivers/media/i2c/tvp7002.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tvp7002.c b/dr
From: Lars-Peter Clausen
This patch adds support for the Analog Devices ADV7611 HDMI receiver.
The adv7611 is quite similar to the adv7604. It has only one instead of four
HDMI inputs and no analog frontend though. Also some register bits have been
shuffled around, but large parts of their regist
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 35 +--
1 file changed, 9 insertions(+), 26 deletions(-)
diff --git a/driv
Parse the device tree node to populate platform data. Only the ADV7611
is currently support with DT.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/i2c/adv7604.txt | 57 +++
drivers
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Acked-by: Sakari Ailus
Acked-by: Lad, Prabhakar
---
include/media/v4l2-subdev.h | 4
1 file changed, 4 deletions(-)
diff --git a/incl
Replace the dummy video format operations by pad format operations that
configure the output format.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 280
include/media/adv7604.h
Add support for optional GPIO-controlled HPD pins in addition to the
ADV7604-specific hotplug notifier.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 37 +
1 file changed, 33 insertions(+), 4 deletions(-)
diff --
The ADV7604 has sink pads for its HDMI and analog inputs. Report them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 61 ++---
include/media/adv7604.h | 23 -
2 files changed, 46 insertions
This helps locating duplicates and inserting new headers.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 7a
The *_and_or() functions take an 'and' bitmask to be ANDed with the
register value before ORing it with th 'or' bitmask. As the functions
are used to mask and set bits selectively, this requires the caller to
invert the 'and' bitmask and is thus error prone. Replace those
functions with a *_clr_set
And set input routing when initializing the device.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 7 +++
include/media/adv7604.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
This allows replacing duplicate code blocks by loops over the arrays.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 248 +---
include/media/adv7604.h | 30 +++---
2 files changed, 88 insertions(+), 190 de
Add an inv_llc_pol field to platform data to control the clock polarity.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Reviewed-by: Sylwester Nawrocki
---
drivers/media/i2c/adv7604.c | 3 ++-
include/media/adv7604.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff -
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 47 +
1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 59f7bf0..684b912 100644
---
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/s5p-tv/mixer_video.c | 8 +++
When extracting multiple bits from a single register read the register
once and extract the bits on the read value.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
The table is always declared but is unused when both CONFIG_OF and
CONFIG_MODULES are not set. This results in a compile warning. Fix it by
marking the table as __maybe_unused. The compiler will discard it if
unused.
Signed-off-by: Laurent Pinchart
---
drivers/media/i2c/adv7604.c | 2 +-
1 file
Hello,
This patch set implements support for the ADV7611 in the adv7604 driver. It
also comes up with new features such as output format configuration through
pad format operations, hot-plug detect control through GPIO and DT support.
I believe I've addressed all comments received on v3 and picke
The HPD GPIO is used as an output but its direction is never set. Fix
it.
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 63
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/i2c/adv7604.txt |
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 48 ++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index dd0a9a9..da256dd 100644
--
This one line function is called in a single location. Inline it.
Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
inde
On 17/04/14 15:08, Laurent Pinchart wrote:
static struct i2c_driver adv7604_driver = {
> > >
> > > .driver = {
> > >
> > > .owner = THIS_MODULE,
> > > .name = "adv7604",
> > >
> > > +.of_match_table = of_ma
Em Thu, 17 Apr 2014 11:49:51 +0200
Hans Verkuil escreveu:
> On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote:
> > Em Thu, 17 Apr 2014 00:33:55 +0200
> > Hans Verkuil escreveu:
> >
> >> On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote:
> >>> Em Mon, 10 Mar 2014 13:20:49 +0100
> >>> Hans Ve
Hi Sylwester,
On Thursday 17 April 2014 14:36:32 Laurent Pinchart wrote:
> On Thursday 17 April 2014 12:59:22 Sylwester Nawrocki wrote:
> > On 11/03/14 00:15, Laurent Pinchart wrote:
> > > Parse the device tree node to populate platform data.
> > >
> > > Cc: devicet...@vger.kernel.org
> > > Signe
Hi Ben,
On Thursday 17 April 2014 14:00:15 Ben Dooks wrote:
> On 17/04/14 13:45, Laurent Pinchart wrote:
> > Hi Sylwester,
> >
> > On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
> >> On 11/03/14 00:15, Laurent Pinchart wrote:
> >>> Add support for the hsync-active, vsync-active and
On 17/04/14 13:45, Laurent Pinchart wrote:
Hi Sylwester,
On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Sig
Hi Sylwester,
On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
> On 11/03/14 00:15, Laurent Pinchart wrote:
> > Add support for the hsync-active, vsync-active and pclk-sample
> > properties to the DT bindings and control BT.656 mode implicitly.
> >
> > Signed-off-by: Laurent Pinchart
Hi Sylwester,
Thank you for the review.
On Thursday 17 April 2014 12:59:22 Sylwester Nawrocki wrote:
> On 11/03/14 00:15, Laurent Pinchart wrote:
> > Parse the device tree node to populate platform data.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > ---
> >
> >
Currently stk1160_read_reg() uses a stack-allocated char to get the
read control value. This is wrong because usb_control_msg() requires
a kmalloc-ed buffer.
This commit fixes such issue by kmalloc'ating a 1-byte buffer to receive
the read value.
While here, let's remove the urb_buf array which w
On 11/03/14 00:15, Laurent Pinchart wrote:
> Add an inv_llc_pol field to platform data to control the clock polarity.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Sylwester Nawrocki
> ---
> drivers/media/i2c/adv7604.c | 3 ++-
> include/media/adv7604.h | 1 +
> 2 files changed, 3 inse
Hi Laurent,
On 11/03/14 00:15, Laurent Pinchart wrote:
> Add support for the hsync-active, vsync-active and pclk-sample
> properties to the DT bindings and control BT.656 mode implicitly.
>
> Signed-off-by: Laurent Pinchart
> ---
> .../devicetree/bindings/media/i2c/adv7604.txt | 13 +++
Hi Laurent.
On 11/03/14 00:15, Laurent Pinchart wrote:
> Parse the device tree node to populate platform data.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Laurent Pinchart
> ---
> .../devicetree/bindings/media/i2c/adv7604.txt | 56 +
> drivers/media/i2c/adv7604.c
From: Hans Verkuil
This solves this bug:
https://bugzilla.kernel.org/show_bug.cgi?id=73361
The problem is that when you quit tvtime it calls STREAMOFF, but then it queues
a
bunch of buffers for no good reason before closing the file descriptor.
In the past closing the fd would free the vb que
From: Hans Verkuil
Create consistent _vbq suffix for videobuf_queue fields.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 12 ++--
drivers/media/pci/saa7134/saa7134-video.c | 2 +-
drivers/media/pci/saa7134/saa7134.h | 2 +-
3 files changed,
From: Hans Verkuil
Don't calculate this for every buffer, store it globally instead.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-vbi.c | 38 +++--
drivers/media/pci/saa7134/saa7134.h | 1 +
2 files changed, 18 insertions(+), 21 deletions(-
From: Hans Verkuil
This will make the next patch a bit easier to read.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/media/pci/saa7134/saa7134-empress.c
b/drive
From: Hans Verkuil
Use consistent _vbq suffix for videobuf_queue fields.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c | 52 +++
drivers/media/pci/saa7134/saa7134.h | 4 +--
2 files changed, 28 insertions(+), 28 deletions(-)
diff
From: Hans Verkuil
Just white space changes to reduce the noise in the following patches.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-alsa.c| 13
drivers/media/pci/saa7134/saa7134-core.c| 47 -
drivers/media/pci/saa7134/saa7134
From: Hans Verkuil
All dmaqueue's use saa7134_pgtable, so move it into struct saa7134_dmaqueue.
The videobuf_queue priv_data field now points to the dmaqueue struct.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-dvb.c | 2 +-
drivers/media/pci/saa7134/saa7134-empress.c
From: Hans Verkuil
saa7134-alsa used low-level videobuf functions to allocate and sync
DMA buffers. Replace this with saa7134-specific code. These functions
will not be available when we convert to vb2.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-alsa.c | 95 +
From: Hans Verkuil
This is already available from saa7134_dev.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-core.c | 3 +--
drivers/media/pci/saa7134/saa7134-video.c | 24 +++-
drivers/media/pci/saa7134/saa7134.h | 1 -
3 files changed, 12 inse
This patch series splits up the previous version into smaller
pieces. The previous version is found here:
http://www.spinics.net/lists/linux-media/msg74171.html
Changes since v1:
- Split up the code in smaller parts where possible. The actual conversion
is still a lot of code.
- Added the regr
From: Hans Verkuil
If the saa7134 module is loaded with the saa7134_userptr set to 1,
then USERPTR support is enabled. A check in buffer_prepare
verifies that the pointer is page-aligned.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-core.c | 4
drivers/media/pci/saa
On 04/16/2014 09:34 PM, Nicolas Dufresne wrote:
>
> Previously we where updating the buffer state using __fill_v4l2_buffer
> before the state transition was completed through __vb2_dqbuf. This
> would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still
> queued. The spec says the dqb
On 04/17/2014 11:18 AM, Steve Cookson wrote:
>
> On 16/04/14 19:15, Steve Cookson wrote:
>> For no good reason AFAICT the initial resolution is set to 320x240. But
>>> you can just set it to 640x480 (or more likely, 720x480 for NTSC or
>>> 720x576 for PAL):
>>>
>>> v4l2-ctl -v width=640,height=480
1 - 100 of 111 matches
Mail list logo
