Re: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

Hi John Sheu, Thanks for the patch. Please find the review comments inline. On Wed, Mar 12, 2014 at 4:22 AM, John Sheu wrote: > Explicitly specify sampling period for subsampled chroma formats, so > stride and image size are properly reported through VIDIOC_{S,G}_FMT. > > Signed-off-by: John She

Re: [PATCH v12][ 07/12] drm: drm_display_mode: add signal polarity flags

Hi Denis, On 04/07/2014 02:44 PM, Denis Carikli wrote: > We need a way to pass signal polarity informations > between DRM panels, and the display drivers. > > To do that, a pol_flags field was added to drm_display_mode. > > Signed-off-by: Denis Carikli > --- > ChangeLog v11->v12: > - Rebased:

RE: [RFC] Fix interrupted recording with Hauppauge HD-PVR

Thanks Hans for getting back to me. I've been trying out your patch and I found the device wasn't actually restarting the streaming/recording properly after a channel change. I changed "msecs_to_jiffies(500))" to "msecs_to_jiffies(1000))" and had the same issue, but "msecs_to_jiffies(2000))" see

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Apr 8 04:05:59 CEST 2014 git branch: test git hash: a83b93a7480441a47856dc9104bea970e84cda87 gcc versi

LOANS

Do you need a loan at 2% with fast approval?If interested Email us:via paydayloan...@yahoo.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

Hi Shaik, Sungchun, Exynos-gsc has no maintainers mentioned in the MAINTAINERS file. I see your activity in the development of this driver. Do you have any comments on this patch? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: John Sheu [mailto:s

Re: [PATCH] [media] stk1160: warrant a NUL terminated string

On Apr 07, Mauro Carvalho Chehab wrote: > strncpy() doesn't warrant a NUL terminated string. Use > strlcpy() instead. > > Fixes Coverity bug CID#1195195. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/usb/stk1160/stk1160-ac97.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

RE: [GIT PULL for 3.15 fixes] VPE fixes

Hi Archit, Thank you for separating the fix patches. I am waiting for 3.15-rc1 to be released. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Archit Taneja [mailto:arc...@ti.com] > Sent: Monday, April 07, 2014 11:31 AM > To: Kamil Debski > Cc: li

RE: [PATCH 4/4] v4l2-mem2mem: allow reqbufs(0) with "in use" MMAP buffers

Pawel, Marek, Before taking this to my tree I wanted to get an ACK from one of the videobuf2 maintainers. Could you spare a moment to look through this patch? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: John Sheu [mailto:s...@google.com] > Sen

Re: [RFC] Fix interrupted recording with Hauppauge HD-PVR

Hi Ryley, Thank you for the patch. Your analysis seems sound. The patch is actually not bad for a first attempt, but I did it a bit differently. Can you test my patch? Regards, Hans Signed-off-by: Hans Verkuil diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hd

[PATCH] [media] gpsca: remove the risk of a division by zero

As reported by Coverity, there's a potential risk of a division by zero on some calls to jpeg_set_qual(), if quality is zero. As quality can't be 0 or lower than that, adds an extra clause to cover this special case. Coverity reports: CID#11922280, CID#11922293, CID#11922295 Signed-off-by: Mauro

Re: [PATCH] [media] stk1160: warrant a NUL terminated string

On 04/07/2014 03:42 PM, Mauro Carvalho Chehab wrote: > strncpy() doesn't warrant a NUL terminated string. Use > strlcpy() instead. > > Fixes Coverity bug CID#1195195. > > Signed-off-by: Mauro Carvalho Chehab My good deed for the day: Acked-by: Hans Verkuil Regards, Hans > --- > dr

[PATCH] [media] stk1160: warrant a NUL terminated string

strncpy() doesn't warrant a NUL terminated string. Use strlcpy() instead. Fixes Coverity bug CID#1195195. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/stk1160/stk1160-ac97.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/stk1160/stk1160-ac97.

[PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression

Prevent decompression of a JPEG 4:2:0 with odd width to the YUV 4:2:0 compliant formats for Exynos4x12 SoCs and adjust capture format to RGB565 in such a case. This is required because the configuration would produce a raw image with broken luma component. Signed-off-by: Jacek Anaszewski Signed-o

[PATCH 8/8] [media] s5p_jpeg: Fix NV12 format entry related to S5C2120 SoC

S5PC210 SoC doesn't support encoding NV12 raw images. Remove the relavant flag from the respective entry in the sjpeg_formats array. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PATCH 6/8] [media] s5p-jpeg: Fix sysmmu page fault

This patch fixes jpeg sysmmu page fault on Exynos4x12 SoCs. During encoding Exynos4x12 SoCs access wider memory area than it results from Image_x and Image_y values written to the JPEG_IMAGE_SIZE register. In order to avoid sysmmu page fault apply proper output buffer size alignment. Signed-off-by

[PATCH 4/8] [media] s5p-jpeg: Fix build break when CONFIG_OF is undefined

This patch fixes build break occurring when there is no support for Device Tree turned on in the kernel configuration. In such a case only the driver variant for S5PC210 SoC will be available. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-

[PATCH 5/8] [media] s5p-jpeg: g_selection callback should always succeed

Remove erroneous guard preventing successful execution of g_selection callback in case the driver variant is different from SJPEG_S5P. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(+), 2 delet

[PATCH 3/8] [media] s5p-jpeg: Add m2m_ops field to the s5p_jpeg_variant structure

Simplify the code by adding m2m_ops field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_probe function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 drivers/media/platfo

[PATCH 2/8] [media] s5p-jpeg: Perform fourcc downgrade only for Exynos4x12 SoCs

Change the driver variant check from "is not S5PC210" to "is Exynos4" while checking whether YUV format needs to be downgraded in order to prevent upsampling which is not supported by Exynos4 SoCs family. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5

[PATCH 1/8] [media] s5p-jpeg: Add fmt_ver_flag field to the s5p_jpeg_variant structure

Simplify the code by adding fmt_ver_flag field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_find_format function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 --- drivers/me

[REVIEWv2 PATCH 01/13] vb2: stop_streaming should return void

From: Hans Verkuil The vb2 core ignores any return code from the stop_streaming op. And there really isn't anything it can do anyway in case of an error. So change the return type to void and update any drivers that implement it. The int return gave drivers the idea that this operation could act

[REVIEWv2 PATCH 13/13] DocBook media: update bytesused field description

From: Hans Verkuil For output buffers the application has to set the bytesused field. In reality applications often do not set this since drivers that deal with fix image sizes just override it anyway. The vb2 framework will replace this field with the length field if bytesused was set to 0 by t

[REVIEWv2 PATCH 05/13] vb2: move __qbuf_mmap before __qbuf_userptr

From: Hans Verkuil __qbuf_mmap was sort of hidden in between the much larger __qbuf_userptr and __qbuf_dmabuf functions. Move it before __qbuf_userptr which is also conform the usual order these memory models are implemented: first mmap, then userptr, then dmabuf. Signed-off-by: Hans Verkuil Ac

[REVIEWv2 PATCH 08/13] vb2: simplify a confusing condition.

From: Hans Verkuil q->start_streaming_called is always true, so the WARN_ON check against it being false can be dropped. Signed-off-by: Hans Verkuil Acked-by: Pawel Osciak --- drivers/media/v4l2-core/videobuf2-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[REVIEWv2 PATCH 12/13] vb2: start messages with a lower-case for consistency.

From: Hans Verkuil The kernel debug messages produced by vb2 started either with a lower or an upper case character. Switched all to use lower-case which seemed to be what was used in the majority of the messages. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 58 ++

[REVIEWv2 PATCH 03/13] vb2: if bytesused is 0, then fill with output buffer length

From: Hans Verkuil The application should really always fill in bytesused for output buffers, unfortunately the vb2 framework never checked for that. So for single planar formats replace a bytesused of 0 by the length of the buffer, and for multiplanar format do the same if bytesused is 0 for AL

[REVIEWv2 PATCH 10/13] vb2: set v4l2_buffer.bytesused to 0 for mp buffers

From: Hans Verkuil The bytesused field of struct v4l2_buffer is not used for multiplanar formats, so just zero it to prevent it from having some random value. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/me

[REVIEWv2 PATCH 09/13] vb2: add vb2_fileio_is_active and check it more often

From: Hans Verkuil Added a vb2_fileio_is_active inline function that returns true if fileio is in progress. Check for this too in mmap() (you don't want apps mmap()ing buffers used by fileio) and expbuf() (same reason). In addition drivers should be able to check for this in queue_setup() to ret

[REVIEWv2 PATCH 06/13] vb2: set timestamp when using write()

From: Hans Verkuil When using write() to write data to an output video node the vb2 core should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody else is able to provide this information with the write() operation. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-c

[REVIEWv2 PATCH 07/13] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

From: Hans Verkuil This is not allowed by the spec and does in fact not make any sense. Return -EINVAL if this is the case. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/media/v4l2-core/videob

[REVIEWv2 PATCH 11/13] vb2: allow read/write as long as the format is single planar

From: Hans Verkuil It was impossible to read() or write() a frame if the queue type was multiplanar. Even if the current format is single planar. Change this to just check whether the number of planes is 1 or more. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 21

[REVIEWv2 PATCH 00/13] vb2: various small fixes/improvements

This is the second version of this review patch series. The first can be found here: http://www.spinics.net/lists/linux-media/msg74220.html Changes since v2: - Rebased to latest master branch - Incorporated all suggestions/remarks from Pawel (patches 2, 4 and 7) - Added patch 12 (follow-up of pa

[REVIEWv2 PATCH 04/13] vb2: use correct prefix

From: Hans Verkuil Many dprintk's in vb2 use a hardcoded prefix with the function name. In many cases that is now outdated. To keep things consistent the dprintk macro has been changed to print the function name in addition to the "vb2:" prefix. Superfluous prefixes elsewhere in the code have bee

[REVIEWv2 PATCH 02/13] vb2: fix handling of data_offset and v4l2_plane.reserved[]

From: Hans Verkuil The videobuf2-core did not zero the 'planes' array in __qbuf_userptr() and __qbuf_dmabuf(). That's now memset to 0. Without this the reserved array in struct v4l2_plane would be non-zero, causing v4l2-compliance errors. More serious is the fact that data_offset was not handled

Re: videobuf2-vmalloc suspect for corrupted data

On 04/07/2014 01:20 PM, Divneil Wadhawan wrote: > Hi Hans, >> Two more questions: >> >> Which kernel version are you using? > 3.4.58 That should be new enough, I see no important differences between 3.4 and 3.14 in this respect. But really, 3.4? That's over two years old! If you have control over

[PATCH v12][ 12/12] ARM: imx_v6_v7_defconfig: Add more drm drivers.

The DRM_PANEL_SIMPLE is needed by the eukrea mbimxsd51's displays. Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - New patch, splitting it would be overkill. --- arch/arm/configs/imx_v6_v7_defconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defcon

[PATCH v12][ 10/12] ARM: dts: mbimx51sd: Add display support.

The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Signed-off-by: Denis Carikli --- ChangeLog v10->v11: - Now uses the drm-panel instead of the display-timings. This is to get regulator support, which is lacking in the imx-drm driver when using the display-timings. ChangeLog v9->v10: - Rebased -

[PATCH v12][ 11/12] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.

Signed-off-by: Denis Carikli --- ChangeLog v9->v11: - Now uses the drm-panel instead of the display-timings. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - The backlight is now on at boot. ChangeLog v6->v7: - Shrinked even more the Cc list. ChangeLog v5->v6:

[PATCH v12][ 09/12] drm/panel: Add Eukrea mbimxsd51 displays.

Signed-off-by: Denis Carikli --- ChangeLog v11->v12: - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names ChangeLog v10->v11: - New patch. --- .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt |7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt |7 ++ .../bindin

[PATCH v12][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.

The imx-drm driver can't use the de-active and pixelclk-active display-timings properties yet. Instead the data-enable and the pixel data clock polarity are hardcoded in the imx-drm driver. So theses properties are now set to keep the same behaviour when imx-drm will start using them. Signed-off

[PATCH v12][ 04/12] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch that is now needed by the "staging: imx-drm: Use de-active and pixelclk-active" patch. --

[PATCH v12][ 08/12] imx-drm: Use drm_display_mode timings flags.

The previous hardware behaviour was kept if the flags are not set. Signed-off-by: Denis Carikli --- ChangeLog v11->v12: - Rebased: It now uses the following new flags defines names: CLK_POL, ENABLE_POL - The inversions in ipuv3-crtc.c are now fixed. - ipuv3-crtc.c was still using mode->private_

[PATCH v12][ 07/12] drm: drm_display_mode: add signal polarity flags

We need a way to pass signal polarity informations between DRM panels, and the display drivers. To do that, a pol_flags field was added to drm_display_mode. Signed-off-by: Denis Carikli --- ChangeLog v11->v12: - Rebased: This patch now applies against drm_modes.h - Rebased: It now uses the new

[PATCH v12][ 05/12] imx-drm: use defines for clock polarity settings

Signed-off-by: Denis Carikli --- ChangeLog 11->v12: - Improved the define names to match the hardware: ENABLE_POL is not a clock signal but instead an enable signal. ChangeLog v9->v10: - New patch which was splitted out from: "staging: imx-drm: Use de-active and pixelclk-active display-timing

[PATCH v12][ 03/12] imx-drm: Correct BGR666 and the board's dts that use them.

The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased. - Added Philipp Zabel's Ack. - Included Lothar Waßmann's suggestion about imx-l

[PATCH v12][ 02/12] imx-drm: Add RGB666 support for parallel display.

Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v8->v9: - Rebased. - Added Philipp Zabel's ack. - Shortened the patch title. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - Rebased. ChangeLog v7->v8: - Shrinked even more the Cc list. Change

[PATCH v12][ 01/12] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Signed-off-by: Denis Carikli Acked-by: Mauro Carvalho Chehab Acked-by: Laurent Pinchart Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased on top of: "211e7f2 [media]

Re: [REVIEW PATCH 02/11] vb2: fix handling of data_offset and v4l2_plane.reserved[]

On 04/07/2014 07:11 AM, Pawel Osciak wrote: > On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The videobuf2-core did not zero the reserved array of v4l2_plane as it >> should. >> >> More serious is the fact that data_offset was not handled correctly: >> >> - for c

RE: videobuf2-vmalloc suspect for corrupted data

>> Which capture driver are you using? > It's a TSMUX driver, written locally. In complete, it's a Multi-INPUT, single output (MUXER) driver, but, currently, it's the capture side fault here. Regards, Divneil -- To unsubscribe from this list: send the line

RE: videobuf2-vmalloc suspect for corrupted data

Hi Hans, > Two more questions: > > Which kernel version are you using? 3.4.58 > Which capture driver are you using? It's a TSMUX driver, written locally. Regards, Divneil -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the bod

Re: videobuf2-vmalloc suspect for corrupted data

On 04/07/2014 12:49 PM, Divneil Wadhawan wrote: > Hi Pawel, > > Thanks for the quick response. > >> Is it possible that your userspace is not always queuing the same >> userptr memory areas with the same v4l2_buffer index values? > No, userptr is always consistent with the index. > In fact, when

RE: videobuf2-vmalloc suspect for corrupted data

Hi Pawel, Thanks for the quick response. > Is it possible that your userspace is not always queuing the same > userptr memory areas with the same v4l2_buffer index values? No, userptr is always consistent with the index. In fact, when we dump the captured buffer (Transport Stream) in this case,

Re: videobuf2-vmalloc suspect for corrupted data

Hi Divneil, On Mon, Apr 7, 2014 at 6:56 PM, Divneil Wadhawan wrote: > Hi, > > I have a V4L2 capture driver accepting a malloc'ed buffer. > The driver is using vb2_vmalloc_memops > (../drivers/media/v4l2-core/videobuf2-vmalloc.c) for user-space to kvaddr > translation. > Randomly, corrupted data

videobuf2-vmalloc suspect for corrupted data

Hi, I have a V4L2 capture driver accepting a malloc'ed buffer. The driver is using vb2_vmalloc_memops (../drivers/media/v4l2-core/videobuf2-vmalloc.c) for user-space to kvaddr translation. Randomly, corrupted data is received by user-app. So, the question is regarding the handling of get_userp

[GIT PULL for 3.15 fixes] VPE fixes

Hi Kamil, Since the VPE m2m patch set couldn't make it on time, I've separated out the fixes from the series so that they can be taken in one of the 3.15-rc series. Thanks, Archit The following changes since commit a83b93a7480441a47856dc9104bea970e84cda87: [media] em28xx-dvb: fix PCTV 461

Re: [REVIEW PATCH 06/11] vb2: set timestamp when using write()

On 04/07/2014 10:32 AM, Pawel Osciak wrote: > On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> When using write() to write data to an output video node the vb2 core >> should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody > > I'm confused. Shouldn't

Re: [REVIEW PATCH 08/11] vb2: simplify a confusing condition.

On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkuil > > q->start_streaming_called is always true, so the WARN_ON check against > it being false can be dropped. > > Signed-off-by: Hans Verkuil Acked-by: Pawel Osciak > --- > drivers/media/v4l2-core/videobuf2-core.c | 5 ++

Re: [REVIEW PATCH 07/11] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkuil > > This is not allowed by the spec and does in fact not make any sense. > Return -EINVAL if this is the case. > > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/videobuf2-core.c | 9 + > 1 file chang

Re: [REVIEW PATCH 06/11] vb2: set timestamp when using write()

On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkuil > > When using write() to write data to an output video node the vb2 core > should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody I'm confused. Shouldn't we be saving the existing timestamp from the buffer i

Re: [REVIEW PATCH 05/11] vb2: move __qbuf_mmap before __qbuf_userptr

On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkuil > > __qbuf_mmap was sort of hidden in between the much larger __qbuf_userptr > and __qbuf_dmabuf functions. Move it before __qbuf_userptr which is > also conform the usual order these memory models are implemented: first >

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

On Mon, Apr 7, 2014 at 4:39 PM, Hans Verkuil wrote: > On 04/07/2014 09:20 AM, Pawel Osciak wrote: >> I'm thinking, that if we are doing this, perhaps we should just update >> the API to allow this case, i.e. say that if the bytesused is not set > > With 'not set' you mean 'is 0', right? Yes, corr

Re: [REVIEW PATCH 04/11] vb2: use correct prefix

On 04/07/2014 09:30 AM, Pawel Osciak wrote: > The idea behind not using __func__ was that it was much more > informative when debugging to see a "reqbufs" prefix instead of, for > example "__verify_memory_type". But since some of the functions are > shared across multiple ioctl impls now (e.g. __ve

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

On 04/07/2014 09:20 AM, Pawel Osciak wrote: > I'm thinking, that if we are doing this, perhaps we should just update > the API to allow this case, i.e. say that if the bytesused is not set With 'not set' you mean 'is 0', right? > for any planes, length will be used by default? > This would be bac

Re: [REVIEW PATCH 04/11] vb2: use correct prefix

The idea behind not using __func__ was that it was much more informative when debugging to see a "reqbufs" prefix instead of, for example "__verify_memory_type". But since some of the functions are shared across multiple ioctl impls now (e.g. __verify_memory_type is used by both reqbufs and createb

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

I'm thinking, that if we are doing this, perhaps we should just update the API to allow this case, i.e. say that if the bytesused is not set for any planes, length will be used by default? This would be backwards-compatible. On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil wrote: > From: Hans Verkui