Re: Writing a HDMI-CEC device driver for the IT66121

2014-04-01 Thread Hans Verkuil
On 04/01/2014 08:55 PM, Sriakhil Gogineni wrote: > Hi Hans, > > Thanks for the detailed response. As, much as I would love to have a > robust, fully functioning implementation for v1, I think it might be > a a bit of 'over-optimization' to write the complete spec into the > driver from the beginni

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-04-01 Thread Olivier Langlois
Hi Laurent, On Tue, 2014-04-01 at 15:49 +0200, Laurent Pinchart wrote: > Hi Olivier, > > On Sunday 30 March 2014 00:23:01 Olivier Langlois wrote: > > Hi Laurent, > > > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets > > > > from ALSA device. > > > > > > OK. I suppo

cron job: media_tree daily build: OK

2014-04-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 2 04:00:27 CEST 2014 git branch: test git hash: a83b93a7480441a47856dc9104bea970e84cda87 gcc versi

Re: [yavta PATCH 7/9] Print timestamp type and source for dequeued buffers

2014-04-01 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. Given that the timestamp type and source are not supposed to change during streaming, do we really need to print them for every frame ? On Saturday 01 March 2014 18:18:08 Sakari Ailus wrote: > Signed-off-by: Sakari Ailus > --- > yavta.c | 52 +

Re: [yavta PATCH 0/9] Timestamp source and mem-to-mem device support

2014-04-01 Thread Laurent Pinchart
Hi Sakari, Thank you for the patches, and sorry for the late reply. I've pushed outstanding multiplane patches to the master branch of the yavta repository, and applied the first two patches of this series on top of that. After addressing the commends I've made on the individual patches, could

Re: [yavta PATCH 6/9] Timestamp source for output buffers

2014-04-01 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Saturday 01 March 2014 18:18:07 Sakari Ailus wrote: > Signed-off-by: Sakari Ailus > --- > yavta.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/yavta.c b/yavta.c > index a9b192a..71c1477 100644 > --- a/yavta

Re: [yavta PATCH 5/9] Allow passing file descriptors to yavta

2014-04-01 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Saturday 01 March 2014 18:18:06 Sakari Ailus wrote: > Signed-off-by: Sakari Ailus > --- > yavta.c | 63 > 1 file changed, 43 insertions(+), 20 deletions(-) > > diff --git a/yavta.c b/yavta.c >

Re: [yavta PATCH 3/9] Allow supporting mem2mem devices by adding forced OUTPUT device type

2014-04-01 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Saturday 01 March 2014 18:18:04 Sakari Ailus wrote: > The option is --output, or -o. Wouldn't it make sense to have an option to force the device type to a user- specified value instead of just an option for the output type ? "-o" is also usually used to s

Re: Writing a HDMI-CEC device driver for the IT66121

2014-04-01 Thread Sriakhil Gogineni
Hi Hans, Thanks for the detailed response. As, much as I would love to have a robust, fully functioning implementation for v1, I think it might be a a bit of 'over-optimization' to write the complete spec into the driver from the beginning. The question I ask myself is, "how can we get it mai

Re: [PATCH] [media] uvcvideo: Fix marking buffer erroneous in case of FID toggling

2014-04-01 Thread Laurent Pinchart
Hi Anton, On Saturday 29 March 2014 09:28:02 Anton Leontiev wrote: > 28.03.2014 20:12, Laurent Pinchart пишет: > + * Set error flag for incomplete buffer. > + */ > +static void uvc_buffer_check_bytesused(const struct uvc_streaming > *const stream, > > > > No need for the secon

Re: [PATCH RFC v2 2/6] drm/i2c: tda998x: Move tda998x to a couple encoder/connector

2014-04-01 Thread Laurent Pinchart
Hi Jean-François, Sorry for the late reply. On Thursday 27 March 2014 12:34:49 Jean-Francois Moine wrote: > On Wed, 26 Mar 2014 18:33:09 +0100 Laurent Pinchart wrote: > > That could work in your case, but I don't really like that. > > > > We need to describe the hardware topology, that might be

Re: em2750 usb camera log as mentioned in dmesg

2014-04-01 Thread Frank Schäfer
Am 28.03.2014 21:21, schrieb aaron.mo...@alsatis.net: > Hi, > > I have endless problems since upgarding to ubuntu12.04 with my usb > microscope and it's a big problem cos i need it for work. Which device are you talking about ? Which sensor does it use ? What does "endless problems" mean ? Which k

Re: sparse: ioctl defines and "error: bad integer constant expression"

2014-04-01 Thread Hans Verkuil
On 04/01/2014 06:48 PM, Christopher Li wrote: > On Mon, Mar 31, 2014 at 10:22 AM, Linus Torvalds > wrote: >> On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil wrote: >> >> Chris, can you please add this to the test cases since Hans did the >> work to create a nice small test-case? > > Sure, I want t

Re: sparse: ioctl defines and "error: bad integer constant expression"

2014-04-01 Thread Christopher Li
On Mon, Mar 31, 2014 at 10:22 AM, Linus Torvalds wrote: > On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil wrote: > > Chris, can you please add this to the test cases since Hans did the > work to create a nice small test-case? Sure, I want to add them to the test case. Hans, May I get a signed-off

Re: [PATCH 1/5] s5p-fimc: Changed RGB32 to BGR32

2014-04-01 Thread Nicolas Dufresne
Le mardi 01 avril 2014 à 16:34 +0200, Sylwester Nawrocki a écrit : > It should be "BGRA, 32 bpp", I can fix it when applying, if > you won't send next version of this patch until then. Good catch, I'll let you fix when applying. thanks, Nicolas signature.asc Description: This is a digitall

Re: [patch] [media] dvb-core: check ->msg_len for diseqc_send_master_cmd()

2014-04-01 Thread Dan Carpenter
Oops. I send this to Mauro's old email address. Sorry about that. regards, dan carpenter On Tue, Apr 01, 2014 at 05:38:07PM +0300, Dan Carpenter wrote: > I'd like to send this patch except that it "breaks" > cx24116_send_diseqc_msg(). The cx24116 driver accepts ->msg_len values > up to 24 but

Re: [PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Prabhakar Lad
Hi Hans, On Tue, Apr 1, 2014 at 8:12 PM, Hans Verkuil wrote: > On 04/01/14 16:26, Hans Verkuil wrote: >> >> >> On 04/01/14 16:06, Prabhakar Lad wrote: >>> Hi Hans, >>> >>> On Tue, Apr 1, 2014 at 7:20 PM, Hans Verkuil wrote: Hi Prabhakar, On 04/01/14 15:45, Lad, Prabhakar wrote: >>

Re: [PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Hans Verkuil
On 04/01/14 16:26, Hans Verkuil wrote: > > > On 04/01/14 16:06, Prabhakar Lad wrote: >> Hi Hans, >> >> On Tue, Apr 1, 2014 at 7:20 PM, Hans Verkuil wrote: >>> Hi Prabhakar, >>> >>> On 04/01/14 15:45, Lad, Prabhakar wrote: From: "Lad, Prabhakar" There was a conflict between the mm

[patch] [media] dvb-core: check ->msg_len for diseqc_send_master_cmd()

2014-04-01 Thread Dan Carpenter
I'd like to send this patch except that it "breaks" cx24116_send_diseqc_msg(). The cx24116 driver accepts ->msg_len values up to 24 but it looks like it's just copying 16 bytes past the end of the ->msg[] array so it's already broken. cmd->msg_len is an unsigned char. The comment next to the str

Re: [PATCH 1/5] s5p-fimc: Changed RGB32 to BGR32

2014-04-01 Thread Sylwester Nawrocki
On 25/03/14 21:55, Nicolas Dufresne wrote: > Testing showed that HW produces BGR32 rather then RGB32 as exposed > in the driver. The documentation seems to state the pixels are stored > in little endian order. > > Signed-off-by: Nicolas Dufresne > --- > drivers/media/platform/exynos4-is/fimc-cor

Re: [PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Hans Verkuil
On 04/01/14 16:06, Prabhakar Lad wrote: > Hi Hans, > > On Tue, Apr 1, 2014 at 7:20 PM, Hans Verkuil wrote: >> Hi Prabhakar, >> >> On 04/01/14 15:45, Lad, Prabhakar wrote: >>> From: "Lad, Prabhakar" >>> >>> There was a conflict between the mmap function pointer prototype of >>> struct v4l_fd an

Re: [PATCH] Fix _IOC_TYPECHECK sparse error

2014-04-01 Thread Josh Triplett
On Tue, Apr 01, 2014 at 09:04:12AM +0200, Hans Verkuil wrote: > When running sparse over drivers/media/v4l2-core/v4l2-ioctl.c I get these > errors: > > drivers/media/v4l2-core/v4l2-ioctl.c:2043:9: error: bad integer constant > expression > drivers/media/v4l2-core/v4l2-ioctl.c:2044:9: error: bad i

Re: [PATCH 0/5] s5p-fimc: Misc fixes

2014-04-01 Thread Sylwester Nawrocki
Hi Nicolas, On 01/04/14 16:13, Nicolas Dufresne wrote: > Any comment/input ? My apologies for the delay. The patches look good to me, I'm going to apply them to my tree for 3.16, as the media tree is already closed for 3.15. Thanks a lot for these fixes! > Le mardi 25 mars 2014 à 16:45 -0400, Ni

Re: [PATCH 0/5] s5p-fimc: Misc fixes

2014-04-01 Thread Nicolas Dufresne
Any comment/input ? Le mardi 25 mars 2014 à 16:45 -0400, Nicolas Dufresne a écrit : > This patch series fixes several bugs found in the s5p-fimc driver. These > bugs relate to bad parameters in the formats definition and short size > of image buffers. > > Nicolas Dufresne (5): > s5p-fimc: Reuse

Re: [PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Prabhakar Lad
Hi Hans, On Tue, Apr 1, 2014 at 7:20 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On 04/01/14 15:45, Lad, Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> There was a conflict between the mmap function pointer prototype of >> struct v4l_fd and the actual function used. Make sure it is in sync >>

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-04-01 Thread Laurent Pinchart
Hi Olivier, On Sunday 30 March 2014 00:23:01 Olivier Langlois wrote: > Hi Laurent, > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets > > > from ALSA device. > > > > OK. I suppose I shouldn't drop support for the realtime clock like I > > wanted to then :-) > > > >

Re: [PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Hans Verkuil
Hi Prabhakar, On 04/01/14 15:45, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > There was a conflict between the mmap function pointer prototype of > struct v4l_fd and the actual function used. Make sure it is in sync > with the prototype of v4l2_mmap. The prototype of v4l2_mmap uses int64_

[PATCH v3] saa7134: add vidioc_querystd

2014-04-01 Thread Mikhail Domrachev
Signed-off-by: Mikhail Domrachev --- drivers/media/pci/saa7134/saa7134-empress.c | 1 + drivers/media/pci/saa7134/saa7134-reg.h | 5 drivers/media/pci/saa7134/saa7134-video.c | 41 +++-- drivers/media/pci/saa7134/saa7134.h | 1 + 4 files changed, 46 i

[PATCH] v4l2-compliance: fix function pointer prototype

2014-04-01 Thread Lad, Prabhakar
From: "Lad, Prabhakar" There was a conflict between the mmap function pointer prototype of struct v4l_fd and the actual function used. Make sure it is in sync with the prototype of v4l2_mmap. This patch fixes following build error, v4l2-compliance.cpp: In function 'void v4l_fd_test_init(v4l_fd*

Re: [RFCv3,3/3] soc_camera: initial of code

2014-04-01 Thread Ben Dooks
On 01/04/14 07:39, Josh Wu wrote: Hi, Ben On 3/31/2014 6:10 PM, Ben Dooks wrote: On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the "mclk" registered in soc-camera driver cannot be find by the soc-camera sensors. See comment i

Re: [PATCH v3] vb2: Check if there are buffers before streamon

2014-04-01 Thread Andrzej Hajda
Hi, It seems the patch has been applied twice in linux-next/master: $ git log --oneline -25 linux-next/master drivers/media/v4l2-core/videobuf2-core.c 9cf3c31 [media] vb2: call buf_finish after the state check 3f1a9a3 [media] vb2: fix streamoff handling if streamon wasn't called e4d2581 [media] v

Re: Writing a HDMI-CEC device driver for the IT66121

2014-04-01 Thread Hans Verkuil
Hi Sri, On 03/31/14 23:12, Sriakhil Gogineni wrote: > Hi, > > I'm trying to write a HDMI-CEC driver for the Radxa Rock > (Specification - Radxa). I am coming from a software background and > have found libcec and am looking at other implementation. > > I'm wondering how to connect the hardware a

[PATCH] Fix _IOC_TYPECHECK sparse error

2014-04-01 Thread Hans Verkuil
When running sparse over drivers/media/v4l2-core/v4l2-ioctl.c I get these errors: drivers/media/v4l2-core/v4l2-ioctl.c:2043:9: error: bad integer constant expression drivers/media/v4l2-core/v4l2-ioctl.c:2044:9: error: bad integer constant expression drivers/media/v4l2-core/v4l2-ioctl.c:2045:9: e