cron job: media_tree daily build: OK

2014-03-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Mar 16 04:00:20 CET 2014 git branch: test git hash: ed97a6fe5308e5982d118a25f0697b791af5ec50 gcc versio

Re: [linuxtv-media:master 471/499] e4000.c:undefined reference to `v4l2_ctrl_handler_free'

2014-03-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Mar 2014 18:34:16 +0200 Antti Palosaari escreveu: > Mauro, > I am not sure how this should be resolved. E4000 has already depends to > VIDEO_V4L2. Should VIDEO_V4L2 selected in config MEDIA_SUBDRV_AUTOSELECT ? The problem is likely with the Kconfig at the dvb driver. You should remem

Re: [linuxtv-media:master 471/499] e4000.c:undefined reference to `v4l2_ctrl_handler_free'

2014-03-15 Thread Antti Palosaari
Mauro, I am not sure how this should be resolved. E4000 has already depends to VIDEO_V4L2. Should VIDEO_V4L2 selected in config MEDIA_SUBDRV_AUTOSELECT ? regards Antti On 15.03.2014 14:18, kbuild test robot wrote: tree: git://linuxtv.org/media_tree.git master head: ed97a6fe5308e5982d118a

[PATCH] [media] imon: Fix internal key table for 15c2:0034

2014-03-15 Thread Ulrich Eckhardt
The front panel of the Thermaltake DH102 is not working since the internal key table does not contain the correct definitions. Some of the key table entries required for this device are conflicting with existing ones. So I had to extend the code to allow to define a key table for each USB id.

Re: [RFC PATCH 1/3] dvbdev: add a dvb_dettach() macro

2014-03-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Mar 2014 14:47:20 +0100 Hans Verkuil escreveu: > Hi Mauro, > > On 03/15/2014 02:43 PM, Mauro Carvalho Chehab wrote: > > The dvb_attach() was unbalanced, as there was no dvb_dettach. Ok, > > on current cases, the dettach is done by dvbdev, but that are some > > future corner cases wher

Re: [RFC PATCH 1/3] dvbdev: add a dvb_dettach() macro

2014-03-15 Thread Hans Verkuil
Hi Mauro, On 03/15/2014 02:43 PM, Mauro Carvalho Chehab wrote: > The dvb_attach() was unbalanced, as there was no dvb_dettach. Ok, > on current cases, the dettach is done by dvbdev, but that are some > future corner cases where we may need to do this before registering > the frontend. > > So, add

[RFC PATCH 3/3] dib7000: export just one symbol

2014-03-15 Thread Mauro Carvalho Chehab
Exporting multiple symbols don't work as it causes compilation breakages, due to the way dvb_attach() works. This were reported several times, like: drivers/built-in.o: In function `cxusb_dualdig4_rev2_tuner_attach': >> cxusb.c:(.text+0x27d4b5): undefined reference to `dib7000p_get_i2c_master'

[RFC PATCH 2/3] dib7000p: rename dvb_attach to dvb_init

2014-03-15 Thread Mauro Carvalho Chehab
Well, what we call as "foo_attach" is the method that should be called by the dvb_attach() macro. It should be noticed that the name "dvb_attach" is really a bad name and don't express what it does. dvb_attach() basically does three things, if the frontend is compiled as a module: - It lookups fo

[RFC PATCH 0/3] Fix compilation breakages with dib7000p

2014-03-15 Thread Mauro Carvalho Chehab
Those patches are meant to fix a long-stanging compilation bug that happens when CONFIG_DVB_DIB7000P=m and one of the bridge drivers that use this frontend is compiled builtin (cxusb, cx23885-dvb and/or dib0700). Those bugs are due to the fact that those drivers use dvb_attach() but have m

[RFC PATCH 1/3] dvbdev: add a dvb_dettach() macro

2014-03-15 Thread Mauro Carvalho Chehab
The dvb_attach() was unbalanced, as there was no dvb_dettach. Ok, on current cases, the dettach is done by dvbdev, but that are some future corner cases where we may need to do this before registering the frontend. So, add a dvb_dettach() and use it at dvb_frontend.c. Signed-off-by: Mauro Carvalh

[REVIEW PATCH for v3.15 1/4] v4l2-subdev.h: fix sparse error with v4l2_subdev_notify

2014-03-15 Thread Hans Verkuil
From: Hans Verkuil The notify function is a void function, yet the v4l2_subdev_notify define uses it in a ? : construction, which causes sparse warnings. Signed-off-by: Hans Verkuil --- include/media/v4l2-subdev.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/incl

[REVIEW PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-15 Thread Hans Verkuil
From: Hans Verkuil Sparse generated a bunch of errors like this: drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in conditional expression (different base types) drivers/media/v4l2-core/videobuf2-core.c:136:17: error: incompatible types in conditional expression (di

[REVIEW PATCH for v3.15 0/4] v4l2 core sparse error/warning fixes

2014-03-15 Thread Hans Verkuil
These four patches fix sparse errors and warnings coming from the v4l2 core. There are more, but those seem to be problems with sparse itself (see my posts from today on that topic). Please take a good look at patch 3/4 in particular: that fixes sparse errors introduced by my vb2 changes, and requ

[REVIEW PATCH for v3.15 3/4] v4l2-common.h: remove __user annotation in struct v4l2_edid

2014-03-15 Thread Hans Verkuil
From: Hans Verkuil The edid array is copied to kernelspace by the v4l2 core, so drivers shouldn't see the __user annotation. This conforms to other structs like v4l2_ext_controls where the data pointed to is copied to from user to kernelspace. Signed-off-by: Hans Verkuil --- include/uapi/linux

[REVIEW PATCH for v3.15 4/4] v4l2-ioctl.c: fix sparse __user-related warnings

2014-03-15 Thread Hans Verkuil
From: Hans Verkuil Drop the use of __user in the user_ptr variable since the v4l2 structs are actually defined without __user, instead cast to a __user pointer only there where it is really needed: in the copy_to/from_user calls. Also remove unnecessary casts in check_array_args and replace a wr

Re: sparse and anonymous unions

2014-03-15 Thread Hans Verkuil
Just for the linux-media mailinglist: I'm patching include/uapi/linux/v4l2-dv-timings.h by adding ' || defined(__CHECKER__)' as described below during the sparse run of the daily build for now. This gets rid of all these errors until I know whether this should be a permanent patch or whether spa

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-15 Thread Hans Verkuil
For the record: all these tests were done with a 3.14-rc5 kernel and sparse compiled from the git tree as of today (version v0.5.0). The gcc version is 4.8.2. Regards, Hans On 03/15/2014 01:09 PM, Hans Verkuil wrote: > Hmm, interesting. Twice 'sparse' in the same subject line with diffe

sparse: ARRAY_SIZE and sparse array initialization

2014-03-15 Thread Hans Verkuil
Hmm, interesting. Twice 'sparse' in the same subject line with different meanings :-) This is another sparse error I get with drivers/media/v4l2-core/v4l2-ioctl.c: drivers/media/v4l2-core/v4l2-ioctl.c:424:9: error: cannot size expression (there are more of those in drivers/media, all with the s

sparse: ioctl defines and "error: bad integer constant expression"

2014-03-15 Thread Hans Verkuil
Hi! Here is another sparse error that I get when running sparse over drivers/media/v4l2-core/v4l2-ioctl.c: drivers/media/v4l2-core/v4l2-ioctl.c:2043:9: error: bad integer constant expression drivers/media/v4l2-core/v4l2-ioctl.c:2044:9: error: bad integer constant expression drivers/media/v4l2-c

sparse and anonymous unions

2014-03-15 Thread Hans Verkuil
Hi! I'm trying to cut down the list of sparse warnings and errors I get when compiling drivers/media. Most of them are obviously our problem, but there is one that seems to be a sparse bug: drivers/media/v4l2-core/v4l2-dv-timings.c:30:9: error: unknown field name in initializer This uses the v4

Re: [PATCH] gspca_gl860: Clean up idxdata structs

2014-03-15 Thread Hans de Goede
Hi, Some better commit msg would be nice, otherwise this patch is: Acked-by: Hans de Goede Hans Verkuil has mailed me that he would like to pick this up through his tree. Hans V. , I say go for it :) Regards, Hans On 03/14/2014 08:43 PM, Ismael Luceno wrote: Signed-off-by: Ismael Luceno

[PATCH] [media] Sensoray 2255 uses videobuf2

2014-03-15 Thread Arnd Bergmann
commit 340a30c514 "s2255drv: upgrade to videobuf2" changed the API used by the s2255 driver, but did not modify the Kconfig statement, which can lead to build errors when no other driver already uses VIDEOBUF2_VMALLOC. This patch does the necessary Kconfig change. Signed-off-by: Arnd Bergmann di