Hi Mauro,
This pull request is identical to the REVIEWv4 series:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg72474.html
except for being rebased to the latest master branch.
Take special note: the first three patches ("vb2: Check if there are buffers
before
streamon", "vb2: fix
On 03/06/2014 02:45 AM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patches.
>
> On Tuesday 04 March 2014 12:30:55 Hans Verkuil wrote:
>> Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev
>> APIs. However, that's in reality quite annoying since for simple vi
Hi Laurent,
Thank you for your comments!
On 03/06/2014 02:41 AM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patch.
>
> On Tuesday 04 March 2014 12:30:57 Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Support this ioctl as part of the v4l2 core. Use the new ioctl
>> name and stru
From: Pawel Osciak
Add a control to enable/disable IVF output stream format for VP8 encode.
Set the IVF format output to disabled as default.
Signed-off-by: Pawel Osciak
Signed-off-by: Arun Kumar K
---
Documentation/DocBook/media/v4l/controls.xml|8
drivers/media/platform/s5p
Hi Seung-Woo,
On 6 March 2014 10:25, Seung-Woo Kim wrote:
> This patch removes meaningless assignment of memory bank to itself.
>
> Signed-off-by: Seung-Woo Kim
> ---
Thanks for re-doing this.
Acked-by: Sachin Kamat
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the lin
This patch removes meaningless assignment of memory bank to itself.
Signed-off-by: Seung-Woo Kim
---
change from v2
- simplify description and change typo in subject
change from v1
- fixes subject and adds proper description
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 --
1 files ch
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote:
> Hi Joe,
>
> On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:
> > On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
> > > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define
> > > CONFIG_DEBUG'
Hello Sachin,
On 2014년 03월 06일 12:28, Sachin Kamat wrote:
> Hi Seung-Woo,
>
> On 6 March 2014 07:43, Seung-Woo Kim wrote:
>> Hello Sachin,
>>
>> On 2014년 03월 05일 20:42, Sachin Kamat wrote:
>>> On 5 March 2014 16:38, Seung-Woo Kim wrote:
>>
>> (...)
>>
- dev->bank1 = dev->bank1;
>>>
>
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Mar 6 04:00:20 CET 2014
git branch: test
git hash: bfd0306462fdbc5e0a8c6999aef9dde0f9745399
gcc versio
Hi Seung-Woo,
On 6 March 2014 07:43, Seung-Woo Kim wrote:
> Hello Sachin,
>
> On 2014년 03월 05일 20:42, Sachin Kamat wrote:
>> On 5 March 2014 16:38, Seung-Woo Kim wrote:
>
> (...)
>
>>> - dev->bank1 = dev->bank1;
>>
>> Are you sure this isn't some kind of typo? If not then your commit
>> de
On Thu, 2014-03-06 at 02:52 +0100, Laurent Pinchart wrote:
Hi again Laurent
> I've thought about that, but it would require iss.h to be included before all
> other headers. I've also thought about creating an iss-debug.h header to be
> included first just to #define DEBUG, but decided to go for
Hello Sachin,
On 2014년 03월 05일 20:42, Sachin Kamat wrote:
> On 5 March 2014 16:38, Seung-Woo Kim wrote:
(...)
>> - dev->bank1 = dev->bank1;
>
> Are you sure this isn't some kind of typo? If not then your commit
> description is too verbose
> to actually say that the code is redundant and
Hi Joe,
On Wednesday 05 March 2014 17:35:42 Joe Perches wrote:
> On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote:
> > On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
> > > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> > > > Would you recommend to drop driver-specifi
Hi Hans,
Thank you for the patches.
On Tuesday 04 March 2014 12:30:55 Hans Verkuil wrote:
> Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev
> APIs. However, that's in reality quite annoying since for simple video
> pipelines there is no need to create v4l-subdev device
Hi Hans,
Thank you for the patch.
On Tuesday 04 March 2014 12:30:57 Hans Verkuil wrote:
> From: Hans Verkuil
>
> Support this ioctl as part of the v4l2 core. Use the new ioctl
> name and struct v4l2_edid type in the existing core code.
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/v4
On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote:
> On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
> > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> > > Would you recommend to drop driver-specific Kconfig options related to
> > > debugging and use CONFIG_DYNAMIC_DEBU
Hi Joe,
On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
> On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> > Would you recommend to drop driver-specific Kconfig options related to
> > debugging and use CONFIG_DYNAMIC_DEBUG instead ?
>
> For development, sure, if there's suffici
On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> Would you recommend to drop driver-specific Kconfig options related to
> debugging and use CONFIG_DYNAMIC_DEBUG instead ?
For development, sure, if there's sufficient memory.
For embedded systems with limited memory, using
dynamic_debu
Hi Joe,
On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:
> On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
> > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define
> > CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any
> > effect.
>
> Not qu
On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
> Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define
> CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any effect.
Not quite. If CONFIG_DYNAMIC_DEBUG is set, these
dev_dbg statements are compile
Hi Antti,
On Wednesday 05 March 2014 20:12:15 Antti Seppälä wrote:
> After reviewing the series and porting my nuvoton changes to it I
> haven't noticed any errors worth mentioning.
> In fact I think this series is very well written and should be merged.
Thanks for reviewing!
> James, I hope you
Hi Mauro,
Thank you for the review.
On Wednesday 05 March 2014 17:10:06 Mauro Carvalho Chehab wrote:
> Em Tue, 11 Feb 2014 13:38:51 +0100 Laurent Pinchart escreveu:
> > On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote:
> > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
Antti,
Attached is a patch that fixed all but one v4l2-compliance error:
fail: v4l2-test-controls.cpp(295): returned control value out
of range
fail: v4l2-test-controls.cpp(357): invalid control 00a2090c
test VIDIOC_G/S_CTRL: FAIL
fail: v4l
Hi All
I've been attempting to use the Logitech C920 with the uvcvideo driver.
I set the controls with v4l2-ctl but some of them change during
VIDIOC_STREAMON. My understanding is that the values of controls should
be preserved.
Minimal test case:
#include
#include
#include
Hi Antti,
While adding sdr support for v4l2-compliance I noticed that the sdr field
of v4l2_format has type struct v4l2_format_sdr. Can you change that to
v4l2_sdr_format to be consistent with the others? (pix/vbi/sliced_vbi_format).
It's unexpected and it can still be changed.
Sorry I missed th
诚邀参加【2014 中国汽车零部件（全球）采供峰会】——
★ 亚洲顶级展馆，逾16万买家、逾1000家展商、3000多个展位
★ 汽车零部件行业年中盛宴，政府重点支持，企业积极参与
★ 全球汽车零部件一站式采购平台，中国汽车产业发展和国际交流合作的风向标
展会名称： 2014第12届中国（广州）国际汽车零部件及用品展览会
英文名称： The 12th China (Guangzhou) International Auto Parts Expo,2014
展会时间： 2014年6月09－11日
展会地点： 广州琶洲保利世贸博览馆 （中国广东省广州市海珠区新港东路100
Em Wed, 5 Mar 2014 14:27:46 -0300
Mauro Carvalho Chehab escreveu:
> Hi Fengguang,
>
> This patch got obsoleted by another patch in the same series.
>
> Unfortunately, I had to break sending the patch series into a few
> pushes, as my mailbomb script has a logic there that prevents it to
> send
Em Tue, 11 Feb 2014 13:38:51 +0100
Laurent Pinchart escreveu:
> Hi Paul,
>
> Thank you for the patch.
>
> On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote:
> > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
> > camera interface - Build system") added a Kconfig entry for
Hi Sakari,
Em Sun, 2 Mar 2014 17:40:24 +0200
Sakari Ailus escreveu:
> Hi Mauro,
>
> Here's a trivial fix for the DocBook build. Please pull.
>
> The following changes since commit a06b429df49bb50ec1e671123a45147a1d1a6186:
>
> [media] au0828: rework GPIO management for HVR-950q (2014-02-28 1
Signed-off-by: Laurent Pinchart
---
.../devicetree/bindings/media/renesas,vsp1.txt | 51 +
drivers/media/platform/vsp1/vsp1_drv.c | 52 ++
2 files changed, 95 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/binding
Hello,
This patch series extends the VSP1 driver with support for the Blend/ROP Units
as well as DT bindings. Please see individual patches for details.
The driver patches (1 to 4) and platform patches (5 to 6) can be merged
independently once the DT bindings will be approved.
The series has bee
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 39 +++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index b007f9e..315215f 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/
The Blend ROP Unit performs blending and ROP operations for up to four
sources.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/Makefile | 2 +-
drivers/media/platform/vsp1/vsp1.h| 2 +
drivers/media/platform/vsp1/vsp1_bru.c| 395 +
Signed-off-by: Laurent Pinchart
---
.../devicetree/bindings/media/renesas,vsp1.txt | 51 +
drivers/media/platform/vsp1/vsp1_drv.c | 52 ++
2 files changed, 95 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/binding
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7790.dtsi | 55 ++
1 file changed, 55 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 618e5b5..979636b 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++
Rework the route configuration code to support entities with multiple
sink pads.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_entity.c | 54 +++
drivers/media/platform/vsp1/vsp1_entity.h | 23 +++--
drivers/media/platform/vsp1/vsp1_hsit
Scaling of the alpha layer is disabled as both the RPF and WPF are
configured to hardcode the alpha value to 255. This results in a 0 alpha
value at the UDS output, making the image invisible when alpha blended
in the BRU. Fix it by enabling scaling of the alpha layer.
Signed-off-by: Laurent Pinch
On 1 March 2014 01:17, James Hogan wrote:
> These patches make some improvements relating to the recently added RC
> scancode filtering interface:
> - Patch 1 adds generic scancode filtering. This allows filtering to also
> work for raw rc drivers and scancode drivers without filtering
> capab
Hello,
Here's the second version of the patch set that make libmediactl usable by the
upcoming media device enumeration library. In order to do so I need to change
the libmediactl API and add support for emulated media devices.
In order to avoid further API/ABI breakages I've decided to make the
Signed-off-by: Laurent Pinchart
---
src/main.c | 94 ++---
src/mediactl-priv.h | 12 +++
src/mediactl.c | 38 --
src/mediactl.h | 78 +++-
4 files changed, 164 insert
Signed-off-by: Laurent Pinchart
---
src/main.c | 32 ---
src/mediactl-priv.h | 45 ++
src/mediactl.c | 29 +
src/mediactl.h | 62 +
src/v4l2su
Make the media_device refcounted to manage its life time.
Signed-off-by: Laurent Pinchart
---
src/main.c | 21 ---
src/mediactl.c | 172 -
src/mediactl.h | 84 +++-
3 files changed, 180 insertions(+), 97 de
Emulated media devices are backed by real hardware devices for the
functions they provide, but have no kernel media device counterpart.
Signed-off-by: Laurent Pinchart
---
src/mediactl.c | 85 +++---
src/mediactl.h | 52
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
---
src/mediactl-priv.h | 7 +++
src/mediactl.c | 32
src/mediactl.h | 19 +++
3 files changed, 58 insertions(+)
diff --git a/src/mediactl-priv.h b/src/mediactl-priv.h
index 37
Hi Fengguang,
This patch got obsoleted by another patch in the same series.
Unfortunately, I had to break sending the patch series into a few
pushes, as my mailbomb script has a logic there that prevents it to
send more than 30~50 emails (I never remember the exact setting).
So, I pushed this 80
Some previous patch introduced this bug:
/devel/v4l/patchwork/Documentation/DocBook/controls.xml:2262: parser error :
attributes construct error
^
/devel/v4l/patchwork/Documentation/DocBook/controls.xml:2262: parser error :
Couldn't find end of Start Tag ro
Check if index is within bounds _before_ accessing the value.
Signed-off-by: Ole Ernst
---
drivers/media/dvb-core/dvb_frontend.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_frontend.c
b/drivers/media/dvb-core/dvb_frontend.c
index 2d32c1
Hi Tomi,
Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen:
> Hi,
>
> On 05/03/14 11:20, Philipp Zabel wrote:
> > Hi,
> >
> > this version of the OF graph helper move series further addresses a few of
> > Tomi's and Sylwester's comments.
> >
> > Changes since v5:
> > - Fixed spel
We can't free struct em28xx while one of the extensions is still
using it.
So, add a kref() to control it, freeing it only after the
extensions fini calls.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-audio.c | 7 ++-
drivers/media/usb/em28xx/em28xx-cards.c | 31
Loan Application at a low rate of 0.5% send your Name,Amount,Phone and country
to standar...@56788.com
Note: $5,000.00 USD minimum and $100,000,000 Maximum.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordo
On 5 March 2014 16:38, Seung-Woo Kim wrote:
> There was assignment of memory bank with dma address converted
> from physical address. But allocation has been changed with dma
> function, so the assignment is not necessary.
>
> Signed-off-by: Seung-Woo Kim
> ---
> change from v1
> - fixes subject
Hi,
On 05/03/14 11:20, Philipp Zabel wrote:
> Hi,
>
> this version of the OF graph helper move series further addresses a few of
> Tomi's and Sylwester's comments.
>
> Changes since v5:
> - Fixed spelling errors and a wrong device node name in the link section
> - Added parentless previous end
This code is correct but the indenting is wrong and triggers a static
checker warning "add curly braces?".
Signed-off-by: Dan Carpenter
---
v2: in v1 I added curly braces.
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
b/drivers/media/usb/em28xx/em28xx-cards.c
index 4d97a76cc3b0..33f06ffe
There was assignment of memory bank with dma address converted
from physical address. But allocation has been changed with dma
function, so the assignment is not necessary.
Signed-off-by: Seung-Woo Kim
---
change from v1
- fixes subject and adds proper description
---
drivers/media/platform/s5p-
Hi Seung-Woo,
> From: Seung-Woo Kim [mailto:sw0312@samsung.com]
> Sent: Wednesday, March 05, 2014 11:08 AM
>
> Signed-off-by: Seung-Woo Kim
Thank you for your patch. I know that content of the patch is obvious, but
please provide a description of the patch.
Best wishes,
--
Kamil Debski
Sa
Signed-off-by: Seung-Woo Kim
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
index 2475a3c..ee05f2d 100644
--- a/drivers/media
On 04/03/14 17:47, Philipp Zabel wrote:
> Am Dienstag, den 04.03.2014, 14:21 +0200 schrieb Tomi Valkeinen:
>> On 04/03/14 13:36, Philipp Zabel wrote:
> [...]
Can port_node be NULL? Probably only if something is quite wrong, but
maybe it's safer to return error in that case.
>>>
>>> both o
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b78359a6894ac3451bec3fde5d0499fba87b8b67 [467/499] [media] drx-j: get
rid of the remaining drx generic functions
New smatch warnings:
The device tree graph bindings as used by V4L2 and documented in
Documentation/device-tree/bindings/media/video-interfaces.txt contain
generic parts that are not media specific but could be useful for any
subsystem with data flow between multiple devices. This document
describes the generic binding
This patch adds a new struct of_endpoint which is then embedded in struct
v4l2_of_endpoint and contains the endpoint properties that are not V4L2
(or even media) specific: the port number, endpoint id, local device tree
node and remote endpoint phandle. of_graph_parse_endpoint parses those
properti
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
Signed-off-by: Philipp Zabel
---
Changes since v5:
- Unrolled for-loop in of_graph_get_remote_port_parent
---
drivers/of/base.c | 42 +-
If of_graph_parse_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabel
---
drivers/of/base.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index ffd0217..75de6bd 100644
--- a/drivers/of/b
Hi,
this version of the OF graph helper move series further addresses a few of
Tomi's and Sylwester's comments.
Changes since v5:
- Fixed spelling errors and a wrong device node name in the link section
- Added parentless previous endpoint's full name to warning
- Fixed documentation comment f
If of_graph_get_next_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabel
---
Changes since v5:
- Added parentless previous endpoint's full name to warning
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(
A 'return endpoint;' at the end of the (!prev) case allows to
reduce the indentation level of the (prev) case.
Signed-off-by: Philipp Zabel
---
drivers/of/base.c | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/of/base.c b/d
This patch moves the parsing helpers used to parse connected graphs
in the device tree, like the video interface bindings documented in
Documentation/devicetree/bindings/media/video-interfaces.txt, from
drivers/media/v4l2-core/v4l2-of.c into drivers/of/base.c.
This allows to reuse the same parser
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
Signed-off-by: Philipp Zabel
---
Documentation/devicetree/bindings/graph.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/g
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b240eacdd536bac23c9d48dfc3d527ed6870ddad [463/499] [media] drx-j: get
rid of drx_driver.c
New smatch warnings:
drivers/media/dvb-front
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed 5 Mar 08:48:23 CET 2014
git branch: test
git hash: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
gcc versio
69 matches
Mail list logo
