Re: [RFCv2,2/2] i2c: add new dual Flash driver,LM3646

2014-01-27 Thread Hans Verkuil
On 01/28/2014 07:55 AM, Daniel Jeong wrote: > Add new dual flash driver. > LM3646 is a dual Flash LED Driver, LED1 and LED2, following the datasheet. > But there is no registers to contorl LED2 brightness. > LED2 brightness can be controlled by limiting max brightness. > LED2 brightness = Total b

Re: [RFCv2,1/2] v4l2-controls.h: add addtional Flash fault bits

2014-01-27 Thread Hans Verkuil
On 01/28/2014 07:55 AM, Daniel Jeong wrote: > Add additional FLASH Fault bits to dectect faults from chip. > Some Flash drivers support UVLO, IVFM, NTC Trip faults. > UVLO :Under Voltage Lock Out Threshold crossed > IVFM :IVFM block reported and/or adjusted LED current Input Voltage

[RFCv2,2/2] i2c: add new dual Flash driver,LM3646

2014-01-27 Thread Daniel Jeong
Add new dual flash driver. LM3646 is a dual Flash LED Driver, LED1 and LED2, following the datasheet. But there is no registers to contorl LED2 brightness. LED2 brightness can be controlled by limiting max brightness. LED2 brightness = Total brightness - LED1 brightness LED2 will be off if LED2 b

[RFCv2,1/2] v4l2-controls.h: add addtional Flash fault bits

2014-01-27 Thread Daniel Jeong
Add additional FLASH Fault bits to dectect faults from chip. Some Flash drivers support UVLO, IVFM, NTC Trip faults. UVLO : Under Voltage Lock Out Threshold crossed IVFM : IVFM block reported and/or adjusted LED current Input Voltage Flash Monitor trip threshold NTC : NTC Threshold crossed. Ma

cron job: media_tree daily build: WARNINGS

2014-01-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jan 28 04:00:26 CET 2014 git branch: test git hash: 587d1b06e07b4a079453c74ba9edf17d21931049 gcc versio

Re: Conexant PCI-8604PW 4 channel BNC Video capture card (bttv)

2014-01-27 Thread Daniel Glöckner
On Mon, Jan 27, 2014 at 08:55:00PM +, Robert Longbottom wrote: > >As for the CPLD, there is not much we can do. I count 23 GPIOs going > >to that chip. And we don't know if some of these are outputs of the > >CPLD, making it a bit risky to just randomly drive values on those > >pins. > > Is th

Re: [PATCH 1/3] e4000: convert DVB tuner to I2C driver model

2014-01-27 Thread Antti Palosaari
On 27.01.2014 19:45, Michael Krufky wrote: On Sun, Jan 26, 2014 at 7:39 PM, Antti Palosaari wrote: On 27.01.2014 02:28, Devin Heitmueller wrote: On Sun, Jan 26, 2014 at 7:16 PM, Antti Palosaari wrote: Driver conversion from proprietary DVB tuner model to more general I2C driver model. M

Re: [PATCH] uvc: update uvc_endpoint_max_bpi to handle USB_SPEED_WIRELESS devices

2014-01-27 Thread Laurent Pinchart
Hi Thomas, On Monday 27 January 2014 09:54:58 Thomas Pugliese wrote: > On Mon, 27 Jan 2014, Laurent Pinchart wrote: > > On Friday 24 January 2014 15:17:28 Thomas Pugliese wrote: > > > Isochronous endpoints on devices with speed == USB_SPEED_WIRELESS can > > > have a max packet size ranging from 1-

Re: Conexant PCI-8604PW 4 channel BNC Video capture card (bttv)

2014-01-27 Thread Robert Longbottom
On 27/01/14 03:20, Daniel Glöckner wrote: On Sun, Jan 26, 2014 at 04:23:06PM +, Robert Longbottom wrote: 000 00D7 DSTATUS 114 32734000 RISC_STRT_ADD 120 32734000 RISC_COUNT Video is present and locked but the RISC counter is stuck at the start address. My best guess is that the CPLD is

Re: [PATCH 1/3] e4000: convert DVB tuner to I2C driver model

2014-01-27 Thread Michael Krufky
On Sun, Jan 26, 2014 at 7:39 PM, Antti Palosaari wrote: > On 27.01.2014 02:28, Devin Heitmueller wrote: >> >> On Sun, Jan 26, 2014 at 7:16 PM, Antti Palosaari wrote: >>> >>> Driver conversion from proprietary DVB tuner model to more >>> general I2C driver model. >> >> >> Mike should definitely we

Re: [PATCH] uvc: update uvc_endpoint_max_bpi to handle USB_SPEED_WIRELESS devices

2014-01-27 Thread Thomas Pugliese
On Mon, 27 Jan 2014, Laurent Pinchart wrote: > Hi Thomas, > > Thank you for the patch. > > On Friday 24 January 2014 15:17:28 Thomas Pugliese wrote: > > Isochronous endpoints on devices with speed == USB_SPEED_WIRELESS can > > have a max packet size ranging from 1-3584 bytes. Add a case to >

[RFCv3 PATCH 05/22] videodev2.h: add struct v4l2_query_ext_ctrl and VIDIOC_QUERY_EXT_CTRL.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Add a new struct and ioctl to extend the amount of information you can get for a control. It gives back a unit string, the range is now a s64 type, and the matrix and element size can be reported through cols/rows/elem_size. Signed-off-by: Hans Verkuil --- include/uapi/linu

[RFCv3 PATCH 02/22] v4l2-ctrls: add unit string.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil The upcoming VIDIOC_QUERY_EXT_CTRL adds support for a unit string. This allows userspace to show the unit belonging to a particular control. This patch adds support for the unit string to the control framework. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki ---

[RFCv3 PATCH 22/22] v4l2-controls.txt: update to the new way of accessing controls.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil The way current and new values are accessed has changed. Update the document to bring it up to date with the code. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- Documentation/video4linux/v4l2-controls.txt | 46 +++-- 1 file changed,

[RFCv3 PATCH 10/22] v4l2-ctrls: compare values only once.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil When setting a control the control's new value is compared to the current value twice: once by new_to_cur(), once by cluster_changed(). Not a big deal when dealing with simple values, but it can be a problem when dealing with compound types or matrices. So fix this: cluster_cha

[RFCv3 PATCH 01/22] v4l2-ctrls: increase internal min/max/step/def to 64 bit

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil While VIDIOC_QUERYCTRL is limited to 32 bit min/max/step/def values for controls, the upcoming VIDIOC_QUERY_EXT_CTRL isn't. So increase the internal representation to 64 bits in preparation. Because of these changes the msi3101 driver has been modified slightly to fix a format

[RFCv3 PATCH 06/22] v4l2-ctrls: add support for complex types.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil This patch implements initial support for complex types. For the most part the changes are fairly obvious (basic support for is_ptr types, the type_is_int function is replaced by a is_int bitfield, and v4l2_query_ext_ctrl is added), but one change needs more explanation: The

[RFCv3 PATCH 11/22] v4l2-ctrls: prepare for matrix support: add cols & rows fields.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Add cols and rows fields to the core control structures in preparation for matrix support. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- drivers/media/v4l2-core/v4l2-ctrls.c | 26 +- include/media/v4l2-ctrls.h | 6 ++

[RFCv3 PATCH 00/22] Add support for complex controls

2014-01-27 Thread Hans Verkuil
This patch series adds support for complex controls (aka 'Properties') to the control framework. It is the first part of a larger patch series that adds support for configuration stores, motion detection matrix controls and support for 'Multiple Selections'. This patch series is based on this RFC:

[RFCv3 PATCH 20/22] DocBook media: fix coding style in the control example code

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Use the proper kernel coding style in these examples. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/controls.xml | 81 ++-- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/Documentation/DocBook/media/v4l/controls.xml

[RFCv3 PATCH 07/22] v4l2: integrate support for VIDIOC_QUERY_EXT_CTRL.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Add the v4l2 core plumbing for the new VIDIOC_QUERY_EXT_CTRL ioctl. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 + drivers/media/v4l2-core/v4l2-dev.c| 2 ++ drivers/media/v4l2-core/v4l2-ioct

[RFCv3 PATCH 13/22] v4l2-ctrls: use 'new' to access pointer controls

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Require that 'new' string and pointer values are accessed through the 'new' field instead of through the union. This reduces the union to just val and val64. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- drivers/media/radio/si4713/si4713.c|

[RFCv3 PATCH 03/22] v4l2-ctrls: use pr_info/cont instead of printk.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Codingstyle fix. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- drivers/media/v4l2-core/v4l2-ctrls.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-

[RFCv3 PATCH 08/22] v4l2-ctrls: create type_ops.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Since complex controls can have non-standard types we need to be able to do type-specific checks etc. In order to make that easy type operations are added. There are four operations: - equal: check if two values are equal - init: initialize a value - log: log the value - valid

[RFCv3 PATCH 15/22] v4l2-ctrls: type_ops can handle matrix elements.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Extend the control type operations to handle matrix elements. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 40 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c

[RFCv3 PATCH 12/22] v4l2-ctrls: replace cur by a union v4l2_ctrl_ptr.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Instead of having to maintain the 'cur' union this patch replaces it by a v4l2_ctrl_ptr union to be consistent with the future configuration stores, which also use that union. The number of drivers that use 'cur' is fairly small, so it is easy enough to convert them all. Unfor

[RFCv3 PATCH 21/22] DocBook media: update control section.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Document the support for complex types in controls. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- Documentation/DocBook/media/v4l/controls.xml | 104 --- 1 file changed, 78 insertions(+), 26 deletions(-) diff --git a/Documentation/

[RFCv3 PATCH 16/22] v4l2-ctrls: add matrix support.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Finish the userspace-facing matrix support. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 108 --- 1 file changed, 63 insertions(+), 45 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v

[RFCv3 PATCH 17/22] v4l2-ctrls: return elem_size instead of strlen

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil When getting a string and the size given by the application is too short return the max length the string can have (elem_size) instead of the string length + 1. That makes more sense. Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- drivers/media/v4l2-core/v4

[RFCv3 PATCH 19/22] DocBook media: update VIDIOC_G/S/TRY_EXT_CTRLS.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Document the support for the new complex type controls. Signed-off-by: Hans Verkuil --- .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 43 ++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-g-ext

[RFCv3 PATCH 04/22] videodev2.h: add initial support for complex controls.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Complex controls are controls that can be used for compound and array types. This allows for more complex data structures to be used with the control framework. Such controls always have the V4L2_CTRL_FLAG_HIDDEN flag set. Note that 'simple' controls can also set that flag. T

[RFCv3 PATCH 09/22] v4l2-ctrls: rewrite copy routines to operate on union v4l2_ctrl_ptr.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil In order to implement matrix support and (for the future) configuration stores we need to have more generic copy routines. The v4l2_ctrl_ptr union was designed for this. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 129 +++---

[RFCv3 PATCH 14/22] v4l2-ctrls: prepare for matrix support.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Add core support for matrices. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 54 +++- include/media/v4l2-ctrls.h | 8 -- 2 files changed, 39 insertions(+), 23 deletions(-) diff --git a/drivers/media/v4l

[RFCv3 PATCH 18/22] DocBook media: document VIDIOC_QUERY_EXT_CTRL.

2014-01-27 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki --- .../DocBook/media/v4l/vidioc-queryctrl.xml | 223 + 1 file changed, 189 insertions(+), 34 deletions(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-queryctrl.xml b/Documentat

Re: [PATCH] nuvoton-cir: Don't touch PS/2 interrupts while initializing

2014-01-27 Thread Jarod Wilson
On Sat, Jan 25, 2014 at 11:57:46AM +0200, Antti Seppälä wrote: > There are reports[1] that on some motherboards loading the nuvoton-cir > disables PS/2 keyboard input. This is caused by an erroneous write of > CIR_INTR_MOUSE_IRQ_BIT to ACPI control register. > > According to datasheet the write en

[PATCH 1/1] [media] radio-keene: Use module_usb_driver

2014-01-27 Thread Sachin Kamat
module_usb_driver eliminates the boilerplate and makes the code simpler. Signed-off-by: Sachin Kamat --- drivers/media/radio/radio-keene.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-keen