As Guennadi mentioned in his review, ENODATA will be replaced by ENOBUFS, which
is
more appropriate.
Prabhakar, Kamil, Tomasz, are you OK with this patch provided
s/ENODATA/ENOBUFS/ ?
Regards,
Hans
On 12/09/2013 02:43 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This works toget
On Mon, 9 Dec 2013, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This works together with the retry_start_streaming mechanism to allow
> userspace
> to start streaming even if not all required buffers have been queued.
>
> Signed-off-by: Hans Verkuil
> Cc: Lad, Prabhakar
> Cc: Tomasz Stanisl
On 12/10/2013 07:38 AM, Guennadi Liakhovetski wrote:
> Hi Hans
>
> On Mon, 9 Dec 2013, Hans Verkuil wrote:
>
>> From: Hans Verkuil
>>
>> If start_streaming returns -ENODATA, then it will be retried the next time
>> a buffer is queued.
>
> Wouldn't ENOBUFS be a better error code?
Actually, it w
Hi Hans
On Mon, 9 Dec 2013, Hans Verkuil wrote:
> From: Hans Verkuil
>
> If start_streaming returns -ENODATA, then it will be retried the next time
> a buffer is queued.
Wouldn't ENOBUFS be a better error code?
Thanks
Guennadi
> This means applications no longer need to know how many
> buffe
ATTENTION:
Monday 9th of December 2013 08:16:22 MYT from 41.206.151.183, your account
was recently accessed with this details, please if you recognize this
details,ignore this message, or use this web link to reconfirm your
account details to prevent spammers and unauthorized users to gain access
Hi Sachin,
On Tue, Dec 10, 2013 at 10:38 AM, Sachin Kamat wrote:
> Hi Arun,
>
> On 10 December 2013 10:15, Arun Kumar K wrote:
>> Hi Pawel,
>>
>> On Tue, Dec 10, 2013 at 6:21 AM, Pawel Osciak wrote:
>>> Hi Arun,
>>>
>
>>
>> Ok will make the change in next version.
>>
>
> While at it also update
Hi Arun,
On 10 December 2013 10:15, Arun Kumar K wrote:
> Hi Pawel,
>
> On Tue, Dec 10, 2013 at 6:21 AM, Pawel Osciak wrote:
>> Hi Arun,
>>
>
> Ok will make the change in next version.
>
While at it also update the patch subject appropriately.
--
With warm regards,
Sachin
--
To unsubscribe f
Hi Pawel,
On Tue, Dec 10, 2013 at 6:21 AM, Pawel Osciak wrote:
> Hi Arun,
>
> On Mon, Dec 9, 2013 at 10:16 PM, Arun Kumar K wrote:
>> Add v4l2 controls to set desired profile for VP8 encoder.
>> Acceptable levels for VP8 encoder are
>> 0: Version 0
>> 1: Version 1
>> 2: Version 2
>> 3: Version 3
Hi Hans,
Thanks for the review.
On Mon, Dec 9, 2013 at 6:52 PM, Hans Verkuil wrote:
> Hi Arun,
>
> Some comments below...
>
> On 12/09/2013 02:16 PM, Arun Kumar K wrote:
>> Add v4l2 controls to set desired profile for VP8 encoder.
>> Acceptable levels for VP8 encoder are
>> 0: Version 0
>> 1: Ve
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Dec 10 04:00:29 CET 2013
git branch: test
git hash: 356ba0213dca4dd68906bb315f8c7a46e81510ea
gcc versio
A missing break resulted in all done buffers being flagged with
V4L2_BUF_FLAG_QUEUED. Fix it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/omap3isp/ispqueue.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/omap3isp/ispqueue.c
b/drivers/media/platform/
ATTENTION:
Monday 9th of December 2013 08:16:22 MYT from 41.206.151.183, your account
was recently accessed with this details, please if you recognize this
details,ignore this message, or use this web link to reconfirm your
account details to prevent spammers and unauthorized users to gain access
Hi Arun,
On Mon, Dec 9, 2013 at 10:16 PM, Arun Kumar K wrote:
> Add v4l2 controls to set desired profile for VP8 encoder.
> Acceptable levels for VP8 encoder are
> 0: Version 0
> 1: Version 1
> 2: Version 2
> 3: Version 3
>
> Signed-off-by: Pawel Osciak
Sorry, but I'm not the author of this pat
On 21.11.2013 23:19, Antti Palosaari wrote:
On 21.11.2013 22:54, Mauro Carvalho Chehab wrote:
Em Thu, 21 Nov 2013 22:22:49 +0200
Antti Palosaari escreveu:
On 21.11.2013 21:12, Mauro Carvalho Chehab wrote:
Em Thu, 21 Nov 2013 20:33:15 +0200
Antti Palosaari escreveu:
On 21.11.2013 20:22, Ha
As value can be initialized with a value lower than zero, change it
to int, to avoid those warnings:
drivers/staging/media/bcm2048/radio-bcm2048.c: In function
'bcm2048_rds_pi_read':
drivers/staging/media/bcm2048/radio-bcm2048.c:1989:9: warning: comparison of
unsigned expression >= 0 is always t
Em Mon, 09 Dec 2013 17:17:41 +0100
Hans Verkuil escreveu:
> On 12/09/2013 04:51 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 6 Dec 2013 11:17:14 +0100
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Fix most checkpatch errors/warnings.
> >>
> >> It's mostly whitespace changes
On 12/09/2013 04:51 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Dec 2013 11:17:14 +0100
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> Fix most checkpatch errors/warnings.
>>
>> It's mostly whitespace changes, except for replacing msleep with
>> usleep_range and the jiffies comparison
On 12/09/2013 04:47 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Dec 2013 11:17:09 +0100
> Hans Verkuil escreveu:
>
>> From: Dinesh Ram
>>
>> This is the USB driver for the Silicon Labs development board.
>> It contains the Si4713 FM transmitter chip.
>>
>> Signed-off-by: Dinesh Ram
>> Signed-
Em Fri, 6 Dec 2013 11:17:03 +0100
Hans Verkuil escreveu:
> This is the second version of this patch series from Dinesh:
>
> http://www.spinics.net/lists/linux-media/msg68927.html
>
> It's identical to the first version except for two new patches: patch 10/11
> prints the product number of the
Em Fri, 6 Dec 2013 11:17:05 +0100
Hans Verkuil escreveu:
> From: Dinesh Ram
>
> Checks have been introduced at several places in the code to test if an
> interrupt is set or not. For devices which do not use the interrupt, to
> get a valid response, within a specified timeout, the device is po
Em Fri, 6 Dec 2013 11:17:14 +0100
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Fix most checkpatch errors/warnings.
>
> It's mostly whitespace changes, except for replacing msleep with
> usleep_range and the jiffies comparison with time_is_after_jiffies().
>
> Signed-off-by: Hans Verkuil
Em Fri, 6 Dec 2013 11:17:09 +0100
Hans Verkuil escreveu:
> From: Dinesh Ram
>
> This is the USB driver for the Silicon Labs development board.
> It contains the Si4713 FM transmitter chip.
>
> Signed-off-by: Dinesh Ram
> Signed-off-by: Hans Verkuil
> Tested-by: Eduardo Valentin
> Acked-by:
Em Sun, 8 Dec 2013 20:18:04 -0500
Michael Krufky escreveu:
> Mauro,
>
> What is the status of this pull request? Patchwork says "changes
> requested" but I have no record of any changes requested
>
> https://patchwork.linuxtv.org/patch/20728/
Thanks for pinging about that.
I can't rememb
From: Hans Verkuil
Two fixes:
- there is no need to set the index when calling dqbuf: dqbuf will
overwrite it.
- __vb2_init_fileio already starts streaming for write(), so there is
no need to do it again in __vb2_perform_fileio. It can never have
worked anyway: either __vb2_init_fileio suc
From: Hans Verkuil
If start_streaming returns -ENODATA, then it will be retried the next time
a buffer is queued. This means applications no longer need to know how many
buffers need to be queued before STREAMON can be called. This is particularly
useful for output stream I/O.
If a DMA engine ne
From: Hans Verkuil
The read/write implementation in vb2 reuses existing vb2 functions, but
it sets q->fileio to NULL before calling them in order to skip the
'q->fileio != NULL' check.
This works today due to the synchronous nature of read/write, but it
1) is ugly, and 2) will fail in an asynchr
From: Hans Verkuil
This works together with the retry_start_streaming mechanism to allow userspace
to start streaming even if not all required buffers have been queued.
Signed-off-by: Hans Verkuil
Cc: Lad, Prabhakar
Cc: Tomasz Stanislawski
Cc: Kyungmin Park
Cc: Kamil Debski
Cc: Guennadi Lia
From: Hans Verkuil
Rather than taking the mmap semaphore at a relatively high-level function,
push it down to the place where it is really needed.
It was placed in vb2_queue_or_prepare_buf() to prevent racing with other
vb2 calls. The only way I can see that a race can happen is when two
threads
From: Hans Verkuil
videobuf2 file I/O emulation assumed that buffers dequeued from the
driver would return in the order they were enqueued in the driver.
Improve the file I/O emulator's book-keeping to remove this assumption.
Also set the buf->size properly if a write() dequeues a buffer and th
From: Hans Verkuil
The callback used to merge the common code of the qbuf/prepare_buf
code can be removed now that the mmap_sem handling is pushed down to
__buf_prepare(). This makes the code more readable.
Signed-off-by: Hans Verkuil
Acked-by: Laurent Pinchart
---
drivers/media/v4l2-core/vid
From: Hans Verkuil
When preparing a buffer the queue lock is released for a short while
if the memory mode is USERPTR (see __buf_prepare for the details), which
would allow a race with a REQBUFS which can free the buffers. Removing the
buffers from underneath __buf_prepare is obviously a bad idea
This patch series does some cleanups in the qbuf/prepare_buf handling
(the first three patches). The fourth patch removes the 'fileio = NULL'
hack. That hack no longer works when dealing with asynchronous calls
from a kernel thread so it had to be fixed.
The next three patches implement retrying s
Hi Arun,
Some comments below...
On 12/09/2013 02:16 PM, Arun Kumar K wrote:
> Add v4l2 controls to set desired profile for VP8 encoder.
> Acceptable levels for VP8 encoder are
> 0: Version 0
> 1: Version 1
> 2: Version 2
> 3: Version 3
>
> Signed-off-by: Pawel Osciak
> Signed-off-by: Kiran AVND
Add v4l2 controls to set desired profile for VP8 encoder.
Acceptable levels for VP8 encoder are
0: Version 0
1: Version 1
2: Version 2
3: Version 3
Signed-off-by: Pawel Osciak
Signed-off-by: Kiran AVND
Signed-off-by: Arun Kumar K
---
This patch is rebased over another VP8 control patch from me:
Hi Enrico,
On Friday 06 December 2013 11:13:50 Enrico wrote:
> Hi,
>
> i know there is some work going on for omap3isp device tree support,
> but right now is it possible to enable it in some other way in a DT
> kernel?
>
> I've tried enabling it in board-generic.c (omap3_init_camera(...) with
>
Hi!
Is there anyone, who has started driver development for this card? I would like
to help testing.
Best wishes.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordo
Hi Hans,
Thank you for the patches.
For patches 1, 2, 4, 7 and 10,
Acked-by: Laurent Pinchart
On Thursday 05 December 2013 09:21:39 Hans Verkuil wrote:
> This patch series does some cleanups in the qbuf/prepare_buf handling
> (the first two patches). The third patch removes the 'fileio = NULL'
Various vb2 fixes. I've asked Marek if I could take care of these since I have
more vb2 patches pending.
Regards,
Hans
The following changes since commit 3f823e094b935c1882605f8720336ee23433a16d:
[media] exynos4-is: Simplify fimc-is hardware polling helpers (2013-12-04
15:54:19 -0200
Mauro,
Please queue these regression fixes for 3.13.
This supersedes my previous earlier 3.13 pull request of today, since I
realized that
the 'fix possible memory leak' patch should also go to 3.13.
Regards,
Hans
The following changes since commit 3f823e094b935c1882605f8720336ee23433
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
? 2013?12?05? 17:36, Kamil Debski ??:
> Hi Randy,
>
>> -Original Message- From: randy
>> [mailto:lxr1...@hotmail.com] Sent: Thursday, December 05, 2013
>> 1:27 AM To: linux-media@vger.kernel.org Cc: Kamil Debski;
>> m.szyprow...@samsung.com; k
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker
Acked-by: Lad, Prabhakar
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(
Hi Mauro,
I'm trying again to get this driver merged. The comments you made have all been
addressed, so hopefully this will now be OK.
Regards,
Hans
The following changes since commit 3f823e094b935c1882605f8720336ee23433a16d:
[media] exynos4-is: Simplify fimc-is hardware polling help
Mauro,
Please queue this regression fix for 3.13.
Regards,
Hans
The following changes since commit 3f823e094b935c1882605f8720336ee23433a16d:
[media] exynos4-is: Simplify fimc-is hardware polling helpers (2013-12-04
15:54:19 -0200)
are available in the git repository at:
git://li
On Fri, Nov 01, 2013 at 07:48:18PM +0800, Nicolin Chen wrote:
> Since gen_pool_dma_alloc() is introduced, we implement it to simplify code.
>
> Signed-off-by: Nicolin Chen
> ---
Acked-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
44 matches
Mail list logo
