Re: [PATCH] media: Add BCM2048 radio driver

2013-12-04 Thread Hans Verkuil
On 12/02/2013 09:51 PM, Pali Rohár wrote: > On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: >> Hi Pali, >> >> On 10/26/2013 10:45 PM, Pali Rohár wrote: >>> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: > Hans, so can it be added to drivers/staging/media tree? Yes, t

[GIT PULL FOR v3.14] Add radio-bcm2048 staging driver

2013-12-04 Thread Hans Verkuil
Hi Mauro, This patch series adds support for the bcm2048 radio found in the Nokia N900. It needs more work before it can be moved to media/radio, but it's OK for staging. Regards, Hans The following changes since commit 3f823e094b935c1882605f8720336ee23433a16d: [media] exynos4-is: Si

Re: [REVIEW PATCH 2/9] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-12-04 Thread Hans Verkuil
Hi Dinesh, On 12/04/2013 04:58 AM, dinesh ram wrote: > Hello Mauro and Hans, > > I agree with Hans that this driver has been sitting here for some time now. > As stated, If this can be a separate follow-up patch, it would be great. > > @Hans : Yes I can have a go at it and send you the changes t

cron job: media_tree daily build: ERRORS

2013-12-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Dec 5 04:00:29 CET 2013 git branch: test git hash: 3f823e094b935c1882605f8720336ee23433a16d gcc versio

Re: Can't open mfc v5 encode but decode can

2013-12-04 Thread randy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ? 2013?12?03? 18:44, Kamil Debski ??: > Hi Randy, > > We also experienced this issue. One of the changes in the v4l2 > core affected the MFC driver. A fix for MFC has been prepared by > Marek Szyprowski and should be sent out soon. > When it is sendi

Re: [PATCH 0/3] V4L2 OF fixes

2013-12-04 Thread Sylwester Nawrocki
Hi Laurent, On 12/04/2013 08:29 PM, Laurent Pinchart wrote: Hello, Here are three small fixes for the V4L2 OF parsing code. The patches should be self-explanatory. Laurent Pinchart (3): v4l: of: Return an int in v4l2_of_parse_endpoint() v4l: of: Remove struct v4l2_of_endpoint remote fiel

Re: [RFCv2 PATCH 7/9] vb2: add thread support

2013-12-04 Thread Laurent Pinchart
Hi Hans, On Wednesday 04 December 2013 18:03:47 Hans Verkuil wrote: > On 12/04/2013 05:33 PM, Laurent Pinchart wrote: > > On Wednesday 04 December 2013 08:47:25 Hans Verkuil wrote: > >> On 12/04/2013 02:17 AM, Laurent Pinchart wrote: > >>> On Tuesday 03 December 2013 10:56:07 Hans Verkuil wrote: >

[PATCH 1/3] v4l: of: Return an int in v4l2_of_parse_endpoint()

2013-12-04 Thread Laurent Pinchart
When CONFIG_OF is not defined the v4l2_of_parse_endpoint() function is defined as a stub that returns -ENOSYS. Make the real function return an integer as well to be able to differentiate between the two cases. Signed-off-by: Laurent Pinchart --- drivers/media/v4l2-core/v4l2-of.c | 8 ++-- i

[PATCH 2/3] v4l: of: Remove struct v4l2_of_endpoint remote field

2013-12-04 Thread Laurent Pinchart
The field isn't set when parsing the endpoint. Remove it. Signed-off-by: Laurent Pinchart --- include/media/v4l2-of.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h index 3480cd0..541cea4 100644 --- a/include/media/v4l2-of.h +++ b/include/m

[PATCH 3/3] v4l: of: Drop endpoint node reference in v4l2_of_get_remote_port()

2013-12-04 Thread Laurent Pinchart
The v4l2_of_get_remote_port() function acquires a reference to an endpoint node through a phandle and then returns the node's parent, without dropping the reference to the endpoint node. Fix it. Signed-off-by: Laurent Pinchart --- drivers/media/v4l2-core/v4l2-of.c | 2 +- 1 file changed, 1 inser

[PATCH 0/3] V4L2 OF fixes

2013-12-04 Thread Laurent Pinchart
Hello, Here are three small fixes for the V4L2 OF parsing code. The patches should be self-explanatory. Laurent Pinchart (3): v4l: of: Return an int in v4l2_of_parse_endpoint() v4l: of: Remove struct v4l2_of_endpoint remote field v4l: of: Drop endpoint node reference in v4l2_of_get_remote_p

[PATCH 5/6] mt9v032: Add support for model-specific parameters

2013-12-04 Thread Laurent Pinchart
To prepare support of the MT9V034, add the necessary infrastructure to support model-specific parameters. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 82 - 1 file changed, 67 insertions(+), 15 deletions(-) diff --git a/drivers/me

[PATCH 2/6] mt9v032: Fix pixel array size

2013-12-04 Thread Laurent Pinchart
The active pixel array size is 753x481 with 4 additional black rows at the top. Fix the driver accordingly. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9

[PATCH 6/6] mt9v032: Add support for the MT9V034

2013-12-04 Thread Laurent Pinchart
The MT9V034 sensor is very similar to the MT9V032, with a couple of different registers and parameters. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 54 ++--- 1 file changed, 46 insertions(+), 8 deletions(-) diff --git a/drivers/media

[PATCH 4/6] mt9v032: Add support for monochrome models

2013-12-04 Thread Laurent Pinchart
Identify the model based on the I2C device name and configure formats accordingly. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/medi

[PATCH 3/6] mt9v032: Fix binning configuration

2013-12-04 Thread Laurent Pinchart
The sensor can scale the image down using binning by 1, 2 or 4 in both directions. Update size enumeration and ratio and binning factor computation accordingly. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 68 ++--- 1 file changed, 45

[PATCH 0/6] MT9V032 sensor driver fixes and features

2013-12-04 Thread Laurent Pinchart
Hello, This patch set fixes two issues in the mt9v032 driver (2/6 and 3/6) and then adds support for monochrome sensors (4/6) and for the very similar MT9V034 sensor model. The code is based on top of the latest linuxtv master branch and has been tested with an MT9V034 on a Beagleboard-xM. I'd li

[PATCH 1/6] mt9v032: Remove unused macro

2013-12-04 Thread Laurent Pinchart
The EXT_CLK macro is unused, remove it. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index 2c50eff..2055820 100644 --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/med

Re: [REVIEW PATCH 2/9] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-12-04 Thread Mauro Carvalho Chehab
Em Wed, 04 Dec 2013 11:58:16 +0800 (SGT) dinesh ram escreveu: > Hello Mauro and Hans, > > I agree with Hans that this driver has been sitting here for some time now. > As stated, If this can be a separate follow-up patch, it would be great. > > @Hans : Yes I can have a go at it and send you the

Re: [REVIEW PATCH 1/9] si4713 : Reorganized drivers/media/radio directory

2013-12-04 Thread Mauro Carvalho Chehab
Em Tue, 03 Dec 2013 17:58:00 +0100 Hans Verkuil escreveu: > On 12/03/2013 04:39 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 15 Oct 2013 17:24:37 +0200 > > Dinesh Ram escreveu: > > > >> Added a new si4713 directory which will contain all si4713 related files. > >> Also updated Makefile and Kcon

[RESEND PATCH v7 5/5] clk: Implement clk_unregister

2013-12-04 Thread Sylwester Nawrocki
clk_unregister() is currently not implemented and it is required when a clock provider module needs to be unloaded. Normally the clock supplier module is prevented to be unloaded by taking reference on the module in clk_get(). For cases when the clock supplier module deinitializes despite the con

[RESEND PATCH v7 3/5] clkdev: Fix race condition in clock lookup from device tree

2013-12-04 Thread Sylwester Nawrocki
There is currently a race condition in the device tree part of clk_get() function, since the pointer returned from of_clk_get_by_name() may become invalid before __clk_get() call. E.g. due to the clock provider driver remove() callback being called in between of_clk_get_by_name() and __clk_get().

[RESEND PATCH v7 2/5] clk: Provide not locked variant of of_clk_get_from_provider()

2013-12-04 Thread Sylwester Nawrocki
Add helper functions for the of_clk_providers list locking and an unlocked variant of of_clk_get_from_provider(). These functions are intended to be used in the clkdev to avoid race condition in the device tree based clock look up in clk_get(). Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyu

[RESEND PATCH v7 1/5] omap3isp: Modify clocks registration to avoid circular references

2013-12-04 Thread Sylwester Nawrocki
The clock core code is going to be modified so clk_get() takes reference on the clock provider module. Until the potential circular reference issue is properly addressed, we pass NULL as the first argument to clk_register(), in order to disallow sub-devices taking a reference on the ISP module back

[PATCH] omap3isp: Use devm_ioremap_resource()

2013-12-04 Thread Laurent Pinchart
Replace devm_request_mem_region() and devm_ioremap_nocache() with devm_ioremap_resource(). The behaviour remains the same and the code is simplified. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c | 25 + drivers/media/platform/omap3isp/isp.h |

[RESEND PATCH v7 4/5] clk: Add common __clk_get(), __clk_put() implementations

2013-12-04 Thread Sylwester Nawrocki
This patch adds common __clk_get(), __clk_put() clkdev helpers that replace their platform specific counterparts when the common clock API is used. The owner module pointer field is added to struct clk so a reference to the clock supplier module can be taken by the clock consumers. The owner modu

[RESEND PATCH v7 0/5] clk: clock deregistration support

2013-12-04 Thread Sylwester Nawrocki
This patch series implements clock deregistration in the common clock framework. Detailed changes are listed at each patch. There is included an additional patch for the omap3isp driver, required to avoid regressions. These patches were rebased on top of 3.13-rc1 and re-retested, are also availabl

Re: [RFCv2 PATCH 7/9] vb2: add thread support

2013-12-04 Thread Hans Verkuil
On 12/04/2013 05:33 PM, Laurent Pinchart wrote: > Hi Hans, > > On Wednesday 04 December 2013 08:47:25 Hans Verkuil wrote: >> On 12/04/2013 02:17 AM, Laurent Pinchart wrote: >>> On Tuesday 03 December 2013 10:56:07 Hans Verkuil wrote: On 11/29/13 19:21, Laurent Pinchart wrote: > On Friday

Re: [RFCv2 PATCH 7/9] vb2: add thread support

2013-12-04 Thread Laurent Pinchart
Hi Hans, On Wednesday 04 December 2013 08:47:25 Hans Verkuil wrote: > On 12/04/2013 02:17 AM, Laurent Pinchart wrote: > > On Tuesday 03 December 2013 10:56:07 Hans Verkuil wrote: > >> On 11/29/13 19:21, Laurent Pinchart wrote: > >>> On Friday 29 November 2013 10:58:42 Hans Verkuil wrote: > Fr

[PATCH 5/5] v4l: atmel-isi: Make the MCK clock optional

2013-12-04 Thread Laurent Pinchart
ISI_MCK is the sensor master clock. It should be handled by the sensor driver directly, as the ISI has no use for that clock. Make the clock optional here while platforms transition to the correct model. Signed-off-by: Laurent Pinchart Acked-by: Josh Wu --- drivers/media/platform/soc_camera/atm

[PATCH 0/5] Atmel ISI fixes and improvements

2013-12-04 Thread Laurent Pinchart
Hello, Here's a set of miscellaneous fixes and improvement patches for the atmel-isi driver. Please see individual commit messages for more information. The last patch makes the MCK clock optional. The goal is to remove it completely, but we first need to port boards to the new clock handling mec

[PATCH 2/5] v4l: atmel-isi: Use devm_* managed allocators

2013-12-04 Thread Laurent Pinchart
This simplifies error and cleanup code paths. Signed-off-by: Laurent Pinchart Acked-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 56 +-- 1 file changed, 19 insertions(+), 37 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/dr

[PATCH 4/5] v4l: atmel-isi: Reset the ISI when starting the stream

2013-12-04 Thread Laurent Pinchart
The queue setup operation isn't the right place to reset the ISI. Move the reset call to the start streaming operation. Signed-off-by: Laurent Pinchart Acked-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-

[PATCH 1/5] v4l: atmel-isi: remove SOF wait in start_streaming()

2013-12-04 Thread Laurent Pinchart
From: Josh Wu when a userspace applications calls the VIDIOC_STREAMON ioctl. The V4L2 core calls the soc_camera_streamon function, which is responsible for starting the video stream. It does so by first starting the atmel-isi host by a call to the vb2_streamon function, and then starting the sens

[PATCH 3/5] v4l: atmel-isi: Defer clock (un)preparation to enable/disable time

2013-12-04 Thread Laurent Pinchart
The PCLK and MCK clocks are prepared and unprepared at probe and remove time. Clock (un)preparation isn't needed before enabling/disabling the clocks, and the enable/disable operation happen in non-atomic context. We can thus defer (un)preparation to enable/disable time. Signed-off-by: Laurent Pin

Get Previous Versions

2013-12-04 Thread Fry, Ashley (GE Intelligent Platforms)
I have discover I can get only old linux-media-2012-06-30.tar.bz2 from http://www.linuxtv.org/downloads/drivers/ but don't understand how I can use them within the current build system. I firstly I did :- sudo git clone git://linuxtv.org/media_build.git then sudo ./build Stopped that after it ha

Get Previous Versions

2013-12-04 Thread Fry, Ashley (GE Intelligent Platforms)
I have discover I can get only old linux-media-2012-06-30.tar.bz2 from http://www.linuxtv.org/downloads/drivers/ but don't understand how I can use them within the current build system. I firstly I did :- sudo git clone git://linuxtv.org/media_build.git then sudo ./build Stopped that after it h

[PATCH for 3.13] vb2: regression fix: always set length field.

2013-12-04 Thread Hans Verkuil
Commit dc77523c5da5513df1bbc74db2a522a94f4cec0e ensured that m.offset is only set for the MMAP memory mode by calling __setup_offsets only for that mode. However, __setup_offsets also initializes the length fields, and that should be done regardless of the memory mode. Because of that change the v

re: V4L/DVB (4922): Add usbvision driver

2013-12-04 Thread Dan Carpenter
Hello Joerg and Dwaine, The patch 781aa1d1ab7b: "V4L/DVB (4922): Add usbvision driver" from Dec 4, 2006, leads to the following static checker warning: "drivers/media/usb/usbvision/usbvision-core.c:298 scratch_get() error: memcpy() 'data' too small (400 vs 401)" drivers/media/usb/usbvisi

Re: [RFCv2 PATCH 4/9] vb2: retry start_streaming in case of insufficient buffers.

2013-12-04 Thread Marek Szyprowski
Hello, On 2013-11-29 10:58, Hans Verkuil wrote: From: Hans Verkuil If start_streaming returns -ENODATA, then it will be retried the next time a buffer is queued. This means applications no longer need to know how many buffers need to be queued before STREAMON can be called. This is particularly