Re: [PATCH] [media] s5p-mfc: Add QP setting support for vp8 encoder

2013-11-11 Thread Arun Kumar K
Hi Hans, On Mon, Nov 11, 2013 at 7:03 PM, Hans Verkuil wrote: > On 11/11/2013 11:44 AM, Arun Kumar K wrote: >> Hi Hans, >> >> On Mon, Nov 11, 2013 at 3:01 PM, Hans Verkuil wrote: >>> Hi Arun, >>> >>> On 11/11/2013 10:19 AM, Arun Kumar K wrote: Adds v4l2 controls to set MIN, MAX QP values an

Re: [PATCH][RESEND 3/8] dma: mmp_tdma: use gen_pool_dma_alloc() to allocate descriptor

2013-11-11 Thread Vinod Koul
On Fri, Nov 01, 2013 at 07:48:16PM +0800, Nicolin Chen wrote: > Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Acked-by: Vinod Koul -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.o

cron job: media_tree daily build: ERRORS

2013-11-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 12 04:00:19 CET 2013 git branch: test git hash: 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9 gcc versio

Re: [PATCH 0/3] media: Add SH-Mobile RCAR-H2 Lager board support

2013-11-11 Thread Laurent Pinchart
Hi Valentine, On Tuesday 24 September 2013 17:38:33 Valentine Barshak wrote: > The following patches add ADV7611/ADV7612 HDMI receiver I2C driver > and add RCAR H2 SOC support along with ADV761x output format support > to rcar_vin soc_camera driver. > > These changes are needed for SH-Mobile R8A7

Re: [PATCH] [RESEND] gspca-stk1135: Add delay after configuring clock

2013-11-11 Thread Sylwester Nawrocki
Hi Ondrej, On 11/11/2013 11:31 PM, Ondrej Zary wrote: Add a small delay at the end of configure_clock() to allow sensor to initialize. This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112). Signed-off-by: Ondrej Zary --- drivers/media/usb/gs

[PATCH] [RESEND] gspca-stk1135: Add delay after configuring clock

2013-11-11 Thread Ondrej Zary
Add a small delay at the end of configure_clock() to allow sensor to initialize. This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112). Signed-off-by: Ondrej Zary --- drivers/media/usb/gspca/stk1135.c |3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH 1/1] v4l: Add frame end event

2013-11-11 Thread Sakari Ailus
Hi Hans, Thanks for your comments. Hans Verkuil wrote: ... I have no objections to this patch. You do need to adapt drivers/media/platform/omap3isp/ispccdc.c a bit since it is using the FRAME_SYNC event and so it should check the id field. Good point. But will you also be upstreaming a dr

Re: [PATCH v9 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:07AM +0100, Arun Kumar K wrote: > The patch adds the DT binding documentation for Samsung > Exynos5 SoC series imaging subsystem (FIMC-IS). > > Signed-off-by: Arun Kumar K > Reviewed-by: Sylwester Nawrocki > --- > .../devicetree/bindings/media/exynos5-fimc-is.txt

Re: [PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:06AM +0100, Arun Kumar K wrote: > From: Shaik Ameer Basha > > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. [...] > diff --git a/Documentation/d

ccdc image capture interrupts

2013-11-11 Thread Tom
Hello, I want to capture an image with my ov3640 camera sensor connected with a gumstix overo board. I tried to change the isp registers and the registers of the ov3640 like in an old driver which worked with kernel version 2.6.34. I was able to get an image but I don't understand what the prob

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Hans Verkuil
On 11/11/2013 03:19 PM, Andy Walls wrote: > On Sun, 2013-11-10 at 19:16 +0200, Antti Palosaari wrote: >> Convert unsigned 8 to float 32 [-1 to +1], which is commonly >> used format for baseband signals. > > Hi Annti, > > I don't think this a good idea. Floating point representations are > inhere

[GIT PULL FOR v3.14] Patches for 3.14.

2013-11-11 Thread Hans Verkuil
The following changes since commit 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9: [media] media: st-rc: Add ST remote control driver (2013-10-31 08:20:08 -0200) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.14a for you to fetch changes up to 604f2fe58da

[GIT PULL FOR v3.13] Various fixes.

2013-11-11 Thread Hans Verkuil
The following changes since commit 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9: [media] media: st-rc: Add ST remote control driver (2013-10-31 08:20:08 -0200) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.13e for you to fetch changes up to e83c52b545a

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Andy Walls
On Sun, 2013-11-10 at 19:16 +0200, Antti Palosaari wrote: > Convert unsigned 8 to float 32 [-1 to +1], which is commonly > used format for baseband signals. Hi Annti, I don't think this a good idea. Floating point representations are inherently non-portable. Even though most everything now uses

Re: [PATCH v1 03/19] uvcvideo: Add support for multiple chains with common roots.

2013-11-11 Thread Paulo Assis
Hi, I'm repeating myself, but this seems the proper place to post this. This patch causes a regression with the logitech c930e. Please see comments below: 2013/11/10 Laurent Pinchart : > Hi Pawel, > > Thank you for the patch. > > On Friday 30 August 2013 11:17:02 Pawel Osciak wrote: >> This add

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Hans Verkuil
On 11/11/2013 02:40 PM, Antti Palosaari wrote: > On 11.11.2013 15:14, Hans Verkuil wrote: >> On 11/10/2013 06:16 PM, Antti Palosaari wrote: >>> Convert unsigned 8 to float 32 [-1 to +1], which is commonly >>> used format for baseband signals. >>> >>> Signed-off-by: Antti Palosaari >>> --- >>> co

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-11 Thread Andy Walls
On Mon, 2013-11-11 at 12:14 +0100, Hans Verkuil wrote: > On 10/19/2013 07:09 PM, Andy Walls wrote: > > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > >> I was finally able to carry out a git bisect. Had to do a git pull on > >> a fast internet hooked machine and ftp the files over to th

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Antti Palosaari
On 11.11.2013 15:14, Hans Verkuil wrote: On 11/10/2013 06:16 PM, Antti Palosaari wrote: Convert unsigned 8 to float 32 [-1 to +1], which is commonly used format for baseband signals. Signed-off-by: Antti Palosaari --- contrib/freebsd/include/linux/videodev2.h | 4 include/linux/videod

Re: [PATCH] [media] s5p-mfc: Add QP setting support for vp8 encoder

2013-11-11 Thread Hans Verkuil
On 11/11/2013 11:44 AM, Arun Kumar K wrote: > Hi Hans, > > On Mon, Nov 11, 2013 at 3:01 PM, Hans Verkuil wrote: >> Hi Arun, >> >> On 11/11/2013 10:19 AM, Arun Kumar K wrote: >>> Adds v4l2 controls to set MIN, MAX QP values and >>> I, P frame QP for vp8 encoder. >> >> I assume these parameters and

Re: [PATCH] media: i2c: Add camera driver for ov9655 chips.

2013-11-11 Thread Hans Verkuil
Hi Marek, Thanks for the patch! I have a few small comments below... On 11/08/2013 10:46 PM, Marek Belisko wrote: > This is a driver for the Omnivision OV9655 camera module > connected to the OMAP3 parallel camera interface and using > the ISP (Image Signal Processor). It supports SXGA and VGA >

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Hans Verkuil
On 11/10/2013 06:16 PM, Antti Palosaari wrote: > Convert unsigned 8 to float 32 [-1 to +1], which is commonly > used format for baseband signals. > > Signed-off-by: Antti Palosaari > --- > contrib/freebsd/include/linux/videodev2.h | 4 > include/linux/videodev2.h | 4

Re: [PATCH v4] videodev2: Set vb2_rect's width and height as unsigned

2013-11-11 Thread Hans Verkuil
Hi Ricardo, A few comments below... On 11/06/2013 05:44 PM, Ricardo Ribalda Delgado wrote: > As addressed on the media summit 2013, there is no reason for the width > and height to be signed. > > Therefore this patch is an attempt to convert those fields into unsigned. > > Signed-off-by: Ricard

Re: [PATCHv2] staging: go7007: fix use of uninitialised pointer

2013-11-11 Thread Dan Carpenter
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote: > go variable is initialised only after the switch case so it cannot be > dereferenced prior to that happening. > > Signed-off-by: Michal Nazarewicz Looks good. Thanks. :) regards, dan carpenter -- To unsubscribe from this li

Re: [PATCH v7] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-11 Thread Hans Verkuil
On 11/06/2013 04:41 PM, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda > > vb2_fop_release does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video

Re: [REVIEW PATCH 6/9] si4713 : Added the USB driver for Si4713

2013-11-11 Thread edubez...@gmail.com
On Thu, Nov 7, 2013 at 3:40 AM, Hans Verkuil wrote: > On 11/05/2013 03:18 PM, edubez...@gmail.com wrote: >> Dinesh >> >> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote: >>> This is the USB driver for the Silicon Labs development board. >>> It contains the Si4713 FM transmitter chip. >>> >> >>

Re: videobuf mmap deadlock

2013-11-11 Thread Hans Verkuil
Hi Pete, On 11/01/2013 07:54 PM, Pete Eberlein wrote: > The patch "videobuf_vm_{open,close} race fixes" > https://linuxtv.org/patch/18365/ introduced a deadlock in 3.11. > > My driver uses videobuf_vmalloc initialized with ext_lock set to NULL. Which driver are we talking about? > My driver's

Re: [PATCH 1/1] v4l: Add frame end event

2013-11-11 Thread Hans Verkuil
Hi Sakari, On 11/01/2013 02:10 PM, Sakari Ailus wrote: > Add an event to signal frame end. This is not necessarily the same timestamp > as the video buffer done timestamp, and can be also subscribed by other > processes than the one controlling streaming and buffer (de)queueing. > > Also make all

[PATCHv2] staging: go7007: fix use of uninitialised pointer

2013-11-11 Thread Michal Nazarewicz
go variable is initialised only after the switch case so it cannot be dereferenced prior to that happening. Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) On Sun, Nov 10 2013, Dan Carpenter wrote: > Th

RE: [PATCH] videobuf2-dma-sg: Support io userptr operations on io memory

2013-11-11 Thread Matthias Wächter
> @@ -180,7 +186,26 @@ static void *vb2_dma_sg_get_userptr(void > *alloc_ctx, unsigned long vaddr, > if (!buf->pages) > return NULL; > > - num_pages_from_user = get_user_pages(current, current->mm, > + buf->vma = find_vma(current->mm, vaddr); > + if (!buf->vma) { > +

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-11 Thread Hans Verkuil
On 10/19/2013 07:09 PM, Andy Walls wrote: > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: >> I was finally able to carry out a git bisect. Had to do a git pull on >> a fast internet hooked machine and ftp the files over to the remote >> machine. >> >> I started with 'git bisect bad v2.6.

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-11 Thread Hans Verkuil
On 11/06/2013 01:25 AM, Andy Walls wrote: > On Mon, 2013-11-04 at 13:44 +0100, Hans Verkuil wrote: >> On 10/19/2013 07:09 PM, Andy Walls wrote: >>> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > >>> Try applying the following (untested) patch that is made against the >>> bleeding edge

Re: [PATCH] [media] s5p-mfc: Add QP setting support for vp8 encoder

2013-11-11 Thread Arun Kumar K
Hi Hans, On Mon, Nov 11, 2013 at 3:01 PM, Hans Verkuil wrote: > Hi Arun, > > On 11/11/2013 10:19 AM, Arun Kumar K wrote: >> Adds v4l2 controls to set MIN, MAX QP values and >> I, P frame QP for vp8 encoder. > > I assume these parameters and their ranges are all defined by the VP8 > standard? > O

Re: [PATCH v1 00/19] UVC 1.5 VP8 support for uvcvideo

2013-11-11 Thread Paulo Assis
Hi, 2013/11/11 Laurent Pinchart : > Hi Paulo, > > On Thursday 10 October 2013 11:27:37 Paulo Assis wrote: >> Hi, >> just want t know the current state on this series. >> >> I'm currently adding h264 stream preview support to guvcview. >> It's already working fine on uvc 1.1 cameras like the BCC950

Re: [PATCH] [media] s5p-mfc: Add QP setting support for vp8 encoder

2013-11-11 Thread Hans Verkuil
Hi Arun, On 11/11/2013 10:19 AM, Arun Kumar K wrote: > Adds v4l2 controls to set MIN, MAX QP values and > I, P frame QP for vp8 encoder. I assume these parameters and their ranges are all defined by the VP8 standard? Or are they HW specific? Regards, Hans > > Signed-off-by: Kiran AVND

[PATCH] [media] s5p-mfc: Add QP setting support for vp8 encoder

2013-11-11 Thread Arun Kumar K
Adds v4l2 controls to set MIN, MAX QP values and I, P frame QP for vp8 encoder. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/v4l/controls.xml| 32 + drivers/media/platform/s5p-mfc/s5p_mfc_common.h |4 +++ drivers/media/platform/