cron job: media_tree daily build: WARNINGS

2013-11-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 6 04:00:21 CET 2013 git branch: for-v3.13c git hash: 3adeac2c34cc28e05d0ec52f38f009dcce278555 gcc

Re: [PATCH 2/6] [media] mt9p031: Include linux/of.h header

2013-11-05 Thread Laurent Pinchart
Hi Sachin, Thank you for the patch, and sorry for the late reply. On Friday 18 October 2013 08:37:11 Sachin Kamat wrote: > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid > build breakage in the future. > > Signed-off-by: Sachin Kamat > Cc: Laurent Pinchart Acked-by: L

Re: [PATCH 07/19] v4l: sh_vou: Enable the driver on all ARM platforms

2013-11-05 Thread Laurent Pinchart
Hi Mauro, On Wednesday 30 October 2013 10:26:23 Mauro Carvalho Chehab wrote: > Em Tue, 29 Oct 2013 00:46:55 +0100 Laurent Pinchart escreveu: > > Renesas ARM platforms are transitioning from single-platform to > > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the > > driver availab

Re: [early RFC] Device Tree bindings for OMAP3 Camera Subsystem

2013-11-05 Thread Laurent Pinchart
Hi Sebastian, Thank you for the aptch. On Sunday 03 November 2013 23:03:15 Sebastian Reichel wrote: > Hi, > > This is an early RFC for omap3isp DT support. For now i just created a > potential DT binding documentation based on the existing platform data: > > Binding for the OMAP3 Camera subsyst

Re: [PATCH 06/24] V4L2: add a common V4L2 subdevice platform data type

2013-11-05 Thread Laurent Pinchart
Hi Hans, On Monday 04 November 2013 12:24:10 Hans Verkuil wrote: > Hi Guennadi, > > Sorry for the delay, I only saw this today while I was going through my > mail backlog. > > On 10/17/2013 08:24 PM, Guennadi Liakhovetski wrote: > > Hi Hans > > > > Sorry for reviving this old thread. I was goin

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-05 Thread Andy Walls
On Mon, 2013-11-04 at 13:44 +0100, Hans Verkuil wrote: > On 10/19/2013 07:09 PM, Andy Walls wrote: > > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > > Try applying the following (untested) patch that is made against the > > bleeding edge Linux kernel. The test on the mute control sta

Re: [PATCH v3 04/29] [media] cx18: struct i2c_client is too big for stack

2013-11-05 Thread Andy Walls
On Tue, 2013-11-05 at 08:01 -0200, Mauro Carvalho Chehab wrote: > drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_read_eeprom': > drivers/media/pci/cx18/cx18-driver.c:357:1: warning: the frame size of > 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] > That happens

Re: [PATCH] Full DVB driver package for Earthsoft PT3 (ISDB-S/T) cards

2013-11-05 Thread ほち
Michael Krufky linuxtv.org> writes: > As the DVB maintainer, I am telling you that I won't merge this as a > monolithic driver. The standard is to separate the driver into > modules where possible, unless there is a valid reason for doing > otherwise. > > I understand that you used the PT1 drive

Re: [PATCH 4/4] media/solo6x10: Changes on the vb2-dma-sg API

2013-11-05 Thread Ismael Luceno
On Fri, 19 Jul 2013 09:58:49 +0200 Ricardo Ribalda Delgado wrote: > The struct vb2_dma_sg_desc has been replaced with the generic sg_table > to describe the location of the video buffers. > > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Ismael Luceno <...> signature.asc Description: PGP

Re: [PATCH] SOLO6x10: don't do DMA from stack in solo_dma_vin_region().

2013-11-05 Thread Ismael Luceno
On Thu, 12 Sep 2013 14:25:36 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: > Signed-off-by: Krzysztof Hałasa Acked-by: Ismael Luceno <...> signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Fix video encoding on big-endian systems.

2013-11-05 Thread Ismael Luceno
On Thu, 12 Sep 2013 14:28:07 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: > Signed-off-by: Krzysztof Hałasa > Acked-by: Ismael Luceno <...> signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Remove unused #define SOLO_DEFAULT_GOP

2013-11-05 Thread Ismael Luceno
On Thu, 12 Sep 2013 14:26:46 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: > Signed-off-by: Krzysztof Hałasa > Acked-by: Ismael Luceno <...> signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Fix video frame type (I/P/B).

2013-11-05 Thread Ismael Luceno
On Mon, 07 Oct 2013 13:33:55 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: > Signed-off-by: Krzysztof Hałasa Acked-by: Ismael Luceno <...> signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Fix video headers on certain hardware.

2013-11-05 Thread Ismael Luceno
On Thu, 12 Sep 2013 14:43:34 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: > On certain platforms a sequence of dma_map_sg() and dma_unmap_sg() > discards data previously stored in the buffers. Build video headers > only after the DMA is completed. > > Signed-off-by: Krzysztof Hałasa > Acked-

Re: [PATCH] Full DVB driver package for Earthsoft PT3 (ISDB-S/T) cards

2013-11-05 Thread Michael Krufky
On Tue, Nov 5, 2013 at 3:56 PM, ほち wrote: > see inline > > 2013/11/6 Michael Krufky : >> responding inline: >> >>> Mauro Carvalho Chehab asked to put tuner code as an I2C driver, under >>> drivers/media/tuners, frontends at drivers/media/dvb- >>> However, to keep package integrity & compatibility

Re: [PATCH] Full DVB driver package for Earthsoft PT3 (ISDB-S/T) cards

2013-11-05 Thread ほち
see inline 2013/11/6 Michael Krufky : > responding inline: > >> Mauro Carvalho Chehab asked to put tuner code as an I2C driver, under >> drivers/media/tuners, frontends at drivers/media/dvb- >> However, to keep package integrity & compatibility with PT1/PT2 user apps, >> FE etc. are still placed

re: staging: media: Use dev_err() instead of pr_err()

2013-11-05 Thread Dan Carpenter
Hello Dulshani Gunawardhana, The patch 44ee8e801137: "staging: media: Use dev_err() instead of pr_err()" from Oct 20, 2013, leads to the following GCC warning: drivers/staging/media/go7007/go7007-usb.c: In function ‘go7007_usb_probe’: drivers/staging/media/go7007/go7007-usb.c:1100:13: warning:

Re: [RFC] [PATCH] media: marvell-ccic: use devm to release clk

2013-11-05 Thread Uwe Kleine-König
On Tue, Nov 05, 2013 at 05:33:16PM +0800, lbyang wrote: > From: Libin Yang > Date: Tue, 5 Nov 2013 16:29:07 +0800 > Subject: [PATCH] media: marvell-ccic: use devm to release clk > > This patch uses devm to release the clks instead of releasing > manually. > And it adds enable/disable mipi_clk whe

Re: [PATCH v3 25/29] [media] af9015: Don't use dynamic static allocation

2013-11-05 Thread Antti Palosaari
Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti On 05.11.2013 12:01, Mauro Carvalho Chehab wrote: Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb-v2/af9015.c:433:1: warning: 'af901

Re: [PATCH v3 26/29] [media] af9035: Don't use dynamic static allocation

2013-11-05 Thread Antti Palosaari
Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti On 05.11.2013 12:01, Mauro Carvalho Chehab wrote: Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb-v2/af9035.c:142:1: warning: 'af9035

Re: [PATCH v3 18/29] [media] tuners: Don't use dynamic static allocation

2013-11-05 Thread Antti Palosaari
Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti On 05.11.2013 12:01, Mauro Carvalho Chehab wrote: Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/tuners/e4000.c:50:1: warning: 'e4000_wr_regs' u

Re: [PATCH v3 13/29] [media] dvb-frontends: Don't use dynamic static allocation

2013-11-05 Thread Antti Palosaari
Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti On 05.11.2013 12:01, Mauro Carvalho Chehab wrote: Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/af9013.c:77:1: warning: 'af9013

Re: [RFC] [PATCH] media: marvell-ccic: use devm to release clk

2013-11-05 Thread Jonathan Corbet
On Tue, 5 Nov 2013 17:33:16 +0800 lbyang wrote: > This patch uses devm to release the clks instead of releasing > manually. > And it adds enable/disable mipi_clk when getting its rate. I can't really test this, so I'll have to assume it works :) Acked-by: Jonathan Corbet However: it seems tha

Re: [PATCH] media: marvell-ccic: drop resource free in driver remove

2013-11-05 Thread Jonathan Corbet
On Tue, 5 Nov 2013 11:21:08 +0800 lbyang wrote: > From: Libin Yang > Date: Tue, 5 Nov 2013 10:18:15 +0800 > Subject: [PATCH] marvell-ccic: drop resource free in driver remove > > The mmp-driver is using devm_* to allocate the resource. The old > resource release methods are not appropriate here

[PATCH v3 17/29] [media] av7110_hw: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/pci/ttpci/av7110_hw.c:510:1: warning: 'av7110_fw_cmd' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer. In the sp

Re: [PATCH v3 00/29] Fix errors/warnings with allmodconfig/allyesconfig on non-x86 archs

2013-11-05 Thread Hans Verkuil
Hi Mauro, For all patches except 22 (which got a newer revision): Reviewed-by: Hans Verkuil Regards, Hans On 11/05/13 11:01, Mauro Carvalho Chehab wrote: > To be sure that we're not introducing compilation regressions on media, I'm > now > using ktest to check for errors/warnings. >

[PATCH v3 25/29] [media] af9015: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb-v2/af9015.c:433:1: warning: 'af9015_eeprom_hash' uses dynamic stack allocation [enabled by default] In this specific case, it is a gcc bug, as the siz

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Hans Verkuil
On 11/05/13 14:16, Mauro Carvalho Chehab wrote: > New patch enclosed. Please reply with your reviewed-by if you're ok with > it. Reviewed-by: Hans Verkuil Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.

Re: [REVIEW PATCH 6/9] si4713 : Added the USB driver for Si4713

2013-11-05 Thread edubez...@gmail.com
Dinesh On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote: > This is the USB driver for the Silicon Labs development board. > It contains the Si4713 FM transmitter chip. > I tried this driver again. The system attempts to probe the device but it fails because the product revision read out of the

Re: [REVIEW PATCH 8/9] si4713: move supply list to si4713_platform_data

2013-11-05 Thread edubez...@gmail.com
On Tue, Nov 5, 2013 at 4:38 AM, Hans Verkuil wrote: > Hi, > > On 11/04/13 15:07, edubez...@gmail.com wrote: >> Hi, >> >> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote: >>> The supply list is needed by the platform driver, but not by the usb driver. >>> So this information belongs to the plat

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

2013-11-05 Thread Arun Kumar K
Hi Sakari, Thank you for the review. On Tue, Nov 5, 2013 at 6:21 PM, Sakari Ailus wrote: > Hi Arun, > > On Tue, Nov 05, 2013 at 11:42:34AM +0530, Arun Kumar K wrote: >> This patch adds all the common header files used by the fimc-is >> driver. It includes the commands for interfacing with the fi

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Tue, 05 Nov 2013 13:35:49 +0100 Hans Verkuil escreveu: > On 11/05/13 13:03, Mauro Carvalho Chehab wrote: > > Em Tue, 05 Nov 2013 12:42:23 +0100 > > Sylwester Nawrocki escreveu: > > > >> On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/media/v4l2-core/v4l2-async.c

[PATCH v3 08/29] [media] radio-si470x-i2c: fix a warning on ia64

2013-11-05 Thread Mauro Carvalho Chehab
on ia64, those warnings appear: drivers/media/radio/si470x/radio-si470x-i2c.c:470:12: warning: 'si470x_i2c_suspend' defined but not used [-Wunused-function] drivers/media/radio/si470x/radio-si470x-i2c.c:487:12: warning: 'si470x_i2c_resume' defined but not used [-Wunused-function]

[PATCH v3 29/29] [media] cx18: disable compilation on frv arch

2013-11-05 Thread Mauro Carvalho Chehab
This driver produces a lot of errors on this arch: In file included from drivers/media/pci/cx18/cx18-driver.c:26:0: /drivers/media/pci/cx18/cx18-io.h: In function 'cx18_raw_readl': drivers/media/pci/cx18/cx18-io.h:40:2: warning: passing argument 1 of '__builtin_read32' disc

[PATCH v3 23/29] [media] dibusb-common: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb/dibusb-common.c:124:1: warning: 'dibusb_i2c_msg' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer to b

[PATCH v3 16/29] [media] stv090x: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/stv090x.c:750:1: warning: 'stv090x_write_regs.constprop.6' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the

[PATCH v3 07/29] [media] platform drivers: Fix build on frv arch

2013-11-05 Thread Mauro Carvalho Chehab
On frv, the following errors happen: drivers/media/platform/soc_camera/rcar_vin.c: In function 'rcar_vin_setup': drivers/media/platform/soc_camera/rcar_vin.c:284:3: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration] drivers/media/pl

[PATCH v3 04/29] [media] cx18: struct i2c_client is too big for stack

2013-11-05 Thread Mauro Carvalho Chehab
drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_read_eeprom': drivers/media/pci/cx18/cx18-driver.c:357:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] That happens because the routine allocates 256 bytes for an eeprom buffer, plus t

[PATCH v3 11/29] [media] s5h1420: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/s5h1420.c:851:1: warning: 's5h1420_tuner_i2c_tuner_xfer' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the b

[PATCH v3 13/29] [media] dvb-frontends: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/af9013.c:77:1: warning: 'af9013_wr_regs_i2c' uses dynamic stack allocation [enabled by default] drivers/media/dvb-frontends/af9033.c:188:1: w

[PATCH v3 19/29] [media] tuner-xc2028: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/tuners/tuner-xc2028.c:651:1: warning: 'load_firmware' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer. In the sp

[PATCH v3 01/29] [media] tda9887: remove an warning when compiling for alpha

2013-11-05 Thread Mauro Carvalho Chehab
There's no need to zero the buffer, as if the routine gets an error, rc will be different than one. That fixes the following warning: drivers/media/tuners/tda9887.c: In function 'tda9887_status': drivers/media/tuners/tda9887.c:539:2: warning: value computed is not used [-Wunused-va

[PATCH v3 10/29] [media] uvc/lirc_serial: Fix some warnings on parisc arch

2013-11-05 Thread Mauro Carvalho Chehab
On this arch, usec is not unsigned long. So, we need to typecast, in order to remove those warnings: drivers/media/usb/uvc/uvc_video.c: In function 'uvc_video_clock_update': drivers/media/usb/uvc/uvc_video.c:678:2: warning: format '%lu' expects argument of type 'long unsigned int',

[PATCH v3 12/29] [media] dvb-frontends: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/bcm3510.c:230:1: warning: 'bcm3510_do_hab_cmd' uses dynamic stack allocation [enabled by default] drivers/media/dvb-frontends/itd1000.c:69:1:

[PATCH v3 03/29] [media] zoran: don't build it on alpha

2013-11-05 Thread Mauro Carvalho Chehab
This driver uses virt_to_bus() with is deprecated on Alpha: drivers/media/pci/zoran/zoran_device.c: In function 'zr36057_set_vfe': drivers/media/pci/zoran/zoran_device.c:451:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114)

[PATCH v3 00/29] Fix errors/warnings with allmodconfig/allyesconfig on non-x86 archs

2013-11-05 Thread Mauro Carvalho Chehab
To be sure that we're not introducing compilation regressions on media, I'm now using ktest to check for errors/warnings. My current setup is cross-building on several architectures: alpha, arm, avr32, cris (64), frv, i386, ia64, m32r, m68k, mips, openrisc, parisc, s390, sh, sparc, sparc

[PATCH v3 28/29] [media] lirc_zilog: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and ompilation complains about it on some archs: drivers/staging/media/lirc/lirc_zilog.c:967:1: warning: 'read' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer to be 64. That sh

[PATCH v3 24/29] [media] dw2102: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb/dw2102.c:368:1: warning: 'dw2102_earda_i2c_transfer' uses dynamic stack allocation [enabled by default] drivers/media/usb/dvb-usb/dw2102.c:449:

[PATCH v3 09/29] [media] rc: Fir warnings on m68k arch

2013-11-05 Thread Mauro Carvalho Chehab
Fix the following warnings: drivers/media/rc/fintek-cir.c: In function 'fintek_cr_write': drivers/media/rc/fintek-cir.c:45:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] drivers/media/rc/fintek-cir.c:46:2: warning: cast to pointer from i

[PATCH v3 05/29] [media] tef6862: fix warning on avr32 arch

2013-11-05 Thread Mauro Carvalho Chehab
On avr32 arch, we get those warnings: drivers/media/radio/tef6862.c:59:1: warning: "MODE_SHIFT" redefined In file included from /devel/v4l/ktest-build/arch/avr32/include/asm/ptrace.h:11, arch/avr32/include/uapi/asm/ptrace.h:41:1: warning: this is the location of the previo

[PATCH v3 22/29] [media] cxusb: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb/cxusb.c:209:1: warning: 'cxusb_i2c_xfer' uses dynamic stack allocation [enabled by default] drivers/media/usb/dvb-usb/cxusb.c:69:1: warning: 'c

[PATCH v3 27/29] [media] mxl111sf: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb-v2/mxl111sf.c:74:1: warning: 'mxl111sf_ctrl_msg' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer to b

[PATCH v3 20/29] [media] cimax2: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/pci/cx23885/cimax2.c:149:1: warning: 'netup_write_i2c' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer. Consideri

[PATCH v3 15/29] [media] stv0367: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/stv0367.c:791:1: warning: 'stv0367_writeregs.constprop.4' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the

[PATCH v3 26/29] [media] af9035: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/usb/dvb-usb-v2/af9035.c:142:1: warning: 'af9035_wr_regs' uses dynamic stack allocation [enabled by default] drivers/media/usb/dvb-usb-v2/af9035.c:305:1: wa

[PATCH v3 02/29] [media] radio-shark: remove a warning when CONFIG_PM is not defined

2013-11-05 Thread Mauro Carvalho Chehab
On alpha, allyesconfig doesn't have CONFIG_PM, and produces the following warnings: drivers/media/radio/radio-shark.c:274:13: warning: 'shark_resume_leds' defined but not used [-Wunused-function] drivers/media/radio/radio-shark2.c:240:13: warning: 'shark_resume_leds' defined but

[PATCH v3 21/29] [media] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/v4l2-core/v4l2-async.c:238:1: warning: 'v4l2_async_notifier_unregister' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the

[PATCH v3 18/29] [media] tuners: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/tuners/e4000.c:50:1: warning: 'e4000_wr_regs' uses dynamic stack allocation [enabled by default] drivers/media/tuners/e4000.c:83:1: warning: 'e4000_rd_regs

[PATCH v3 14/29] [media] stb0899_drv: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/dvb-frontends/stb0899_drv.c:540:1: warning: 'stb0899_write_regs' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for the buffer.

[PATCH v3 06/29] [media] iguanair: simplify calculation of carrier delay cycles

2013-11-05 Thread Mauro Carvalho Chehab
From: Sean Young Simplify the logic that calculates the carrier, and removes a warning on avr32 arch: drivers/media/rc/iguanair.c: In function 'iguanair_set_tx_carrier': drivers/media/rc/iguanair.c:304: warning: 'sevens' may be used uninitialized in this function Signed-off-by:

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

2013-11-05 Thread Sakari Ailus
Hi Arun, On Tue, Nov 05, 2013 at 11:42:34AM +0530, Arun Kumar K wrote: > This patch adds all the common header files used by the fimc-is > driver. It includes the commands for interfacing with the firmware > and error codes from IS firmware, metadata and command parameter > definitions. > > Signe

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Hans Verkuil
On 11/05/13 13:03, Mauro Carvalho Chehab wrote: > Em Tue, 05 Nov 2013 12:42:23 +0100 > Sylwester Nawrocki escreveu: > >> On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/v4l2-core/v4l2-async.c > b/drivers/media/v4l2-core/v4l2-async.c >>> index c85d69da35bd

[PATCH v12 08/12] [media] exynos5-fimc-is: Add the hardware pipeline control

2013-11-05 Thread Arun Kumar K
This patch adds the crucial hardware pipeline control for the fimc-is driver. All the subdev nodes will call this pipeline interfaces to reach the hardware. Responsibilities of this module involves configuring and maintaining the hardware pipeline involving multiple sub-ips like ISP, DRC, Scalers,

[PATCH v12 11/12] V4L: Add DT binding doc for s5k4e5 image sensor

2013-11-05 Thread Arun Kumar K
S5K4E5 is a Samsung raw image sensor controlled via I2C. This patch adds the DT binding documentation for the same. Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki Acked-by: Mark Rutland --- .../devicetree/bindings/media/samsung-s5k4e5.txt | 45 1 file chan

[PATCH v12 10/12] [media] exynos5-is: Add Kconfig and Makefile

2013-11-05 Thread Arun Kumar K
Adds Kconfig and Makefile for exynos5-is driver files. Signed-off-by: Shaik Ameer Basha Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |1 + drivers/media/platform/e

[PATCH v12 09/12] [media] exynos5-fimc-is: Add the hardware interface module

2013-11-05 Thread Arun Kumar K
The hardware interface module finally sends the commands to the FIMC-IS firmware and runs the interrupt handler for getting the responses. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- .../media/platform/exynos5-is/fimc-is-interface.c | 810 +++

[PATCH v12 07/12] [media] exynos5-fimc-is: Add sensor interface

2013-11-05 Thread Arun Kumar K
Some sensors to be used with fimc-is are exclusively controlled by the fimc-is firmware. This minimal sensor driver provides the required info for the firmware to configure the sensors sitting on I2C bus. Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exy

[PATCH v12 12/12] V4L: Add s5k4e5 sensor driver

2013-11-05 Thread Arun Kumar K
This patch adds subdev driver for Samsung S5K4E5 raw image sensor. Like s5k6a3, it is also another fimc-is firmware controlled sensor. This minimal sensor driver doesn't do any I2C communications as its done by ISP firmware. It can be updated if needed to a regular sensor driver by adding the I2C c

[PATCH v12 04/12] [media] exynos5-fimc-is: Add register definition and context header

2013-11-05 Thread Arun Kumar K
This patch adds the register definition file for the fimc-is driver and also the header file containing the main context for the driver. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-is-regs.h | 105 +++

[PATCH v12 05/12] [media] exynos5-fimc-is: Add isp subdev

2013-11-05 Thread Arun Kumar K
fimc-is driver takes video data input from the ISP video node which is added in this patch. This node accepts Bayer input buffers which is given from the IS sensors. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc

[PATCH v12 06/12] [media] exynos5-fimc-is: Add scaler subdev

2013-11-05 Thread Arun Kumar K
FIMC-IS has two hardware scalers named as scaler-codec and scaler-preview. This patch adds the common code handling the video nodes and subdevs of both the scalers. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-

[PATCH v12 01/12] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-05 Thread Arun Kumar K
The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). Signed-off-by: Arun Kumar K Reviewed-by: Sylwester Nawrocki Acked-by: Mark Rutland --- .../devicetree/bindings/media/exynos5-fimc-is.txt | 113 1 file changed, 113 ins

[PATCH v12 02/12] [media] exynos5-fimc-is: Add driver core files

2013-11-05 Thread Arun Kumar K
This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im Reviewed-by: Sylwester Nawrocki --- drivers/media/platform/exynos5-is/fimc-is-core.c | 386 +

[PATCH v12 00/12] Exynos5 IS driver

2013-11-05 Thread Arun Kumar K
The patch series adds support for exynos5 fimc-is driver and a new sensor s5k4e5. The media driver part is omitted form this series as it is already applied. Changes from v11 - Addressed review comments from Sakari Ailus http://www.mail-archive.com/linux-media@vger.kernel.org/msg6

Re: [PATCH] [media] az6007: support Technisat Cablestar Combo HDCI (minus remote)

2013-11-05 Thread Janusz S. Bien
Quote/Cytat - "Janusz S. Bien" (Tue 05 Nov 2013 07:14:22 AM CET): Thank you very much for the patch. Quote/Cytat - Roland Scheidegger (Sat 02 Nov 2013 08:49:32 PM CET): [...] Originally based on idea found on http://www.linuxtv.org/wiki/index.php/TechniSat_CableStar_Combo_HD_CI cl

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Tue, 05 Nov 2013 12:42:23 +0100 Sylwester Nawrocki escreveu: > On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > >>> diff --git a/drivers/media/v4l2-core/v4l2-async.c > >>> b/drivers/media/v4l2-core/v4l2-async.c > >>> > > index c85d69da35bd..071596869036 100644 > >>> > > --- a/drivers/media/v

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Sylwester Nawrocki
On 05/11/13 12:36, Mauro Carvalho Chehab wrote: >>> diff --git a/drivers/media/v4l2-core/v4l2-async.c >>> b/drivers/media/v4l2-core/v4l2-async.c >>> > > index c85d69da35bd..071596869036 100644 >>> > > --- a/drivers/media/v4l2-core/v4l2-async.c >>> > > +++ b/drivers/media/v4l2-core/v4l2-async.c >>>

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Mon, 04 Nov 2013 14:15:04 +0100 Hans Verkuil escreveu: > On 11/02/2013 02:31 PM, Mauro Carvalho Chehab wrote: > > Dynamic static allocation is evil, as Kernel stack is too low, and > > compilation complains about it on some archs: > > > > drivers/media/v4l2-core/v4l2-async.c:238:1: warnin

Re: [PATCH v11 02/12] [media] exynos5-fimc-is: Add driver core files

2013-11-05 Thread Arun Kumar K
Hi Sakari, Thank you for the review. Will make the required changes. Thanks Arun On Tue, Nov 5, 2013 at 4:51 PM, Sakari Ailus wrote: > Hi Arun, > > Thanks for the patch. A few comments below. > > On Tue, Nov 05, 2013 at 11:42:33AM +0530, Arun Kumar K wrote: >> This driver is for the FIMC-IS IP

Re: [PATCH v11 02/12] [media] exynos5-fimc-is: Add driver core files

2013-11-05 Thread Sakari Ailus
Hi Arun, Thanks for the patch. A few comments below. On Tue, Nov 05, 2013 at 11:42:33AM +0530, Arun Kumar K wrote: > This driver is for the FIMC-IS IP available in Samsung Exynos5 > SoC onwards. This patch adds the core files for the new driver. > > Signed-off-by: Arun Kumar K > Signed-off-by:

[PATCH v11 2/2] [media] exynos5-is: Add media device driver for exynos5 SoCs camera subsystem

2013-11-05 Thread Arun Kumar K
From: Shaik Ameer Basha This patch adds a top level media device driver for the Exynos5 SoC series camera subsystem. The driver currently supports processing pipelines involving following IP blocks: * MIPI-CSIS MIPI CSI-2 bus front-end to the FIMC-LITE, image sensors with MIPI CSI-2 bus shou

[PATCH v11 1/2] [media] exynos5-is: Adds DT binding documentation

2013-11-05 Thread Arun Kumar K
From: Shaik Ameer Basha The patch adds the DT binding doc for exynos5 SoC camera subsystem. Signed-off-by: Shaik Ameer Basha Signed-off-by: Arun Kumar K --- .../bindings/media/exynos5250-camera.txt | 126 1 file changed, 126 insertions(+) create mode 100644 D

Re: [GIT PULL FOR 3.13] Exynos5 SoC FIMC-IS imaging subsystem driver

2013-11-05 Thread Arun Kumar K
Hi Sylwester, Ok will resend the media-dev patch after splitting. Thanks Arun On Tue, Nov 5, 2013 at 3:48 PM, Sylwester Nawrocki wrote: > On 05/11/13 05:21, Arun Kumar K wrote: >> Hi Sylwester, >> >> Sorry for the delayed response as I was on leave. >> I will address the comments from Mark today

Re: [GIT PULL FOR 3.13] Exynos5 SoC FIMC-IS imaging subsystem driver

2013-11-05 Thread Sylwester Nawrocki
On 05/11/13 05:21, Arun Kumar K wrote: > Hi Sylwester, > > Sorry for the delayed response as I was on leave. > I will address the comments from Mark today itself and post those DT > binding patches. Hi Arun, Thanks, could you also split this patch [1] in two so the DT binding documentation and t

[RFC] [PATCH] media: marvell-ccic: use devm to release clk

2013-11-05 Thread lbyang
From: Libin Yang Date: Tue, 5 Nov 2013 16:29:07 +0800 Subject: [PATCH] media: marvell-ccic: use devm to release clk This patch uses devm to release the clks instead of releasing manually. And it adds enable/disable mipi_clk when getting its rate. Signed-off-by: Libin Yang --- drivers/media/pla

Re: [REVIEW PATCH 8/9] si4713: move supply list to si4713_platform_data

2013-11-05 Thread Hans Verkuil
Hi, On 11/04/13 15:07, edubez...@gmail.com wrote: > Hi, > > On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote: >> The supply list is needed by the platform driver, but not by the usb driver. >> So this information belongs to the platform data and should not be hardcoded >> in the subdevice driv