Re: [RFC PATCH 3/8] v4l2: move dv-timings related code to v4l2-dv-timings.c

2013-08-04 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Mon, Jul 29, 2013 at 6:10 PM, Hans Verkuil wrote: > From: Hans Verkuil > > v4l2-common.c contained a bunch of dv-timings related functions. > Move that to the new v4l2-dv-timings.c which is a more appropriate > place for them. > > There aren't many drivers that

Re: [RFC PATCH 2/8] v4l2-dv-timings: add new helper module.

2013-08-04 Thread Prabhakar Lad
Hi Hans, Thanks for the patch, this will still simplify driver writing :-) On Mon, Jul 29, 2013 at 6:10 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This module makes it easy to filter valid timings from the full list of > CEA and DMT timings based on the timings capabilities. > > Signed-of

[PATCH] dma-buf: Expose buffer size to userspace

2013-08-04 Thread Christopher James Halse Rogers
Each dma-buf has an associated size and it's reasonable for userspace to want to know what it is. Since userspace already has an fd, expose the size using the size = lseek(fd, SEEK_END, 0); lseek(fd, SEEK_CUR, 0); idiom. Signed-off-by: Christopher James Halse Rogers --- I've run into a point i

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-04 Thread Sachin Kamat
On 2 August 2013 20:32, Arun Kumar K wrote: > From: Shaik Ameer Basha > > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > > * MIPI-CSIS > Support interconnection(subdev interf

Re: [PATCH 2/3] [media] exynos4-is: Annotate unused functions

2013-08-04 Thread Sachin Kamat
Hi Sylwester, On 2 August 2013 12:02, Sachin Kamat wrote: > __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have > any callers. However these functions may be used in the future. Hence > instead of deleting them, staticize and annotate them with __maybe_unused > flag to avoid compil

Re: [RFC v3 00/13] Exynos5 IS driver

2013-08-04 Thread Arun Kumar K
Hi Sylwester, On Sun, Aug 4, 2013 at 3:10 AM, Sylwester Nawrocki wrote: > Hi Arun, > > > On 08/02/2013 05:02 PM, Arun Kumar K wrote: >> >> The patch series add support for Exynos5 camera subsystem. It >> re-uses mipi-csis and fimc-lite from exynos4-is and adds a new >> media device and fimc-is de

[PATCH RFC] [media] gspca-ov534: don't call sd_start() from sd_init()

2013-08-04 Thread Antonio Ospite
--- Hi Yaroslav, the patch below should fix the Oops caused by sd_start() called too early, but I am not sure about why sd_start() was called from sd_init() for Hercules webcams in the first place, maybe the snippet marked with: /* (from ms-win trace) */ in sd_start() must be moved to sd_init

Re: [PATCH 4/5] [media] winbond: wire up rc feedback led

2013-08-04 Thread David Härdeman
On Wed, Jul 31, 2013 at 12:00:03AM +0100, Sean Young wrote: >Note that with the rc-feedback trigger, the cir-rx trigger is now >redundant. The cir-tx trigger is not used by default; if this >functionality is desired then it should exist in rc-core, not in >a driver. > >Also make sure that the led i

Re: How to express planar formats with mediabus format code?

2013-08-04 Thread Guennadi Liakhovetski
Hi Su Jiaquan On Sun, 4 Aug 2013, Su Jiaquan wrote: > Hi, > > I know the title looks crazy, but here is our problem: > > In our SoC based ISP, the hardware can be divide to several blocks. > Some blocks can do color space conversion(raw to YUV > interleave/planar), others can do the pixel > re-

Re: [RFC v3 10/13] [media] exynos5-fimc-is: Add the hardware interface module

2013-08-04 Thread Sylwester Nawrocki
Hi Arun, On 08/02/2013 05:02 PM, Arun Kumar K wrote: The hardware interface module finally sends the commands to the FIMC-IS firmware and runs the interrupt handler for getting the responses. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im --- .../media/platform/exynos5-is/fimc-is-inter

mceusb Fintek ir transmitter only works when X is not running

2013-08-04 Thread Rajil Saraswat
Hi, I have a HP MCE ir transreceiver which is recognised as Fintek device. The receiver works fine, however the transmitter only works when there is no X session running. When X is stopped and the following command is issued from the virtual console (tty1), then the transmitter works: irsend SE

Re: [PATCH v2 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-04 Thread Ricardo Ribalda Delgado
Hello Gregor Thanks for your comments. I have replied inline. On Sat, Aug 3, 2013 at 6:42 PM, Gregor Jasny wrote: > On 8/3/13 12:42 AM, Ricardo Ribalda Delgado wrote: >> >> + case V4L2_PIX_FMT_RGB32: >> + switch (dest_pix_fmt) { >> + case V4L2_PIX_FMT_RGB24: >>