Re: [PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-24 Thread Arun Kumar K
Hi Sylwester, Thank you for the review. On Mon, Jun 24, 2013 at 2:23 AM, Sylwester Nawrocki wrote: > Hi Arun, > > > On 06/18/2013 02:56 PM, Arun Kumar K wrote: >> >> This patch adds new V4L controls for VP8 encoding. >> >> Signed-off-by: Arun Kumar K >> Signed-off-by: Kiran AVND > > > I think yo

Re: [PATCH v2 6/8] [media] V4L: Add support for integer menu controls with standard menu items

2013-06-24 Thread Arun Kumar K
Hi Sylwester, On Mon, Jun 24, 2013 at 2:20 AM, Sylwester Nawrocki wrote: > Hi Arun, > > > On 06/18/2013 02:56 PM, Arun Kumar K wrote: >> >> @@ -806,6 +820,7 @@ const char *v4l2_ctrl_get_name(u32 id) >> case V4L2_CID_FM_RX_CLASS: return "FM Radio Receiver >> Controls"; >>

[GIT PULL FOR v3.11] uvcvideo Kconfig dependency fix

2013-06-24 Thread Laurent Pinchart
Hi Mauro, Sorry for the late pull request. This small patch fixes a Kconfig dependency that can prevent the kernel from building. Is it still possible to get it to v3.11 ? The following changes since commit ee17608d6aa04a86e253a9130d6c6d00892f132b: [media] imx074: support asynchronous probin

Re: [RFC] Support for events with a large payload

2013-06-24 Thread Sylwester Nawrocki
Hi all, On 06/24/2013 02:57 PM, Hans Verkuil wrote: On Sun June 23 2013 00:46:57 Sakari Ailus wrote: On Wed, Jun 19, 2013 at 08:32:35AM +0200, Hans Verkuil wrote: On Tue June 18 2013 23:22:33 Laurent Pinchart wrote: On Friday 07 June 2013 00:38:04 Sakari Ailus wrote: On Mon, May 13, 2013 at

Re: [PATCH v2] V4L2: add documentation for V4L2 clock helpers and asynchronous probing

2013-06-24 Thread Sylwester Nawrocki
Hi Guennadi, On 06/24/2013 01:20 PM, Guennadi Liakhovetski wrote: Add documentation for the V4L2 clock and V4L2 asynchronous probing APIs to v4l2-framework.txt. Signed-off-by: Guennadi Liakhovetski --- v2: addressed comments by Hans and Laurent (thanks), including (a) language clean up (b) ext

[PATCH 2/2] [media] tlg2300: fix checking firmware in poseidon_probe()

2013-06-24 Thread Alexey Khoroshilov
check_firmware() makes sure firmware is in a device. It returns zero on success and error code otherwise. Also it sets down_firmware flag to 1 if downloading occurs. The only caller poseidon_probe() checks down_firmware flag and returns 0 without any initialization if it is set. That looks very s

[PATCH 1/2] [media] tlg2300: implement error handling in poseidon_probe()

2013-06-24 Thread Alexey Khoroshilov
All poseidon init functions properly return error codes, but they are ignored by poseidon_probe(). The patch implements handling of error cases. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/usb/tlg2300/pd-main.c | 27

cron job: media_tree daily build: WARNINGS

2013-06-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Jun 24 19:00:22 CEST 2013 git branch: test git hash: ee17608d6aa04a86e253a9130d6c6d00892f132b gcc versi

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-24 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On Sat June 22 2013 17:03:03 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds video sync properties as part of endpoint >> properties and also support to parse them in th

[PATCH v2] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" Both synchronous and asynchronous tvp514x subdevice probing is supported by this patch. This patch also fixes the error path by calling media_entity_cleanup() on failure in probe when CONFIG_MEDIA_CONTROLLER is enabled. Signed-off-by: Prabhakar Lad Cc: Guennadi Liakhovets

[PATCH 1/2] media: i2c: tvp7002: remove manual setting of subdev name

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes manual setting of subdev name in the probe, ideally subdev names must be unique. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil --- drivers/media/i2c/tvp7002.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/tvp7002.c b/drivers

[PATCH 0/2] tvp514x/tvp7002 remove manual setting of subdev names

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series removes manual setting of subdev names, as ideally the subdev names must be unique and this would not be the case if there are two devices. Lad, Prabhakar (2): media: i2c: tvp7002: remove manual setting of subdev name media: i2c: tvp514x: remove manua

[PATCH 2/2] media: i2c: tvp514x: remove manual setting of subdev name

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes manual setting of subdev name in the probe, ideally subdev names must be unique. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil --- drivers/media/i2c/tvp514x.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/tvp514x.c b/drivers

AW: AW: mt9p031 shows purple coloured capture

2013-06-24 Thread Florian Neuhaus
Hi Laurent, Laurent Pinchart wrote onĀ 2013-06-22: If I use omap3isp-live to capture a stream on my beagleboard, the first time I start the app, the picture has always a green taint. The second time I start the app, the picture is good. As the camera is reset by a gpio upon dev

Re: [RFC] Support for events with a large payload

2013-06-24 Thread Hans Verkuil
On Sat June 22 2013 22:58:01 Sakari Ailus wrote: > Hi Laurent, > > On Tue, Jun 18, 2013 at 11:22:33PM +0200, Laurent Pinchart wrote: > > On Friday 07 June 2013 00:38:04 Sakari Ailus wrote: > > > On Mon, May 13, 2013 at 02:14:43PM +0200, Hans Verkuil wrote: > > > > Currently the event API allows fo

Re: [RFC] Support for events with a large payload

2013-06-24 Thread Hans Verkuil
On Sun June 23 2013 00:46:57 Sakari Ailus wrote: > Hi Hans, > > On Wed, Jun 19, 2013 at 08:32:35AM +0200, Hans Verkuil wrote: > > On Tue June 18 2013 23:22:33 Laurent Pinchart wrote: > > > Hi Hans and Sakari, > > > > > > On Friday 07 June 2013 00:38:04 Sakari Ailus wrote: > > > > Hi Hans, > > > >

Question: interaction between selection API, ENUM_FRAMESIZES and S_FMT?

2013-06-24 Thread Hans Verkuil
Hi all, While working on extending v4l2-compliance with cropping/selection test cases I decided to add support for that to vivi as well (this would give applications a good test driver to work with). However, I ran into problems how this should be implemented for V4L2 devices (we are not talking

[PATCH v2] V4L2: add documentation for V4L2 clock helpers and asynchronous probing

2013-06-24 Thread Guennadi Liakhovetski
Add documentation for the V4L2 clock and V4L2 asynchronous probing APIs to v4l2-framework.txt. Signed-off-by: Guennadi Liakhovetski --- v2: addressed comments by Hans and Laurent (thanks), including (a) language clean up (b) extended the V4L2 clock API section with an explanation, what special

Re:

2013-06-24 Thread Neslihanp
-- Do you received our last email. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] V4L2: add documentation for V4L2 clock helpers and asynchronous probing

2013-06-24 Thread Laurent Pinchart
Hi Guennadi, On Monday 24 June 2013 10:53:35 Guennadi Liakhovetski wrote: > On Mon, 17 Jun 2013, Laurent Pinchart wrote: > > [snip] > > > > +drivers. > > > + > > > +Bridge drivers in turn have to register a notifier object with an array > > > +of subdevice descriptors, that the bridge device ne

Re: Mistake on the colorspace page in the API doc

2013-06-24 Thread Laurent Pinchart
Hi Wouter, On Monday 24 June 2013 14:47:30 Wouter Thielen wrote: > Hi Laurent, > > Sorry for the late reply. I'll post a patch of your revised version, > but I don't see the documentation anywhere in your git repositories. I > guess I'll download the file (preserving directory structure), update

Re: [PATCH] V4L2: soc-camera: fix uninitialised use compiler warning

2013-06-24 Thread Hans Verkuil
On Mon June 24 2013 11:32:32 Guennadi Liakhovetski wrote: > In scan_async_group() if the size parameter is negative, the sasd pointer > will be used uninitialised: > > drivers/media/platform/soc_camera/soc_camera.c: In function > "soc_camera_host_register": > drivers/media/platform/soc_camera/soc

[PATCH] V4L2: soc-camera: fix uninitialised use compiler warning

2013-06-24 Thread Guennadi Liakhovetski
In scan_async_group() if the size parameter is negative, the sasd pointer will be used uninitialised: drivers/media/platform/soc_camera/soc_camera.c: In function "soc_camera_host_register": drivers/media/platform/soc_camera/soc_camera.c:1514:55: warning: "sasd" may be used uninitialized in this f

[PATCH] V4L2: fix compilation if CONFIG_I2C is undefined

2013-06-24 Thread Guennadi Liakhovetski
i2c_verify_client() is only available, if I2C is enabled. Fix v4l2-async.c compilation if I2C is disabled. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/v4l2-async.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-async.

[PATCH] V4L2: sh_vou: add I2C build dependency

2013-06-24 Thread Guennadi Liakhovetski
The sh_vou driver needs CONFIG_I2C or CONFIG_I2C_MODULE to build, add the respective dependency. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platfo

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Hans Verkuil
On Mon June 24 2013 10:53:37 Prabhakar Lad wrote: > Hi Hans, > > On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote: > > On Mon June 24 2013 10:24:02 Prabhakar Lad wrote: > >> Hi Hans, > >> > >> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: > >> > On Sun June 23 2013 17:48:20 Prabhakar

Samsung i2c subdev drivers that set sd->name

2013-06-24 Thread Hans Verkuil
Hi Sylwester, It came to my attention that several i2c subdev drivers overwrite the sd->name as set by v4l2_i2c_subdev_init with a custom name. This is wrong if it is possible that there are multiple identical sensors in the system. The sd->name must be unique since it is used to prefix kernel me

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote: > On Mon June 24 2013 10:24:02 Prabhakar Lad wrote: >> Hi Hans, >> >> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: >> > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: >> >> Hi Guennadi, >> >> >> >> Thanks for the review. >

Re: [PATCH] V4L2: add documentation for V4L2 clock helpers and asynchronous probing

2013-06-24 Thread Guennadi Liakhovetski
Hi Laurent Thanks for the review. On Mon, 17 Jun 2013, Laurent Pinchart wrote: [snip] > > +drivers. > > + > > +Bridge drivers in turn have to register a notifier object with an array of > > +subdevice descriptors, that the bridge device needs for its operation. This > > s/descriptors,/descript

[GIT PULL FOR v3.11] Updates for 3.11

2013-06-24 Thread Hans Verkuil
(Same as my previous git pull message, but with an additional patch from Prabhakar.) Some async/OF work from Prabhakar (the correct version this time) and assorted improvements and fixes for compiler warnings. Regards, Hans The following changes since commit ee17608d6aa04a86e253a9130d6c

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Hans Verkuil
On Mon June 24 2013 10:24:02 Prabhakar Lad wrote: > Hi Hans, > > On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: > > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: > >> Hi Guennadi, > >> > >> Thanks for the review. > >> > >> On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski > >> wr

[PATCH v6 2/7] mutex: add support for wound/wait style locks

2013-06-24 Thread Maarten Lankhorst
Op 20-06-13 14:23, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Well they've helped me with some of the changes and contributed some >> code and/or fixes, but if acked-by is preferred I'll use that.. > Such contributions can be credited in the changelog, and/or copyright > notices, and

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: >> Hi Guennadi, >> >> Thanks for the review. >> >> On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski >> wrote: >> > On Sat, 22 Jun 2013, Prabhakar Lad wrote: >> > >> >> From: "

Re: [PATCH v2 1/2] media: i2c: tvp7002: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 12:44 PM, Hans Verkuil wrote: > On Sat June 22 2013 19:44:14 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> Both synchronous and asynchronous tvp7002 subdevice probing >> is supported by this patch. > > Can I merge this patch without patch 2/2? Or should I

[GIT PULL FOR v3.11] Updates for 3.11

2013-06-24 Thread Hans Verkuil
Some async/OF work from Prabhakar (the correct version this time) and assorted improvements and fixes for compiler warnings. Regards, Hans The following changes since commit ee17608d6aa04a86e253a9130d6c6d00892f132b: [media] imx074: support asynchronous probing (2013-06-21 16:36:15 -03

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-24 Thread Hans Verkuil
Hi Prabhakar, On Sat June 22 2013 17:03:03 Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > This patch adds video sync properties as part of endpoint > properties and also support to parse them in the parser. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil FYI: using my private email w

Re: [PATCH v2 1/2] media: i2c: tvp7002: add support for asynchronous probing

2013-06-24 Thread Hans Verkuil
On Sat June 22 2013 19:44:14 Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > Both synchronous and asynchronous tvp7002 subdevice probing > is supported by this patch. Can I merge this patch without patch 2/2? Or should I wait with both until the video sync properties have been approved?

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Hans Verkuil
On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: > Hi Guennadi, > > Thanks for the review. > > On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski > wrote: > > On Sat, 22 Jun 2013, Prabhakar Lad wrote: > > > >> From: "Lad, Prabhakar" > >> > >> Both synchronous and asynchronous tvp514x subde