Error handling of usb_submit_urb() is not as all others in imon_probe().
It just unlocks mutexes and returns nonzero leaving all already
allocated resources unfreed.
The patch makes sure all the resources are deallocated.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-
Hi Sylwester,
On Wed, May 22, 2013 at 11:41:50PM +0200, Sylwester Nawrocki wrote:
> [...]
> >>>I'm in favour of using a separate video buffer queue for passing
> >>>low-level
> >>>metadata to user space.
> >>
> >>Sure. I certainly see a need for such an interface. I wouldn't like to
> >>see it
> >
From: Hans Verkuil
Can you try this patch:
---
drivers/media/radio/radio-keene.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/radio-keene.c
b/drivers/media/radio/radio-keene.c
index 4c9ae76..99da3d4 100644
--- a/drivers/media/radio/radio-keene.c
+
Hans, here you are!
Antti Palosaari (1):
keene: add delay in order to settle hardware
Hans Verkuil (1):
Keene
drivers/media/radio/radio-keene.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-medi
It was found by trial and error testing that at least 11 ms delay is
needed before first I/O, otherwise device will skip given command.
Signed-off-by: Antti Palosaari
---
drivers/media/radio/radio-keene.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/radio/radio-keene.c
b/
On 06/03/2013 12:24 AM, Gianluca Gennari wrote:
As suggested by Antti, this patch replaces:
https://patchwork.kernel.org/patch/2649861/
The buffer overflow is fixed by reading only the r820t ID register.
Signed-off-by: Gianluca Gennari
Acked-by: Antti Palosaari
Reviewed-by: Antti Palosaari
On 05/31/2013 08:53 AM, Jussi Jääskeläinen wrote:
Jussi Jääskeläinen jjussi.com> writes:
Older models have: idVendor=0b48, idProduct=300d
Model what I just bought was: idVendor=04b4, idProduct=8613 and this is not
supported!
usb 2-1: New USB device found, idVendor=04b4, idProduct=8613
usb 2-1
As suggested by Antti, this patch replaces:
https://patchwork.kernel.org/patch/2649861/
The buffer overflow is fixed by reading only the r820t ID register.
Signed-off-by: Gianluca Gennari
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
Il 02/06/2013 22:04, Antti Palosaari ha scritto:
> On 06/02/2013 10:51 PM, Gianluca Gennari wrote:
>> Il 02/06/2013 21:30, Antti Palosaari ha scritto:
>>> On 06/02/2013 09:56 PM, Gianluca Gennari wrote:
req_r820t wants a buffer with a size of 5 bytes, but the buffer 'buf'
has a size of 2
On 06/01/2013 05:10 PM, Torsten Seyffarth wrote:
Am 30.05.2013 21:50, schrieb poma:
You've used the original driver provided by Realtek, 'dvb-usb-rtl2832'.
You are currently using GPL'd, 'dvb_usb_v2', 'dvb_usb_rtl28xxu' and
'e4000' designed by Antti & Thomas.
So I will try to find another us
On 06/02/2013 03:19 PM, Hans Petter Selasky wrote:
On 05/30/13 10:00, Hans Petter Selasky wrote:
Hi there,
I need to get in concat with someone that can handle, test and review a
patch for TT-USB2.0. I've found that for certain high-bitrate streams,
the TT-USB2.0 sends more ISOCHRONOUS MPEG dat
On 06/02/2013 07:05 PM, marco caminati wrote:
This usb dongle (0bda:2838) now works for me.
Thanks to all people who worked on it, especially to Gianluca.
Built from git://linuxtv.org/media_build under Linux box 3.8.10-tinycore #3810
SMP Tue Apr 30 15:45:26 UTC 2013 i686 GNU/Linux.
---INFRARED
On 06/02/2013 10:51 PM, Gianluca Gennari wrote:
Il 02/06/2013 21:30, Antti Palosaari ha scritto:
On 06/02/2013 09:56 PM, Gianluca Gennari wrote:
req_r820t wants a buffer with a size of 5 bytes, but the buffer 'buf'
has a size of 2 bytes.
This patch fixes the kernel oops with the r820t driver o
Il 02/06/2013 21:30, Antti Palosaari ha scritto:
> On 06/02/2013 09:56 PM, Gianluca Gennari wrote:
>> req_r820t wants a buffer with a size of 5 bytes, but the buffer 'buf'
>> has a size of 2 bytes.
>>
>> This patch fixes the kernel oops with the r820t driver on old kernels
>> during the probe stage
On 06/02/2013 09:56 PM, Gianluca Gennari wrote:
req_r820t wants a buffer with a size of 5 bytes, but the buffer 'buf'
has a size of 2 bytes.
This patch fixes the kernel oops with the r820t driver on old kernels
during the probe stage.
Successfully tested on a 2.6.32 32 bit kernel (Ubuntu 10.04).
Hello.
On 05/24/2013 02:11 AM, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy .
Signed-off-by: Vladimir Barinov
[Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
values, reordere
req_r820t wants a buffer with a size of 5 bytes, but the buffer 'buf'
has a size of 2 bytes.
This patch fixes the kernel oops with the r820t driver on old kernels
during the probe stage.
Successfully tested on a 2.6.32 32 bit kernel (Ubuntu 10.04).
Hopefully it will also help with the random stabi
The following changes since commit
7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e:
[media] media: pci: remove duplicate checks for EPERM (2013-05-27
09:34:56 -0300)
are available in the git repository at:
git://linuxtv.org/mkrufky/dvb stb0899
for you to fetch changes up to fda0cbcc4878079829b5e
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Jun 2 19:00:19 CEST 2013
git branch: test
git hash: 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e
gcc versi
The following changes since commit
7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e:
[media] media: pci: remove duplicate checks for EPERM (2013-05-27
09:34:56 -0300)
are available in the git repository at:
git://linuxtv.org/mkrufky/dvb stb0899
for you to fetch changes up to fda0cbcc4878079829b5e
The following changes since commit
7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e:
[media] media: pci: remove duplicate checks for EPERM (2013-05-27
09:34:56 -0300)
are available in the git repository at:
git://linuxtv.org/mkrufky/tuners r820t
for you to fetch changes up to 0fe5886ef7a961fc184f
The following changes since commit
7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e:
[media] media: pci: remove duplicate checks for EPERM (2013-05-27
09:34:56 -0300)
are available in the git repository at:
git://linuxtv.org/mkrufky/dvb dib8000
for you to fetch changes up to 441939932b4968cd24a1d
Olivier,
I have regenerated your patch against the most recent codebase, as
your patch no longer applies. (There were changes merged on the 29th
of April that broke it.)
The new patch is attached, but I am reluctant to merge it, as I do not
have any description of the patch, and it lacks a sign-
This usb dongle (0bda:2838) now works for me.
Thanks to all people who worked on it, especially to Gianluca.
Built from git://linuxtv.org/media_build under Linux box 3.8.10-tinycore #3810
SMP Tue Apr 30 15:45:26 UTC 2013 i686 GNU/Linux.
---INFRARED REMOTE---
I also ask if ir remote will be sup
On 05/30/13 10:00, Hans Petter Selasky wrote:
Hi there,
I need to get in concat with someone that can handle, test and review a
patch for TT-USB2.0. I've found that for certain high-bitrate streams,
the TT-USB2.0 sends more ISOCHRONOUS MPEG data than is specified in the
wMaxPacketSize fields. I
From: Hans Verkuil
The saa7134 driver is now converted to the control framework, so drop the
control compat code in saa6752hs.c.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa6752hs.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/dri
From: Hans Verkuil
This driver is independent from saa7134, so there is no reason why this
shouldn't be in media/i2c like all other i2c media drivers.
Signed-off-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 14 +-
drivers/media/i2c/Makefile|1 +
drivers/media/
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-core.c|9 +-
drivers/media/pci/saa7134/saa7134-empress.c | 142 ++
drivers/media/pci/saa7134/saa7134-video.c | 395 ---
drivers/media/pci/saa7134/saa7134.h |
From: Hans Verkuil
Use the saa7134_fh struct for the empress video node as well, drop the dev
pointer from that struct since we can use drvdata for that.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 44 ++
drivers/media/pci/saa7134/saa7134-video.c |
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 19
drivers/media/pci/saa7134/saa7134-video.c | 32 +++
2 files changed, 38 insertions(+), 13 deletions(-)
diff --git a/drivers/media/pci/saa7134/saa7
From: Hans Verkuil
The empress video node can share resource management with the normal
video nodes, thus allowing for code sharing and making the empress node
non-exclusive.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 98 ++-
drivers
From: Hans Verkuil
Missing fields and a missing TRY_FMT implementation in saa6752hs.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa6752hs.c | 58 ---
drivers/media/pci/saa7134/saa7134-empress.c | 13 +-
2 files changed, 47 insertions(+), 24
From: Hans Verkuil
These fields are global, not per-filehandle.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-core.c |1 +
drivers/media/pci/saa7134/saa7134-vbi.c | 11 ++--
drivers/media/pci/saa7134/saa7134-video.c | 102 +++--
drivers/med
From: Hans Verkuil
NO_SYNC was meant for DVB and shouldn't be used anymore.
In this case NO_SIGNAL is a good alternative.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/saa7134/
From: Hans Verkuil
The radio filter function that filters controls that are valid for a radio
device should also accept V4L2_CTRL_CLASS_FM_RX controls.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-ctrls.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/v4
From: Hans Verkuil
- map overlay format values to the supported ranges
- set colorspace
- zero priv field
- fix cliplist handling
- fix field handling
- initialize ovbuf values
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c | 74 -
1 fil
From: Hans Verkuil
These fields are global, not per-filehandle.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c | 57 +++--
drivers/media/pci/saa7134/saa7134.h |4 +-
2 files changed, 32 insertions(+), 29 deletions(-)
diff --git a/
From: Hans Verkuil
This is a global field, not a per-filehandle field.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c |4 ++--
drivers/media/pci/saa7134/saa7134.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/pci/sa
This patch series cleans up saa7134, updating it to the latest frameworks
(except for vb2). Tested with a Beholder BeholdTV M6 empress card.
There is also one small v4l2-ctrls fix in the patch series and the
saa6752hs is moved to media/i2c, since it really has nothing to do with
the saa7134 driver
From: Hans Verkuil
The video and empress nodes can share various ioctls.
Drop the input/std ioctls from the radio node (out of spec).
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-empress.c | 79 +++-
drivers/media/pci/saa7134/saa7134-video.c | 108 +++
From: Hans Verkuil
This information is already available in vfl_type in video_device.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c | 89 +++--
drivers/media/pci/saa7134/saa7134.h |2 -
2 files changed, 32 insertions(+), 59 deleti
From: Hans Verkuil
This is global data, not per-filehandle data.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/saa7134/saa7134-video.c | 33 +++--
drivers/media/pci/saa7134/saa7134.h |9
2 files changed, 21 insertions(+), 21 deletions(-)
diff -
42 matches
Mail list logo
