Re: [PATCH] [media] hdpvr: Simplify the logic that checks for error

2013-05-27 Thread Hans Verkuil
On Mon May 27 2013 14:04:29 Mauro Carvalho Chehab wrote: > At get_video_info, there's a somewhat complex logic that checks > for error. > > That logic can be highly simplified, as usb_control_msg will > only return a negative value, or the buffer length, as it does > the transfers via DMA. > > Wh

Re: [GIT PULL] go7007 firmware updates

2013-05-27 Thread Hans Verkuil
On Mon May 27 2013 23:53:15 Ben Hutchings wrote: > On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote: > > On Mon May 27 2013 18:24:32 Ben Hutchings wrote: > > > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: > > > > Hi Ben, David, > > > > > > > > The go7007 staging driver has been subs

RE: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Inki Dae
> -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Tuesday, May 28, 2013 1:02 AM > To: Rob Clark > Cc: Inki Dae; Maarten Lankhorst; linux-fbdev; YoungJun Cho; Kyungmin Park; > myungjoo.ham; DRI mailing list; linux-arm-k

RE: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Inki Dae
> -Original Message- > From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev- > ow...@vger.kernel.org] On Behalf Of Rob Clark > Sent: Tuesday, May 28, 2013 12:48 AM > To: Inki Dae > Cc: Maarten Lankhorst; Daniel Vetter; linux-fbdev; YoungJun Cho; Kyungmin > Park; myungjoo.ham; DRI m

Re: [PATCH stable < v3.7] media mantis: fix silly crash case

2013-05-27 Thread Ben Hutchings
On Tue, 2013-05-21 at 15:07 +0200, Bjørn Mork wrote: > Hello, > > Please apply mainline commit e1d45ae to any maintained stable kernel > prior to v3.7. I just hit this bug on a Debian 3.2.41-2+deb7u2 kernel: [...] Queued up for 3.2, thanks. Ben. -- Ben Hutchings If at first you don't succeed,

RE: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Inki Dae
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@canonical.com] > Sent: Tuesday, May 28, 2013 12:23 AM > To: Inki Dae > Cc: 'Daniel Vetter'; 'Rob Clark'; 'linux-fbdev'; 'YoungJun Cho'; 'Kyungmin > Park'; 'myungjoo.ham'; 'DRI mailing list'; linux-arm- > ker...@lists

Re: EM28xx - new device ID - Ion "Video Forever" USB capture dongle

2013-05-27 Thread alxgomz
Hi Philip, Thank you for sharing this bit of info. I just bought what I think to be the very same device from local maplin too. I have loaded it using your tweak. Just like you the composite video input works just great, however I can't get any sound captured using the RCA audio leads. The S-vide

Re: [GIT PULL] go7007 firmware updates

2013-05-27 Thread Ben Hutchings
On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote: > On Mon May 27 2013 18:24:32 Ben Hutchings wrote: > > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: > > > Hi Ben, David, > > > > > > The go7007 staging driver has been substantially overhauled for kernel > > > 3.10. > > > As part of

Re: [GIT PULL] go7007 firmware updates

2013-05-27 Thread Hans Verkuil
On Mon May 27 2013 18:24:32 Ben Hutchings wrote: > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: > > Hi Ben, David, > > > > The go7007 staging driver has been substantially overhauled for kernel 3.10. > > As part of that process the firmware situation has been improved as well. > > > > W

cron job: media_tree daily build: WARNINGS

2013-05-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon May 27 19:00:24 CEST 2013 git branch: test git hash: 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e gcc versi

Re: [GIT PULL] go7007 firmware updates

2013-05-27 Thread Ben Hutchings
On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: > Hi Ben, David, > > The go7007 staging driver has been substantially overhauled for kernel 3.10. > As part of that process the firmware situation has been improved as well. > > While Micronas allowed the firmware to be redistributed, it was

Re: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Daniel Vetter
On Mon, May 27, 2013 at 5:47 PM, Rob Clark wrote: > On Mon, May 27, 2013 at 6:38 AM, Inki Dae wrote: >> Hi all, >> >> I have been removed previous branch and added new one with more cleanup. >> This time, the fence helper doesn't include user side interfaces and cache >> operation relevant codes

Re: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Rob Clark
On Mon, May 27, 2013 at 6:38 AM, Inki Dae wrote: > Hi all, > > I have been removed previous branch and added new one with more cleanup. > This time, the fence helper doesn't include user side interfaces and cache > operation relevant codes anymore because not only we are not sure that > coupling t

Re: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Maarten Lankhorst
Hey, Op 27-05-13 12:38, Inki Dae schreef: > Hi all, > > I have been removed previous branch and added new one with more cleanup. > This time, the fence helper doesn't include user side interfaces and cache > operation relevant codes anymore because not only we are not sure that > coupling those tw

Re: InstantFM

2013-05-27 Thread Patrice Levesque
> Good to hear, your device has "software version 0, hardware version 7", > right? If you can confirm then I'll lower the version requirement in > the kernel too match (so that you'll no longer get the warning message). Yes, software version 0. -- --|-- |=

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Daniel Vetter
On Mon, May 27, 2013 at 4:47 PM, Daniel Vetter wrote: > On Mon, May 27, 2013 at 10:21 AM, Peter Zijlstra wrote: >> On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: >>> >> +static inline void ww_acquire_init(struct ww_acquire_ctx *ctx, >>> >> + struct

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Daniel Vetter
On Mon, May 27, 2013 at 10:21 AM, Peter Zijlstra wrote: > On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: >> >> +static inline void ww_acquire_init(struct ww_acquire_ctx *ctx, >> >> + struct ww_class *ww_class) >> >> +{ >> >> + ctx->task = current; >

Creative WebCam Live! Pro recognized, initialised but unusable

2013-05-27 Thread kewlcat
Hello I'm having trouble with a Creative WebCam Live! Pro, usb id 041e:4038 "Creative Technology, Ltd ORITE CCD Webcam [PC370R]" This device is supposed to be "supported" but is marked as "untested". Apparently it works up to the point where sq930x fail with this message : gspca_sq930x: reg_r

[PATCH] [media] hdpvr: Simplify the logic that checks for error

2013-05-27 Thread Mauro Carvalho Chehab
At get_video_info, there's a somewhat complex logic that checks for error. That logic can be highly simplified, as usb_control_msg will only return a negative value, or the buffer length, as it does the transfers via DMA. While here, document why this particular driver is returning -EFAULT, inste

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 13:15, Peter Zijlstra schreef: > On Mon, May 27, 2013 at 12:52:00PM +0200, Maarten Lankhorst wrote: >> The reason ttm needed it was because there was another lock that interacted >> with the ctx lock in a weird way. The ww lock it was using was inverted with >> another >> lock, so it h

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Mon, May 27, 2013 at 12:52:00PM +0200, Maarten Lankhorst wrote: > The reason ttm needed it was because there was another lock that interacted > with the ctx lock in a weird way. The ww lock it was using was inverted with > another > lock, so it had to grab that lock first, perform a trylock on

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 12:24, Peter Zijlstra schreef: > On Mon, May 27, 2013 at 12:01:50PM +0200, Maarten Lankhorst wrote: >>> Again, early.. monday.. would a trylock, even if successful still need >>> the ctx? >> No ctx for trylock is supported. You can still do a trylock while >> holding a context, but the

RE: Introduce a new helper framework for buffer synchronization

2013-05-27 Thread Inki Dae
Hi all, I have been removed previous branch and added new one with more cleanup. This time, the fence helper doesn't include user side interfaces and cache operation relevant codes anymore because not only we are not sure that coupling those two things, synchronizing caches and buffer access betwe

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Mon, May 27, 2013 at 12:01:50PM +0200, Maarten Lankhorst wrote: > > Again, early.. monday.. would a trylock, even if successful still need > > the ctx? > No ctx for trylock is supported. You can still do a trylock while > holding a context, but the mutex won't be a part of the context. > Normal

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 10:21, Peter Zijlstra schreef: > On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: +static inline void ww_acquire_init(struct ww_acquire_ctx *ctx, + struct ww_class *ww_class) +{ + ctx->task = current; + do { +

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 11:13, Peter Zijlstra schreef: > On Mon, May 27, 2013 at 10:26:39AM +0200, Maarten Lankhorst wrote: >> Op 27-05-13 10:00, Peter Zijlstra schreef: >>> On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: >> +- Functions to only acquire a single w/w mutex, which results

Re: [PATCH 22/24] drivers/media/radio/radio-maxiradio: Convert to module_pci_driver

2013-05-27 Thread Hans Verkuil
On Mon 27 May 2013 04:31:59 Libo Chen wrote: > use module_pci_driver instead of init/exit, make code clean > > Signed-off-by: Libo Chen Acked-by: Hans Verkuil > --- > drivers/media/radio/radio-maxiradio.c | 13 + > 1 files changed, 1 insertions(+), 12 deletions(-) > > diff --gi

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Mon, May 27, 2013 at 10:26:39AM +0200, Maarten Lankhorst wrote: > Op 27-05-13 10:00, Peter Zijlstra schreef: > > On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: > +- Functions to only acquire a single w/w mutex, which results in the > exact same > + semantics

Re: [PATCH] Fix spelling of Qt in .desktop file (typo)

2013-05-27 Thread Hans Verkuil
On Sun 26 May 2013 10:15:51 Diego Viola wrote: > Proper spelling of Qt is Qt, not QT. "QT" is often confused with > QuickTime, here is a minor patch to fix this issue in the .desktop file. Thanks, I've committed this. Regards, Hans > > Signed-off-by: Diego Viola > --- > utils/qv4l2/

Re: [PATCH] media: i2c: mt9p031: add OF support

2013-05-27 Thread Sascha Hauer
On Sun, May 26, 2013 at 06:38:54PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > Alongside this patch sorts the header inclusion alphabetically. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Car

Re: [PATCH v4] adv7180: add more subdev video ops

2013-05-27 Thread Hans Verkuil
Hi Sergei, Vladimir, Just one small remaining issue: On Thu 23 May 2013 22:05:42 Sergei Shtylyov wrote: > From: Vladimir Barinov > > Add subdev video ops for ADV7180 video decoder. This makes decoder usable on > the soc-camera drivers. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Ser

Re: [PATCH v5] V4L2: I2C: ML86V7667 video decoder driver

2013-05-27 Thread Hans Verkuil
Hi Sergei, Vladimir, Just two small things to fix, see below: On Thu 23 May 2013 22:07:32 Sergei Shtylyov wrote: > From: Vladimir Barinov > > Add OKI Semiconductor ML86V7667 video decoder driver. > > Signed-off-by: Vladimir Barinov > [Sergei: added v4l2_device_unregister_subdev() call to the

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Wed, May 22, 2013 at 06:49:04PM +0200, Daniel Vetter wrote: > - _slow functions can check whether all acquire locks have been > released and whether the caller is indeed blocking on the contending > lock. Not doing so could either result in needless spinning instead of > blocking (when blocking

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 10:00, Peter Zijlstra schreef: > On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: +- Functions to only acquire a single w/w mutex, which results in the exact same + semantics as a normal mutex. These functions have the _single postfix. >>> This is miss

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: > >> +static inline void ww_acquire_init(struct ww_acquire_ctx *ctx, > >> + struct ww_class *ww_class) > >> +{ > >> + ctx->task = current; > >> + do { > >> + ctx->stamp = atomic_long_inc_return

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Peter Zijlstra
On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: > >> +- Functions to only acquire a single w/w mutex, which results in the > >> exact same > >> + semantics as a normal mutex. These functions have the _single postfix. > > This is missing rationale. > trylock_single is useful wh

[PATCH] [media] s5p-mfc: Remove special clock usage in driver

2013-05-27 Thread Arun Kumar K
MFC uses two clocks - MFC gate clock and special clock which is named as "sclk_mfc" in exynos4 and "aclk_333" in exynos5 SoC. The driver was doing just a clk_prepare on this special clock without a clk_enable call. As this sclk is the parent of gate clock, it gets prepared and enabled along with th