Re: mt9p031 shows purple coloured capture

2013-05-16 Thread Andrei Andreyanau
Hi, Chris, No, I didn't try this, but I'll try. Also I was thinking that this issue appears because the bus width is not 12 bits as needed by the datasheet, but 10 bits (as it is limited by the hardware) so I was thinking that it may cause this issue to appear. Regards, Andrei On 05/16/2013 05:

Re: [PATCH 1/7] media: davinci: vpif: remove unwanted header includes

2013-05-16 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 16, 2013 at 6:32 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Thursday 16 May 2013 18:28:16 Lad Prabhakar wrote: >> From: Lad, Prabhakar >> >> Signed-off-by: Lad, Prabhakar >> --- >> drivers/media/platform/davin

Re: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata

2013-05-16 Thread Prabhakar Lad
Hi Sakari, Thanks for the review. On Fri, May 17, 2013 at 4:07 AM, Sakari Ailus wrote: > Hi Prabhakar, > > Thanks for the patch! > > On Wed, May 15, 2013 at 05:27:17PM +0530, Lad Prabhakar wrote: >> diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c >> index 65853ee..8cddcd0

[PATCH v4 2/2] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_drv.c

2013-05-16 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_drv.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mixer

[PATCH v4 1/2] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in hdmi_drv.c

2013-05-16 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- Based on for-next branch of git://linuxtv.org/snawrocki/samsung.git Changes since v3: Renamed the function and changed the prototype of {hdmi,mxr}_reset_clocks as suggested

Re: Introduce a new helper framework for buffer synchronization

2013-05-16 Thread Daniel Vetter
On Wed, May 15, 2013 at 4:06 PM, Rob Clark wrote: > So while it seems nice and orthogonal/clean to couple cache and > synchronization and handle dma->cpu and cpu->cpu and cpu->dma in the > same generic way, but I think in practice we have to make things more > complex than they otherwise need to b

Re: Media controller versus int device in V4L2

2013-05-16 Thread Sakari Ailus
Hi Phillip, On Mon, May 13, 2013 at 06:03:38PM +, Phillip Norisez wrote: > Hans, > > I fear that in my ignorance of V4L2, I have backed my client into a > corner, so to speak. I am developing embedded Linux firmware for boards > intended to driver video sensors within a medical device. As suc

Re: [PATCH RESEND] media: davinci: vpbe: fix checkpatch warning for CamelCase

2013-05-16 Thread Sakari Ailus
On Fri, May 03, 2013 at 05:09:25PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > This patch fixes checkpatch warning to avoid CamelCase. > > Signed-off-by: Lad, Prabhakar Thanks! Reviewed-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata

2013-05-16 Thread Sakari Ailus
Hi Prabhakar, Thanks for the patch! On Wed, May 15, 2013 at 05:27:17PM +0530, Lad Prabhakar wrote: > diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c > index 65853ee..8cddcd0 100644 > --- a/drivers/media/i2c/ths7303.c > +++ b/drivers/media/i2c/ths7303.c > @@ -356,9 +356,7 @@

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-16 Thread Sakari Ailus
Hi Andrzej, Thanks for the patchset! On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: > This patch adds managed version of initialization > function for v4l2 control handler. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > ---

[PATCH v4 3/3] ARM: shmobile: BOCK-W: enable VIN and ML86V7667 in defconfig

2013-05-16 Thread Sergei Shtylyov
From: Vladimir Barinov Add the VIN and ML86V7667 drivers to 'bockw_defconfig'. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov --- arch/arm/configs/bockw_defconfig |7 +++ 1 file changed, 7 insertions(+) Index: renesas/arch/arm/configs/bockw_defconfig

[PATCH v4 2/3] ARM: shmobile: BOCK-W: add VIN and ML86V7667 support

2013-05-16 Thread Sergei Shtylyov
From: Vladimir Barinov Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data. Signed-off-by: Vladimir Barinov [Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated

[PATCH v4 1/3] ARM: shmobile: r8a7778: add VIN support

2013-05-16 Thread Sergei Shtylyov
From: Vladimir Barinov Add VIN clocks and platform devices on R8A7778 SoC; add function to register the VIN platform devices. Signed-off-by: Vladimir Barinov [Sergei: added 'id' parameter check to r8a7779_add_vin_device(), used '*pdata' in *sizeof* operator there, renamed some variables, annota

[PATCH v4 0/3] R8A7778/BOCK-W R-Car VIN driver support

2013-05-16 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130515v2' tag and my recent yet unapplied patches. Here we add the VIN platform code working on the R8A7778/BOCK-W with ML86V7667. The driver patch also applies (with offsets) to Mauro's 'media_tre

Re: mt9p031 shows purple coloured capture

2013-05-16 Thread Guennadi Liakhovetski
On Thu, 16 May 2013, Andrei Andreyanau wrote: > Hi, Laurent, > I have an issue with the mt9p031 camera. The kernel version I use > uses soc camera framework as well as camera does. And I have > the following thing which appears randomly while capturing the > image using gstreamer. When I start the

cron job: media_tree daily build: ERRORS

2013-05-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 16 19:00:21 CEST 2013 git branch: test git hash: 4237c09a63906b980741725da63f85e454caec02 gcc versi

[media] cx25821 regression from 3.9: BUG: bad unlock balance detected!

2013-05-16 Thread Sander Eikelenboom
Hi Hans / Mauro, With 3.10.0-rc1 (including the cx25821 changes from Hans), I get the bug below which wasn't present with 3.9. -- Sander [ 53.004968] = [ 53.004968] [ BUG: bad unlock balance detected! ] [ 53.004968] 3.10.0-rc1-20130516-jens+ #

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam

2013-05-16 Thread Laurent Pinchart
Hi Joseph, On Thursday 16 May 2013 12:07:54 Joseph Salisbury wrote: > On 05/16/2013 08:03 AM, Laurent Pinchart wrote: > > On Wednesday 15 May 2013 16:38:48 joseph.salisb...@canonical.com wrote: > >> From: Joseph Salisbury > >> > >> BugLink: http://bugs.launchpad.net/bugs/1180409 > >> > >> Omini

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam

2013-05-16 Thread Joseph Salisbury
On 05/16/2013 08:03 AM, Laurent Pinchart wrote: > Hi Joseph, > > Thank you for the patch. Thanks for the feedback. > > On Wednesday 15 May 2013 16:38:48 joseph.salisb...@canonical.com wrote: >> From: Joseph Salisbury >> >> BugLink: http://bugs.launchpad.net/bugs/1180409 >> >> OminiVision webcam 0

Re: [RFCv2] Motion Detection API

2013-05-16 Thread Sylwester Nawrocki
On 05/16/2013 09:54 AM, Hans Verkuil wrote: #define V4L2_EVENT_MOTION_DET 5 /** * struct v4l2_event_motion_det - motion detection event * @flags: if set to V4L2_EVENT_MD_VALID_FRAME, then the * frame_sequence field is val

Re: omap3 : isp clock a : Difference between dmesg frequency and actual frequency with 3.9

2013-05-16 Thread jean-philippe francois
2013/5/16 Laurent Pinchart : > Hi Jean-Philippe, > > On Thursday 16 May 2013 10:21:14 jean-philippe francois wrote: >> 2013/5/15 jean-philippe francois : >> > Hi, >> > >> > I am working on a dm3730 based camera. >> > The sensor input clock is provided by the cpu via the CAM_XCLK pin. >> > Here is t

[PATCH RFC v2] media: OF: add sync-on-green endpoint property

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar This patch adds "sync-on-green" property as part of endpoint properties and also support to parse them in the parser. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Saka

mt9p031 shows purple coloured capture

2013-05-16 Thread Andrei Andreyanau
Hi, Laurent, I have an issue with the mt9p031 camera. The kernel version I use uses soc camera framework as well as camera does. And I have the following thing which appears randomly while capturing the image using gstreamer. When I start the capture for the first time, it shows the correct image (

Re: [PATCH 1/7] media: davinci: vpif: remove unwanted header includes

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Thursday 16 May 2013 18:28:16 Lad Prabhakar wrote: > From: Lad, Prabhakar > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/davinci/vpif.c |7 --- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/drivers/medi

[PATCH 5/7] media: davinci: vpif_capture: Convert to devm_* api

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. use module_platform_driver to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 75 +

[PATCH 4/7] media: davinci: vpif_capture: remove unwanted header inclusion and sort them alphabetically

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar This patch removes unwanted header inclusion and sorts them alphabetically Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 21 + drivers/media/platform/davinci/vpif_capture.h |6 ++ 2 files changed, 7 insertio

[PATCH 3/7] media: davinci: vpif: remove unnecessary braces around defines

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index 7d028ca..1f2b2c6 100644 --- a/drivers

[PATCH 7/7] media: davinci: vpif_display: Convert to devm_* api

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. use module_platform_driver to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 62 +

[PATCH 6/7] media: davinci: vpif_display: remove unwanted header inclusion and sort them alphabetically

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar This patch removes unwanted header inclusion and sorts them alphabetically Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 23 +++ drivers/media/platform/davinci/vpif_display.h |6 ++ 2 files changed, 5 insert

[PATCH 2/7] media: davinci: vpif: Convert to devm_* api

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c | 27 --- 1 files changed, 4 insertio

[PATCH 1/7] media: davinci: vpif: remove unwanted header includes

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index ea82a8b..d354d50 100644 --- a/drivers/

[PATCH 0/7] media: davinci: vpif trivial cleanup

2013-05-16 Thread Lad Prabhakar
From: Lad, Prabhakar This patch series cleans the VPIF driver, uses devm_* api wherever required and uses module_platform_driver() to simplify the code. This patch series applies on 3.10.rc1 and is tested on OMAP-L138. Lad, Prabhakar (7): media: davinci: vpif: remove unwanted header includes

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: >> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: >> > Hi Prabhakar, >> >> [Snip] >> >> >> + >> >> + pdata = devm_kzalloc(&client->dev, size

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: > On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > [Snip] > > >> + > >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); > >> + if (!pdata) > > > > I've started playing wit

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: > Hi Prabhakar, > [Snip] >> + >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); >> + if (!pdata) > > I've started playing with the V4L2 OF bindings, and realized that should > s

Re: [PATCH RFC V4 FINAL] media: i2c: mt9p031: add OF support

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Monday 13 May 2013 10:47:04 Lad Prabhakar wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > Alongside this patch sorts the header inclusion alphabetically. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Lau

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Tuesday 14 May 2013 16:30:36 Lad Prabhakar wrote: > From: Lad, Prabhakar > > add OF support for the tvp514x driver. Alongside this patch > removes unnecessary header file inclusion and sorts them alphabetically. > > Signed-off-by: Lad, Prabhakar > Cc:

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam

2013-05-16 Thread Laurent Pinchart
Hi Joseph, Thank you for the patch. On Wednesday 15 May 2013 16:38:48 joseph.salisb...@canonical.com wrote: > From: Joseph Salisbury > > BugLink: http://bugs.launchpad.net/bugs/1180409 > > OminiVision webcam 0x05a9:0x2643 needs the same UVC_QUIRK_PROBE_DEF as other > OmniVision models to work

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-16 Thread Laurent Pinchart
Hi Prabhakar, On Thursday 16 May 2013 17:18:00 Prabhakar Lad wrote: > On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad wrote: > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart wrote: > >> On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: > >>> From: Lad, Prabhakar > >>> > >>> remove init_

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart > wrote: >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Wednesday 15 May 2013 17:27:18 Lad Prabhakar wrote: >>> From: Lad, Pr

Re: omap3 : isp clock a : Difference between dmesg frequency and actual frequency with 3.9

2013-05-16 Thread Laurent Pinchart
Hi Jean-Philippe, On Thursday 16 May 2013 10:21:14 jean-philippe francois wrote: > 2013/5/15 jean-philippe francois : > > Hi, > > > > I am working on a dm3730 based camera. > > The sensor input clock is provided by the cpu via the CAM_XCLK pin. > > Here is the corresponding log : > > > > [9.

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Thu, May 16, 2013 at 4:15 PM, Sylwester Nawrocki wrote: > On 05/15/2013 02:52 PM, Lad Prabhakar wrote: >> >> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt >> inde

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
Hi Sylwester, On Thu, May 16, 2013 at 4:13 PM, Sylwester Nawrocki wrote: > Hi, > > > On 05/16/2013 06:53 AM, Prabhakar Lad wrote: [Snip] >> May be we rename "field-active" to "fid-pol" ? > > > I guess we failed to clearly describe the 'field-even-active' property then. > It seems to be exact

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Sylwester Nawrocki
On 05/15/2013 02:52 PM, Lad Prabhakar wrote: diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index e022d2d..6bf87d0 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentati

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Sylwester Nawrocki
Hi, On 05/16/2013 06:53 AM, Prabhakar Lad wrote: diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt index >> e022d2d..6bf87d0 100644 >> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt >

Re: omap3 : isp clock a : Difference between dmesg frequency and actual frequency with 3.9

2013-05-16 Thread jean-philippe francois
2013/5/15 jean-philippe francois : > Hi, > > I am working on a dm3730 based camera. > The sensor input clock is provided by the cpu via the CAM_XCLK pin. > Here is the corresponding log : > > [9.115966] Entering cam_set_xclk > [9.119781] omap3isp omap3isp: isp_set_xclk(): cam_xclka set to 2

[PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-16 Thread Andrzej Hajda
This patch adds managed version of initialization function for v4l2 control handler. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- v3: - removed managed cleanup v2: - added missing struct device forward declaration, - corre

[PATCH RFC v3 3/3] media: added managed v4l2/i2c subdevice initialization

2013-05-16 Thread Andrzej Hajda
This patch adds managed version of initialization function for v4l2/i2c subdevices. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- v3: - removed devm_v4l2_subdev_(init|free), v2: - changes of v4l2-ctrls.h moved to proper patch ---

[PATCH RFC v3 1/3] media: added managed media entity initialization

2013-05-16 Thread Andrzej Hajda
This patch adds managed versions of initialization function for media entity. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- v3: - removed managed cleanup --- drivers/media/media-entity.c | 44 ++

[PATCH RFC v3 0/3] added managed media/v4l2 initialization

2013-05-16 Thread Andrzej Hajda
This is the 3rd version of managed initializations for media/v4l2. Patches are adjusted according to Hans and Laurent suggestions. Details of changes documented in individual patches. *** BLURB HERE *** Andrzej Hajda (3): media: added managed media entity initialization media: added managed v

Re: [RFCv2] Motion Detection API

2013-05-16 Thread Hans Verkuil
Hi Sylwester! On Wed 15 May 2013 17:23:33 Sylwester Nawrocki wrote: > Hi Hans, > > On 05/13/2013 11:32 AM, Hans Verkuil wrote: > > This RFC looks at adding support for motion detection to V4L2. This is the > > main > > missing piece that prevents the go7007 and solo6x10 drivers from being moved

Re: omap3 : isp clock a : Difference between dmesg frequency and actual frequency with 3.9

2013-05-16 Thread jean-philippe francois
2013/5/15 jean-philippe francois : > Hi, > > I am working on a dm3730 based camera. > The sensor input clock is provided by the cpu via the CAM_XCLK pin. > Here is the corresponding log : > > [9.115966] Entering cam_set_xclk > [9.119781] omap3isp omap3isp: isp_set_xclk(): cam_xclka set to 2