Re: [PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-15 Thread Sachin Kamat
Hi Sylwester, On 15 April 2013 20:51, Sylwester Nawrocki wrote: >> - if (!fimc->drv_data || fimc->id >= fimc->drv_data->num_entities || >> - fimc->id < 0) { >> - dev_err(dev, "Invalid driver data or device id (%d/%d)\n", >> - fimc->id, fimc->drv_data->

[PATCH 5/5] [media] exynos4-is: Remove unused functions

2013-04-15 Thread Sachin Kamat
These functions do not have any callers yet and hence could be removed for now. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-is-param.c | 21 - drivers/media/platform/exynos4-is/fimc-is-regs.c | 12 2 files changed, 33 deletions(-)

[PATCH 4/5] [media] exynos4-is: Initialize 'sensor' before using

2013-04-15 Thread Sachin Kamat
Add missing initialization code to the 'sensor' data structure variable before using it. Signed-off-by: Sachin Kamat --- Only compile tested. --- drivers/media/platform/exynos4-is/fimc-is-sensor.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exy

[PATCH 2/5] [media] exynos4-is: Convert index variable to signed

2013-04-15 Thread Sachin Kamat
index variable is used to check the validity of the data by testing for negative values. Hence make it signed. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-core.h |2 +- drivers/media/platform/exynos4-is/fimc-lite.h |2 +- 2 files changed, 2 insertions(+), 2 del

[PATCH 3/5] [media] exynos4-is: Staticize local symbols

2013-04-15 Thread Sachin Kamat
These symbols are used only in their respective files and hence should be made static. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-is-i2c.c |2 +- drivers/media/platform/exynos4-is/fimc-is-param.c |6 +++--- drivers/media/platform/exynos4-is/fimc-is.c |

[PATCH 1/5] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-15 Thread Sachin Kamat
If fimc->drv_data is NULL, then fimc->drv_data->num_entities would cause NULL pointer dereferencing. Hence remove it from print statement. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH -next] media:

2013-04-15 Thread David Rientjes
On Tue, 9 Apr 2013, Antti Palosaari wrote: > On 04/08/2013 08:47 PM, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Fix randconfig error when USB is not enabled: > > > > ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] > > undefined! > > > > Signed-off-by: Randy Dunlap

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Apr 2013 18:26:56 +0200 Frank Schäfer escreveu: > Am 15.04.2013 14:51, schrieb Mauro Carvalho Chehab: > > Em Sun, 14 Apr 2013 22:35:05 +0200 > > Frank Schäfer escreveu: > > > >> Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: > >>> Em Sat, 13 Apr 2013 19:46:20 +0200 > >>> Frank Sc

Re: Patchwork and em28xx delegates

2013-04-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Apr 2013 23:02:51 +0200 Frank Schäfer escreveu: > Am 15.04.2013 18:50, schrieb Mauro Carvalho Chehab: > > Em Mon, 15 Apr 2013 18:41:44 +0200 > > Frank Schäfer escreveu: > > > >> I've just noticed that my 2 pending em28xx patches have got delegate > >> assigned: > >> > >> https://patch

Patch mceusb.c -- Kernel 3.9-rc6

2013-04-15 Thread William Steidtmann
Fix mceusb_cmdsize() which returns incorrect datasize=0 for sub-commands MCE_RSP_GETPORTSTATUS, MCE_RSP_GETWAKESOURCE, MCE_RSP_EQDEVDETAILS, MCE_RSP_EQEMVER, and MCE_RSP_EQIRNUMPORTS. Change mceusb_cmdsize() name to reflect that it returns data size not cmd size. Signed-off-by: William Steidt

Re: Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 18:50, schrieb Mauro Carvalho Chehab: > Em Mon, 15 Apr 2013 18:41:44 +0200 > Frank Schäfer escreveu: > >> I've just noticed that my 2 pending em28xx patches have got delegate >> assigned: >> >> https://patchwork.linuxtv.org/patch/17834/ >> => delegated to mkrufky >> >> https://patchw

Re: [PATCH] bttv: Add CyberVision CV06

2013-04-15 Thread Ondrej Zary
On Sunday 14 April 2013 23:26:21 Ondrej Zary wrote: > Add CyberVision CV06 4-camera card (from CyberVision SV card kit): > http://www.cybervision.com.tw/products-swcard_kits-sv.html > > There are some interesting things on the card but they're not supported: > 4 LEDs, a connector with 4 IN and 4 OU

[PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam

2013-04-15 Thread Kamal Mostafa
BugLink: https://bugs.launchpad.net/bugs/1168430 OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the same UVC_QUIRK_PROBE_DEF as other OmniVision model to be recognized consistently. Signed-off-by: Kamal Mostafa --- drivers/media/usb/uvc/uvc_driver.c |9 + 1 file

cron job: media_tree daily build: ERRORS

2013-04-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 15 19:00:18 CEST 2013 git branch: test git hash: 4c41dab4d69fb887884dc571fd70e4ddc41774fb gcc versi

Re: Patchwork and em28xx delegates

2013-04-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Apr 2013 18:41:44 +0200 Frank Schäfer escreveu: > I've just noticed that my 2 pending em28xx patches have got delegate > assigned: > > https://patchwork.linuxtv.org/patch/17834/ > => delegated to mkrufky > > https://patchwork.linuxtv.org/patch/17928/ (Obsoleted) > => delegated to

Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
I've just noticed that my 2 pending em28xx patches have got delegate assigned: https://patchwork.linuxtv.org/patch/17834/ => delegated to mkrufky https://patchwork.linuxtv.org/patch/17928/ (Obsoleted) => delegated to hverkuil Ist this a patchwork failure or is the new submaintainers workflow

Re: Patch update notification: 1 patch updated

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 17:23, schrieb Patchwork: > Hello, > > The following patch (submitted by you) has been updated in patchwork: > > * em28xx: add basic support for the "SpeedLink Vicious And Devine Laplace" > webcam > - http://patchwork.linuxtv.org/patch/17928/ > was: New > now: Under Rev

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 14:51, schrieb Mauro Carvalho Chehab: > Em Sun, 14 Apr 2013 22:35:05 +0200 > Frank Schäfer escreveu: > >> Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: >>> Em Sat, 13 Apr 2013 19:46:20 +0200 >>> Frank Schäfer escreveu: >>> Am 13.04.2013 19:04, schrieb Mauro Carvalho Cheha

Re: [PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-15 Thread Sylwester Nawrocki
Hi Sachin, On 04/15/2013 02:03 PM, Sachin Kamat wrote: > If fimc->drv_data is NULL, then fimc->drv_data->num_entities would > cause NULL pointer dereferencing. > While at it also remove the check for fimc->id being negative as 'id' is > unsigned variable and can't be less than 0. > > Signed-off-b

[GIT PULL FOR v3.10] Two bug fixes and a MAINTAINERS update

2013-04-15 Thread Hans Verkuil
It makes sense to get this in 3.10. Regards, Hans The following changes since commit 4c41dab4d69fb887884dc571fd70e4ddc41774fb: [media] rc: fix single line indentation of keymaps/Makefile (2013-04-14 22:51:41 -0300) are available in the git repository at: git://linuxtv.org/hverkui

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-15 Thread Hans Verkuil
Hi Scott! On Sat April 13 2013 01:52:58 Scott Jiang wrote: > This is a bridge driver for blackfin diplay device. > It can work with ppi or eppi interface. DV timings > are supported. Thanks for the patch. There are a number of comments below. For the most part you can save a lot of code by making

Re: [PATCH 0/3] em28xx: clean up end extend the GPIO port handling

2013-04-15 Thread Mauro Carvalho Chehab
Em Sun, 14 Apr 2013 22:32:34 +0300 Antti Palosaari escreveu: > On 04/14/2013 04:32 AM, Mauro Carvalho Chehab wrote: > > Em Sat, 13 Apr 2013 17:37:26 +0300 > > Antti Palosaari escreveu: > > > >> On 04/13/2013 05:25 PM, Mauro Carvalho Chehab wrote: > >>> Em Sat, 13 Apr 2013 16:15:39 +0300 > >>> An

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-15 Thread Prabhakar Lad
Hi Guennadi, On Fri, Apr 12, 2013 at 9:10 PM, Guennadi Liakhovetski wrote: > Currently bridge device drivers register devices for all subdevices > synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor > is attached to a video bridge device, the bridge driver will create an I2

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Antti Palosaari
On 04/15/2013 03:51 PM, Mauro Carvalho Chehab wrote: Em Sun, 14 Apr 2013 22:35:05 +0200 Frank Schäfer escreveu: I checked the em25xx datasheet (excerpt) and it talks about separate registers for GPIO configuration (unfortunately without explaining their function in detail). Interesting. The

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Mauro Carvalho Chehab
Em Sun, 14 Apr 2013 22:35:05 +0200 Frank Schäfer escreveu: > Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: > > Em Sat, 13 Apr 2013 19:46:20 +0200 > > Frank Schäfer escreveu: > > > >> Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: > >>> Em Sat, 13 Apr 2013 17:33:28 +0200 > >>> Frank Sc

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Apr 2013 12:19:23 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Sunday 14 April 2013 16:59:58 Mauro Carvalho Chehab wrote: > > Em Fri, 12 Apr 2013 11:13:06 +0200 Laurent Pinchart escreveu: > > > Hi Mauro, > > > > > > The following changes since commit > 81e096c8ac6a064854c2157

[PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-15 Thread Sachin Kamat
If fimc->drv_data is NULL, then fimc->drv_data->num_entities would cause NULL pointer dereferencing. While at it also remove the check for fimc->id being negative as 'id' is unsigned variable and can't be less than 0. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-core.c

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-15 Thread Sylwester Nawrocki
Hi Guennadi, On 04/12/2013 05:40 PM, Guennadi Liakhovetski wrote: > Currently bridge device drivers register devices for all subdevices > synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor > is attached to a video bridge device, the bridge driver will create an I2C > device

[GIT PULL FOR v3.9] cx25821: do not expose broken video output streams

2013-04-15 Thread Hans Verkuil
Hi Mauro, As requested: the cx25821 fix to prevent it exposing the broken video output streams posing a security risk. Regards, Hans The following changes since commit 4c41dab4d69fb887884dc571fd70e4ddc41774fb: [media] rc: fix single line indentation of keymaps/Makefile (2013-04-14 2

Re: [PATCH v8 0/7] V4L2 clock and async patches and soc-camera example

2013-04-15 Thread Laurent Pinchart
Hi, On Friday 12 April 2013 14:48:17 Sylwester Nawrocki wrote: > On 04/12/2013 08:13 AM, Guennadi Liakhovetski wrote: > > On Thu, 11 Apr 2013, Sylwester Nawrocki wrote: > >> On 04/11/2013 11:59 AM, Guennadi Liakhovetski wrote: > >>> On Mon, 8 Apr 2013, Guennadi Liakhovetski wrote: [snip] > >> A

[GIT PULL FOR v3.10] cx25821: driver overhaul

2013-04-15 Thread Hans Verkuil
Hi Mauro, This is the full pull request for all the cx25821 changes for 3.10. It's identical to the patch series posted Sunday, but adds one last patch removing cx25821-audio-upstream.c from the Makefile. Hopefully I can add that functionality back as a proper alsa device for 3.11 or 3.12 at the l

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-15 Thread Laurent Pinchart
Hi Mauro, On Sunday 14 April 2013 16:59:58 Mauro Carvalho Chehab wrote: > Em Fri, 12 Apr 2013 11:13:06 +0200 Laurent Pinchart escreveu: > > Hi Mauro, > > > > The following changes since commit 81e096c8ac6a064854c2157e0bf802dc4906678c: > > [media] budget: Add support for Philips Semi Sylt PCI r