Re: [PATCH] solo6x10: Approximate frame intervals with non-standard denominator

2013-04-10 Thread Hans Verkuil
Hi Ismael! A quick review below: On Wed April 10 2013 23:28:05 Ismael Luceno wrote: > Instead of falling back to 1/25 (PAL) or 1/30 (NTSC). > > Signed-off-by: Ismael Luceno > > # Please enter the commit message for your changes. Lines starting > # with '#' will be ignored, and an empty message

Re: [PATCH v8 1/7] media: V4L2: add temporary clock helpers

2013-04-10 Thread Barry Song
Hi Guennadi, > Typical video devices like camera sensors require an external clock source. > Many such devices cannot even access their hardware registers without a > running clock. These clock sources should be controlled by their consumers. > This should be performed, using the generic clock fra

Re: [PATCH 11/30] [media] exynos: remove unnecessary header inclusions

2013-04-10 Thread Mauro Carvalho Chehab
Em Thu, 11 Apr 2013 02:04:53 +0200 Arnd Bergmann escreveu: > In multiplatform configurations, we cannot include headers > provided by only the exynos platform. Fortunately a number > of drivers that include those headers do not actually need > them, so we can just remove the inclusions. > > Sign

[PATCH 11/30] [media] exynos: remove unnecessary header inclusions

2013-04-10 Thread Arnd Bergmann
In multiplatform configurations, we cannot include headers provided by only the exynos platform. Fortunately a number of drivers that include those headers do not actually need them, so we can just remove the inclusions. Signed-off-by: Arnd Bergmann Cc: linux-media@vger.kernel.org Cc: Mauro Carva

[PATCH 00/30] ARM: exynos multiplatform support

2013-04-10 Thread Arnd Bergmann
Hi everyone, I have updated my series for multiplatform support of the ARM exynos platform, based on what is currently queued up in arm-soc. It would be really nice to still get this merged for 3.10. A lot of the patches are really trivial, but there are some complex ones as well. To all subsyst

Re: linux-next: Tree for Apr 10 (media and OF)

2013-04-10 Thread Sylwester Nawrocki
On 04/10/2013 11:36 PM, Randy Dunlap wrote: On 04/10/13 01:48, Stephen Rothwell wrote: Hi all, Changes since 20130409: on i386: ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined! 'of_get_next_parent()' should be exported for use by modules...? Yes, there was a

Re: linux-next: Tree for Apr 10 (meda and OF)

2013-04-10 Thread Randy Dunlap
On 04/10/13 01:48, Stephen Rothwell wrote: > Hi all, > > Changes since 20130409: > on i386: ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined! 'of_get_next_parent()' should be exported for use by modules...? -- ~Randy -- To unsubscribe from this list: send the li

[PATCH] solo6x10: Approximate frame intervals with non-standard denominator

2013-04-10 Thread Ismael Luceno
Instead of falling back to 1/25 (PAL) or 1/30 (NTSC). Signed-off-by: Ismael Luceno # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch media # Changes to be committed: # (use "git reset HEAD ..." to

[PATCH] drivers: media: platform: convert to devm_ioremap_resource()

2013-04-10 Thread Silviu-Mihai Popescu
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. Signed-off-by: Silviu-Mihai Popescu --- drivers/media/platform/sh_veu.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

cron job: media_tree daily build: WARNINGS

2013-04-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 10 19:00:17 CEST 2013 git branch: test git hash: 81e096c8ac6a064854c2157e0bf802dc4906678c gcc versi

Re: [REVIEWv2 PATCH 12/12] hdpvr: allow g/s_std when in legacy mode.

2013-04-10 Thread Hans Verkuil
On Wed April 10 2013 18:27:43 Hans Verkuil wrote: > Leo, can you verify that this works for you as well? I tested it without > problems with MythTV and gstreamer. > > Thanks! > > Hans > > Both MythTV and gstreamer expect that they can set/get/query/enumerate the > standards, even if the in

[REVIEWv2 PATCH 12/12] hdpvr: allow g/s_std when in legacy mode.

2013-04-10 Thread Hans Verkuil
Leo, can you verify that this works for you as well? I tested it without problems with MythTV and gstreamer. Thanks! Hans Both MythTV and gstreamer expect that they can set/get/query/enumerate the standards, even if the input is the component input for which standards really do not apply

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Barry Song
2013/4/10 Guennadi Liakhovetski : > On Wed, 10 Apr 2013, Barry Song wrote: > >> 2013/4/10 Guennadi Liakhovetski : >> > On Wed, 10 Apr 2013, Barry Song wrote: > > [snip] > >> >> > This cannot work, because some I2C devices, e.g. sensors, need a clock >> >> > signal from the camera interface to probe

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Guennadi Liakhovetski
On Wed, 10 Apr 2013, Barry Song wrote: > 2013/4/10 Guennadi Liakhovetski : > > On Wed, 10 Apr 2013, Barry Song wrote: [snip] > >> > This cannot work, because some I2C devices, e.g. sensors, need a clock > >> > signal from the camera interface to probe. Before the bridge driver has > >> > complet

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Barry Song
2013/4/10 Guennadi Liakhovetski : > On Wed, 10 Apr 2013, Barry Song wrote: > >> Hi Guennadi, > > There's a typo above. sorry for the typo. > >> Thanks! >> >> 2013/4/10 Guennadi Liakhovetski : >> > Hi Barry >> > >> > On Wed, 10 Apr 2013, Barry Song wrote: >> > >> >> Hi Guennadia, >> >> >> >> 2012/

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Guennadi Liakhovetski
On Wed, 10 Apr 2013, Barry Song wrote: > Hi Guennadia, There's a typo above. > Thanks! > > 2013/4/10 Guennadi Liakhovetski : > > Hi Barry > > > > On Wed, 10 Apr 2013, Barry Song wrote: > > > >> Hi Guennadia, > >> > >> 2012/9/27 Guennadi Liakhovetski : > >> > Currently soc-camera doesn't work wi

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Barry Song
2013/4/10 Mark Brown : > On Wed, Apr 10, 2013 at 09:53:20PM +0800, Barry Song wrote: >> 2013/4/10 Guennadi Liakhovetski : > >> >> what about another possible way: >> >> we let all host and i2c client driver probed in any order, > >> > This cannot work, because some I2C devices, e.g. sensors, need a

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Mark Brown
On Wed, Apr 10, 2013 at 09:53:20PM +0800, Barry Song wrote: > 2013/4/10 Guennadi Liakhovetski : > >> what about another possible way: > >> we let all host and i2c client driver probed in any order, > > This cannot work, because some I2C devices, e.g. sensors, need a clock > > signal from the came

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Barry Song
Hi Guennadia, Thanks! 2013/4/10 Guennadi Liakhovetski : > Hi Barry > > On Wed, 10 Apr 2013, Barry Song wrote: > >> Hi Guennadia, >> >> 2012/9/27 Guennadi Liakhovetski : >> > Currently soc-camera doesn't work with independently registered I2C client >> > devices, it has to register them itself. Thi

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Guennadi Liakhovetski
Hi Barry On Wed, 10 Apr 2013, Barry Song wrote: > Hi Guennadia, > > 2012/9/27 Guennadi Liakhovetski : > > Currently soc-camera doesn't work with independently registered I2C client > > devices, it has to register them itself. This patch adds support for such > > configurations, in which case cli

[patch] [media] radio-si476x: check different function pointers

2013-04-10 Thread Dan Carpenter
This is a static checker where it complains if we check for one function pointer and then call a different function on the next line. In most cases, the code does the same thing before and after this patch. For example, when ->phase_diversity is non-NULL then ->phase_div_status is also non-NULL.

Re: [media] redrat3: remove memcpys and fix unaligned memory access

2013-04-10 Thread Sean Young
On Tue, Apr 09, 2013 at 12:02:59PM +0300, Dan Carpenter wrote: > I had a question about 4c055a5ae94c: "[media] redrat3: remove memcpys > and fix unaligned memory access" from Feb 16, 2013. > > drivers/media/rc/redrat3.c >619 /* grab the Length and type of transfer */ >620

[REVIEW PATCH 2/2] dt3155v4l: fix timestamp handling.

2013-04-10 Thread Hans Verkuil
From: Hans Verkuil Use the monotonic clock and set the timestamp_type that vb2 expects. Signed-off-by: Hans Verkuil --- drivers/staging/media/dt3155v4l/dt3155v4l.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/s

[REVIEW PATCH 1/2] dt3155v4l: fix incorrect mutex locking.

2013-04-10 Thread Hans Verkuil
From: Hans Verkuil A mutex_unlock was missing in the 'success' path of the open() call, and also at one error path in the same function. Signed-off-by: Hans Verkuil --- drivers/staging/media/dt3155v4l/dt3155v4l.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[REVIEW PATCH 0/2] dt3155v4l: Two fixes.

2013-04-10 Thread Hans Verkuil
This small patch series fixes two different bugs in dt3155v4l: it fixes a mutex locking bug in the open() function and it switches the driver to the monotonic clock (as all drivers should use). I've tested this on actual hardware, and I hope to post more fixes for this driver for 3.11. But I'd lik

[PATCH 2/2] v4l2-ctl: initial attempt to support M2M device streaming

2013-04-10 Thread Tzu-Jung Lee
Signed-off-by: Tzu-Jung Lee --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 207 +- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp b/utils/v4l2-ctl/v4l2-ctl-streaming.cpp index a180c6a..0d9553a 100644 --- a/utils/v

[PATCH 1/2] v4l2-ctl: break down the streaming_set()

2013-04-10 Thread Tzu-Jung Lee
This patch breaks down the streaming_set() into smaller ones, which can be resued for supporting m2m devices. Further cleanup or consolidation can be applied with separate patches, since this one tries not to modify logics. Signed-off-by: Tzu-Jung Lee --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp |

[PATCH 6/7] exynos4-is: Remove meaningless test before bit setting

2013-04-10 Thread Sylwester Nawrocki
There is no need to check same bit before setting it, since we always end up with a bit set. Remove some of the tests and make set unconditional, in every place where all that needs to be done is just setting a bit. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/medi

[PATCH 7/7] exynos4-is: Disable debug trace by default in fimc-isp.c

2013-04-10 Thread Sylwester Nawrocki
Make sure the debug level is properly set initially so any debug information is not printed to the kernel log without explicitly enabling it. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-isp.c |2 +- 1 file changed, 1 insertion(+)

[PATCH 5/7] exynos4-is: Rename the ISP chain configuration data structure

2013-04-10 Thread Sylwester Nawrocki
More appropriate names for the ISP chain data structure. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-param.c | 191 ++--- drivers/media/platform/exynos4-is/fimc-is-regs.c | 14 +- drivers/media/platform/exynos4

[PATCH 4/7] exynos4-is: Improve the ISP chain parameter count calculation

2013-04-10 Thread Sylwester Nawrocki
Instead of incrementing p_region_num field each time we set a bit in the parameter mask calculate the number of bits set only when this information is needed. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-param.c | 86 +++-

[PATCH 3/7] exynos4-is: Make fimc-lite independent on struct fimc_sensor_info

2013-04-10 Thread Sylwester Nawrocki
Make the sensor subdevs host_data hold a pointer to struct fimc_source_info, which is defined in the driver's public header, rather than a pointer to struct fimc_sensor_info which is specific to exynos4-is media device driver. The purpose of this change is to allow easier reuse of the fimc-lite mo

[PATCH 2/7] exynos4-is: Make fimc-lite independent of the pipeline->subdevs array

2013-04-10 Thread Sylwester Nawrocki
Get the sensor subdev by walking media graph in both cases: when the device is used as a subdev only and through video node. This allows to not dereference the pipeline->subdevs[] array and makes the module more generic and easier to re-use in other media driver. Signed-off-by: Sylwester Nawrocki

[PATCH 1/7] exynos4-is: Move the subdev group ID definitions to public header

2013-04-10 Thread Sylwester Nawrocki
Move the sub-device group ID definitions to the driver's public header so they are available to other media drivers that need to share modules found in exynos4-is. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.h |9 -

[PATCH 0/7] exynos4-is cleanups and improvements

2013-04-10 Thread Sylwester Nawrocki
This patch series includes some cleanups of the recently added FIMC-IS driver and prerequisite patches for the FIMC-LITE module to make it easier to reuse in the future exynos5-is driver. Sylwester Nawrocki (7): exynos4-is: Move the subdev group ID definitions to public header exynos4-is: Make

Re: [PATCH 07/14] media: soc-camera: support deferred probing of clients

2013-04-10 Thread Barry Song
Hi Guennadia, 2012/9/27 Guennadi Liakhovetski : > Currently soc-camera doesn't work with independently registered I2C client > devices, it has to register them itself. This patch adds support for such > configurations, in which case client drivers have to request deferred > probing until their hos

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-10 Thread Daniel Vetter
On Mon, Apr 08, 2013 at 01:50:26PM +0200, Daniel Vetter wrote: > On Mon, Apr 08, 2013 at 12:39:24PM +0200, Peter Zijlstra wrote: > > On Thu, 2013-04-04 at 18:56 +0200, Daniel Vetter wrote: > > > Presuming I'm still following we should be able to fix this with the > > > new sleep state TASK_DEADLOCK

[PATCH] s5p-mfc: Remove potential uninitialized variable usage

2013-04-10 Thread Sylwester Nawrocki
Make sure mem_info[] array is not used uninitialized. This prevents following compiler warning: drivers/media/platform/s5p-mfc/s5p_mfc.c: In function s5p_mfc_probe: drivers/media/platform/s5p-mfc/s5p_mfc.c:1032:33: warning: mem_info[0] may be used uninitialized in this function [-Wuninitialized]

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-10 Thread Daniel Vetter
On Tue, Apr 09, 2013 at 06:28:08PM -0400, Steven Rostedt wrote: > On Thu, Apr 04, 2013 at 06:41:02PM +0200, Peter Zijlstra wrote: > > On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: > > > The thing is now that you're not expected to hold these locks for a > > > long > > > time - if you need

Re: [PATCH 2/2] v4l2-ctl: initial attempt to support M2M device streaming

2013-04-10 Thread Hans Verkuil
On Wed 10 April 2013 10:38:13 Tzu-Jung Lee wrote: > On Wed, Apr 10, 2013 at 2:48 PM, Hans Verkuil wrote: > >> + if (!eos[OUT]) { > >> + if (FD_ISSET(fd, &write_fds)) { > >> + r = do_handle_out(fd, &reqbufs[OUT], > >> is_mplane, num_plan

Re: [PATCH 2/2] v4l2-ctl: initial attempt to support M2M device streaming

2013-04-10 Thread Tzu-Jung Lee
On Wed, Apr 10, 2013 at 2:48 PM, Hans Verkuil wrote: > On Wed April 10 2013 07:35:35 Tzu-Jung Lee wrote: >> --- >> utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 189 >> +- >> 1 file changed, 188 insertions(+), 1 deletion(-) >> >> diff --git a/utils/v4l2-ctl/v4l2-ctl-str

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-10 Thread Daniel Vetter
On Wed, Apr 10, 2013 at 12:27 AM, Steven Rostedt wrote: > On Thu, Apr 04, 2013 at 06:38:36PM +0200, Peter Zijlstra wrote: >> On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: >> > Hm, I guess your aim with the TASK_DEADLOCK wakeup is to bound the >> > wait >> > times of older task. >> >> No,

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-10 Thread Peter Zijlstra
On Tue, 2013-04-09 at 18:42 -0400, Steven Rostedt wrote: > What about setting an age as soon as it starts the process > of grabbing one of these locks? And it keeps the age until it > successfully grabs and releases all the locks again. It wont reset if > it > had to drop the locks and start over.

v4l2-ctl-streaming: ideas for improvements

2013-04-10 Thread Hans Verkuil
Hi all, Just in case someone has time to work on this: I thought I'd write down some of the ideas I have to improve the streaming code in v4l2-ctl: 1) Add an option to select between limited and full range colors. 2) Add more test patterns: - solid colors: black, white, red, green, blue,