[PATCH 6/7] soc_camera/sh_mobile_ceu_camera: Fix warning related to spacing

2013-04-02 Thread Sachin Kamat
Fixes the following checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- .../platform/soc_camera/sh_mobile_ceu_camera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c b/driv

[PATCH 7/7] soc_camera/soc_camera_platform: Fix warning related to spacing

2013-04-02 Thread Sachin Kamat
Fixes the following checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- .../platform/soc_camera/soc_camera_platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drive

[PATCH 4/7] soc_camera/pxa_camera: Fix warning related to spacing

2013-04-02 Thread Sachin Kamat
Fixes the following checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- drivers/media/platform/soc_camera/pxa_camera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/plat

[PATCH 5/7] soc_camera/pxa_camera: Constify struct dev_pm_ops

2013-04-02 Thread Sachin Kamat
struct dev_pm_ops should be const. Signed-off-by: Sachin Kamat --- drivers/media/platform/soc_camera/pxa_camera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c index b0e6f3b.

[PATCH 2/7] soc_camera/mx2_camera: Fix warnings related to spacing

2013-04-02 Thread Sachin Kamat
Fixes the following checkpatch warnings: WARNING: unnecessary whitespace before a quoted newline WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- drivers/media/platform/soc_camera/mx2_camera.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 3/7] soc_camera/mx3_camera: Fix warning related to spacing

2013-04-02 Thread Sachin Kamat
Silences the following checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- drivers/media/platform/soc_camera/mx3_camera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/mx3_camera.c b/drivers/media/p

[PATCH 1/7] soc_camera/mx1_camera: Fix warnings related to spacing

2013-04-02 Thread Sachin Kamat
Fixes the following checkpatch warnings: WARNING: unnecessary whitespace before a quoted newline WARNING: please, no space before tabs Signed-off-by: Sachin Kamat --- drivers/media/platform/soc_camera/mx1_camera.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] cxd2820r_t2: Multistream support (MultiPLP)

2013-04-02 Thread CrazyCat
Now confirmed in Russia - work ok. Used my mods scan-s2 + tzap-t2 + vdr 1.7.27 https://bitbucket.org/CrazyCat/szap-s2 https://bitbucket.org/CrazyCat/scan-s2 24.03.2013, 20:19, "Antti Palosaari" : > Is there anyone who could test that patch? > > I have no multi PLP signal here. > > Also there is m

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Mauro Carvalho Chehab
Em Tue, 02 Apr 2013 21:02:33 +0200 Frank Schäfer escreveu: > > We don't have enough documentation to write a driver for avf4910b. Some > > developers at the ML are trying to implement support for it for HVR-930C: > > > > http://www.mail-archive.com/linux-media@vger.kernel.org/msg59296.html >

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 02:48, schrieb Devin Heitmueller: > On Mon, Apr 1, 2013 at 6:14 PM, Mauro Carvalho Chehab > wrote: >> In time, I meant to say: >> "So, it seems very unlikely that any change here will keep it >> working for >> model 16009 while breaking it for other HVR-930 devices.

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 00:12, schrieb Mauro Carvalho Chehab: > Em Mon, 01 Apr 2013 22:39:28 +0200 > Frank Schäfer escreveu: > >> Am 01.04.2013 21:22, schrieb Mauro Carvalho Chehab: >>> Em Mon, 01 Apr 2013 19:14:03 +0200 >>> Frank Schäfer escreveu: >>> Am 18.03.2013 22:22, schrieb Mauro Carvalho Cheha

cron job: media_tree daily build: ERRORS

2013-04-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Apr 2 19:00:23 CEST 2013 git branch: test git hash: f9f11dfe4831adb1531e1face9dcd9fc57665d2e gcc versi

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Daniel Vetter
On Tue, Apr 2, 2013 at 6:59 PM, Peter Zijlstra wrote: >> > Also, is there anything in CS literature that comes close to this? I'd >> > think the DBMS people would have something similar with their >> > transactional systems. What do they call it? > >> I didn't study cs, but judging from your phras

Re: [GIT PULL FOR 3.10] Media DT bindings and V4L2 OF parsing library

2013-04-02 Thread Sylwester Nawrocki
On 03/29/2013 09:22 PM, Rob Herring wrote: > On 03/29/2013 12:39 PM, Sylwester Nawrocki wrote: >> > Mauro, >> > >> > This includes two patches adding device tree support at the V4L2 API. >> > I added Rob and Grant at Cc in case they still wanted to comment on >> > those patches. Not sure what the

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Daniel Vetter
On Tue, Apr 2, 2013 at 6:59 PM, Peter Zijlstra wrote: >> > Head hurts, needs more time to ponder. It would be good if someone else >> > (this would probably be you maarten) would also consider this explore >> > this 'interesting' problem space :-) > >> My head too, evil priority stuff! >> >> Hacky

soc-camera: last call for 3.10

2013-04-02 Thread Guennadi Liakhovetski
Hi These are the patches that I've got in my 3.10 soc-camera queue. Please, ping me if any are missing. I'll be pushing these some time later this week. Fabio Porcedda (2): drivers: media: use module_platform_driver_probe() mx2_camera: use module_platform_driver_probe() Guennadi Li

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Peter Zijlstra
On Tue, 2013-04-02 at 16:57 +0200, Maarten Lankhorst wrote: > Hey, > > Thanks for reviewing. Only partway through so far :-) > Op 02-04-13 13:00, Peter Zijlstra schreef: > > On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: > >> +Reservation type mutexes > >> +struct ticket_mutex { > >

Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-02 Thread Guennadi Liakhovetski
On Tue, 2 Apr 2013, Arnd Bergmann wrote: > On Tuesday 02 April 2013, Guennadi Liakhovetski wrote: > > Currently modular V4L2 build with enabled OF is broken dur to the > > of_get_next_parent() function being unavailable to modules. Export it to > > fix the build. > > > > Cc: Sylwester Nawrocki >

Re: Terratec Grabby hwrev 2

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 07:43, schrieb Timo Teras: > On Mon, 01 Apr 2013 19:26:53 +0200 > Frank Schäfer wrote: > >> Am 30.03.2013 10:54, schrieb Timo Teras: >>> On Thu, 28 Mar 2013 12:22:52 -0300 >>> Mauro Carvalho Chehab wrote: >>> > On the W7 driver, I don't get any of the above mentioned problems. >

Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-02 Thread Arnd Bergmann
On Tuesday 02 April 2013, Guennadi Liakhovetski wrote: > Currently modular V4L2 build with enabled OF is broken dur to the > of_get_next_parent() function being unavailable to modules. Export it to > fix the build. > > Cc: Sylwester Nawrocki > Signed-off-by: Guennadi Liakhovetski Looks good to

[PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-02 Thread Guennadi Liakhovetski
Currently modular V4L2 build with enabled OF is broken dur to the of_get_next_parent() function being unavailable to modules. Export it to fix the build. Cc: Sylwester Nawrocki Signed-off-by: Guennadi Liakhovetski --- This is for 3.10 drivers/of/base.c |1 + 1 files changed, 1 insertions(

[PATCH v4 7/7] exynos4-is: Create media links for the FIMC-IS entities

2013-04-02 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 79 +++-- 1 file changed, 60 insertions(+

[PATCH v4 6/7] exynos4-is: Add fimc-is subdevs registration

2013-04-02 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki Signed-off-by:

[PATCH v4 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree binding documentation

2013-04-02 Thread Sylwester Nawrocki
This patch adds DT binding documentaton for the Imaging Subsystem (camera ISP) found on Samsung Exynos4x12 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - specified order of the interrupts, - added a note about image sensor device nodes. Changes s

[PATCH v4 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-04-02 Thread Sylwester Nawrocki
This patch adds a common image sensor driver and Makefile/Kconfig to enable cpmpilation of the whole IS drives. The sensor subdev driver currently only handles an image sensor's power supplies and reset signal. There is no an I2C communication as it is handled by the ISP's firmware. Signed-off-by

[PATCH v4 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-04-02 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - dropped unused headers, - removed get_is_cfg() macro which was temporary only. --- drivers/media/platform/exynos4-is

[PATCH v4 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-04-02 Thread Sylwester Nawrocki
This patch adds the ISP I2C bus controller driver files. Creating a standard I2C bus adapter, even if the driver doesn't actually communicates with the hardware and it is instead used by the ISP firmware running on the Cortex-A5, allows to use standard hardware description in the device tree. As t

[PATCH v4 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-04-02 Thread Sylwester Nawrocki
This iteration includes mostly headers inclusion and comments cleanup, minor DT binding documentation update and added missing cleanup steps at the I2C bus driver. Detailed changes are listed at individual patches. Below is a full cover letter of v3. If there is no more comments I would send a pul

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Daniel Vetter
On Tue, Apr 2, 2013 at 1:00 PM, Peter Zijlstra wrote: > Also, is there anything in CS literature that comes close to this? I'd > think the DBMS people would have something similar with their > transactional systems. What do they call it? I've looked around a bit and in dbms row-locking land this

saa7134 irq status bits

2013-04-02 Thread Gerd Hoffmann
Hi, Forwarding to linux-media mailing list, hoping that someone there can help out. I havn't worked in the code for years now, can't remember what the AR irq bit is and can't find my copy of the saa7134 data sheet too ... cheers, Gerd Original Message Subject: hello kraxel

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

2013-04-02 Thread Guennadi Liakhovetski
On Tue, 2 Apr 2013, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 04/02/2013 04:54 PM, Guennadi Liakhovetski wrote: > > On Tue, 2 Apr 2013, Sylwester Nawrocki wrote: > > > >> > v4l2_of_parse_parallel_bus() function is now static and > >> > EXPORT_SYMBOL() doesn't apply to it any more. Drop thi

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

2013-04-02 Thread Sylwester Nawrocki
Hi Guennadi, On 04/02/2013 04:54 PM, Guennadi Liakhovetski wrote: > On Tue, 2 Apr 2013, Sylwester Nawrocki wrote: > >> > v4l2_of_parse_parallel_bus() function is now static and >> > EXPORT_SYMBOL() doesn't apply to it any more. Drop this >> > meaningless statement, which was supposed to be done i

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Maarten Lankhorst
Hey, Thanks for reviewing. Op 02-04-13 13:00, Peter Zijlstra schreef: > On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: >> +Reservation type mutexes >> +struct ticket_mutex { >> +extern int __must_check _mutex_reserve_lock(struct ticket_mutex *lock, > That's two different names and tw

Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

2013-04-02 Thread Guennadi Liakhovetski
Hi Sylwester On Tue, 2 Apr 2013, Sylwester Nawrocki wrote: > v4l2_of_parse_parallel_bus() function is now static and > EXPORT_SYMBOL() doesn't apply to it any more. Drop this > meaningless statement, which was supposed to be done in > the original merged patch. > > While at it, edit the copyrigh

[PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

2013-04-02 Thread Sylwester Nawrocki
v4l2_of_parse_parallel_bus() function is now static and EXPORT_SYMBOL() doesn't apply to it any more. Drop this meaningless statement, which was supposed to be done in the original merged patch. While at it, edit the copyright notice so it is sorted in both the v4l2-of.c and v4l2-of.h file in newe

Announce: xawtv-3.103

2013-04-02 Thread Hans de Goede
Hi All, I'm happy to announce the latest xawtv release Changes: 3.103 = * Improve alsa stream handling * Add support for alsa audio loopback to the radio app * Add support for multiple-band (AM+FM) tuners to radio app * Tons of other bugfixes + improvements for the radio app * Fix xawtv win

[PATCH] soc-camera: protect against racing open(2) and rmmod

2013-04-02 Thread Guennadi Liakhovetski
To protect against open() racing with rmmod, hold the list_lock also while obtaining a reference to the camera host driver and check that the video device hasn't been unregistered yet. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/soc_camera.c | 42

Re: [PATCH v3] davinci: vpif: add pm_runtime support

2013-04-02 Thread Hans Verkuil
On Tue 2 April 2013 15:41:30 Prabhakar lad wrote: > From: Lad, Prabhakar > > Add pm_runtime support to the TI Davinci VPIF driver. > > Signed-off-by: Lad, Prabhakar > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil Acked-by: Hans Verkuil Regards, Hans > Cc: Laurent Pinchart > Cc: S

[PATCH v3] davinci: vpif: add pm_runtime support

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar Add pm_runtime support to the TI Davinci VPIF driver. Signed-off-by: Lad, Prabhakar Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Sakari Ailus Cc: Sekhar Nori --- Changes for v3: 1: Removed pm_runtime_resume() from probe as pm_runtime_get()

[PATCH] m5mols: Improved power on routine

2013-04-02 Thread Sylwester Nawrocki
From: Andrzej Hajda The regulator bulk API doesn't guarantee an order in which regulators are enabled or disabled. Make sure the regulators are enabled sequentially, as specified in the sensor's datasheet. Additionally a 1ms delay is added after the reset GPIO (de)assertion. Signed-off-by: Andrz

[PATCH] exynos4-is: Correct clock properties description at the DT binding documentation

2013-04-02 Thread Sylwester Nawrocki
The 'camera' DT node needs to have sclk_cam0/1 and pxl_async0/1 clocks specified, while 'fimc' nodes should have only "fimc" and "sclk_fimc". "mux" and "parent" are leftovers from early versions of patches adding DT support, when the IP bus clock parent clock was being set by the driver. A better s

[PATCH] exynos4-is: Remove dependency on SYSCON for non-dt platforms

2013-04-02 Thread Sylwester Nawrocki
Currently the whole driver depends on MFD_SYSCON, which in turn depends on OF. To allow to use the driver on non-dt platforms (S5PV210) the SYSREG support is made conditional (it is needed only for dt enabled platforms) and MFD_SYSCON is selected if OF is enabled, instead of depending on OF. Signe

Re: [PATCH 10/23] [media] exynos: remove unnecessary header inclusions

2013-04-02 Thread Sylwester Nawrocki
On 04/02/2013 03:08 PM, Sylwester Nawrocki wrote: > On 03/05/2013 06:42 PM, Arnd Bergmann wrote: >> In multiplatform configurations, we cannot include headers >> provided by only the exynos platform. Fortunately a number >> of drivers that include those headers do not actually need >> them, so we c

[PATCH v2 3/3] davinic: vpss: trivial cleanup

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar this patch removes unnecessary header file inclusions and fixes the typo's. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/davinci/vpss.c b/d

[PATCH v2 0/3] davinci: vpss: clock cleanup

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar This patch series cleanup's the VPSS clock enabling. The first patch removes vpss clock enabling from the capture drivers and moves it to the VPSS driver itself. The second patch moves the venc_enable_vpss_clock() to the driver which was being done in platform code. Changes

[PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks were enabled in capture driver for davinci family which creates duplicates for dm355/dm365/dm644x. This patch adds support to enable the VPSS clocks in VPSS driver, which avoids duplication of code and also adding clock aliases. This patch uses PM

[PATCH v2 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-02 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar --- drivers/medi

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Peter Zijlstra
On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: > +The algorithm that TTM came up with for dealing with this problem is > +quite simple. For each group of buffers (execbuf) that need to be > +locked, the caller would be assigned a unique reservation_id, from a > +global counter. In ca

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Peter Zijlstra
On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: > +Reservation type mutexes > +struct ticket_mutex { > +extern int __must_check _mutex_reserve_lock(struct ticket_mutex *lock, That's two different names and two different forms of one (for a total of 3 variants) for the same scheme. F

Re: [PATCH v2] davinci: vpif: add pm_runtime support

2013-04-02 Thread Prabhakar Lad
Hi Hans, On Tue, Apr 2, 2013 at 2:17 PM, Hans Verkuil wrote: > On Mon 1 April 2013 08:36:50 Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Add pm_runtime support to the TI Davinci VPIF driver. >> >> Signed-off-by: Lad, Prabhakar >> Cc: Mauro Carvalho Chehab >> Cc: Hans Verkuil >> Cc: Laur

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Peter Zijlstra
On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: > +struct ticket_mutex { > + struct mutex base; > + atomic_long_t reservation_id; > +}; I'm not sure this is a good name, esp. due to the potential confusion vs the ticket spinlocks we have. -- To unsubscribe from this list:

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-02 Thread Peter Zijlstra
On Thu, 2013-02-28 at 11:25 +0100, Maarten Lankhorst wrote: > +mutex_reserve_lock_slow and mutex_reserve_lock_intr_slow: > + Similar to mutex_reserve_lock, except it won't backoff with > -EAGAIN. > + This is useful when mutex_reserve_lock failed with -EAGAIN, and you > + unreserved all reservati

Re: [PATCH] xawtv: release buffer if it can't be displayed

2013-04-02 Thread Hans de Goede
Hi, On 04/01/2013 04:39 PM, Hans Verkuil wrote: On Mon April 1 2013 16:23:51 Hans de Goede wrote: Hi, On 04/01/2013 12:19 PM, Hans Verkuil wrote: Hi Hans, On Sun March 31 2013 14:48:01 Hans de Goede wrote: Hi, On 03/30/2013 10:47 AM, Hans Verkuil wrote: This patch for xawtv3 releases the

Re: Status of the patches under review at LMML (32 patches)

2013-04-02 Thread Guennadi Liakhovetski
On Tue, 2 Apr 2013, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 29 March 2013 16:13:41 Guennadi Liakhovetski wrote: > > Hi Mauro > > > > On Sun, 24 Mar 2013, Mauro Carvalho Chehab wrote: > > > == Guennadi Liakhovetski == > > > > > > I suspect that some of the above may be ob

Re: [PATCH v2] davinci: vpif: add pm_runtime support

2013-04-02 Thread Hans Verkuil
On Mon 1 April 2013 08:36:50 Prabhakar lad wrote: > From: Lad, Prabhakar > > Add pm_runtime support to the TI Davinci VPIF driver. > > Signed-off-by: Lad, Prabhakar > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Sakari Ailus > Cc: Sekhar Nori > --- > Changes f

[RFC] [media] dvb-core: check ->msg_len for diseqc_send_master_cmd()

2013-04-02 Thread Dan Carpenter
I'd like to send this patch except that it "breaks" cx24116_send_diseqc_msg(). The cx24116 driver accepts ->msg_len values up to 24 but it looks like it's just copying 16 bytes past the end of the ->msg[] array so it's already broken. cmd->msg_len is an unsigned char. The comment next to the str