Re: NACK: [PATCH] [media] s5p-mfc: Modify encoder buffer alloc sequence

2013-03-20 Thread Arun Kumar K
Hi John Sheu, On Thu, Mar 21, 2013 at 7:30 AM, John Sheu wrote: > Arun Kumar K samsung.com> writes: > >> MFC v6 needs minimum number of capture buffers to be queued >> for encoder depending on the stream type and profile. >> For achieving this the sequence for allocating buffers at >> the encode

NACK: [PATCH] [media] s5p-mfc: Modify encoder buffer alloc sequence

2013-03-20 Thread John Sheu
Arun Kumar K samsung.com> writes: > MFC v6 needs minimum number of capture buffers to be queued > for encoder depending on the stream type and profile. > For achieving this the sequence for allocating buffers at > the encoder is modified similar to that of decoder. > The new sequence is as follow

Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-20 Thread Devin Heitmueller
On Wed, Mar 20, 2013 at 3:20 PM, Hans Verkuil wrote: > I want to make a pull request for this. Can I have your Acked-by or do you > want to look at this some more? I *looked* at all the patches, and they all look fine. That said, I haven't actually installed them at all and seen if anything got

[RFC PATCH 08/10] bttv: apply mute settings on open

2013-03-20 Thread Frank Schäfer
Previously, this has been done implicitly for video device nodes by calling set_input() (which calls audio_input() and also modified the mute setting). Since input and mute setting are now untangled (as much as possible), we need to apply the mute setting with an explicit call to audio_mute(). Also

[RFC PATCH 06/10] bttv: untangle audio input and mute setting

2013-03-20 Thread Frank Schäfer
Split function audio_mux(): move the mute setting part to function audio_mute() and the input setting part to function audio_input(). Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c | 51 - 1 Datei geändert, 24 Zeilen hinzugefügt(+), 27 Ze

[RFC PATCH 04/10] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

2013-03-20 Thread Frank Schäfer
'audio_input' better describes the meaning of this field. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-cards.c |2 +- drivers/media/pci/bt8xx/bttv-driver.c | 12 ++-- drivers/media/pci/bt8xx/bttvp.h |2 +- 3 Dateien geändert, 8 Zeilen hinzugefügt(+), 8 Z

[RFC PATCH 10/10] bttv: avoid mute on last close when the radio device node is still open

2013-03-20 Thread Frank Schäfer
In contrast to video devices, radio devices should not be muted on the last close of the device node. In cases where a device provides a video and a radio device node, tuner ownership has to be taken into account. The current code doesn't handle tuner ownership yet, so never mute the device if the

[RFC PATCH 09/10] bttv: fix mute on last close of the video device node

2013-03-20 Thread Frank Schäfer
Instead of applying the current mute setting on last device node close, always mute the device. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/d

[RFC PATCH 07/10] bttv: do not unmute the device before the first open

2013-03-20 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 0df4a16..55eab61 100644 --- a/drivers/media/pci/bt8

[RFC PATCH 05/10] bttv: separate GPIO part from function audio_mux()

2013-03-20 Thread Frank Schäfer
Move the GPIO part of function audio_mux() to a separate function audio_mux_gpio(). This prepares the code for the next patch which will separate mute and input setting. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c | 18 -- 1 Datei geändert, 12 Zeilen

[RFC PATCH 03/10] bttv: do not save the audio input in audio_mux()

2013-03-20 Thread Frank Schäfer
We can't and do not save the mute setting in function audio_mux(), so we should also not save the input in this function for consistency. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c | 10 +- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) dif

[RFC PATCH 02/10] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-20 Thread Frank Schäfer
There are cases where we want to call audio_mux() without changing the value of the v4l2 mute control, for example - mute mute on last close - mute on device probing Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei geändert, 4 Zeilen hinzugefügt(+),

[RFC PATCH 01/10] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute"

2013-03-20 Thread Frank Schäfer
Function audio_mux() actually deals with two types of mute: gpio mute and subdevice muting. This patch claryfies the meaning of these values, but mainly prepares the code for the next patch. Signed-off-by: Frank Schäfer --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei geändert

[RFC PATCH 00/10] bttv: refactor audio_mux() and fix muting/unmuting

2013-03-20 Thread Frank Schäfer
This patch series refactors function audio_mux() and fixes several issues related to muting/unmuting on probing, first open and last close. Two thirds of the changes have already been sent as part of the RFC patch series "bttv: fix muting/unmuting on probing, first open and last close" v1 and v2,

Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

2013-03-20 Thread Hans Verkuil
On Tue March 12 2013 03:05:50 Devin Heitmueller wrote: > On Mon, Mar 11, 2013 at 5:00 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The driver crashed when the device was disconnected while an application > > still had a device node open. Fixed by using the release() callback of > > str

cron job: media_tree daily build: ERRORS

2013-03-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 20 19:00:22 CET 2013 git branch: test git hash: 72873e51c578ae29463a5d146f68881fcd0924c0 gcc versio

[REVIEW PATCH 04/11] hdpvr: remove hdpvr_fh and just use v4l2_fh.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil This prepares the driver for priority and control event handling. This patch also checks for correct streaming ownership and it makes a small improvement to the encoder_cmd ioctls: always zero 'flags' and drop the memset of 'raw' as that is already done by the v4l2 core. Sign

[REVIEW PATCH 08/11] hdpvr: register the video node at the end of probe.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Video nodes can be used at once after registration, so make sure the full initialization is done before registering them. Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/

[REVIEW PATCH 07/11] hdpvr: small fixes

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil - return EBUSY instead of EAGAIN. - add missing break. - remove unnecessary buf type check (done by the core). Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb

[REVIEW PATCH 10/11] hdpvr: add g/querystd, remove deprecated current_norm.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 62 ++--- drivers/media/usb/hdpvr/hdpvr.h |5 ++- 2 files changed, 54 insertions(+), 13 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/

[REVIEW PATCH 03/11] hdpvr: convert to the control framework.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 515 + drivers/media/usb/hdpvr/hdpvr.h |8 + 2 files changed, 145 insertions(+), 378 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/

[REVIEW PATCH 11/11] hdpvr: add dv_timings support.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 217 + drivers/media/usb/hdpvr/hdpvr.h |1 + 2 files changed, 194 insertions(+), 24 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/m

[REVIEW PATCH 05/11] hdpvr: add prio and control event support.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index 873bb23..789d808 100644 --- a

[REVIEW PATCH 09/11] hdpvr: recognize firmware version 0x1e.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil This is the latest firmware version and - it seems - the most reliable. Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-core.c |1 + drivers/media/usb/hdpvr/hdpvr.h |1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-

[REVIEW PATCH 06/11] hdpvr: support device_caps in querycap.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/hdpvr/hdpvr-video.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index 789d808..51f05d9 100644 --- a/drivers/media/

[REVIEW PATCH 02/11] v4l2-dv-timings.h: add 480i59.94 and 576i50 CEA-861-E timings.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil These formats are supported by the HDPVR, but they were missing in the list. Note that these formats are different from the common PAL/NTSC/SECAM formats since all color channels are transmitted separately and so there is no PAL or NTSC or SECAM color encoding involved. Signed

[REVIEW PATCH 01/11] videodev2.h: fix incorrect V4L2_DV_FL_HALF_LINE bitmask.

2013-03-20 Thread Hans Verkuil
From: Hans Verkuil This was set to 1 << 0 which is the same as V4L2_DV_FL_REDUCED_BLANKING. It should be 1 << 3 instead. Luckily interlaced formats are rarely used, which is why this bug wasn't seen until now. Signed-off-by: Hans Verkuil --- include/uapi/linux/videodev2.h |2 +- 1 file cha

[REVIEW PATCH 00/11] hdpvr cleanup

2013-03-20 Thread Hans Verkuil
This patch series updates the hdpvr driver to the latest v4l2 frameworks (except, as usual, vb2). It has been tested with my hdpvr and a HDTV signal generator and it looks pretty good. I did discover that you need the latest firmware to have the hdpvr handle input and format switches correctly. I

[GIT PULL FOR v3.10] Remove the dv_preset API from s5p-tv

2013-03-20 Thread Hans Verkuil
This removes the dv_preset API from s5p-tv. Tested and acked by Tomasz. Thank you very much for testing! After this patch series is applied there should be no more users of the DV_PRESET API and I'll post another patch series completely removing the API. Regards, Hans The following cha

Re: [PATCH RFC v6] [media] Add common video interfaces OF bindings documentation

2013-03-20 Thread Sylwester Nawrocki
On 01/31/2013 07:41 PM, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > This patch adds a document describing common OF bindings for video > capture, output and video processing devices. It is curently mainly > focused on video capture devices, with data busses defined by > standards

Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-20 Thread Tomasz Stanislawski
Hi everyone, After successful testing (after applying "use cap instead of 0" fix), please add: Tested-by: Tomasz Stanislawski Acked-by: Tomasz Stanislawski to the commit log. Regards, Tomasz Stanislawski On 03/18/2013 03:24 PM, Hans Verkuil wrote: > On Mon March 4 2013 14:02:00 Hans Verkuil w

[PATCH -next] [media] gspca: remove needless check before usb_free_coherent()

2013-03-20 Thread Wei Yongjun
From: Wei Yongjun usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun --- drivers/media/usb/gspca/gspca.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gsp

"./build --main-git" failed

2013-03-20 Thread leo
Dear linux-media, I'm getting a fatal error with the "./build --main-git" command (see log below). Please help! Thank you, -Leo. leo@ubaduba:~/ltv3$ git clone git://linuxtv.org/media_build.git Cloning into 'media_build'... remote: Counting objects: 1859, done. remote: Compressing objects: 100%

Re: [PATCH 2/5] [media] drxk: Add pre/post BER and PER/UCB stats

2013-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2013 11:02:13 -0300 Mauro Carvalho Chehab escreveu: > The original az6007 driver has the code to calculate such > stats. Add it to the driver, reporting them via DVBv5 > stats API. There's an scale problem with this patch for S/N ratio at carrier. Fix patch enclosed. Regards, Ma

[RFC] mt9m131/mt9m111 manual exposure control.

2013-03-20 Thread javier Martin
Hi, the attached patch, adds support for manual exposure control for sensor mt9m111. For this purpose, the register 0x009 (Shutter width) is written with values from 0x to 0x. In order to test this, an mt9m131 sensor was connected to a DM3730 (omap3isp). Using yavta to capture some frames,

[PATCH 0/5] Improve DRX-K statistics

2013-03-20 Thread Mauro Carvalho Chehab
As reported by Jean, the drxk statistics are not ok. While we don't have enough documentation about this device, it is possible to do better, by using what's available. In particular, the AZ6007 driver released a few years ago by Terratec, with served as the basis for the Kernel's driver has a ver

[PATCH 2/5] [media] drxk: Add pre/post BER and PER/UCB stats

2013-03-20 Thread Mauro Carvalho Chehab
The original az6007 driver has the code to calculate such stats. Add it to the driver, reporting them via DVBv5 stats API. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c | 179 +--- drivers/media/dvb-frontends/drxk_hard.h | 2 + dri

[PATCH 5/5] [media] dvb-core: don't clear stats at DTV_CLEAR

2013-03-20 Thread Mauro Carvalho Chehab
The stats are cleared by the frontend. Don't do it at DTV_CLEAR. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index

[PATCH 3/5] [media] drxk: use a better calculus for RF strength

2013-03-20 Thread Mauro Carvalho Chehab
The AZ6007 driver released by Terratec has a better way to estimate the signal strength, at CtrlSigStrength(). Port it to the driver. It should be noticed that there are two parameters there that are tuner-specific. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.

[PATCH 1/5] [media] drxk: remove dummy BER read code

2013-03-20 Thread Mauro Carvalho Chehab
The BER code does nothing but filling it with zero. Remove it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c

[PATCH 4/5] [media] drxk: Fix bogus signal strength indicator

2013-03-20 Thread Mauro Carvalho Chehab
The DVBv3 signal strength indicator is bogus: it doesn't range from 0 to 65535 as it would be expected. Also, 0 means the max signal strength. Now that a better way to estimate it was added, use the new way. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c | 33 +

[media] drxk_hard: Drop unused parameter

2013-03-20 Thread Jean Delvare
Last parameter of function GetLockStatus() isn't used so drop it. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- linux-3.8.orig/drivers/media/dvb-frontends/drxk_hard.c 2013

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Arnd Bergmann
On Wednesday 20 March 2013, Fabio Porcedda wrote: > > On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: > > On Wednesday 20 March 2013, Fabio Porcedda wrote: > >> I think we can check inside the deferred_probe_work_func() > >> if the dev->probe function pointer is equal to platform_drv_prob

[PATCH v2] drm/exynos: enable FIMD clocks

2013-03-20 Thread Vikas Sajjan
While migrating to common clock framework (CCF), found that the FIMD clocks were pulled down by the CCF. If CCF finds any clock(s) which has NOT been claimed by any of the drivers, then such clock(s) are PULLed low by CCF. By calling clk_prepare_enable() for FIMD clocks fixes the issue. this patc

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-20 Thread Hans Verkuil
On Wed 20 March 2013 12:11:11 edubez...@gmail.com wrote: > Hi Hans, > > My last email didn't reach the list, so re-sending. > > On Wed, Mar 20, 2013 at 5:04 AM, Hans Verkuil wrote: > > > > Hi Eduardo! > > > > On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote: > > > Hello Mauro and Hans, > > >

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-20 Thread edubez...@gmail.com
Hi Hans, My last email didn't reach the list, so re-sending. On Wed, Mar 20, 2013 at 5:04 AM, Hans Verkuil wrote: > > Hi Eduardo! > > On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote: > > Hello Mauro and Hans, > > > > Here are a couple of minor changes for si4713 FM transmitter driver. > > T

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Jon Arne Jørgensen
On Wed, Mar 20, 2013 at 11:21:48AM +0100, Hans Verkuil wrote: > On Wed 20 March 2013 11:16:26 Jon Arne Jørgensen wrote: > > On Wed, Mar 20, 2013 at 11:10:57AM +0100, Hans Verkuil wrote: > > > On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote: > > > > On Mon, Mar 18, 2013 at 09:29:07AM +0100, H

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> I think we can check inside the deferred_probe_work_func() >> if the dev->probe function pointer is equal to platform_drv_probe_fail(). > > I think it's too late by then, because that wou

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Hans Verkuil
On Wed 20 March 2013 11:16:26 Jon Arne Jørgensen wrote: > On Wed, Mar 20, 2013 at 11:10:57AM +0100, Hans Verkuil wrote: > > On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote: > > > On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote: > > > > On Thu March 14 2013 15:07:00 Jon Arne Jørg

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Arnd Bergmann
On Wednesday 20 March 2013, Fabio Porcedda wrote: > I think we can check inside the deferred_probe_work_func() > if the dev->probe function pointer is equal to platform_drv_probe_fail(). I think it's too late by then, because that would only warn if we try to probe it again, but when platform_dri

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Jon Arne Jørgensen
On Wed, Mar 20, 2013 at 11:10:57AM +0100, Hans Verkuil wrote: > On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote: > > On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote: > > > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: > > > > This file is responsible for registering th

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Hans Verkuil
On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote: > On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote: > > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: > > > This file is responsible for registering the device with the v4l2 > > > subsystem, > > > and the communication w

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-20 Thread Hans Verkuil
On Wed 20 March 2013 11:06:36 Jon Arne Jørgensen wrote: > On Mon, Mar 18, 2013 at 09:58:32AM +0100, Bjørn Mork wrote: > > Hans Verkuil writes: > > > > >> +/* > > >> + * > > >> + * The device delivers data in chunks of 0x400 bytes. > > >> + * The four first bytes is a magic header to identify the

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Hans Verkuil
On Wed 20 March 2013 10:43:26 Jon Arne Jørgensen wrote: > On Mon, Mar 18, 2013 at 09:12:31AM +0100, Hans Verkuil wrote: > > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: > > > This file is responsible for registering the device with the v4l2 > > > subsystem, > > > and the communication w

Re: [RFC V1 0/8] Add a driver for somagic smi2021

2013-03-20 Thread Jon Arne Jørgensen
On Sun, Mar 17, 2013 at 09:05:08PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Sun, Mar 17, 2013 at 09:01:58PM +0100, Jon Arne Jørgensen wrote: > > On Fri, Mar 15, 2013 at 09:08:58AM -0300, Ezequiel Garcia wrote: > > > On Thu, Mar 14, 2013 at 03:06:56PM +0100, Jon Arne Jørgensen wrote: > > > >

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 09:58:32AM +0100, Bjørn Mork wrote: > Hans Verkuil writes: > > >> +/* > >> + * > >> + * The device delivers data in chunks of 0x400 bytes. > >> + * The four first bytes is a magic header to identify the chunks. > >> + *0xaa 0xaa 0x00 0x00 = saa7113 Active Video Dat

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote: > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: > > This file is responsible for registering the device with the v4l2 subsystem, > > and the communication with v4l2. > > Most of the v4l2 ioctls are just passed on to vidbuf2. >

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 09:12:31AM +0100, Hans Verkuil wrote: > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: > > This file is responsible for registering the device with the v4l2 subsystem, > > and the communication with v4l2. > > Most of the v4l2 ioctls are just passed on to vidbuf2. >

Re: [RFC V1 3/8] smi2021: Add smi2021_i2c.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 09:04:56AM +0100, Hans Verkuil wrote: > On Thu March 14 2013 15:06:59 Jon Arne Jørgensen wrote: > > This file is responsible for registering the device > > with the kernel i2c subsystem. > > v4l2 talks to the saa7113 chip of the device via i2c. > > > > Signed-off-by: Jon Ar

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 09:30:38AM +0100, Hans Verkuil wrote: > On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote: > > This is the core of the smi2021 module. > > It will register the module with the kernel, and register the > > usb probe function. > > > > Signed-off-by: Jon Arne Jørgensen >

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 08:58:47AM +0100, Hans Verkuil wrote: > Hi Jon Arne, > > Here is my review of this driver. > Great, thank you. > Regards, > > Hans > > On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote: > > This is the core of the smi2021 module. > > It will register the modu

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-20 Thread Hans Verkuil
Hi Eduardo! On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote: > Hello Mauro and Hans, > > Here are a couple of minor changes for si4713 FM transmitter driver. Thanks! Patches 2-4 are fine, but I don't really see the point of the first patch (except for the last chunk which is a real improve

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Tue, Mar 19, 2013 at 6:59 PM, Arnd Bergmann wrote: > On Tuesday 19 March 2013, Fabio Porcedda wrote: >> On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann wrote: >> > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: >> >> Hmm, so we may have drivers that (now) work perfectly fine with >> >> mod

Re: [RFC V1 7/8] smi2021: Add smi2021_bl.c

2013-03-20 Thread Jon Arne Jørgensen
On Mon, Mar 18, 2013 at 10:31:14AM +0100, Bjørn Mork wrote: > Jon Arne Jørgensen writes: > > > This is the smi2021-bootloader module. > > This module will upload the firmware for the different somagic devices. > > I really don't understand why you want to make that a separate module. > Building