Re: [PATCH v7 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
On Tue, Feb 26, 2013 at 10:06:48PM -0800, Andrey Smirnov wrote: > This patch adds all necessary header files and Kbuild plumbing for the > core driver for Silicon Laboratories Si476x series of AM/FM tuner > chips. > > The driver as a whole is implemented as an MFD device and this patch > adds a co

[PATCH v7 0/9] Driver for Si476x series of chips

2013-02-26 Thread Andrey Smirnov
This is a fourth version of the patchset originaly posted here: https://lkml.org/lkml/2012/9/13/590 Second version of the patch was posted here: https://lkml.org/lkml/2012/10/5/598 Third version of the patch was posted here: https://lkml.org/lkml/2012/10/23/510 Fourth version of the patch was po

[PATCH v7 2/9] mfd: Add the main bulk of core driver for SI476x code

2013-02-26 Thread Andrey Smirnov
This patch adds main part(out of three) of the I2C driver for the "core" of MFD device. Acked-by: Hans Verkuil Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-i2c.c | 878 ++ 1 file changed, 878 insertions(+) create mode 100644 drivers/mfd/si47

[PATCH v7 3/9] mfd: Add chip properties handling code for SI476X MFD

2013-02-26 Thread Andrey Smirnov
This patch adds code related to manipulation of the properties of SI476X chips. Acked-by: Hans Verkuil Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-prop.c | 234 + 1 file changed, 234 insertions(+) create mode 100644 drivers/mfd/si476x-prop.

[PATCH v7 5/9] v4l2: Fix the type of V4L2_CID_TUNE_PREEMPHASIS in the documentation

2013-02-26 Thread Andrey Smirnov
Change the type of V4L2_CID_TUNE_PREEMPHASIS from 'integer' to 'enum v4l2_preemphasis' Acked-by: Hans Verkuil Singed-off-by: Andrey Smirnov --- Documentation/DocBook/media/v4l/controls.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/con

[PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-02-26 Thread Andrey Smirnov
This patch adds all the functions used for exchanging commands with the chip. Acked-by: Hans Verkuil Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-cmd.c | 1553 ++ 1 file changed, 1553 insertions(+) create mode 100644 drivers/mfd/si476x-cmd.c

[PATCH v7 6/9] v4l2: Add standard controls for FM receivers

2013-02-26 Thread Andrey Smirnov
This commit introduces new class of standard controls V4L2_CTRL_CLASS_FM_RX. This class is intended to all controls pertaining to FM receiver chips. Also, two controls belonging to said class are added as a part of this commit: V4L2_CID_TUNE_DEEMPHASIS and V4L2_CID_RDS_RECEPTION. This patch is bas

[PATCH v7 8/9] v4l2: Add private controls base for SI476X

2013-02-26 Thread Andrey Smirnov
Add a base to be used for allocation of all the SI476X specific controls in the corresponding driver. Acked-by: Hans Verkuil Signed-off-by: Andrey Smirnov --- include/uapi/linux/v4l2-controls.h |4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/v4l2-controls.h b/incl

[PATCH v7 7/9] v4l2: Add documentation for the FM RX controls

2013-02-26 Thread Andrey Smirnov
Add appropriate documentation for all the newly added standard controls. Based on the patch by Manjunatha Halli [1] [1] http://lists-archives.com/linux-kernel/27641303-media-update-docs-for-v4l2-fm-new-features.html Acked-by: Hans Verkuil Signed-off-by: Andrey Smirnov --- Documentation/DocBo

[PATCH v7 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Andrey Smirnov
This patch adds all necessary header files and Kbuild plumbing for the core driver for Silicon Laboratories Si476x series of AM/FM tuner chips. The driver as a whole is implemented as an MFD device and this patch adds a core portion of it that provides all the necessary functionality to the two ot

Re: [PATCH 2/3] [media] redrat3: remove memcpys and fix unaligned memory access

2013-02-26 Thread David Härdeman
On Sat, Feb 16, 2013 at 09:25:44PM +, Sean Young wrote: >In stead of doing a memcpy from #defined offset, declare structs which >describe the incoming and outgoing data accurately. > >Tested on first generation RedRat. Oh, so you have that hardwarethat's great. I greatly appreciate that t

Re: [REVIEW PATCH 01/11] s2255: convert to the control framework.

2013-02-26 Thread Sylwester Nawrocki
Hi Hans, On 02/26/2013 06:35 PM, Hans Verkuil wrote: diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index dcd6374..f6ba2fc 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -146,6 +146,10 @@ enum v4l2_colorfx { *

Initial tuning data for upc cablecom Berne, Switzerland

2013-02-26 Thread Christian Affolter
Hi please find the initial tuning data for the Swiss cable provider "upc cablecom" in Berne. I've added the data below to dvb-c/ch-Bern-upc-cablecom # upc cablecom # Berne, Switzerland # freq sr fec mod C 42600 690 NONE QAM64 regards Christian -- To unsubscribe from this list: send

Re: SMDKV210 support issue in kernel 3.8 (dma-pl330 and HDMI failed)

2013-02-26 Thread Sylwester Nawrocki
On 02/22/2013 01:00 PM, Lonsn wrote: Hi, I have tested the kernel 3.8 with a SMDKV210 like board. But I failed with dma-pl330 and HDMI driver. For dma-pl330, kernel print: dma-pl330 dma-pl330.0: PERIPH_ID 0x0, PCELL_ID 0x0 ! dma-pl330: probe of dma-pl330.0 failed with error -22 dma-pl330 dma-pl33

cron job: media_tree daily build: ERRORS

2013-02-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 26 19:00:22 CET 2013 git branch: for_v3.9 git hash: ed72d37a33fdf43dc47787fe220532cdec9da528 gcc ve

Re: SMDKV210 support issue in kernel 3.8 (dma-pl330 and HDMI failed)

2013-02-26 Thread Sylwester Nawrocki
On 02/26/2013 09:07 PM, Sylwester Nawrocki wrote: Hi Lonsn, On 02/26/2013 01:59 PM, Lonsn wrote: Now I checked HDMI failed at: drivers/media/platform/s5p-tv/hdmi_drv.c: 912 line adapter = i2c_get_adapter(pdata->hdmiphy_bus); if (adapter == NULL) { dev_err(dev, "hdmiphy adapter request failed\n"

Re: SMDKV210 support issue in kernel 3.8 (dma-pl330 and HDMI failed)

2013-02-26 Thread Sylwester Nawrocki
Hi Lonsn, On 02/26/2013 01:59 PM, Lonsn wrote: Now I checked HDMI failed at: drivers/media/platform/s5p-tv/hdmi_drv.c: 912 line adapter = i2c_get_adapter(pdata->hdmiphy_bus); if (adapter == NULL) { dev_err(dev, "hdmiphy adapter request failed\n"); ret = -ENXIO;

[PATCH] dvb-usb: Remove redundant NULL check before kfree

2013-02-26 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/media/usb/dvb-usb/cinergyT2-fe.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb/cinergyT2-fe.c b/drivers/media/usb/dvb-usb/cinergyT2-fe.c index 1efc028..c890fe4 10064

[PATCH] media: tuners: Remove redundant NULL check before kfree

2013-02-26 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/media/tuners/tuner-xc2028.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c index 0945173..878d2c4 100644 --- a/drivers

[PATCH] media: ivtv: Remove redundant NULL check before kfree

2013-02-26 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/media/pci/ivtv/ivtvfb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c index 05b94aa..9ff1230 100644 --- a/drivers/media/pci/iv

[PATCH] siano: Remove redundant NULL check before kfree

2013-02-26 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/media/common/siano/smscoreapi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c index 1842e64..9565dcc 100644 -

[PATCH] soc-camera: mt9m111: Fix auto-exposure control

2013-02-26 Thread Benoît Thébaudeau
Commit f9bd5843658e18a7097fc7258c60fb840109eaa8 changed V4L2_CID_EXPOSURE_AUTO from boolean to enum, and commit af8425c54beb3c32cbb503a379132b3975535289 changed the creation of this control into a menu for the mt9m111. However, mt9m111_set_autoexposure() is still interpreting the value set for this

Re: [PATCH v6 1/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
On Tue, Feb 26, 2013 at 08:31:27AM -0800, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all necessary header files and Kbuild plumbing for the > core driver for Silicon Laboratories Si476x series of AM/FM tuner > chips. > > The driver as a whole is implemented as an MFD device

Re: [PATCH v6 0/9] Driver for Si476x series of chips

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 17:31:26 Andrey Smirnov wrote: > This is a fourth version of the patchset originaly posted here: > https://lkml.org/lkml/2012/9/13/590 > > Second version of the patch was posted here: > https://lkml.org/lkml/2012/10/5/598 > > Third version of the patch was posted here: > h

[REVIEW PATCH 11/11] s2255: fix big-endian support.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index cd06f3c..2bd8613 100644 --- a/drivers/media/usb/

[REVIEW PATCH 07/11] s2255: fix field handling

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Just set the field value based on the chosen format. It's either INTERLACED or TOP. Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 61 +--- 1 file changed, 15 insertions(+), 46 deletions(-) diff --git a/drivers/media/u

[REVIEW PATCH 02/11] s2255: add V4L2_CID_JPEG_COMPRESSION_QUALITY

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil The use of the V4L2_CID_JPEG_COMPRESSION_QUALITY control is recommended over the G/S_JPEGCOMP ioctls. Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/me

[REVIEW PATCH 08/11] s2255: don't zero struct v4l2_streamparm

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil All fields after 'type' are already zeroed by the core framework. Clearing the full struct also clears 'type', which causes a wrong type value to be returned. Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c |1 - 1 file changed, 1 deletion(-) diff --g

[REVIEW PATCH 01/11] s2255: convert to the control framework.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 172 include/uapi/linux/v4l2-controls.h |4 + 2 files changed, 59 insertions(+), 117 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/u

[REVIEW PATCH 06/11] s2255: zero priv and set colorspace.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Set priv field of struct v4l2_pix_format to 0 and fill in colorspace. Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index

[REVIEW PATCH 09/11] s2255: Add ENUM_FRAMESIZES support.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 73 +--- 1 file changed, 51 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index eaae9d1..59d40e6 1006

[REVIEW PATCH 05/11] s2255: fixes in the way standards are handled.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Instead of comparing against STD_NTSC and STD_PAL compare against 60 and 50 Hz formats. That's what you really want. When the standard is changed, make sure the width and height of the format are also updated to reflect the current standard. Also replace the deprecated curren

[REVIEW PATCH 10/11] s2255: choose YUYV as the default format, not YUV422P

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil The planar YUV422P is quite unusual and few if any applications support it. Instead choose the common YUYV format as the default. Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[REVIEW PATCH 04/11] s2255: add device_caps support to querycap.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 55c972a..9cb8325 100644 --- a/drivers/media/usb/s2255/s2

[REVIEW PATCH 03/11] s2255: add support for control events and prio handling.

2013-02-26 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/usb/s2255/s2255drv.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 42c3afe..55c972a 100644 --- a/driver

s2255: v4l2 compliance fixes

2013-02-26 Thread Hans Verkuil
This patch series fixes v4l2-compliance issues in the Sensoray s2255drv driver and makes it run on a big endian system. It has been tested with a s2255 unit generously supplied by Sensoray (thanks!). The only changes since the previous RFC patches are the addition of patches 10 and 11. If there a

[PATCH 5/5] anysee: coding style changes

2013-02-26 Thread Antti Palosaari
I did what I liked to do. Also corrected two long log writings as checkpatch.pl was complaining about those. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/anysee.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/dvb-usb

[PATCH 3/5] af9035: do not use buffers from stack for usb_bulk_msg()

2013-02-26 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9035.c | 44 +-- drivers/media/usb/dvb-usb-v2/af9035.h | 2 ++ 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/

[PATCH 4/5] anysee: do not use buffers from stack for usb_bulk_msg()

2013-02-26 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/anysee.c | 27 --- drivers/media/usb/dvb-usb-v2/anysee.h | 3 ++- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.

[PATCH 2/5] af9015: do not use buffers from stack for usb_bulk_msg()

2013-02-26 Thread Antti Palosaari
WARNING: at lib/dma-debug.c:947 check_for_stack+0xa7/0xf0() ehci-pci :00:04.1: DMA-API: device driver maps memory fromstack Reported-by: poma Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 39 +++ drivers/media/usb/dvb-usb-v2/af901

[PATCH 1/5] dvb_usb_v2: locked versions of USB bulk IO functions

2013-02-26 Thread Antti Palosaari
Implement: dvb_usbv2_generic_rw_locked() dvb_usbv2_generic_write_locked() Caller must hold device lock when locked versions are called. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/dvb_usb.h | 4 drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 38 ++

[PATCH v6 2/9] mfd: Add commands abstraction layer for SI476X MFD

2013-02-26 Thread Andrey Smirnov
From: Andrey Smirnov This patch adds all the functions used for exchanging commands with the chip. Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-cmd.c | 1553 ++ 1 file changed, 1553 insertions(+) create mode 100644 drivers/mfd/si476x-cmd.c

[PATCH v6 3/9] mfd: Add the main bulk of core driver for SI476x code

2013-02-26 Thread Andrey Smirnov
From: Andrey Smirnov This patch adds main part(out of three) of the I2C driver for the "core" of MFD device. Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-i2c.c | 878 ++ 1 file changed, 878 insertions(+) create mode 100644 drivers/mfd/si476

[PATCH v6 1/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Andrey Smirnov
From: Andrey Smirnov This patch adds all necessary header files and Kbuild plumbing for the core driver for Silicon Laboratories Si476x series of AM/FM tuner chips. The driver as a whole is implemented as an MFD device and this patch adds a core portion of it that provides all the necessary func

[PATCH v6 0/9] Driver for Si476x series of chips

2013-02-26 Thread Andrey Smirnov
This is a fourth version of the patchset originaly posted here: https://lkml.org/lkml/2012/9/13/590 Second version of the patch was posted here: https://lkml.org/lkml/2012/10/5/598 Third version of the patch was posted here: https://lkml.org/lkml/2012/10/23/510 Fourth version of the patch was po

[PATCH v6 4/9] mfd: Add chip properties handling code for SI476X MFD

2013-02-26 Thread Andrey Smirnov
From: Andrey Smirnov This patch adds code related to manipulation of the properties of SI476X chips. Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-prop.c | 234 + 1 file changed, 234 insertions(+) create mode 100644 drivers/mfd/si476x-prop.c

[PATCH v6 5/9] v4l2: Fix the type of V4L2_CID_TUNE_PREEMPHASIS in the documentation

2013-02-26 Thread Andrey Smirnov
Change the type of V4L2_CID_TUNE_PREEMPHASIS from 'integer' to 'enum v4l2_preemphasis' Singed-off-by: Andrey Smirnov --- Documentation/DocBook/media/v4l/controls.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentati

[PATCH v6 7/9] v4l2: Add documentation for the FM RX controls

2013-02-26 Thread Andrey Smirnov
Add appropriate documentation for all the newly added standard controls. Based on the patch by Manjunatha Halli [1] [1] http://lists-archives.com/linux-kernel/27641303-media-update-docs-for-v4l2-fm-new-features.html Signed-off-by: Andrey Smirnov --- Documentation/DocBook/media/v4l/compat.xml

[PATCH v6 8/9] v4l2: Add private controls base for SI476X

2013-02-26 Thread Andrey Smirnov
Add a base to be used for allocation of all the SI476X specific controls in the corresponding driver. Signed-off-by: Andrey Smirnov --- include/uapi/linux/v4l2-controls.h |4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-cont

[PATCH v6 6/9] v4l2: Add standard controls for FM receivers

2013-02-26 Thread Andrey Smirnov
This commit introduces new class of standard controls V4L2_CTRL_CLASS_FM_RX. This class is intended to all controls pertaining to FM receiver chips. Also, two controls belonging to said class are added as a part of this commit: V4L2_CID_TUNE_DEEMPHASIS and V4L2_CID_RDS_RECEPTION. This patch is bas

Re: [PATCH v5 8/8] v4l2: Add a V4L2 driver for SI476X MFD

2013-02-26 Thread Andrey Smirnov
>> + >> +enum phase_diversity_modes_idx { >> + SI476X_IDX_PHDIV_DISABLED, >> + SI476X_IDX_PHDIV_PRIMARY_COMBINING, >> + SI476X_IDX_PHDIV_PRIMARY_ANTENNA, >> + SI476X_IDX_PHDIV_SECONDARY_ANTENNA, >> + SI476X_IDX_PHDIV_SECONDARY_COMBINING, >> +}; >> + >> +static const char * con

[PATCH] [media] s5p-mfc: Fix frame skip bug

2013-02-26 Thread Arun Kumar K
The issue was seen in VP8 decoding where the last frame was skipped by the driver. This patch gets the correct frame_type value to fix this bug. Signed-off-by: Arun Kumar K Signed-off-by: Arun Mankuzhi --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- 1 file changed, 1 insertion(+), 1 del

Re: SMDKV210 support issue in kernel 3.8 (dma-pl330 and HDMI failed)

2013-02-26 Thread Lonsn
Now I checked HDMI failed at: drivers/media/platform/s5p-tv/hdmi_drv.c: 912 line adapter = i2c_get_adapter(pdata->hdmiphy_bus); if (adapter == NULL) { dev_err(dev, "hdmiphy adapter request failed\n"); ret = -ENXIO; goto fail_vdev;

Re: Please update DVB-T frequency list 'dvb-t/nl-All'

2013-02-26 Thread Oliver Schinagl
On 25-02-13 22:07, Geert Hedde Bosman wrote: Hello, in summer 2012 in the Netherlands major frequency changes took place in DVB-t broadcast. Some new frequencies were added as well. Therefore the frequency-file dvb/dvb-t/nl-All is no longer actual. Could someone (i believe Cristoph P. is one o

Re: [PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-26 Thread Timo Kokkonen
On 02.25 2013 23:17:27, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically d

Re: [PATCH v5 0/8] Driver for Si476x series of chips

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 07:38:46 Andrey Smirnov wrote: > This is a fourth version of the patchset originaly posted here: > https://lkml.org/lkml/2012/9/13/590 > > Second version of the patch was posted here: > https://lkml.org/lkml/2012/10/5/598 > > Third version of the patch was posted here: > h

Re: [PATCH v5 8/8] v4l2: Add a V4L2 driver for SI476X MFD

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 07:38:54 Andrey Smirnov wrote: > From: Andrey Smirnov > > This commit adds a driver that exposes all the radio related > functionality of the Si476x series of chips via the V4L2 subsystem. > > Signed-off-by: Andrey Smirnov > --- > Documentation/video4linux/si476x.txt |

Re: [PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-26 Thread Sakari Ailus
Hi Dmitry, On Mon, Feb 25, 2013 at 11:17:27PM -0800, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_drive

Re: [PATCH v5 7/8] v4l2: Add private controls base for SI476X

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 07:38:53 Andrey Smirnov wrote: > Add a base to be used for allocation of all the SI476X specific > controls in the corresponding driver. > > Signed-off-by: Andrey Smirnov > --- > include/uapi/linux/v4l2-controls.h |4 > 1 file changed, 4 insertions(+) > > diff -

Re: [PATCH v5 6/8] v4l2: Add documentation for the FM RX controls

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 07:38:52 Andrey Smirnov wrote: > Add appropriate documentation for all the newly added standard > controls. Give credit to Manjunatha Halli. > Signed-off-by: Andrey Smirnov > --- > Documentation/DocBook/media/v4l/compat.xml |3 + > Documentation/DocBook/media

Re: [PATCH v5 5/8] v4l2: Add standard controls for FM receivers

2013-02-26 Thread Hans Verkuil
On Tue February 26 2013 07:38:51 Andrey Smirnov wrote: > This commit introduces new class of standard controls > V4L2_CTRL_CLASS_FM_RX. This class is intended to all controls > pertaining to FM receiver chips. Also, two controls belonging to said > class are added as a part of this commit: V4L2_CID