Re: [PATCH] Media: remove incorrect __exit markups

2013-02-24 Thread Guennadi Liakhovetski
Hi Dmitry On Sun, 24 Feb 2013, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which speci

RE: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Sri Deevi
Andy, Thanks for the composition. Most of all you are right about everything. I hope you got all the firmwares that are working properly with hardware you guys have been using. To my knowledge there were no updates in recent past. Merlin firmware should be more or less same as all the others.

RE: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Sri Deevi
Mauro and All, Apologies for delay in reply. Whatever firmware works keep that one as reference. If you guys think the firmware from Hauppauge is latest, please keep that and I can get the required permissions as needed. Please do let me know whatever is the plan. Currently, there are no upda

[PATCH] Media: remove incorrect __exit markups

2013-02-24 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: D

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-02-24 Thread Matthew Gyurgyik
On 02/24/2013 05:23 PM, Antti Palosaari wrote: I rebased it to the latest LinuxTV 3.9. There is quite a lot of changes done for em28xx driver so it could work. Please test. http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/HU345-Q regards Antti I checked out the branch and th

Re: [PATCH] solo6x10: Update TODO (maintainer change)

2013-02-24 Thread Mauro Carvalho Chehab
Em Fri, 22 Feb 2013 13:13:03 -0300 Ismael Luceno escreveu: > > Signed-off-by: Ismael Luceno > --- > drivers/staging/media/solo6x10/TODO | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/solo6x10/TODO > b/drivers/staging/media/solo6x10/TODO > i

Re: [PATCH] af9015: do not use buffers from stack for usb_bulk_msg()

2013-02-24 Thread Antti Palosaari
Ooops, I think it will not work properly for the long ran as there is no lock to serialize access to that buffer early enough. I have to rethink whole situation and maybe try to move "usb_mutex" from the dvb_usbv2_generic_rw() to the device driver. Or add totally new mutex. regards Antti On

[PATCH] af9015: do not use buffers from stack for usb_bulk_msg()

2013-02-24 Thread Antti Palosaari
WARNING: at lib/dma-debug.c:947 check_for_stack+0xa7/0xf0() ehci-pci :00:04.1: DMA-API: device driver maps memory fromstack Reported-by: poma Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 34 -- drivers/media/usb/dvb-usb-v2/af9015

[PATCH] hdpvr: Fix memory leak

2013-02-24 Thread Syam Sidhardhan
This patch fixes the print_buf leaking. Signed-off-by: Syam Sidhardhan --- drivers/media/usb/hdpvr/hdpvr-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index 5c61935..73195fe 100644 --- a/drivers/media/us

[PATCH] lmedm04: Fix possible NULL pointer dereference

2013-02-24 Thread Syam Sidhardhan
Check for (adap == NULL) has to done before accessing adap. Signed-off-by: Syam Sidhardhan --- drivers/media/usb/dvb-usb-v2/lmedm04.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c index

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-02-24 Thread Antti Palosaari
On 02/17/2013 01:38 AM, Matthew Gyurgyik wrote: On 01/20/2013 12:46 PM, Antti Palosaari wrote: On 01/20/2013 04:40 PM, Matthew Gyurgyik wrote: On 01/02/2013 09:53 PM, Matthew Gyurgyik wrote: On 01/02/2013 03:59 PM, Antti Palosaari wrote: On 12/18/2012 05:08 AM, Matthew Gyurgyik wrote: I can

Re: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Andy Walls
Hi, Instead of answering points in the email chain, I'm just going to provide the best information I have. I. Definitions: - Thresher: broadcast video decoder - Merlin: broadcast audio system detection microcontroller and decoder - Mako: Thresher + Merlin - CX2583[67]: stand-alone Thresh

cron job: media_tree daily build: ERRORS

2013-02-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Feb 24 19:00:21 CET 2013 git branch: for_v3.9 git hash: ed72d37a33fdf43dc47787fe220532cdec9da528 gcc ve

[PATCH 2/2] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad is pressed

2013-02-24 Thread Kevin Baradon
My 15c2:0036 device floods syslog when a keypad key is pressed: Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fef2 Feb 18 19:00:57 homeserv

[PATCH 1/2] media/rc/imon.c: make send_packet() delay configurable

2013-02-24 Thread Kevin Baradon
Some imon devices (like 15c2:0036) need a higher delay between send_packet calls. Default value is still 5ms to avoid regressions on already working hardware. Also use interruptible wait to avoid load average going too high (and let caller handle signals). Signed-off-by: Kevin Baradon --- dri

[PATCH 0/2] Improve imon LCD/VFD driver to better support 15c2:0036

2013-02-24 Thread Kevin Baradon
Hi, Please find those two short patches to improve support of (at least) 15c2:0036 imon device. These apply on latest git and were tested on 3.7.8 and 3.7.9 kernels. Thanks. Kevin Baradon (2): media/rc/imon.c: make send_packet() delay configurable media/rc/imon.c: avoid flooding syslog with

Re: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Ben Hutchings
On Sun, 2013-02-24 at 11:36 -0500, Joseph Yasi wrote: > On Sun, Feb 24, 2013 at 7:22 AM, Mauro Carvalho Chehab > wrote: > > Em Sun, 24 Feb 2013 03:16:35 + > > Ben Hutchings escreveu: [...] > >> For now, I think we should delete the current version. > > > > That seems to be the only approach l

Re: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Joseph Yasi
On Sun, Feb 24, 2013 at 7:22 AM, Mauro Carvalho Chehab wrote: > Em Sun, 24 Feb 2013 03:16:35 + > Ben Hutchings escreveu: > >> On Fri, 2013-02-22 at 19:30 -0500, Joseph Yasi wrote: >> > Hi, >> > >> > I'm not sure the appropriate list to email for this, but the >> > v4l-cx23885-enc.fw file in t

Re: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Mauro Carvalho Chehab
Em Sun, 24 Feb 2013 03:16:35 + Ben Hutchings escreveu: > On Fri, 2013-02-22 at 19:30 -0500, Joseph Yasi wrote: > > Hi, > > > > I'm not sure the appropriate list to email for this, but the > > v4l-cx23885-enc.fw file in the linux-firmware.git tree is incorrect. > > It is the wrong size and ju