Re: [PATCH] [media] stv090x: do not unlock unheld mutex in stv090x_sleep()

2013-02-19 Thread Manu Abraham
Hi, On Wed, Feb 20, 2013 at 12:28 AM, Alexey Khoroshilov wrote: > goto err and goto err_gateoff before mutex_lock(&state->internal->demod_lock) > lead to unlock of unheld mutex in stv090x_sleep(). Out of curiosity, what happens when you try to unlock an unlocked mutex ? Regards, Manu -- To unsu

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Theodore Kilgore
On Tue, 19 Feb 2013, Mauro Carvalho Chehab wrote: > Em Tue, 19 Feb 2013 20:45:21 +0100 > Frank Sch?fer escreveu: > > > Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: > > > Em Tue, 19 Feb 2013 19:45:29 +0100 > > > Frank Sch?fer escreveu: > > > > > >>> I don't like the idea of merging thos

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 23:14:38 +0100 Frank Schäfer escreveu: > Am 19.02.2013 21:03, schrieb Mauro Carvalho Chehab: > > Em Tue, 19 Feb 2013 20:45:21 +0100 > > Frank Schäfer escreveu: > > > >> Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: > >>> Em Tue, 19 Feb 2013 19:45:29 +0100 > >>> Frank Sc

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Frank Schäfer
Am 19.02.2013 21:03, schrieb Mauro Carvalho Chehab: > Em Tue, 19 Feb 2013 20:45:21 +0100 > Frank Schäfer escreveu: > >> Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: >>> Em Tue, 19 Feb 2013 19:45:29 +0100 >>> Frank Schäfer escreveu: >>> > I don't like the idea of merging those two entri

Re: coda: support of decoding

2013-02-19 Thread Gaëtan Carlier
On 02/19/2013 10:30 PM, Robert Schwebel wrote: On Tue, Feb 19, 2013 at 08:57:50PM +0100, Gaëtan Carlier wrote: We have a lot of encoder + decoder patches for Coda in the queue, but unfortunately not all of that is ready-for-primetime yet. MX27. I have not yet tested if encoding is working or n

Re: coda: support of decoding

2013-02-19 Thread Robert Schwebel
On Tue, Feb 19, 2013 at 08:57:50PM +0100, Gaëtan Carlier wrote: > > We have a lot of encoder + decoder patches for Coda in the queue, > > but unfortunately not all of that is ready-for-primetime yet. > > MX27. I have not yet tested if encoding is working or not. Where can I > find this set of patch

cron job: media_tree daily build: ERRORS

2013-02-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 19 19:00:20 CET 2013 git branch: for_v3.9 git hash: ed72d37a33fdf43dc47787fe220532cdec9da528 gcc ve

[media-ctl PATCH] Fix linking of shared libraries

2013-02-19 Thread Andreas Bombe
When using libudev, it is actually libmediactl that uses it and not the media-ctl executable. libv4l2subdev uses functions from libmediactl and therefore needs to be linked against it. Signed-off-by: Andreas Bombe --- In light of their relative simplicity as well as cross dependency, does it mak

Re: [patch] [media] mceusb: move check earlier to make smatch happy

2013-02-19 Thread David Härdeman
On Tue, Feb 12, 2013 at 03:22:08PM +0300, Dan Carpenter wrote: >Smatch complains that "cmdbuf[cmdcount - length]" might go past the end >of the array. It's an easy warning to silence by moving the limit >check earlier. > >Signed-off-by: Dan Carpenter Looks ok. I'll leave the signing off to Jarod

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 20:45:21 +0100 Frank Schäfer escreveu: > Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: > > Em Tue, 19 Feb 2013 19:45:29 +0100 > > Frank Schäfer escreveu: > > > >>> I don't like the idea of merging those two entries. As far as I remember > >>> there are devices that work

Re: coda: support of decoding

2013-02-19 Thread Gaëtan Carlier
Hi On 02/19/2013 07:47 PM, Robert Schwebel wrote: On Tue, Feb 19, 2013 at 02:47:05AM +0100, Gaëtan Carlier wrote: I see in code source of coda driver that decoding is not supported. ctx->inst_type = CODA_INST_DECODER; v4l2_err(v4l2_dev, "decoding not supported.\n"); return -EINVAL; Is there an

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Frank Schäfer
Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: > Em Tue, 19 Feb 2013 19:45:29 +0100 > Frank Schäfer escreveu: > >>> I don't like the idea of merging those two entries. As far as I remember >>> there are devices that works out of the box with >>> EM2860_BOARD_SAA711X_REFERENCE_DESIGN. A change

[PATCH] [media] stv090x: do not unlock unheld mutex in stv090x_sleep()

2013-02-19 Thread Alexey Khoroshilov
goto err and goto err_gateoff before mutex_lock(&state->internal->demod_lock) lead to unlock of unheld mutex in stv090x_sleep(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/dvb-frontends/stv090x.c | 22

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 19:45:29 +0100 Frank Schäfer escreveu: > > I don't like the idea of merging those two entries. As far as I remember > > there are devices that works out of the box with > > EM2860_BOARD_SAA711X_REFERENCE_DESIGN. A change like that can break > > the driver for them. > > As des

Re: coda: support of decoding

2013-02-19 Thread Robert Schwebel
On Tue, Feb 19, 2013 at 02:47:05AM +0100, Gaëtan Carlier wrote: > I see in code source of coda driver that decoding is not supported. > > ctx->inst_type = CODA_INST_DECODER; > v4l2_err(v4l2_dev, "decoding not supported.\n"); > return -EINVAL; > > Is there any technical reason or the code has not be

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Frank Schäfer
Am 19.02.2013 19:30, schrieb Mauro Carvalho Chehab: > Em Tue, 19 Feb 2013 17:47:28 +0100 > Frank Schäfer escreveu: > >> Am 18.02.2013 23:36, schrieb Mr Goldcove: >>> I've only tried composite video input. >>> The video/ audio output is good. >>> >>> It has the following input: >>> RCA stereo sou

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 17:47:28 +0100 Frank Schäfer escreveu: > Am 18.02.2013 23:36, schrieb Mr Goldcove: > > I've only tried composite video input. > > The video/ audio output is good. > > > > It has the following input: > > RCA stereo sound > > RCA video > > S-video > > > > It has no push button

omap3isp, omap3-isp-live, mt9p031: snapshot-mode causing picture corruption

2013-02-19 Thread Florian Neuhaus
Hi Laurent I'm still modifying your omap3-isp-live application to fit our needs. Now I have severe problems with the snapshot-mode. When I let the "live"-app running, the picture is fine. Then I capture a snapshot by clicking the right mouse-button. The snapshot is taken (1-2 seconds) and display

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mr Goldcove
On 19. feb. 2013 17:02, Frank Schäfer wrote: > Am 18.02.2013 23:36, schrieb Mr Goldcove: >> > I've only tried composite video input. >> > The video/ audio output is good. >> > >> > It has the following input: >> > RCA stereo sound >> > RCA video >> > S-video >> > >> > It has no push button but ha

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Frank Schäfer
Am 18.02.2013 23:36, schrieb Mr Goldcove: > I've only tried composite video input. > The video/ audio output is good. > > It has the following input: > RCA stereo sound > RCA video > S-video > > It has no push button but has a green led which illuminates when the > device is in use. > > > On 18.

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Frank Schäfer
Am 18.02.2013 23:36, schrieb Mr Goldcove: > I've only tried composite video input. > The video/ audio output is good. > > It has the following input: > RCA stereo sound > RCA video > S-video > > It has no push button but has a green led which illuminates when the > device is in use. Ok, could yo

[PATCH RFC v2 1/2] max77693: added device tree support

2013-02-19 Thread Andrzej Hajda
max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source property in device tree. Device tree bindings doc will be added in max77693-led patch. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park ---

[PATCH RFC v2 0/2] max77693-led driver

2013-02-19 Thread Andrzej Hajda
Those two patches add max77693-led driver with device tree support. Driver is exposed to user space as a V4L2 flash subdevice. This subdevice should be registered by V4L2 driver of the camera device. Changes for v2 are described in patch 2/2, thanks for review to Sylwester. Additionally I have ins

[PATCH RFC v2 2/2] media: added max77693-led driver

2013-02-19 Thread Andrzej Hajda
The patch adds led-flash support to Maxim max77693 chipset. Device is exposed to user space as a V4L2 subdevice. It can be controlled via V4L2 controls interface. Device supports up to two leds which can work in flash and torch mode. Leds can be triggered externally or by software. Signed-off-by:

Re: Wrongly identified easycap em28xx

2013-02-19 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 22:25:01 +0100 Frank Schäfer escreveu: > Am 18.02.2013 21:53, schrieb Mr Goldcove: > > "Easy Cap DC-60++" > > Wrongly identified as card 19 "EM2860/SAA711X Reference Design", > > resulting in no audio. > > Works perfectly when using card 64 "Easy Cap Capture DC-60" > > Video

MT9P031 manual BLC

2013-02-19 Thread Camera . Geomatics
Hi, I am looking for advise on the MT9P031 manual black level calibration. I can see that the MT9P031 driver on the mainline kernel supports manual BLC with the V4L2_CID_BLC_* controls. Even though I use an older version of the MT9P031 driver, controlling of black level calibration is handled th

[PATCH 1/1] [media] timblogiw: Fix sparse warning

2013-02-19 Thread Sachin Kamat
Fixes the below warning: drivers/media/platform/timblogiw.c:81:31: warning: symbol 'timblogiw_tvnorms' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/platform/timblogiw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media

[PATCH 2/2] media: added max77693-led driver

2013-02-19 Thread Andrzej Hajda
The patch adds led-flash support to Maxim max77693 chipset. Device is exposed to user space as a V4L2 subdevice. It can be controlled via V4L2 controls interface. Device supports up to two leds which can work in flash and torch mode. Leds can be triggered externally or by software. Signed-off-by:

[PATCH 1/2] max77693: added device tree support

2013-02-19 Thread Andrzej Hajda
Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/mfd/max77693.c | 40 +--- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c index cc5155e..462

[PATCH RFC 0/2] max77693-led driver

2013-02-19 Thread Andrzej Hajda
Those two patches adds max77693-led driver with device tree support. Driver is exposed to user space as a V4L2 flash subdevice. This subdevice should be registered by V4L2 driver of the camera device. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the

Re: [RFC PATCH 06/18] davinci: replace V4L2_OUT_CAP_CUSTOM_TIMINGS by V4L2_OUT_CAP_DV_TIMINGS

2013-02-19 Thread Sekhar Nori
Hi Hans, On 2/17/2013 1:03 AM, Hans Verkuil wrote: > On Sat February 16 2013 20:23:39 Sekhar Nori wrote: >> On 2/16/2013 6:28 PM, Prabhakar Lad wrote: >>> Cc'ed Sekhar, DLOS, LAK. >>> >>> Sekhar Can you Ack this patch ? Or maybe you can take this patch through >>> your tree ? >> >> I can take the