Re: [RFC PATCH] Add new value for V4L2_CID_MPEG_STREAM_VBI_FMT for userdata GOP

2013-01-30 Thread Hans Verkuil
On Thu January 31 2013 00:02:22 Devin Heitmueller wrote: > Add a new possible value to the V4L2 API for embedded VBI data, > which allows for embedding of CC and teletext data in the userdata > section of the GOP. This allows for compatibility with applications > such as VLC which already have cod

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Hans Verkuil
On Wed January 30 2013 20:07:29 Mauro Carvalho Chehab wrote: > Em Wed, 30 Jan 2013 10:49:25 +0100 > Hans Verkuil escreveu: > > > On Wed 30 January 2013 10:40:30 Mauro Carvalho Chehab wrote: > > > Em Wed, 30 Jan 2013 09:01:22 +0100 > > > Hans Verkuil escreveu: > > > > > > > This was part of my o

Re: [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

2013-01-30 Thread Sachin Kamat
Hi Sylwester. Thank you for the review. On 31 January 2013 03:08, Sylwester Nawrocki wrote: > Hi Sachin, > > > On 01/25/2013 10:55 AM, Sachin Kamat wrote: >> >> This patch adds device tree based discovery support to G2D driver >> >> Signed-off-by: Sachin Kamat >> --- > > Don' you need something

Re: [PATCH v2 1/1] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-30 Thread Vikas Sajjan
Hi Sean, Sorry, wrongly sent incomplete mail. On 31 January 2013 10:41, Vikas Sajjan wrote: > Hi Sean, > > On 30 January 2013 21:28, Sean Paul wrote: >> On Wed, Jan 30, 2013 at 1:30 AM, Vikas Sajjan >> wrote: >>> This patch adds display-timing node parsing using video helper function >>> >>>

Re: [PATCH v2 1/1] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-30 Thread Vikas Sajjan
Hi Sean, On 30 January 2013 21:28, Sean Paul wrote: > On Wed, Jan 30, 2013 at 1:30 AM, Vikas Sajjan wrote: >> This patch adds display-timing node parsing using video helper function >> >> Signed-off-by: Leela Krishna Amudala >> Signed-off-by: Vikas Sajjan >> --- >> drivers/gpu/drm/exynos/exyn

[PATCH 1/1] [media] s5c73m3: Use devm_regulator_bulk_get API

2013-01-30 Thread Sachin Kamat
devm_regulator_bulk_get saves some cleanup and exit code. Cc: Andrzej Hajda Signed-off-by: Sachin Kamat --- drivers/media/i2c/s5c73m3/s5c73m3-core.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
> -Original Message- > From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com] > Sent: Thursday, January 31, 2013 5:51 AM > To: Inki Dae > Cc: Sachin Kamat; linux-media@vger.kernel.org; dri- > de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; > patc...@linaro.org; s

[RFC PATCH] Add new value for V4L2_CID_MPEG_STREAM_VBI_FMT for userdata GOP

2013-01-30 Thread Devin Heitmueller
Add a new possible value to the V4L2 API for embedded VBI data, which allows for embedding of CC and teletext data in the userdata section of the GOP. This allows for compatibility with applications such as VLC which already have code to read captions out of the userdata area for ATSC A/53 complia

Re: [PATCH RFC v4 01/14] [media] Add common video interfaces OF bindings documentation

2013-01-30 Thread Sylwester Nawrocki
Hi, On 01/30/2013 01:40 PM, Sylwester Nawrocki wrote: On 01/25/2013 02:52 AM, Laurent Pinchart wrote: +Data interfaces on all video devices are described by their child 'port' +nodes. Configuration of a port depends on other devices participating in +the data transfer and is described by 'endpo

Re: [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

2013-01-30 Thread Sylwester Nawrocki
Hi Sachin, On 01/25/2013 10:55 AM, Sachin Kamat wrote: This patch adds device tree based discovery support to G2D driver Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-g2d/g2d.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/medi

cron job: media_tree daily build: WARNINGS

2013-01-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Jan 30 19:00:20 CET 2013 git branch: for_v3.9 git hash: a32f7d1ad3744914273c6907204c2ab3b5d496a0 gcc ve

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Sylwester Nawrocki
On 01/30/2013 09:50 AM, Inki Dae wrote: +static const struct of_device_id exynos_g2d_match[] = { + { .compatible = "samsung,g2d-v41" }, not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d driver shoud support for all Exynos SoCs. How about using "samsung,exynos5-g2d" instea

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Mauro Carvalho Chehab
Em Wed, 30 Jan 2013 10:49:25 +0100 Hans Verkuil escreveu: > On Wed 30 January 2013 10:40:30 Mauro Carvalho Chehab wrote: > > Em Wed, 30 Jan 2013 09:01:22 +0100 > > Hans Verkuil escreveu: > > > > > This was part of my original em28xx patch series. That particular patch > > > combined two things:

[RFC PATCH 1/2] c-qcam: fix v4l2-compliance issues.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil - zero priv field in pix_format - fix poll return mask - correctly fill in bus_info Signed-off-by: Hans Verkuil --- drivers/media/parport/c-qcam.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/parport/c-qcam.c b/drivers/media

[RFC PATCH 2/2] c-qcam: add enum_framesizes support.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/parport/c-qcam.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/media/parport/c-qcam.c b/drivers/media/parport/c-qcam.c index 8de8a20..41f5d23 100644 --- a/drivers/media/parp

[RFC PATCH 0/2] c-qcam: v4l2-compliance fixes

2013-01-30 Thread Hans Verkuil
Again, old patches I worked on months ago and now have time to post. These changes make the old c-qcam driver comply with v4l2-compliance. Tested with my Connectix webcam. As an aside: I never have been able to get a proper picture out of it. I suspect that the sensor might be bad. But it works

[RFC PATCH] vb2_poll: don't return POLLERR when testing for event only

2013-01-30 Thread Hans Verkuil
I found this while testing the vb2 conversion of bw-qcam. Without this change select() will always return when polling for events only. If you only poll for events, then vb2_poll will return 'res | POLLERR' if no streaming is in progress. That's not right, it's perfectly valid to poll just for eve

[RFC PATCH 1/3] bw-qcam: zero priv field.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Fix a v4l2-compliance problem: the priv field of v4l2_pix_format must be cleared by drivers. Signed-off-by: Hans Verkuil --- drivers/media/parport/bw-qcam.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qc

[RFC PATCH 2/3] bw-qcam: convert to videobuf2.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil I know, nobody really cares about this black-and-white webcam anymore, but it was fun to do. Tested with an actual webcam. Signed-off-by: Hans Verkuil --- drivers/media/parport/Kconfig |1 + drivers/media/parport/bw-qcam.c | 157 +++---

[RFC PATCH 3/3] bw-qcam: remove unnecessary qc_reset and qc_setscanmode calls.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil These are already done elsewhere. Signed-off-by: Hans Verkuil --- drivers/media/parport/bw-qcam.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qcam.c index d3fe34f..06231b8 100644 --- a

[RFC PATCH 0/3] bw-qcam: fixes and vb2 conversion

2013-01-30 Thread Hans Verkuil
I worked on this some months ago, but didn't have the time to post it until now. These patches fix a few v4l2-compliance failures and convert this driver to vb2. I mainly did that conversion to understand vb2 a bit better, because it isn't really useful for such an old driver :-) Regards,

[PATCH] s5p-fimc: Add missing line breaks

2013-01-30 Thread Sylwester Nawrocki
Add missing line breaks in the debug traces. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-core.c|4 ++-- drivers/media/platform/s5p-fimc/fimc-lite.c| 12 ++-- drivers/media/platform/s5p-fimc/fimc-mdevice.c |4 +

[PATCH 5/5] s5p-fimc: Redefine platform data structure for fimc-is

2013-01-30 Thread Sylwester Nawrocki
Newer Exynos4 SoC are equipped with a local camera ISP that controls external raw image sensor directly. Such sensors can be connected through FIMC-LITEn (and MIPI-CSISn) IPs to the ISP, which then feeds image data to the FIMCn IP. Thus there can be two busses associated with an image source (senso

[PATCH 4/5] s5p-fimc: Add clk_prepare/unprepare for sclk_cam clocks

2013-01-30 Thread Sylwester Nawrocki
Add clk_prepare(), clk_unprepare() calls for the sclk_cam clocks to ensure the driver works on platforms with the common clocks API enabled. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 53 1 file

[PATCH 3/5] s5p-fimc: Fix FIMC.n subdev set_selection ioctl handler

2013-01-30 Thread Sylwester Nawrocki
The V4L2_SEL_TGT_CROP_BOUNDS, V4L2_SEL_TGT_COMPOSE_BOUNDS selection targets are not supposed to be handled in the set_selection ioctl. Remove the code that doesn't do anything sensible now and make sure ctx->state is modified with the spinlock held. Signed-off-by: Sylwester Nawrocki Signed-off-by

[PATCH 2/5] s5p-fimc: Set default image format at device open()

2013-01-30 Thread Sylwester Nawrocki
Make sure a valid image format is initially set on both the CAPTURE and the OUTPUT buffer queue. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-core.c | 20 +--- drivers/media/platform/s5p-fimc/fimc-core.h |5 +- drivers/media/platf

[PATCH 1/5] s5p-fimc: Avoid null pointer dereference in fimc_capture_ctrls_create()

2013-01-30 Thread Sylwester Nawrocki
With presence of some faults, e.g. caused by wrong platform data or the device tree structure the IDX_SENSOR entry in the array may be NULL, so make sure it is not dereferenced then. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-capture.

[PATCH 0/5] s5p-fimc driver fixes/cleanups

2013-01-30 Thread Sylwester Nawrocki
This series includes s5p-fimc driver fixes, one v4l2 compliance fix (I'm working on converting this driver to use the selection API and there is more to come after that, patches 4/6 is required for the driver to work with v3.9 kernel and patch 5/5 is a prerequiste for FIMC-IS driver - as this is al

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Hans Verkuil
On Wed January 30 2013 17:32:38 Frank Schäfer wrote: > Am 30.01.2013 10:49, schrieb Hans Verkuil: > > On Wed 30 January 2013 10:40:30 Mauro Carvalho Chehab wrote: > >> Em Wed, 30 Jan 2013 09:01:22 +0100 > >> Hans Verkuil escreveu: > >> > >>> This was part of my original em28xx patch series. That p

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Frank Schäfer
Am 30.01.2013 10:49, schrieb Hans Verkuil: > On Wed 30 January 2013 10:40:30 Mauro Carvalho Chehab wrote: >> Em Wed, 30 Jan 2013 09:01:22 +0100 >> Hans Verkuil escreveu: >> >>> This was part of my original em28xx patch series. That particular patch >>> combined two things: this fix and the change

Re: [PATCH v2 1/1] video: drm: exynos: Adds display-timing node parsing using video helper function

2013-01-30 Thread Sean Paul
On Wed, Jan 30, 2013 at 1:30 AM, Vikas Sajjan wrote: > This patch adds display-timing node parsing using video helper function > > Signed-off-by: Leela Krishna Amudala > Signed-off-by: Vikas Sajjan > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 38 > +++--- > 1 fi

[RFC PATCH 6/6] radio-miropcm20: fix signal and stereo indication.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c index eb6cd86..3d0ff44 100644 --- a/drivers/me

[RFC PATCH 3/6] radio-miropcm20: convert to the control framework.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c | 64 ++--- 1 file changed, 26 insertions(+), 38 deletions(-) diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c index 4b7c164..061ebc

[RFC PATCH 5/6] radio-miropcm20: Fix audmode/tuner/frequency handling

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil - instead of a mute module option, use audmode as per the spec. - clamp the frequency before setting it. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c | 52 +++-- 1 file changed, 24 insertions(+), 28 deletions(-) diff --

[RFC PATCH 4/6] radio-miropcm20: add prio and control event support.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c index 061ebcf..4ac813c 100644 --- a/drivers/media/radio/radio-m

[RFC PATCH 2/6] radio-miropcm20: remove input/audio ioctls

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Such ioctls are not valid for radio devices. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm2

[RFC PATCH 1/6] radio-miropcm20: fix querycap.

2013-01-30 Thread Hans Verkuil
From: Hans Verkuil Don't set version (done by the v4l2 core), fill in bus_info, set correct driver name and add device_caps support. Signed-off-by: Hans Verkuil --- drivers/media/radio/radio-miropcm20.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/me

[RFC PATCH 0/6] convert radio-miropcm20 to the latest frameworks

2013-01-30 Thread Hans Verkuil
I worked on this driver last year but never had the opportunity to post this work until now. It's cleaned up, rebased, tested on my miropcm20 and it passes all v4l2-compliance tests. I've also worked on RDS support for this driver, but that's not ready yet as that needs more testing. Regards,

[PATCH] soc-camera: fix compilation breakage in 3 drivers

2013-01-30 Thread Guennadi Liakhovetski
A recent commit broke compilation of 3 camera drivers: for PXA2x0, OMAP1 and MX1 by using a wrong pointer. Fix them. Signed-off-by: Guennadi Liakhovetski --- Mauro, if possible, would be nice to merge this with http://patchwork.linuxtv.org/patch/15990/ which is already in -next. If too late - w

[QUERY] V4L async api

2013-01-30 Thread Prabhakar Lad
Hi Guennadi, I am working on adding v4l-asyn for capture and display device.. Here is my hw details:-- 1: The capture device has two subdevs tvp514x @0x5c and tvp514x @0x5d. 2: The display device has a one subdev adv7343 @0x2a. Note:- I have added async support for all the subdevices and the

em28xx: Terratec Cinergy T USB XS (USBID: 0ccd:0043) does not work

2013-01-30 Thread Ruwen
Hi! I tried to get my DVB-T-Stick working, but without success. Errormessage: em28xx_dvb: This device does not support the extension The linuxtv.org-wiki (http://linuxtv.org/wiki/index.php/Em28xx_devices#How_to_validate_my_vendor.2Fproduct_id_at_upstream_kernel.3F) pointed me to this

Re: [PATCH RFC v4 01/14] [media] Add common video interfaces OF bindings documentation

2013-01-30 Thread Sylwester Nawrocki
Hi Laurent, On 01/25/2013 02:52 AM, Laurent Pinchart wrote: +Data interfaces on all video devices are described by their child 'port' +nodes. Configuration of a port depends on other devices participating in +the data transfer and is described by 'endpoint' subnodes. + +de

Re: [PATCH 2/7] mutex: add support for reservation style locks

2013-01-30 Thread Rob Clark
On Wed, Jan 30, 2013 at 5:08 AM, Daniel Vetter wrote: > On Wed, Jan 30, 2013 at 2:07 AM, Rob Clark wrote: >> == >> Basic problem statement: >> - --- - >> GPU's do operations that commonly involve many buffers. Those buffers >> can be shared across contexts

[PATCH] mt9t112: mt9t111 format set up differs from mt9t112

2013-01-30 Thread Guennadi Liakhovetski
The original commit, adding the mt9t112 driver said, that mt9t111 and mt9t112 had identical register layouts. This however doesn't seem to be the case. At least pixel format selection in the mt9t111 datasheet is different from the driver implementation. So far only the default YUYV format has been

[PATCH] sh-mobile-ceu-camera: fix SHARPNESS control default

2013-01-30 Thread Guennadi Liakhovetski
The V4L2_CID_SHARPNESS control in the sh-mobile-ceu-camera driver, if off, turns the CEU low-pass filter on. This is the opposite to the hardware default and can degrade image quality. Switch default to on to restore the default unfiltered mode. Signed-off-by: Guennadi Liakhovetski --- This bug

Re: [PATCH 2/7] mutex: add support for reservation style locks

2013-01-30 Thread Maarten Lankhorst
Op 30-01-13 02:07, Rob Clark schreef: > On Tue, Jan 15, 2013 at 6:33 AM, Maarten Lankhorst > wrote: > Hi Maarten, > > This is a nice looking extension to avoid re-implementing a mutex in > TTM/reservation code.. ofc, probably someone more familiar with mutex > code should probably review, but pro

Re: [PATCH 2/7] mutex: add support for reservation style locks

2013-01-30 Thread Daniel Vetter
On Wed, Jan 30, 2013 at 2:07 AM, Rob Clark wrote: > == > Basic problem statement: > - --- - > GPU's do operations that commonly involve many buffers. Those buffers > can be shared across contexts/processes, exist in different memory > domains (for example V

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Hans Verkuil
On Wed 30 January 2013 10:40:30 Mauro Carvalho Chehab wrote: > Em Wed, 30 Jan 2013 09:01:22 +0100 > Hans Verkuil escreveu: > > > This was part of my original em28xx patch series. That particular patch > > combined two things: this fix and the change where TRY_FMT would no > > longer return -EINVA

Re: [RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Mauro Carvalho Chehab
Em Wed, 30 Jan 2013 09:01:22 +0100 Hans Verkuil escreveu: > This was part of my original em28xx patch series. That particular patch > combined two things: this fix and the change where TRY_FMT would no > longer return -EINVAL for unsupported pixelformats. The latter change was > rejected (correct

[PATCH 1/1] [media] saa7134: Add capture card Hawell HW-9004V1

2013-01-30 Thread Vadim Frolov
This patch adds new capture board Hawell HW-9004V1. This card has 4 SAA71300 chips. In order to work it is needed to initialize its registers (gpio mask and value). The value of these registers were dumped under Windows using flytest. Signed-off-by: Vadim Frolov --- Documentation/video4linux/C

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
2013/1/25 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) >

[RFCv2 PATCH] em28xx: fix bytesperline calculation in G/TRY_FMT

2013-01-30 Thread Hans Verkuil
This was part of my original em28xx patch series. That particular patch combined two things: this fix and the change where TRY_FMT would no longer return -EINVAL for unsupported pixelformats. The latter change was rejected (correctly), but we all forgot about the second part of the patch which fixe