[PATCH 1/1] [media] s3c-camif: Add missing version.h header file

2012-12-02 Thread Sachin Kamat
versioncheck script complains about missing linux/version.h header file. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/

Re: [PATCH -next] [media] media: davinci: vpbe: fix return value check in vpbe_display_reqbufs()

2012-12-02 Thread Prabhakar Lad
Hi, On Sun, Dec 2, 2012 at 3:48 PM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function vb2_dma_contig_init_ctx() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Acked-b

Re: [PATCH -next] [media] media: davinci: vpbe: return error code on error in vpbe_display_g_crop()

2012-12-02 Thread Prabhakar Lad
Wei, On Mon, Dec 3, 2012 at 8:20 AM, Wei Yongjun wrote: > From: Wei Yongjun > > We have assigned error code to 'ret' if crop->type is not > V4L2_BUF_TYPE_VIDEO_OUTPUT, but never use it. > We'd better return the error code on this error. > > Signed-off-by: Wei Yongjun Acked-by: Prabhakar Lad

Re: [PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize()

2012-12-02 Thread Prabhakar Lad
Hi Wei, Thanks for the patch. On Mon, Dec 3, 2012 at 8:23 AM, Wei Yongjun wrote: > From: Wei Yongjun > > The variable 'output_index' is initialized but never used > otherwise, so remove the unused variable. > > Signed-off-by: Wei Yongjun Acked-by: Prabhakar Lad Regards, --Prabhakar > --- >

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-12-02 Thread Sachin Kamat
On 28 November 2012 11:33, Sachin Kamat wrote: >>> How about testing it on Origen board ? >> >> I wanted to but could not due to hardware setup problem. >> I will see if I can get it up today (I am off for the rest of the week). > > Tested this series with test application on Origen. Works fine.

[PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize()

2012-12-02 Thread Wei Yongjun
From: Wei Yongjun The variable 'output_index' is initialized but never used otherwise, so remove the unused variable. Signed-off-by: Wei Yongjun --- drivers/media/platform/davinci/vpbe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media

[PATCH -next] [media] media: davinci: vpbe: return error code on error in vpbe_display_g_crop()

2012-12-02 Thread Wei Yongjun
From: Wei Yongjun We have assigned error code to 'ret' if crop->type is not V4L2_BUF_TYPE_VIDEO_OUTPUT, but never use it. We'd better return the error code on this error. Signed-off-by: Wei Yongjun --- drivers/media/platform/davinci/vpbe_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 de

Re: [PATCH] ad5820: Voice coil motor controller driver

2012-12-02 Thread Sakari Ailus
Hi Laurent, Thanks for the patch! On Thu, Nov 15, 2012 at 01:15:46AM +0100, Laurent Pinchart wrote: > The AD5820 is a voice coil motor controller typically used to control > lens position in digital cameras. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/i2c/Kconfig |9 + > dri

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-12-02 Thread Sakari Ailus
Hi Enric, Thanks for the patch. (Removing my old e-mail address from cc.) On Fri, Oct 05, 2012 at 12:34:47PM +0200, Enric Balletbo i Serra wrote: > From: Enric Balletbo i Serra > > The MT9V034 is a parallel wide VGA sensor from Aptina (formerly Micron) > controlled through I2C. > > The driver

Re: [PATCH v1.2 1/4] v4l: Define video buffer flags for timestamp types

2012-12-02 Thread Sakari Ailus
Hi Laurent, Thanks for the comments. On Tue, Nov 27, 2012 at 05:04:29PM +0100, Laurent Pinchart wrote: > On Thursday 22 November 2012 01:59:00 Sakari Ailus wrote: > > On Wed, Nov 21, 2012 at 11:53:02PM +0100, Hans Verkuil wrote: ,,, > > > What do you think? > > > > Fine for me. Sylwester also br

cron job: media_tree daily build: ERRORS

2012-12-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Dec 2 19:00:21 CET 2012 git hash:d8658bca2e5696df2b6c69bc5538f8fe54e4a01e gcc version: i686-linux-gcc (GCC

Re: ivtv driver inputs randomly "block"

2012-12-02 Thread Brian J. Murrell
On 12-11-29 02:47 PM, Brian J. Murrell wrote: > > I'm afraid I didn't notice the problem until about 40m into the > recording bug given that MythTV is in a loop repeatedly opening the > card and trying to use it perhaps the high volume even 40 minutes into > the recording is useful. > >> Then onc

Re: LGDT3305 configuration questions

2012-12-02 Thread Frank Schäfer
Hi Devin, Am 02.12.2012 17:10, schrieb Devin Heitmueller: > Hi Frank, > > I might be able to help out here a bit. > > On Sun, Dec 2, 2012 at 6:53 AM, Frank Schäfer > wrote: >> 1) When should deny_i2c_rptr in struct lgdt3305_config be set ? >> I can see what the code does, but I'm unsure which val

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-02 Thread Frank Schäfer
Am 02.12.2012 15:23, schrieb Antti Palosaari: > On 12/02/2012 01:44 PM, Frank Schäfer wrote: >> Am 30.11.2012 02:45, schrieb Matthew Gyurgyik: >>> On 11/29/2012 02:28 PM, Frank Schäfer wrote: Matthew, stay tuned but be patient. ;) Regards, Frank >>> >>> Sure thing, just let me know what you ne

Re: LGDT3305 configuration questions

2012-12-02 Thread Devin Heitmueller
Hi Frank, I might be able to help out here a bit. On Sun, Dec 2, 2012 at 6:53 AM, Frank Schäfer wrote: > 1) When should deny_i2c_rptr in struct lgdt3305_config be set ? > I can see what the code does, but I'm unsure which value to use. > What's the i2c repeater / i2c gate ctrl and how does it wo

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-02 Thread Antti Palosaari
On 12/02/2012 01:44 PM, Frank Schäfer wrote: Am 30.11.2012 02:45, schrieb Matthew Gyurgyik: On 11/29/2012 02:28 PM, Frank Schäfer wrote: Matthew, stay tuned but be patient. ;) Regards, Frank Sure thing, just let me know what you need me to do! Ok, please test the attached experimental patc

[PATCH -next] [media] s5p-mfc: remove unused variable

2012-12-02 Thread Wei Yongjun
From: Wei Yongjun The variable index is initialized but never used otherwise, so remove the unused variable. Signed-off-by: Wei Yongjun --- drivers/media/platform/s5p-mfc/s5p_mfc.c| 5 - drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 6 -- 2 files changed, 11 deletions(-) d

LGDT3305 configuration questions

2012-12-02 Thread Frank Schäfer
Hi Michael, I'm currently working on adding support for the "MSI Digivox ATSC" (EM2874B + TDA18271HDC2 + LGDT3305) to the em28xx driver and I'm trying to find the right setup for the LGDT3305. Maybe you can answer some questions about the LGDT3305 configuration: 1) When should deny_i2c_rptr in st

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-02 Thread Frank Schäfer
Am 30.11.2012 02:45, schrieb Matthew Gyurgyik: > On 11/29/2012 02:28 PM, Frank Schäfer wrote: >> Matthew, stay tuned but be patient. ;) Regards, Frank > > Sure thing, just let me know what you need me to do! > Ok, please test the attached experimental patch and post the dmesg output. Open questio

[patch] [media] mantis: cleanup NULL checking in mantis_ca_exit()

2012-12-02 Thread Dan Carpenter
Smatch complainst that the call to mantis_evmgr_exit() dereferences "ca" but then we check it for NULL on the next line. I've moved the NULL check forward to avoid that. Signed-off-by: Dan Carpenter --- There aren't any callers for this function. It is commented out in mantis_dvb_exit(). diff

[PATCH -next] [media] media: davinci: vpbe: fix return value check in vpbe_display_reqbufs()

2012-12-02 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function vb2_dma_contig_init_ctx() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/media/platform/davinci/vpbe_display.c | 4 ++-- 1 file changed,