Re: [PATCH v6] [media] vivi: Teach it to tune FPS

2012-11-18 Thread Kirill Smelkov
On Sun, Nov 18, 2012 at 07:25:38AM -0200, Mauro Carvalho Chehab wrote: > Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu: > >Em 17-11-2012 08:45, Kirill Smelkov escreveu: > >>On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote: > >>>Em 16-11-2012 11:38, Hans Verkuil escreveu:

Re: [RFCv1 PATCH 0/2] Two vpif fixes protecting the dma_queue by a lock

2012-11-18 Thread Prabhakar Lad
Hi Hans, Thanks for the patches. On Fri, Nov 16, 2012 at 9:33 PM, Hans Verkuil wrote: > Hi Prabhakar, > > These two patches add protection to the dma_queue. We discovered that not > locking caused race conditions, which caused the display DMA to jam. After > adding the lock we never saw this aga

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-18 Thread Tushar Behera
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: > On Fri, 16 Nov 2012, Tushar Behera wrote: > >> Checking '< 0' for unsigned variables always returns false. For error >> codes, use IS_ERR_VALUE() instead. > > Wouldn't just changing "irq" type to "int" also work? I think that would > be a mo

Re: Hauppauge WinTV HVR 900 (M/R 65018/B3C0) doesn't work anymore since linux 3.6.6

2012-11-18 Thread Antti Palosaari
On 11/14/2012 10:30 PM, Philippe Valembois - Phil wrote: Hello, I have posted a bug report here : https://bugzilla.kernel.org/show_bug.cgi?id=50361 and I have been told to send it to the ML too. The commit causing the bug has been pushed to kernel between linux-3.5 and linux-3.6. Here is my bug

cron job: media_tree daily build: WARNINGS

2012-11-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Nov 18 19:00:21 CET 2012 git hash:2c4e11b7c15af70580625657a154ea7ea70b8c76 gcc version: i686-linux-gcc (GCC

[PATCH 4/7] ir-rx51: Replace module_{init,exit} macros with module_platform_driver

2012-11-18 Thread Timo Kokkonen
No reason to avoid using the existing helpers. Signed-off-by: Timo Kokkonen --- drivers/media/rc/ir-rx51.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c index 16b3c1f..6e1ffa6 100644 --- a/drivers/media/rc

[PATCH 6/7] ir-rx51: Remove useless variable from struct lirc_rx51

2012-11-18 Thread Timo Kokkonen
As clearly visible from the patch, this variable has no useful purpose what so ever. Thus, it can be removed altogether without any side effects. Signed-off-by: Timo Kokkonen --- drivers/media/rc/ir-rx51.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/media/

[PATCH 5/7] ir-rx51: Convert latency constraints to PM QoS API

2012-11-18 Thread Timo Kokkonen
Convert the driver from the obsolete omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. This allows the callback to be removed from the platform data structure. The latency requirements are also adjusted to prevent the MPU from going into sleep mode. This is needed as the GP timers have no

[PATCH 7/7] ir-rx51: Fix sparse warnings

2012-11-18 Thread Timo Kokkonen
Add missing __user annotation to all of the user space memory accesses. Otherwise sparse is complainign about address space difference in types. Also struct lirc_rx51_platform_driver is missing static keyword even though it should have it. Signed-off-by: Timo Kokkonen --- drivers/media/rc/ir-rx

[PATCH 1/7] ir-rx51: Handle signals properly

2012-11-18 Thread Timo Kokkonen
The lirc-dev expects the ir-code to be transmitted when the write call returns back to the user space. We should not leave TX ongoing no matter what is the reason we return to the user space. Easiest solution for that is to simply remove interruptible sleeps. The first wait_event_interruptible is

[PATCH 2/7] ir-rx51: Clean up timer initialization code

2012-11-18 Thread Timo Kokkonen
Remove a redundant macro definition. This is unneeded and becomes more readable once the actual timer code is refactored a little. Signed-off-by: Timo Kokkonen --- drivers/media/rc/ir-rx51.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/ir-rx51.

[PATCH 0/7] ir-rx51: Various fixes

2012-11-18 Thread Timo Kokkonen
Hi, Here is a set of fixes that did not make in the last merge window. Everything else except the last patch that fixes sparse complaints have been posted before. Especially the PM QoS conversion patch is important, without that one the driver does not work at all unless there is some background

[PATCH 3/7] ir-rx51: Move platform data checking into probe function

2012-11-18 Thread Timo Kokkonen
This driver is useless without proper platform data. If data is not available, we should not register the driver at all. Once this check is done, the BUG_ON check during device open is no longer needed. Signed-off-by: Timo Kokkonen --- drivers/media/rc/ir-rx51.c | 4 +++- 1 file changed, 3 inser

Re: [PATCH v4] [media] vivi: Teach it to tune FPS

2012-11-18 Thread Mauro Carvalho Chehab
Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu: Em 17-11-2012 08:45, Kirill Smelkov escreveu: On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote: Em 16-11-2012 11:38, Hans Verkuil escreveu: On Wed November 7 2012 12:30:01 Kirill Smelkov wrote: [...] diff --git a/driv

Re: [PATCH v4] [media] vivi: Teach it to tune FPS

2012-11-18 Thread Mauro Carvalho Chehab
Em 17-11-2012 08:45, Kirill Smelkov escreveu: On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote: Em 16-11-2012 11:38, Hans Verkuil escreveu: On Wed November 7 2012 12:30:01 Kirill Smelkov wrote: [...] diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/viv