Re: [PATCH] dma-buf: might_sleep() in dma_buf_unmap_attachment()

2012-09-28 Thread Sumit Semwal
On Friday 28 September 2012 01:09 PM, Maarten Lankhorst wrote: Op 28-09-12 09:29, Rob Clark schreef: From: Rob Clark We never really clarified if unmap could be done in atomic context. But since mapping might require sleeping, this implies mutex in use to synchronize mapping/unmapping, so unma

Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Eric Miao
On Fri, Sep 28, 2012 at 8:21 PM, Guennadi Liakhovetski wrote: > Hi Eric > > On Fri, 28 Sep 2012, Guennadi Liakhovetski wrote: > >> Hi Anatolij >> >> I can take this patch, but we need an ack from a PXA / ARM maintainer. > > Could we have your ack, please? Yes, this looks completely good to me. So

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Thomas Hellstrom
On 09/28/2012 09:42 PM, Thomas Hellstrom wrote: On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it ob

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Thomas Hellstrom
On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it obvious what went wrong, instead of silently doing

Re: [PATCH] tda18271-common: hold the I2C adapter during write transfers

2012-09-28 Thread Michael Krufky
On Fri, Sep 28, 2012 at 2:31 PM, Antti Palosaari wrote: > Hello, > Did not fix the issue. Problem remains same. With the sleep + that patch it > works still. > > On 09/28/2012 06:04 PM, Mauro Carvalho Chehab wrote: >> >> The tda18271 datasheet says: >> >> "The image rejection calibration a

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2012-09-28 Thread Malcolm Priestley
On Fri, 2012-09-28 at 20:55 +0300, Antti Palosaari wrote: > On 09/28/2012 07:34 PM, Damien Bally wrote: > > > I will NACK that initially because that USB ID already used by AF9015 > >> driver. You have to explain / study what happens when AF9015 driver > >> claims that device same time. > >> > >

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2012-09-28 Thread Damien Bally
Le 28/09/2012 19:55, Antti Palosaari a écrit : I am not sure what you do here but let it be clear. There is same ID used by af9015 and it913x. Both drivers are loaded when that ID appears. What I understand *both* drivers, af9015 and it913x should detect if device is correct or not. If device

cron job: media_tree daily build: ERRORS

2012-09-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Sep 28 19:00:22 CEST 2012 git hash:8928b6d1568eb9104cc9e2e6627d7086437b2fb3 gcc version: i686-linux-gcc (GC

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Sylwester Nawrocki
Hi, On 09/28/2012 08:37 PM, Albert Wang wrote: >>> + ret = v4l2_subdev_call(sd, core, g_chip_ident,&id); > >> Yuck. Don't abuse this. g_chip_ident is for debugging purposes only. > > Yes, can remove it. > >>> + if (ret< 0) { >>> + cam_err(mcam, "%s %d\n", __func__, __LINE__); >>>

RE: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Albert Wang
Hi, Hans Thank you for reviewing the patches! >>On Fri September 28 2012 15:47:20 Albert Wang wrote: >> >> This patch adds the support of Soc Camera on marvell-ccic mcam-core. >> The Soc Camera mode does not compatible with current mode. >> Only one mode can be used at one time. >> >> To use So

Re: [PATCH] tda18271-common: hold the I2C adapter during write transfers

2012-09-28 Thread Antti Palosaari
Hello, Did not fix the issue. Problem remains same. With the sleep + that patch it works still. On 09/28/2012 06:04 PM, Mauro Carvalho Chehab wrote: The tda18271 datasheet says: "The image rejection calibration and RF tracking filter calibration must be launched exactly as de

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2012-09-28 Thread Antti Palosaari
On 09/28/2012 07:34 PM, Damien Bally wrote: > I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time. Hi Antti With the Cinergy stick alone, dvb_usb_af9015 is predictably loaded,

Re: [git:v4l-dvb/for_v3.7] [media] add LNA support for DVB API

2012-09-28 Thread Antti Palosaari
On 09/28/2012 08:07 PM, Hans Verkuil wrote: On Fri September 28 2012 17:30:05 Mauro Carvalho Chehab wrote: Em Fri, 28 Sep 2012 16:21:35 +0200 Hans Verkuil escreveu: On Fri September 28 2012 14:43:32 Hans Verkuil wrote: Hi Antti, Mauro asked me to look into LNA as well, in particular how thi

Re: qv4l2-bug / libv4lconvert API issue

2012-09-28 Thread Frank Schäfer
Hi, Am 27.09.2012 21:41, schrieb Hans de Goede: > Hi, > > On 09/27/2012 03:20 PM, Frank Schäfer wrote: > > > >>> What you've found is a qv4l2 bug (do you have the latest version?) >> >> Of course, I'm using the latest developer version. >> >> Even if this is just a qv4l2-bug: how do you want to f

Re: [git:v4l-dvb/for_v3.7] [media] add LNA support for DVB API

2012-09-28 Thread Hans Verkuil
On Fri September 28 2012 17:30:05 Mauro Carvalho Chehab wrote: > Em Fri, 28 Sep 2012 16:21:35 +0200 > Hans Verkuil escreveu: > > > On Fri September 28 2012 14:43:32 Hans Verkuil wrote: > > > Hi Antti, > > > > > > Mauro asked me to look into LNA as well, in particular how this could be > > > don

Error when doing build of media modules: WARNING: "snd_tea575x_init" [drivers/media/radio/radio-shark.ko] undefined!

2012-09-28 Thread Marcos Souza
Just giving a proper subject -- Forwarded message -- From: Marcos Souza Date: 2012/9/28 Subject: Build To: linux-media@vger.kernel.org, linux-ker...@vger.kernel.org Hi media guys, After try to build the media drivers with some radios enabled, I got this error: marcos@tux:/mnt

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2012-09-28 Thread Damien Bally
> I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time. Hi Antti With the Cinergy stick alone, dvb_usb_af9015 is predictably loaded, but doesn't prevent dvb_usb_it913x from work

Re: tda18271 driver power consumption

2012-09-28 Thread Antti Palosaari
On 09/28/2012 02:43 PM, Mauro Carvalho Chehab wrote: Em Thu, 27 Sep 2012 17:58:24 -0400 Michael Krufky escreveu: On Thu, Sep 27, 2012 at 5:38 PM, Antti Palosaari wrote: On 09/28/2012 12:20 AM, Michael Krufky wrote: Mike, There is other problem too. PCTV 520e, which is Em28xx + DRX-K + TDA

Re: [PATCH 4/5] reservation: cross-device reservation support

2012-09-28 Thread Maarten Lankhorst
Op 28-09-12 17:29, Thomas Hellström schreef: > On 9/28/12 2:43 PM, Maarten Lankhorst wrote: >> This adds support for a generic reservations framework that can be >> hooked up to ttm and dma-buf and allows easy sharing of reservations >> across devices. >> >> The idea is that a dma-buf and ttm objec

Re: [git:v4l-dvb/for_v3.7] [media] add LNA support for DVB API

2012-09-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Sep 2012 16:21:35 +0200 Hans Verkuil escreveu: > On Fri September 28 2012 14:43:32 Hans Verkuil wrote: > > Hi Antti, > > > > Mauro asked me to look into LNA as well, in particular how this could be > > done > > on the analog side as well. Thanks for that! > > > > While reading thr

Re: [PATCH 4/5] reservation: cross-device reservation support

2012-09-28 Thread Thomas Hellström
On 9/28/12 2:43 PM, Maarten Lankhorst wrote: This adds support for a generic reservations framework that can be hooked up to ttm and dma-buf and allows easy sharing of reservations across devices. The idea is that a dma-buf and ttm object both will get a pointer to a struct reservation_object, w

Re: omap3isp: wrong image after resizer with mt9v034 sensor

2012-09-28 Thread Enric Balletbò i Serra
Hi Laurent, 2012/9/28 Laurent Pinchart : > Hi Enric, > > On Friday 28 September 2012 10:21:56 Enric Balletbò i Serra wrote: >> 2012/9/28 Laurent Pinchart : >> > On Thursday 27 September 2012 18:05:56 Enric Balletbò i Serra wrote: >> >> 2012/9/27 Laurent Pinchart : >> >> > On Wednesday 26 September

[PATCH] tda18271-common: hold the I2C adapter during write transfers

2012-09-28 Thread Mauro Carvalho Chehab
The tda18271 datasheet says: "The image rejection calibration and RF tracking filter calibration must be launched exactly as described in the flowchart, otherwise bad calibration or even blocking of the TDA18211HD can result making it impossible to communicate

Re: [git:v4l-dvb/for_v3.7] [media] add LNA support for DVB API

2012-09-28 Thread Hans Verkuil
On Fri September 28 2012 14:43:32 Hans Verkuil wrote: > Hi Antti, > > Mauro asked me to look into LNA as well, in particular how this could be done > on the analog side as well. > > While reading through this patch I noticed that the new property was added to > dtv_property_process_set, but not t

[PATCH 2/2] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-28 Thread Prashanth Subramanya
This driver adds basic support for Aptina ar0130 1.2M sensor. Changes for v2: 1: Include new test pattern control as pointed by Hans and Lad. 2: Remove soc_camera.h as suggested by Guennadi. 3: Change auto exposure control as pointed by Dan Rittersdorf. 4: Change incorrect return value as pointed

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Hans Verkuil
On Fri September 28 2012 15:47:20 Albert Wang wrote: > From: Libin Yang > > This patch adds the support of Soc Camera on marvell-ccic mcam-core. > The Soc Camera mode does not compatible with current mode. > Only one mode can be used at one time. > > To use Soc Camera, CONFIG_VIDEO_MMP_SOC_CAMER

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Maarten Lankhorst
Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: > Documentation says that code requiring dma-buf should add it to > select, so inline fallbacks are not going to be used. A link error > will make it obvious what went wrong, instead of silently doing > nothing at runtime. > The whole patch s

[PATCH 4/4] [media] marvell-ccic: core: add 3 frame buffers support in DMA_CONTIG mode

2012-09-28 Thread Albert Wang
This patch adds support of 3 frame buffers in DMA-contiguous mode. In current DMA_CONTIG mode, only 2 frame buffers can be supported. Actually, Marvell CCIC can support at most 3 frame buffers. Currently 2 frame buffers mode will be used by default. To use 3 frame buffers mode, can do: define M

[PATCH 3/4] [media] marvell-ccic: mmp: add soc camera support on marvell-ccic mmp-driver

2012-09-28 Thread Albert Wang
From: Libin Yang This patch adds the support of Soc Camera on marvell-ccic mmp-driver. The Soc Camera mode does not compatible with current mode. Only one mode can be used at one time. To enable Soc Camera on mmp: In Device Drivers --> Multimedia support: select Cameras/video grabbers support

[PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-28 Thread Albert Wang
From: Libin Yang This patch adds the support of Soc Camera on marvell-ccic mcam-core. The Soc Camera mode does not compatible with current mode. Only one mode can be used at one time. To use Soc Camera, CONFIG_VIDEO_MMP_SOC_CAMERA should be defined. What's more, the platform driver should suppor

[PATCH 1/4] [media] mmp: add register definition for marvell ccic

2012-09-28 Thread Albert Wang
From: Libin Yang This patch adds the definition of CCIC1/2 Clock Reset register address Signed-off-by: Albert Wang Signed-off-by: Libin Yang --- arch/arm/mach-mmp/include/mach/regs-apmu.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach

[PATCH 0/4] [media] marvell-ccic: add soc camera support on marvell-ccic

2012-09-28 Thread Albert Wang
The following patches series will add soc camera support on marvell-ccic [PATCH 1/4] [media] mmp: add register definition for marvell ccic [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core [PATCH 3/4] [media] marvell-ccic: mmp: add soc camera support on ma

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Anatolij Gustschin
On Fri, 28 Sep 2012 15:30:33 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > Yes. But i.e. the driver calling the sub-device stream control function > > on streamon knows that the normal mode is not supported and therefore it > > calls this function with argument enable == 0, effectively setting

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Guennadi Liakhovetski
On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Fri, 28 Sep 2012 14:33:34 +0200 (CEST) > Guennadi Liakhovetski wrote: > ... > > > @@ -235,12 +238,32 @@ static int mt9v022_s_stream(struct v4l2_subdev *sd, > > > int enable) > > > struct i2c_client *client = v4l2_get_subdevd

account got bounced at vger that might affect patch reviews

2012-09-28 Thread Mauro Carvalho Chehab
Dear developers, Due to some temporary trouble, I was unable to receive emails from linux-media, since 10 hours ago. As I use my IMAP box to check for review e-mails, if you replied to an existing patch during that period of time, and didn't answered it with a Nacked-by/Acked-by tag[1], please pin

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Daniel Vetter
On Fri, Sep 28, 2012 at 02:41:48PM +0200, Maarten Lankhorst wrote: > Documentation says that code requiring dma-buf should add it to > select, so inline fallbacks are not going to be used. A link error > will make it obvious what went wrong, instead of silently doing > nothing at runtime. > > Sign

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Anatolij Gustschin
Hi Guennadi, On Fri, 28 Sep 2012 14:33:34 +0200 (CEST) Guennadi Liakhovetski wrote: ... > > @@ -235,12 +238,32 @@ static int mt9v022_s_stream(struct v4l2_subdev *sd, > > int enable) > > struct i2c_client *client = v4l2_get_subdevdata(sd); > > struct mt9v022 *mt9v022 = to_mt9v022(client);

[PATCH 4/5] reservation: cross-device reservation support

2012-09-28 Thread Maarten Lankhorst
This adds support for a generic reservations framework that can be hooked up to ttm and dma-buf and allows easy sharing of reservations across devices. The idea is that a dma-buf and ttm object both will get a pointer to a struct reservation_object, which has to be reserved before anything is done

[PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Maarten Lankhorst
Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it obvious what went wrong, instead of silently doing nothing at runtime. Signed-off-by: Maarten Lankhorst --- include/linux/dma-buf.h | 99 -

[PATCH 5/5] reservation: Add lockdep annotation and selftests

2012-09-28 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- The self-tests will fail if the commit "lockdep: Check if nested lock is actually held" from linux tip core/locking is not applied. --- drivers/base/reservation.c | 46 +- include/linux/reservation.h | 29 +++- lib/Kconfig.debug |1 l

[PATCH 2/5] fence: dma-buf cross-device synchronization (v9)

2012-09-28 Thread Maarten Lankhorst
A fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call page_flip ioctl to display the next frame of graphics after kicking the GPU but while the GPU is still rendering. T

[PATCH 3/5] seqno-fence: Hardware dma-buf implementation of fencing (v3)

2012-09-28 Thread Maarten Lankhorst
This type of fence can be used with hardware synchronization for simple hardware that can block execution until the condition (dma_buf[offset] - value) >= 0 has been met. A software fallback still has to be provided in case the fence is used with a device that doesn't support this mechanism. It is

[PATCH 3/7] [media] ds3000: properly report register read errors

2012-09-28 Thread Rémi Cardona
This brings both ds3000_readreg() and ds3000_tuner_readreg() in line with ds3000_writereg() and ds3000_tuner_writereg() respectively. Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/med

[PATCH 1/7] [media] ds3000: Declare MODULE_FIRMWARE usage

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index 4c8ac26..46874c7 100644 --- a/drivers/media/dvb-frontends/ds3000.c +++ b/drivers/media/dvb

[PATCH 5/7] [media] ds3000: properly report firmware probing issues

2012-09-28 Thread Rémi Cardona
ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c

[PATCH 4/7] [media] ds3000: bail out early on i2c failures during firmware load

2012-09-28 Thread Rémi Cardona
- if kmalloc() returns NULL, we can return immediately without trying to kfree() a NULL pointer. - if i2c_transfer() fails, error out immediately instead of trying to upload the remaining bytes of the firmware. - the error code is then properly propagated down to ds3000_initfe(). Signed-o

[PATCH 2/7] [media] ds3000: remove useless 'locking'

2012-09-28 Thread Rémi Cardona
Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function ds3000_firmware_ondemand() is called only once during init. This locking scheme may have been useful when the firmware was loaded at each tune. Furthermore, it looks like this 'lock' was put in to prevent concurrent access (and not recur

[PATCH v3 0/7] ds3000/dw2102 improvements

2012-09-28 Thread Rémi Cardona
Hi all, Here's hopefully the final round of patches for ds3000. All of the patches have been rebased on top of today's staging/for_v3.7 branch. Patches 1 through 4 are identical to the previous v2. Patches 5 and 6 are functionally identical, only the printk()s have been removed. Patch 7 is new,

[PATCH 7/7] [media] dw2102: Declare MODULE_FIRMWARE usage

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/usb/dvb-usb/dw2102.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c index 9382895..937c744 100644 --- a/drivers/medi

[PATCH 6/7] [media] ds3000: add module parameter to force firmware upload

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index 59184a8..c66d731 100644 --- a/drivers/media/dvb-frontends/ds3000.c ++

Re: [PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.

2012-09-28 Thread Prabhakar Lad
Hi Hans, On Fri, Sep 28, 2012 at 6:22 PM, Hans Verkuil wrote: > Hi Prabhakar! > > On Fri September 28 2012 14:44:59 Prabhakar Lad wrote: >> Hi Kevin, >> >> On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad wrote: >> > From: Hans Verkuil >> > >> > Signed-off-by: Hans Verkuil >> > Signed-off-by: Lad

Re: [PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.

2012-09-28 Thread Hans Verkuil
Hi Prabhakar! On Fri September 28 2012 14:44:59 Prabhakar Lad wrote: > Hi Kevin, > > On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > Signed-off-by: Lad, Prabhakar > > Signed-off-by: Manjunath Hadli > > --- > > arch/arm/mach

[PATCH 5/7] media: mx2_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx2_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx2_camera.c |5 +++-- 1 files change

[PATCH 1/7] media: sh_mobile_ceu_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in sh_mobile_ceu_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 13 +++

[PATCH 6/7] media: mx1_camera: use the default .set_crop() implementation

2012-09-28 Thread Guennadi Liakhovetski
.set_crop() implementation in mx1_camera is identical with the default. Remove the copy to switch to using the default stab. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx1_camera.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH 0/7] soc-camera and sh_vou cropping constification fixes

2012-09-28 Thread Guennadi Liakhovetski
These patches fix warnings, added by the recent commit commit 4f996594ceaf6c3f9bc42b40c40b0f7f87b79c86 Author: Hans Verkuil Date: Wed Sep 5 05:10:48 2012 -0300 [media] v4l2: make vidioc_s_crop const If there are no objections, I'll include them in my (hopefully) last 3.7-merge pull reques

[PATCH 7/7] media: omap1_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in omap1_camera. Fix them by adjusting a function declaration. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/omap1_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) dif

[PATCH 3/7] media: sh_vou: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in sh_vou. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/sh_vou.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 4/7] media: mx3_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx3_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx3_camera.c |5 +++-- 1 files change

[PATCH 2/7] media: pxa_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in pxa_camera.c. Fix them by adjusting a function declaration. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/pxa_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.

2012-09-28 Thread Prabhakar Lad
Hi Kevin, On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > --- > arch/arm/mach-davinci/board-dm644x-evm.c | 15 ++-- > arch/arm/mach-davinci/dm644x.c |

Re: [git:v4l-dvb/for_v3.7] [media] add LNA support for DVB API

2012-09-28 Thread Hans Verkuil
Hi Antti, Mauro asked me to look into LNA as well, in particular how this could be done on the analog side as well. While reading through this patch I noticed that the new property was added to dtv_property_process_set, but not to dtv_property_process_get. Can you look into that and add 'get' sup

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Guennadi Liakhovetski
Hi Anatolij On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > Some camera systems cannot operate mt9v022 in normal mode and use > only the snapshot mode. The TechNote for mt9v022 (TN0960) and mt9v024 > (TN-09-225) describes required register settings when configuring the > snapshot operation. The

Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Guennadi Liakhovetski
Hi Eric On Fri, 28 Sep 2012, Guennadi Liakhovetski wrote: > Hi Anatolij > > I can take this patch, but we need an ack from a PXA / ARM maintainer. Could we have your ack, please? Thanks Guennadi > On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > > > Set "y_skip_top" to zero and revise commen

Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Guennadi Liakhovetski
Hi Anatolij I can take this patch, but we need an ack from a PXA / ARM maintainer. Thanks Guennadi On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > Set "y_skip_top" to zero and revise comment as I do not see this line > corruption on two different mt9v022 setups. The first read-out line > is pe

Re: tda18271 driver power consumption

2012-09-28 Thread Mauro Carvalho Chehab
Em Thu, 27 Sep 2012 17:58:24 -0400 Michael Krufky escreveu: > On Thu, Sep 27, 2012 at 5:38 PM, Antti Palosaari wrote: > > On 09/28/2012 12:20 AM, Michael Krufky wrote: > > Mike, There is other problem too. PCTV 520e, which is Em28xx + DRX-K + > > TDA18271, fails to attach tuner now. Tuner is wi

[PATCH v3 2/4] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drive

[PATCH v3 3/4] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/dr

[PATCH v3 4/4] ov7670: remove legacy ctrl callbacks.

2012-09-28 Thread Javier Martin
via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file c

[PATCH v3 1/4] ov7670: use the control framework

2012-09-28 Thread Javier Martin
Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v2: - Do not use 'cur.val' to get gain value. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a/drivers/media/i2c/ov7670.

[PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-09-28 Thread Javier Martin
The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

[RFCv2 PATCH] tuner-core: map audmode to STEREO for radio devices.

2012-09-28 Thread Hans Verkuil
Changes since RFCv1: - Improved the commit text - Changed 'if (t->audmode > V4L2_TUNER_MODE_STEREO)' as suggested by Mauro. - Update t->audmode after having called the tuner driver, allowing the tuner driver to modify audmode if it only supports mono. Regards, Hans -- To unsubscribe f

[RFCv2 PATCH] tuner-core: map audmode to STEREO for radio devices.

2012-09-28 Thread Hans Verkuil
From: Hans Verkuil Fixes a v4l2-compliance error: setting audmode to a value other than mono or stereo for a radio device should map to MODE_STEREO. The spec specifies that for radio devices only mono and stereo audmodes are valid. If the user specifies another audmode in v4l2_tuner, then that s

Re: [PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-09-28 Thread Guennadi Liakhovetski
Hi Anatolij On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > With mpc52xx_csi interface I2C subdev streamon after vb2_streamon() > doesn't work due to mpc52xx sensor interface glue-logic restrictions. > > Since mpc5200 doesn't have a camera sensor interface, the sensor on > O2D cameras is connec

Re: [PATCH v2 1/4] ov7670: use the control framework

2012-09-28 Thread javier Martin
Hi Hans, On 28 September 2012 13:05, Hans Verkuil wrote: > On Fri September 28 2012 12:50:55 Javier Martin wrote: >> Signed-off-by: Hans Verkuil >> Signed-off-by: Javier Martin >> --- >> Changes since v1: >> - Use v4l2_ctrl_auto_cluster() for auto_gain and auto_exp. >> >> --- >> drivers/media

[GIT PULL FOR v3.7] Two control framework enhancements

2012-09-28 Thread Hans Verkuil
This pull request adds two new features to the control framework: - a notify function that is needed to have a bridge driver be notified of subdevice control changes - a new filter function to have more control over which controls are added by v4l2_ctrl_add_handler. Both of these features are

Re: [PATCH v2 1/4] ov7670: use the control framework

2012-09-28 Thread Hans Verkuil
On Fri September 28 2012 12:50:55 Javier Martin wrote: > Signed-off-by: Hans Verkuil > Signed-off-by: Javier Martin > --- > Changes since v1: > - Use v4l2_ctrl_auto_cluster() for auto_gain and auto_exp. > > --- > drivers/media/i2c/ov7670.c | 310 >

[PATCH 15/14] OF: define of_*_cmp() macros also if CONFIG_OF isn't set

2012-09-28 Thread Guennadi Liakhovetski
of_*_cmp() macros do not depend on any OF functions and can be defined also if CONFIG_OF isn't set. Also include linux/string.h, required by those macros. Signed-off-by: Guennadi Liakhovetski --- These definitions are also required for "# CONFIG_OF is not set" builds. include/linux/of.h | 15

[PATCH v2 4/4] ov7670: remove legacy ctrl callbacks.

2012-09-28 Thread Javier Martin
via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file changed, 7 deletions(-) dif

[PATCH v2 3/4] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/media/platform/via-ca

[PATCH v2 2/4] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/marvell-c

[PATCH v2 1/4] ov7670: use the control framework

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v1: - Use v4l2_ctrl_auto_cluster() for auto_gain and auto_exp. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a/driver

[PATCH v2 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-09-28 Thread Javier Martin
The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

Re: [GIT PULL FOR v3.7] all the rest patches!

2012-09-28 Thread Antti Palosaari
PULL request updated, contains now 3 fc2580 driver fixes from Gianluca Gennari. Could you handle these quickly :) The following changes since commit 8928b6d1568eb9104cc9e2e6627d7086437b2fb3: [media] media: mx2_camera: use managed functions to clean up code (2012-09-27 15:56:47 -0300) are

[PATCH v7 5/6] [media] s5p-mfc: MFCv6 register definitions

2012-09-28 Thread Arun Kumar K
From: Jeongtae Park Adds register definitions for MFC v6.x firmware Signed-off-by: Jeongtae Park Signed-off-by: Janghyuck Kim Signed-off-by: Jaeryul Oh Signed-off-by: Naveen Krishna Chatradhi Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h | 408 ++

[PATCH v7 4/6] [media] s5p-mfc: Add MFC variant data to device context

2012-09-28 Thread Arun Kumar K
MFC variant data replaces various macros used in the driver which will change in a different version of MFC hardware. Also does a cleanup of MFC context structure and common files. Signed-off-by: Jeongtae Park Signed-off-by: Janghyuck Kim Signed-off-by: Jaeryul Oh Signed-off-by: Naveen Krishna

[PATCH v7 2/6] [media] v4l: Add control definitions for new H264 encoder features

2012-09-28 Thread Arun Kumar K
New controls are added for supporting H264 encoding features like - MVC frame packing - Flexible macroblock ordering - Arbitrary slice ordering - Hierarchial coding Signed-off-by: Jeongtae Park Signed-off-by: Naveen Krishna Chatradhi Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/

[PATCH v7 1/6] [media] v4l: Add fourcc definitions for new formats

2012-09-28 Thread Arun Kumar K
Adds the following new fourcc definitions. For multiplanar YCbCr - V4L2_PIX_FMT_NV21M - V4L2_PIX_FMT_NV12MT_16X16 and compressed formats - V4L2_PIX_FMT_H264_MVC - V4L2_PIX_FMT_VP8 Signed-off-by: Jeongtae Park Signed-off-by: Naveen Krishna Chatradhi Signed-off-by:

[PATCH v7 0/6] Update MFC v4l2 driver to support MFC6.x

2012-09-28 Thread Arun Kumar K
The patchset adds support for MFCv6 firmware in s5p-mfc driver. The patches are rebased to the latest media-tree. Changelog v7 - Removed unused macros from register files Changelog v6 - Use s5p_mfc_hw_call macro to call all HW related ops and cmds - Rebased onto latest media-tree - Resending patc

[PATCH v3] drivers/media: Remove unnecessary semicolon

2012-09-28 Thread Peter Senna Tschudin
A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p

Re: [PATCH] [media] s5p-mfc: Fix misplaced return statement in s5p_mfc_suspend()

2012-09-28 Thread Sylwester Nawrocki
On 09/28/2012 11:21 AM, Kamil Debski wrote: >> -Original Message- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: 28 September 2012 09:02 >> To: linux-media@vger.kernel.org >> Cc: k.deb...@samsung.com; s.nawro...@samsung.com; sachin.ka...@linaro.org; >> patc...@linaro.org >>

[RFCv2 PATCH 2/4] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-28 Thread Hans Verkuil
From: Hans Verkuil length should be set to num_planes in __fill_v4l2_buffer(). That way the caller knows how many planes there are in the buffer. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-c

[RFCv2 PATCH 0/4] vb2 & multiplanar fixes/changes

2012-09-28 Thread Hans Verkuil
Changes since RFCv1: - Don't move num_planes to vb2_queue. In certain circumstances it is possible to have buffers with different number of planes, so keep num_planes in vb2_buffer. This complicated vb2_dqbuf a bit since the plane verification now has to be done just before the buffer is deq

[RFCv2 PATCH 3/4] v4l2-ioctl.c: handle PREPARE_BUF like QUERYBUF.

2012-09-28 Thread Hans Verkuil
From: Hans Verkuil The core code for PREPARE_BUF didn't take the multiplanar case into account, which might cause page faults. Handle PREPARE_BUF just like QUERYBUF and QBUF/DQBUF. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + 1 file changed, 1 insertion(+) di

[RFCv2 PATCH 1/4] videobuf2-core: move plane verification out of __fill_v4l2/vb_buffer.

2012-09-28 Thread Hans Verkuil
From: Hans Verkuil The plane verification should be done before actually queuing or dequeuing buffers, so move it out of __fill_v4l2_buffer and __fill_vb_buffer and call it as a separate step. This also makes it possible to change the return type of __fill_v4l2/vb_buffer to void. The dqbuf case

[RFCv2 PATCH 4/4] DocBook: various updates w.r.t. v4l2_buffer and multiplanar.

2012-09-28 Thread Hans Verkuil
From: Hans Verkuil Clarify the behavior of v4l2_buffer in the multiplanar case, including fixing a false statement: you can't set m.planes to NULL when calling DQBUF. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/io.xml |6 -- Documentation/DocBook/media/

RE: [PATCH] [media] s5p-mfc: Fix misplaced return statement in s5p_mfc_suspend()

2012-09-28 Thread Kamil Debski
Hi Sachin, Thank you for your patch, fixing this bug and testing suspend/resume. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: 28 September 2012 09:02 > To: linux-media@vger.

[PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-09-28 Thread Anatolij Gustschin
With mpc52xx_csi interface I2C subdev streamon after vb2_streamon() doesn't work due to mpc52xx sensor interface glue-logic restrictions. Since mpc5200 doesn't have a camera sensor interface, the sensor on O2D cameras is connected to the LocalPlus bus by special glue-logic. While sensor read-out t

[PATCH 1/2] V4L: soc_camera: add driver for IFM camera sensor interface on mpc5200

2012-09-28 Thread Anatolij Gustschin
IFM O2D cameras use special sensor bus interface glue-logic to connect camera sensors to mpc5200 LocalPlus bus. Add camera sensor driver for this mpc5200 camera interface. Signed-off-by: Anatolij Gustschin --- drivers/media/platform/soc_camera/Kconfig |7 + drivers/media/platform/so

Re: [PATCH 1/3] ov7670: use the control framework

2012-09-28 Thread javier Martin
Hi Hans, On 28 September 2012 10:23, Hans Verkuil wrote: > On Fri September 28 2012 09:48:01 Javier Martin wrote: >> static const struct v4l2_subdev_core_ops ov7670_core_ops = { >> .g_chip_ident = ov7670_g_chip_ident, >> - .g_ctrl = ov7670_g_ctrl, >> - .s_ctrl = ov7670_s_ctrl, >> -

  1   2   >