Re: [PATCH v4] media: v4l2-ctrls: add control for test pattern

2012-09-24 Thread Hans Verkuil
On Tue September 25 2012 08:09:05 Prabhakar wrote: > From: Lad, Prabhakar > > add V4L2_CID_TEST_PATTERN of type menu, which determines > the internal test pattern selected by the device. Acked-by: Hans Verkuil Regards, Hans > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjuna

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 22:11:50 Rémi Denis-Courmont wrote: > Le dimanche 23 septembre 2012 14:43:42, Sakari Ailus a écrit : > > > I think I like this idea best, it's relatively simple (even with adding > > > support for reporting flags in VIDIOC_QUERYBUF) for the purpose. > > > > > > If we ever

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Hans Verkuil
On Tue September 25 2012 02:00:55 Laurent Pinchart wrote: > Hi Hans, > > On Friday 21 September 2012 11:33:24 Hans Verkuil wrote: > > On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > > > Hi all, > > > > > > > > > This RFC intends to summarise and further the recent discussion on > > > lin

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar Lad
Hi Hans, On Tue, Sep 25, 2012 at 11:59 AM, Hans Verkuil wrote: > On Tue September 25 2012 07:38:12 Prabhakar Lad wrote: >> Hi Hans, >> >> On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil wrote: >> > On Mon September 24 2012 15:21:44 Prabhakar Lad wrote: >> >> Hi Hans, >> >> >> >> On Mon, Sep 24, 20

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Tue September 25 2012 07:38:12 Prabhakar Lad wrote: > Hi Hans, > > On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil wrote: > > On Mon September 24 2012 15:21:44 Prabhakar Lad wrote: > >> Hi Hans, > >> > >> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote: > >> > On Mon September 24 2012 12:59

[PATCH v4] media: v4l2-ctrls: add control for test pattern

2012-09-24 Thread Prabhakar
From: Lad, Prabhakar add V4L2_CID_TEST_PATTERN of type menu, which determines the internal test pattern selected by the device. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Acked-by: Sakari Ailus Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Sylwester

Re: [PATCH v3] media: v4l2-ctrls: add control for test pattern

2012-09-24 Thread Prabhakar Lad
Hi Hans, Thanks for the review, On Mon, Sep 24, 2012 at 7:07 PM, Hans Verkuil wrote: > On Mon September 24 2012 14:53:41 Prabhakar wrote: >> From: Lad, Prabhakar >> >> add V4L2_CID_TEST_PATTERN of type menu, which determines >> the internal test pattern selected by the device. >> >> Signed-off-

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar Lad
Hi Hans, On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil wrote: > On Mon September 24 2012 15:21:44 Prabhakar Lad wrote: >> Hi Hans, >> >> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote: >> > On Mon September 24 2012 12:59:11 Hans Verkuil wrote: >> >> On Mon September 24 2012 12:44:11 Prabhak

Re: omap3isp: wrong image after resizer with mt9v034 sensor

2012-09-24 Thread Laurent Pinchart
Hi Enric, On Monday 24 September 2012 15:49:01 Enric Balletbò i Serra wrote: > 2012/9/24 Laurent Pinchart : > > On Monday 24 September 2012 10:33:42 Enric Balletbò i Serra wrote: > >> Hi everybody, > >> > >> I'm trying to add support for MT9V034 Aptina image sensor to current > >> mainline, as a

Re: [PATCH] [media] media-devnode: Replace printk with pr_*

2012-09-24 Thread Laurent Pinchart
Hi Sachin, Thanks for the patch. On Monday 24 September 2012 16:56:24 Sachin Kamat wrote: > Fixes checkpatch warnings related to printk. > > Signed-off-by: Sachin Kamat Acked-by: Laurent Pinchart I've applied the patch to my tree. > --- > drivers/media/media-devnode.c | 14 --

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Laurent Pinchart
Hi Sylwester, On Sunday 23 September 2012 20:40:36 Sylwester Nawrocki wrote: > On 09/22/2012 10:28 PM, Daniel Glöckner wrote: > > On Sat, Sep 22, 2012 at 07:12:52PM +0200, Sylwester Nawrocki wrote: > >> If we ever need the clock selection API I would vote for an IOCTL. > >> The controls API is a b

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Laurent Pinchart
Hi Sylwester, On Saturday 22 September 2012 19:12:52 Sylwester Nawrocki wrote: > On 09/22/2012 02:38 PM, Sakari Ailus wrote: > >> You are missing one other option: > >> > >> Using v4l2_buffer flags to report the clock > >> --- > >> > >> By defining flags l

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Laurent Pinchart
Hi Hans, On Sunday 23 September 2012 11:18:45 Hans Verkuil wrote: > On Sat September 22 2012 14:38:07 Sakari Ailus wrote: > > Hans Verkuil wrote: > > > On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > > >> Hi all, > > >> > > >> > > >> This RFC intends to summarise and further the recent d

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Laurent Pinchart
Hi Hans, On Friday 21 September 2012 11:33:24 Hans Verkuil wrote: > On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > > Hi all, > > > > > > This RFC intends to summarise and further the recent discussion on > > linux-media regarding the proposed changes of timestamping V4L2 buffers. > > >

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Laurent Pinchart
On Friday 21 September 2012 11:33:24 Hans Verkuil wrote: > On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > > Hi all, > > > > > > This RFC intends to summarise and further the recent discussion on > > linux-media regarding the proposed changes of timestamping V4L2 buffers. > > > > > > Th

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Laurent Pinchart
Hi Sakari, On Monday 24 September 2012 23:06:34 Sakari Ailus wrote: > On Sun, Sep 23, 2012 at 04:56:21PM +0530, Prabhakar Lad wrote: > > Hi All, > > > > The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, > > B/Mg gain values. > > Since these control can be re-usable I am plannin

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Laurent Pinchart
On Monday 24 September 2012 12:16:01 Chris MacGregor wrote: > On 09/24/2012 11:46 AM, Hans de Goede wrote: > > On 09/24/2012 07:17 PM, Chris MacGregor wrote: > >> On 09/24/2012 07:42 AM, Prabhakar Lad wrote: > >>> On Mon, Sep 24, 2012 at 4:25 PM, Hans de Goede wrote: > On 09/23/2012 01:26 PM,

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Sakari Ailus
Hi Chris and Hans, On Mon, Sep 24, 2012 at 12:16:01PM -0700, Chris MacGregor wrote: ... > > (I have patches to add the controls, but I haven't had time yet > >to get them into good enough shape to submit - sorry!) > >> > >>It seems to me that for applications that want to set them to > >>the same

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Rémi Denis-Courmont
Le dimanche 23 septembre 2012 14:43:42, Sakari Ailus a écrit : > > I think I like this idea best, it's relatively simple (even with adding > > support for reporting flags in VIDIOC_QUERYBUF) for the purpose. > > > > If we ever need the clock selection API I would vote for an IOCTL. > > The control

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Sakari Ailus
Hi Prabhakar, On Sun, Sep 23, 2012 at 04:56:21PM +0530, Prabhakar Lad wrote: > Hi All, > > The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, > B/Mg gain values. > Since these control can be re-usable I am planning to add the > following gain controls as part > of the framework:

Re: [PATCH] [media] media-devnode: Replace printk with pr_*

2012-09-24 Thread Sakari Ailus
On Mon, Sep 24, 2012 at 04:56:24PM +0530, Sachin Kamat wrote: > Fixes checkpatch warnings related to printk. > > Signed-off-by: Sachin Kamat Thanks, Sachin! Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: se

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Chris MacGregor
Hi, Hans. On 09/24/2012 11:46 AM, Hans de Goede wrote: Hi, On 09/24/2012 07:17 PM, Chris MacGregor wrote: On 09/24/2012 07:42 AM, Prabhakar Lad wrote: Hi Hans, On Mon, Sep 24, 2012 at 4:25 PM, Hans de Goede wrote: Hi, On 09/23/2012 01:26 PM, Prabhakar Lad wrote: Hi All, The CCD/Senso

cron job: media_tree daily build: ERRORS

2012-09-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Sep 24 19:00:24 CEST 2012 git hash:f9040ef3fab8f6f5f6fced5583203695d08efde3 gcc version: i686-linux-gcc (GC

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Hans de Goede
Hi, On 09/24/2012 07:17 PM, Chris MacGregor wrote: On 09/24/2012 07:42 AM, Prabhakar Lad wrote: Hi Hans, On Mon, Sep 24, 2012 at 4:25 PM, Hans de Goede wrote: Hi, On 09/23/2012 01:26 PM, Prabhakar Lad wrote: Hi All, The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, B/

Re: [PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Sakari Ailus
Hi Sylwester, On Mon, Sep 24, 2012 at 06:51:41PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, > > On 09/24/2012 03:44 PM, Sakari Ailus wrote: > > How about useing a separate video buffer queue for the purpose? That would > > provide a nice way to pass it to the user space where it's needed. It'd

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Chris MacGregor
On 09/24/2012 07:42 AM, Prabhakar Lad wrote: Hi Hans, On Mon, Sep 24, 2012 at 4:25 PM, Hans de Goede wrote: Hi, On 09/23/2012 01:26 PM, Prabhakar Lad wrote: Hi All, The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, B/Mg gain values. Since these control can be re-usable

Re: [PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Sylwester Nawrocki
Hi Laurent, On 09/24/2012 03:58 PM, Laurent Pinchart wrote: >> How about useing a separate video buffer queue for the purpose? That would >> provide a nice way to pass it to the user space where it's needed. It'd also >> play nicely together with the frame layout descriptors. > > Beside, a void *

Re: [PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Sylwester Nawrocki
Hi Sakari, On 09/24/2012 03:44 PM, Sakari Ailus wrote: > How about useing a separate video buffer queue for the purpose? That would > provide a nice way to pass it to the user space where it's needed. It'd also > play nicely together with the frame layout descriptors. It's tempting, but doing fra

[PATCH 2/2] video: add generic videomode description

2012-09-24 Thread Steffen Trumtrar
Backend-independent videomode. At the moment this is not very different from fb_mode or drm_mode. It is supposed to be a generic description of videomodes and conversion step to the desired backend video mode representation. At the moment, only really makes sense when used with of_display Signed-o

[PATCH 1/2] of: add helper to parse display specs

2012-09-24 Thread Steffen Trumtrar
Parse a display-node with timings and hardware-specs from devictree. Signed-off-by: Steffen Trumtrar --- Documentation/devicetree/bindings/video/display | 208 +++ drivers/of/Kconfig |5 + drivers/of/Makefile |

RE: mt9t031 driver support on OMAP3 system

2012-09-24 Thread John Weber
Hi Pete, The next issue to solve is auto-exposure/white balance (AEWB). For this, Laurent has put together a nice example application in a project called omap3-isp-live [1]. This project builds two programs, 'live' and 'snapshot'. For my purposes, I want to have live streaming video. 'live' mak

[PATCH v5] of: add display helper (was: of: add videomode helper)

2012-09-24 Thread Steffen Trumtrar
Hi! After the feedback I got on v4, I thought about the current state of the videomode helper and decided to reengineer it. The most confusion seems to stem from the fact, that a videomode does not have ranges. And that is correct. Therefore the description of the display now uses a list of timi

Re: [PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support

2012-09-24 Thread Sylwester Nawrocki
On 09/24/2012 04:55 PM, Sylwester Nawrocki wrote: > Hi All, > > This patch series adds device/vendor specific media bus pixel code section > and defines S5C73MX camera specific media bus pixel code, along with > corresponding fourcc. I realize this isn't probably the best possible > solution but I

RE: [RFC] Frame format descriptors

2012-09-24 Thread Vincent ABRIOU
Hi Sakari Thank you for sharing your opinion on this subject. I know that for you it is an old topics but I would like to revive this RFC by asking you some questions about your proposal in order to move forward on this subject. Indeed, stream format description is very important and mandatory

[PATCH RFC 4/5] s5p-fimc: Add support for V4L2_PIX_FMT_S5C_UYVY_JPG fourcc

2012-09-24 Thread Sylwester Nawrocki
The V4L2_PIX_FMT_S5C_YUYV_JPG image format consists of 2 planes, the first containing interleaved JPEG/YUYV image data followed by meta-data describing the interleaving method and the second plane containing suplementary frame meta data. The image data is transferred with MIPI-CSI "User Defined By

[PATCH RFC 5/5] m5mols: Implement .get_frame_desc subdev callback

2012-09-24 Thread Sylwester Nawrocki
.get_frame_desc can be used by host interface driver to query properties of captured frames, e.g. required memory buffer size. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/i2c/m5mols/m5mols.h | 9 ++ drivers/media/i2c/m5mols/m5mols_capture.c | 3

[PATCH RFC 3/5] s5p-csis: Add support for non-image data packets capture

2012-09-24 Thread Sylwester Nawrocki
MIPI-CSI has internal memory mapped buffers for the frame embedded (non-image) data. There are two buffers, for even and odd frames which need to be saved after an interrupt is raised. The packet data buffers size is 4 KiB and there is no status register in the hardware where the actual non-image d

[PATCH RFC 2/5] V4L: Add V4L2_PIX_FMT_S5C_UYVY_JPG fourcc definition

2012-09-24 Thread Sylwester Nawrocki
The V4L2_PIX_FMT_S5C_UYVY_JPG is a two-plane image format used by Samsung S5C73M3 camera. The first plane contains interleaved UYVY and JPEG data, followed by meta-data in form of offsets to the UYVU data blocks. The second plane contains additional meta-data needed for extracting JPEG and UYVY da

[PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format

2012-09-24 Thread Sylwester Nawrocki
This patch adds media bus pixel code for the interleaved JPEG/UYVY image format used by S5C73MX Samsung cameras. This interleaved image data is transferred on MIPI-CSI2 bus as User Defined Byte-based Data. It also defines an experimental vendor and device specific media bus formats section and add

[PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support

2012-09-24 Thread Sylwester Nawrocki
Hi All, This patch series adds device/vendor specific media bus pixel code section and defines S5C73MX camera specific media bus pixel code, along with corresponding fourcc. I realize this isn't probably the best possible solution but I don't know how to better handle this without major changes in

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Prabhakar Lad
Hi Hans, On Mon, Sep 24, 2012 at 4:25 PM, Hans de Goede wrote: > Hi, > > > On 09/23/2012 01:26 PM, Prabhakar Lad wrote: >> >> Hi All, >> >> The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, >> B/Mg gain values. >> Since these control can be re-usable I am planning to add the >>

[PATCH] media-ctl: Fix build error with newer autotools

2012-09-24 Thread Gary Thomas
Rename configure.in to be configure.ac - required for newer versions of autotools (older versions silently handled this, now it's an error) Signed-off-by: Gary Thomas --- configure.ac | 93 ++ configure.in | 93 --

[PATCH] media_build: add module_pci_driver to compat.h

2012-09-24 Thread Gianluca Gennari
This patch corrects this warnings on a Ubuntu 10.04 system with kernel 2.6.32-43: bt87x.c:972: warning: data definition has no type or storage class bt87x.c:972: warning: type defaults to 'int' in declaration of 'module_pci_driver' bt87x.c:972: warning: parameter names (without types) in functio

Re: [PATCH 1/4] gspca_pac7302: correct register documentation

2012-09-24 Thread Hans de Goede
Hi, On 09/23/2012 03:29 PM, Frank Schäfer wrote: R,G,B balance registers are 0x01-0x03 instead of 0x02-0x04, which lead to the wrong conclusion that values are inverted. Exposure is controlled via page 3 registers and this is already documented. Also fix a whitespace issue. Signed-off-by: Frank

Re: [PATCH 2/4] pwc: Add return code check at vb2_queue_init()

2012-09-24 Thread Hans de Goede
Hi, Thanks I've added this to my media tree and it will be included in my next pull-req to Mauro. Regards, Hans On 09/17/2012 03:47 PM, elezegar...@gmail.com wrote: From: Ezequiel Garcia This function returns an integer and it's mandatory to check the return code. Cc: Hans de Goede Signe

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-24 Thread Hans de Goede
Hi, On 09/24/2012 03:36 PM, Frank Schäfer wrote: Hi Hans, Am 24.09.2012 12:47, schrieb Hans de Goede: Hi, Sorry for the slow response ... On 09/20/2012 01:54 PM, Frank Schäfer wrote: Hi, Am 20.09.2012 11:08, schrieb Hans de Goede: Many webcams have RGB gains, but we don't have standar

[PATCH RFC] V4L: Add get/set_frame_desc subdev callbacks

2012-09-24 Thread Sylwester Nawrocki
Add subdev callbacks for setting up and retrieving parameters of the frame on media bus that are not exposed to user space directly. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Hi All, This patch is intended as an initial, mostly a stub, implementation of the media bus f

Re: [PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Laurent Pinchart
On Monday 24 September 2012 16:44:54 Sakari Ailus wrote: > On Mon, Sep 24, 2012 at 03:26:53PM +0200, Sylwester Nawrocki wrote: > > The s_rx_buffer callback allows the host to set buffer for non-image > > (meta) data at a subdev. This callback can be implemented by an image > > sensor or a MIPI-CSI

Re: [RFCv1 PATCH 4/6] videobuf2-core: fill in length field for multiplanar buffers.

2012-09-24 Thread Hans Verkuil
On Fri September 21 2012 18:54:12 Hans Verkuil wrote: > On Fri September 21 2012 18:47:54 Sylwester Nawrocki wrote: > > On 09/21/2012 06:23 PM, Hans Verkuil wrote: > > > On Fri September 21 2012 18:13:20 Sylwester Nawrocki wrote: > > >> Hi Hans, > > >> > > >> On 09/19/2012 04:37 PM, Hans Verkuil wr

Re: omap3isp: wrong image after resizer with mt9v034 sensor

2012-09-24 Thread Enric Balletbò i Serra
Hi Laurent, 2012/9/24 Laurent Pinchart : > Hi Enric, > > On Monday 24 September 2012 10:33:42 Enric Balletbò i Serra wrote: >> Hi everybody, >> >> I'm trying to add support for MT9V034 Aptina image sensor to current >> mainline, as a base of my current work I start using the latest >> omap3isp-nex

Re: [PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Sakari Ailus
Hi Sylwester, On Mon, Sep 24, 2012 at 03:26:53PM +0200, Sylwester Nawrocki wrote: > The s_rx_buffer callback allows the host to set buffer for non-image > (meta) data at a subdev. This callback can be implemented by an image > sensor or a MIPI-CSI receiver, allowing the host to retrieve the frame

Re: [PATCH v3] media: v4l2-ctrls: add control for test pattern

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 14:53:41 Prabhakar wrote: > From: Lad, Prabhakar > > add V4L2_CID_TEST_PATTERN of type menu, which determines > the internal test pattern selected by the device. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Acked-by: Sakari Ailus > Cc: Hans Ver

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-24 Thread Frank Schäfer
Hi Hans, Am 24.09.2012 12:47, schrieb Hans de Goede: > Hi, > > Sorry for the slow response ... > > On 09/20/2012 01:54 PM, Frank Schäfer wrote: >> Hi, >> >> Am 20.09.2012 11:08, schrieb Hans de Goede: > > > >>> Many webcams have RGB gains, but we don't have standard CID-s for >>> these, >>> inste

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 15:21:44 Prabhakar Lad wrote: > Hi Hans, > > On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote: > > On Mon September 24 2012 12:59:11 Hans Verkuil wrote: > >> On Mon September 24 2012 12:44:11 Prabhakar wrote: > >> > From: Lad, Prabhakar > >> > > >> > vpif_display reli

[PATCH RFC] V4L: Add s_rx_buffer subdev video operation

2012-09-24 Thread Sylwester Nawrocki
The s_rx_buffer callback allows the host to set buffer for non-image (meta) data at a subdev. This callback can be implemented by an image sensor or a MIPI-CSI receiver, allowing the host to retrieve the frame embedded data from a subdev. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar Lad
Hi Hans, On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote: > On Mon September 24 2012 12:59:11 Hans Verkuil wrote: >> On Mon September 24 2012 12:44:11 Prabhakar wrote: >> > From: Lad, Prabhakar >> > >> > vpif_display relied on a 1-1 mapping of output and subdev. This is not >> > necessarily

Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-24 Thread Laurent Pinchart
On Monday 24 September 2012 18:23:40 Prabhakar wrote: > From: Lad, Prabhakar > > Add helper function v4l2_ctrl_new_std_menu_items(), which adds > a standard menu control, with driver specific menu. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Hans Verkuil > Cc: Sak

Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 14:53:40 Prabhakar wrote: > From: Lad, Prabhakar > > Add helper function v4l2_ctrl_new_std_menu_items(), which adds > a standard menu control, with driver specific menu. Acked-by: Hans Verkuil Regards, Hans > > Signed-off-by: Lad, Prabhakar > Signed-off-by:

Re: [PATCH 2/3 V2] fc2580: silence uninitialized variable warning

2012-09-24 Thread Antti Palosaari
On 09/24/2012 03:51 PM, Gianluca Gennari wrote: fc2580.c: In function 'fc2580_set_params': fc2580.c:118: warning: 'ret' may be used uninitialized in this function V2: fixed coding style. Signed-off-by: Gianluca Gennari Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari --- drivers

[PATCH v3] media: v4l2-ctrls: add control for test pattern

2012-09-24 Thread Prabhakar
From: Lad, Prabhakar add V4L2_CID_TEST_PATTERN of type menu, which determines the internal test pattern selected by the device. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Acked-by: Sakari Ailus Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Sylwester

[PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu

2012-09-24 Thread Prabhakar
From: Lad, Prabhakar Add helper function v4l2_ctrl_new_std_menu_items(), which adds a standard menu control, with driver specific menu. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Cc: Hans Verkuil Cc: Sakari Ailus Cc: Sylwester Nawrocki Cc: Laurent Pinchart Cc: Mauro Carva

[PATCH 2/3 V2] fc2580: silence uninitialized variable warning

2012-09-24 Thread Gianluca Gennari
fc2580.c: In function 'fc2580_set_params': fc2580.c:118: warning: 'ret' may be used uninitialized in this function V2: fixed coding style. Signed-off-by: Gianluca Gennari --- drivers/media/tuners/fc2580.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tu

RE: [PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-24 Thread Marek Szyprowski
Hello, It would be great if you could keep the correct authorship of the patch by adding the following line on top of the patch (git will handle it automatically after applying): -->8-- From: Marek Szyprowski -->8-- On Monday, September 24, 2012 12:59 PM Federico Vaga wrote: > This patch adds

RE: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-24 Thread Marek Szyprowski
Hello, On Monday, September 24, 2012 12:59 PM Federico Vaga wrote: > The DMA streaming allocator is similar to the DMA contig but it use the > DMA streaming interface (dma_map_single, dma_unmap_single). The > allocator allocates buffers and immediately map the memory for DMA > transfer. For each

Re: omap3isp: wrong image after resizer with mt9v034 sensor

2012-09-24 Thread Laurent Pinchart
Hi Enric, On Monday 24 September 2012 10:33:42 Enric Balletbò i Serra wrote: > Hi everybody, > > I'm trying to add support for MT9V034 Aptina image sensor to current > mainline, as a base of my current work I start using the latest > omap3isp-next branch from Laurent's git tree [1]. The MT9V034 i

Re: mt9t031 driver support on OMAP3 system

2012-09-24 Thread Laurent Pinchart
Hi Pete, On Sunday 23 September 2012 00:04:20 Guennadi Liakhovetski wrote: > On Sat, 22 Sep 2012, P Jackson wrote: > > I'm trying to incorporate an MT9T031-based sensor into a commercial > > small form-factor OMAP3 DM3730-based system which is supplied with > > sources for a 2.6.37 kernel and is s

Re: [PULL FOR v3.7] OMAP3 ISP patches

2012-09-24 Thread Laurent Pinchart
Hi Mauro, Here's an additional patch if there's still time. The following changes since commit f9040ef3fab8f6f5f6fced5583203695d08efde3:

Re: [PATCHv8 02/26] Documentation: media: description of DMABUF importing in V4L2

2012-09-24 Thread Tomasz Stanislawski
Hi Hans, Thank you for review. On 08/22/2012 12:47 PM, Hans Verkuil wrote: > On Tue August 14 2012 17:34:32 Tomasz Stanislawski wrote: >> This patch adds description and usage examples for importing >> DMABUF file descriptor in V4L2. >> >> Signed-off-by: Tomasz Stanislawski >> Signed-off-by: Kyun

Re: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code

2012-09-24 Thread Laurent Pinchart
Hi, On Sunday 23 September 2012 19:46:53 Peter Senna Tschudin wrote: > On Sun, Sep 23, 2012 at 7:39 PM, Mauro Carvalho Chehab wrote: > > Laurent, > > > > Could you please review this patch? > > > > Peter, > > > > Please, always c/c the driver maintainer/author on patches you submit. > > > > Yo

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 13:50:00 Hans Verkuil wrote: > On Mon September 24 2012 12:59:11 Hans Verkuil wrote: > > On Mon September 24 2012 12:44:11 Prabhakar wrote: > > > From: Lad, Prabhakar > > > > > > vpif_display relied on a 1-1 mapping of output and subdev. This is not > > > necessarily the

Re: [PATCH 3/3] fc2580: use macro for 64 bit division and reminder

2012-09-24 Thread Antti Palosaari
On 09/24/2012 02:37 PM, Gianluca Gennari wrote: Fixes the following warnings on a 32 bit system with GCC 4.4.3 and kernel Ubuntu 2.6.32-43 32 bit: WARNING: "__udivdi3" [fc2580.ko] undefined! WARNING: "__umoddi3" [fc2580.ko] undefined! Signed-off-by: Gianluca Gennari Acked-by: Antti Palosaar

Re: [PATCH 2/3] fc2580: silence uninitialized variable warning

2012-09-24 Thread Antti Palosaari
On 09/24/2012 02:37 PM, Gianluca Gennari wrote: fc2580.c: In function 'fc2580_set_params': fc2580.c:118: warning: 'ret' may be used uninitialized in this function Signed-off-by: Gianluca Gennari --- drivers/media/tuners/fc2580.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) di

Re: [PATCH 1/3] fc2580: define const as UL to silence a warning

2012-09-24 Thread Antti Palosaari
On 09/24/2012 02:37 PM, Gianluca Gennari wrote: fc2580.c: In function 'fc2580_set_params': fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90 Signed-off-by: Gianluca Gennari Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari --- drivers/media/tuners/fc2580.c |

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 12:59:11 Hans Verkuil wrote: > On Mon September 24 2012 12:44:11 Prabhakar wrote: > > From: Lad, Prabhakar > > > > vpif_display relied on a 1-1 mapping of output and subdev. This is not > > necessarily the case. Separate the two. So there is a list of subdevs > > and a li

[PATCH 3/3] fc2580: use macro for 64 bit division and reminder

2012-09-24 Thread Gianluca Gennari
Fixes the following warnings on a 32 bit system with GCC 4.4.3 and kernel Ubuntu 2.6.32-43 32 bit: WARNING: "__udivdi3" [fc2580.ko] undefined! WARNING: "__umoddi3" [fc2580.ko] undefined! Signed-off-by: Gianluca Gennari --- drivers/media/tuners/fc2580.c |3 +-- 1 files changed, 1 insertions

[PATCH 2/3] fc2580: silence uninitialized variable warning

2012-09-24 Thread Gianluca Gennari
fc2580.c: In function 'fc2580_set_params': fc2580.c:118: warning: 'ret' may be used uninitialized in this function Signed-off-by: Gianluca Gennari --- drivers/media/tuners/fc2580.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tuners/fc2580.c b/drivers/m

[PATCH 1/3] fc2580: define const as UL to silence a warning

2012-09-24 Thread Gianluca Gennari
fc2580.c: In function 'fc2580_set_params': fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90 Signed-off-by: Gianluca Gennari --- drivers/media/tuners/fc2580.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tuners/fc2580.c b/drivers/

[PATCH 0/3] Fix several warnings on new fc2580 tuner driver

2012-09-24 Thread Gianluca Gennari
Hi all, this small patch series fixes the warnings generated compiling the new fc2580 tuner driver on a Ubuntu system with the 2.6.32-43 32 bit kernel and GCC 4.4.3. Compile tested only. Best regards, Gianluca Gennari Gianluca Gennari (3): fc2580: define const as UL to silence a warning fc25

[PATCH] [media] media-devnode: Replace printk with pr_*

2012-09-24 Thread Sachin Kamat
Fixes checkpatch warnings related to printk. Signed-off-by: Sachin Kamat --- drivers/media/media-devnode.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index f6b52d5..023b2a1 100644 --- a/drive

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Laurent Pinchart
On Sunday 23 September 2012 19:27:03 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Sunday 23 September 2012 16:20:06 Sakari Ailus wrote: > >> Prabhakar Lad wrote: > >>> Hi All, > >>> > >>> The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, > >>> B/Mg gain values. > >>> Sin

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Hans de Goede
Hi, On 09/24/2012 01:00 PM, Laurent Pinchart wrote: Hi Hans, On Monday 24 September 2012 12:55:53 Hans de Goede wrote: On 09/23/2012 01:26 PM, Prabhakar Lad wrote: Hi All, The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, B/Mg gain values. Since these control can be re-usa

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Laurent Pinchart
Hi Hans, On Monday 24 September 2012 12:55:53 Hans de Goede wrote: > On 09/23/2012 01:26 PM, Prabhakar Lad wrote: > > Hi All, > > > > The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, > > B/Mg gain values. > > Since these control can be re-usable I am planning to add the > > fo

Re: [PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 12:44:11 Prabhakar wrote: > From: Lad, Prabhakar > > vpif_display relied on a 1-1 mapping of output and subdev. This is not > necessarily the case. Separate the two. So there is a list of subdevs > and a list of outputs. Each output refers to a subdev and has routing > in

[PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-24 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimo

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-24 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x1

[PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-24 Thread Federico Vaga
The DMA streaming allocator is similar to the DMA contig but it use the DMA streaming interface (dma_map_single, dma_unmap_single). The allocator allocates buffers and immediately map the memory for DMA transfer. For each buffer prepare/finish it does a DMA synchronization. Signed-off-by: Federico

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-24 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

Re: Gain controls in v4l2-ctrl framework

2012-09-24 Thread Hans de Goede
Hi, On 09/23/2012 01:26 PM, Prabhakar Lad wrote: Hi All, The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, B/Mg gain values. Since these control can be re-usable I am planning to add the following gain controls as part of the framework: 1: V4L2_CID_GAIN_RED 2: V4L2_CID_GAIN_

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-24 Thread Hans de Goede
Hi, Sorry for the slow response ... On 09/20/2012 01:54 PM, Frank Schäfer wrote: Hi, Am 20.09.2012 11:08, schrieb Hans de Goede: Many webcams have RGB gains, but we don't have standard CID-s for these, instead we've Blue and Red Balance. This has grown historically because of the bttv car

[PATCH v2] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar
From: Lad, Prabhakar vpif_display relied on a 1-1 mapping of output and subdev. This is not necessarily the case. Separate the two. So there is a list of subdevs and a list of outputs. Each output refers to a subdev and has routing information. An output does not have to have a subdev. The initi

Re: [PATCH] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Mon, Sep 24, 2012 at 3:39 PM, Hans Verkuil wrote: > On Mon September 24 2012 12:02:26 Prabhakar wrote: >> From: Lad, Prabhakar >> >> vpif_display relied on a 1-1 mapping of output and subdev. This is not >> necessarily the case. Separate the two. So there is a

Re: [PATCH] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Hans Verkuil
On Mon September 24 2012 12:02:26 Prabhakar wrote: > From: Lad, Prabhakar > > vpif_display relied on a 1-1 mapping of output and subdev. This is not > necessarily the case. Separate the two. So there is a list of subdevs > and a list of outputs. Each output refers to a subdev and has routing > in

[PATCH RFC] s5p-tv: Report only multi-plane capabilities in vidioc_querycap

2012-09-24 Thread Sylwester Nawrocki
The mixer video node supports only multi-planar API so the driver should not be setting V4L2_CAP_VIDEO_OUTPUT flags. Fix this and also switch to device_caps. Additionally fix the VIDIOC_ENUM_FMT ioctl handler which now works for V4L2_BUF_TYPE_CAPTURE, rather than expected V4L2_BUF_TYPE_CAPTURE_MPLA

[PATCH] media: davinci: vpif: display: separate out subdev from output

2012-09-24 Thread Prabhakar
From: Lad, Prabhakar vpif_display relied on a 1-1 mapping of output and subdev. This is not necessarily the case. Separate the two. So there is a list of subdevs and a list of outputs. Each output refers to a subdev and has routing information. An output does not have to have a subdev. The initi

Re: Fwd: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Sylwester Nawrocki
On 09/23/2012 09:30 PM, Mauro Carvalho Chehab wrote: > Sylwester, > > Please review. > > Regards, > Mauro > > Mensagem original > Assunto: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return > code > Data: Thu, 6 Sep 2012 10:38:29 +0200 > De: Peter Senna Tsch

Re: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Tomasz Stanislawski
Hi. On 09/06/2012 10:38 AM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle

[PATCH V2 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code

2012-09-24 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

[PATCH] [media] s5p-fimc: Use the new linux/sizes.h header file

2012-09-24 Thread Sachin Kamat
Replaces asm/sizes.h with linux/sizes.h. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/fimc-core.h |2 +- drivers/media/platform/s5p-fimc/fimc-lite.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-core.h b/dri

Re: [PATCH] [media] s5p-tv: Fix potential NULL pointer dereference error

2012-09-24 Thread Tomasz Stanislawski
On 09/22/2012 09:39 AM, Sachin Kamat wrote: > When mdev is NULL, the error print statement will try to dereference > the NULL pointer. > > Signed-off-by: Sachin Kamat > --- > drivers/media/platform/s5p-tv/mixer_drv.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a

Re: [RFC] Timestamps and V4L2

2012-09-24 Thread Hans Verkuil
On Sun September 23 2012 15:07:24 Sakari Ailus wrote: > Hi Hans, > > Hans Verkuil wrote: > > On Sat September 22 2012 14:38:07 Sakari Ailus wrote: > >> Hi Hans, > >> > >> Thanks for the comments. > >> > >> Hans Verkuil wrote: > >>> On Thu September 20 2012 22:21:22 Sakari Ailus wrote: > ... >

  1   2   >