Re: [PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

2012-09-15 Thread YunQiang Su
I upgrade my system yesterday, and this morning, it panic always, even I boot another system first and reboot. Both the kernel in testing and experimental have this problem. On Wed, Aug 29, 2012 at 4:48 AM, Luis Henriques wrote: > On Tue, Aug 28, 2012 at 10:09:55AM -0700, Ben Hutchings wrote: >>

Re: [PATCH 6/6] [media] ds3000: add module parameter to force firmware upload

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: Signed-off-by: Rémi Cardona Reviewed-by: Antti Palosaari With same comments as earlier patch. --- drivers/media/dvb/frontends/ds3000.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb/frontends/d

Re: [PATCH 5/6] [media] ds3000: properly report firmware probing issues

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Also print out a message

Re: [PATCH 4/6] [media] ds3000: bail out early on i2c failures during firmware load

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: - if kmalloc() returns NULL, we can return immediately without trying to kfree() a NULL pointer. - if i2c_transfer() fails, error out immediately instead of trying to upload the remaining bytes of the firmware. - the error code is then pro

Re: [PATCH 3/6] [media] ds3000: properly report register read errors

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: This brings both ds3000_readreg() and ds3000_tuner_readreg() in line with ds3000_writereg() and ds3000_tuner_writereg() respectively. Signed-off-by: Rémi Cardona Reviewed-by: Antti Palosaari Not related, but just guess, register 03 value 12 opens

Re: [PATCH 2/6] [media] ds3000: remove useless 'locking'

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function ds3000_firmware_ondemand() is called only once during init. This locking scheme may have been useful when the firmware was loaded at each tune. Furthermore, it looks like this 'lock' was put

Re: [PATCH 1/6] [media] ds3000: Declare MODULE_FIRMWARE usage

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: Signed-off-by: Rémi Cardona Reviewed-by: Antti Palosaari -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH v2 0/6] ds3000 improvements

2012-09-15 Thread Antti Palosaari
On 09/14/2012 12:27 PM, Rémi Cardona wrote: Hi all, Here is an updated and more complete patch series for ds3000. I've done my testing on top of kernel 3.5.2 and things look ok so far. Reviews and comments are again more than welcome. I reviewed it and I was near to test it also, but patches

Re: [PATCH 6/6] DVB API: LNA documentation

2012-09-15 Thread Antti Palosaari
On 09/12/2012 03:45 PM, Mauro Carvalho Chehab wrote: Em 12-09-2012 08:01, David Waring escreveu: On 11/09/12 19:38, Mauro Carvalho Chehab wrote: Em 16-08-2012 22:35, Antti Palosaari escreveu: [snip] + Possible values: 0, 1, INT_MIN Hmm... INT_MIN... are you sure it is portable on all L

Re: [PATCH 4/4] dvb_frontend: add routine for DTMB parameter validation

2012-09-15 Thread Antti Palosaari
On 09/11/2012 10:43 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DTMB parameters correctness. I won't repeat myself on the stuff I commented on patch 1/4. I dunno much about this stand

Re: [PATCH 3/4] dvb_frontend: add routine for DVB-C annex A parameter validation

2012-09-15 Thread Antti Palosaari
On 09/11/2012 10:40 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-C annex A parameters correctness. Signed-off-by: Antti Palosaari I won't repeat myself on the stuff I commented on

Re: [PATCH 2/4] dvb_frontend: add routine for DVB-T2 parameter validation

2012-09-15 Thread Antti Palosaari
On 09/11/2012 10:33 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-T2 parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 118

Re: [PATCH 1/4] dvb_frontend: add routine for DVB-T parameter validation

2012-09-15 Thread Antti Palosaari
On 09/11/2012 10:23 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-T parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 136 +

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2012 20:12:49 +0200 Anders Thomson escreveu: > On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: > > Em Sat, 15 Sep 2012 19:39:31 +0200 > > Anders Thomson escreveu: > > > > > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > > > $ cat /TV_CARD.diff > > > > > diff --

[PATCH 2/2] smiapp: Provide module identification information through sysfs

2012-09-15 Thread Sakari Ailus
From: Sakari Ailus Provide module ident information through sysfs. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 28 ++-- 1 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media

[PATCH 1/2] smiapp: Use highest bits-per-pixel for sensor internal format

2012-09-15 Thread Sakari Ailus
The format shown on the links internal to the sensor was the first one enumerated from the sensor, not the highest bit depth data that can be produced by the sensor. Correct this. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c |6 +- 1 files changed, 5 insertions(

[PATCH 0/2] SMIA++ driver improvements

2012-09-15 Thread Sakari Ailus
Hi, The first one of these two small patches fixes a minor issue in format enumeration from the sensor, whereas the second one provides the module identification information to the user space through a sysfs file. Regards, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list:

[PATCH 1/2] MAINTAINERS: Remove entries for drivers that got removed

2012-09-15 Thread Mauro Carvalho Chehab
Those two drivers got removed, as gspca replaced both. So, remove the old entries. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS | 17 - 1 file changed, 17 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 91b79ba..ada8f05 100644 --- a/MAINTAINERS +++ b/MAINTAINER

[PATCH 2/2] MAINTAINERS: fix the path for the media drivers that got renamed

2012-09-15 Thread Mauro Carvalho Chehab
Due to the media tree path renaming, several drivers change their location. Update MAINTAINERS accordingly. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Sylwester Nawrocki
On 09/15/2012 02:35 PM, Hans Verkuil wrote: If we switch all existing drivers to monotonic timestamps in kernel release 3.x, v4l2-compliance can just use the version it gets from VIDIOC_QUERYCAP and enforce monotonic timestamps verification if the version is>= 3.x. This i

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: Em Sat, 15 Sep 2012 19:39:31 +0200 Anders Thomson escreveu: > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > $ cat /TV_CARD.diff > > > diff --git a/drivers/media/common/tuners/tda8290.c > > > b/drivers/media/common/tuners/t

cron job: media_tree daily build: ERRORS

2012-09-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sat Sep 15 19:00:38 CEST 2012 git hash:3404cb5c4dbbbac884722f418d5561d81dba969f gcc version: i686-linux-gcc (GC

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2012 19:39:31 +0200 Anders Thomson escreveu: > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > $ cat /TV_CARD.diff > > > diff --git a/drivers/media/common/tuners/tda8290.c > > > b/drivers/media/common/tuners/tda8290.c > > > index 064d14c..498cc7b 100644 > > > --- a/dri

Re: [PATCH] v3 Add support to Avermedia Twinstar double tuner in af9035

2012-09-15 Thread Antti Palosaari
Hello Could you split that patch to 2? 1) mxl5007t changes 2) af9035/af9033 dual mode 3) af9035/af9033 changes needed for mxl5007t I cannot say much about tuner changes, but I still wonder are those really needed as this device is already supported. Is it broken currently? What happens when no_

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 19:39, Anders Thomson wrote: On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > $ cat /TV_CARD.diff > > diff --git a/drivers/media/common/tuners/tda8290.c > > b/drivers/media/common/tuners/tda8290.c > > index 064d14c..498cc7b 100644 > > --- a/drivers/media/common/t

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > $ cat /TV_CARD.diff > diff --git a/drivers/media/common/tuners/tda8290.c > b/drivers/media/common/tuners/tda8290.c > index 064d14c..498cc7b 100644 > --- a/drivers/media/common/tuners/tda8290.c > +++ b/drivers/media/common/tuners/tda8290.c

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Thu, 30 Aug 2012 13:27:21 +0200 Anders Thomson escreveu: > Hi, > > Ever since 2.6.26 or so (where there was a code reorg) I had to carry > this patch. > Without it the received signal is noisy, and the card worked fine prior > to the code > reorg. This patch is a hack, mostly as a result of

[PATCH] exynos-gsc: Add missing Makefile

2012-09-15 Thread Sylwester Nawrocki
Add missing Makefile that got lost while rebasing commit 655ceff16b45c847 "[media] gscaler: Add Makefile for G-Scaler Driver" onto latest source tree. Signed-off-by: Sylwester Nawrocki --- Mauro, my apologies for this omission. I somehow missed to add the Makefile while rebasing on latest media

Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

2012-09-15 Thread Mauro Carvalho Chehab
Em Thu, 13 Sep 2012 06:03:21 +0200 Laurent Pinchart escreveu: > Hi Wanlong, > > Thanks for the patch. > > On Monday 27 August 2012 15:23:15 Wanlong Gao wrote: > > At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be > > translated as ENOTTY to user mode. > > > > Cc: Laurent Pinchar

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2012 12:22:48 -0300 Ezequiel Garcia escreveu: > Mauro, > > (Cc got messed up, so I'm sending this to you and media list) > > On Sat, Sep 15, 2012 at 10:37 AM, Mauro Carvalho Chehab > wrote: > > Em Sat, 15 Sep 2012 10:05:40 -0300 > > Ezequiel Garcia escreveu: > > > >> On Sat, Se

Fw: [PATCH] Corrected Oops on omap_vout when no manager is connected

2012-09-15 Thread Mauro Carvalho Chehab
Prabhakar, Please review. Thanks! Mauro Forwarded message: Date: Fri, 24 Aug 2012 17:54:11 +0200 From: Federico Fuga To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, Federico Fuga Subject: [PATCH] Corrected Oops on omap_vout when no manager is connected If no manager is connected

[PATCH] [media] gscaler: mark it as BROKEN

2012-09-15 Thread Mauro Carvalho Chehab
-EMISSINGMAKEFILE Without a Makefile, the driver will not compile, causing breakages for arm exynos5 sub-architecture. Cc: Shaik Ameer Basha Cc: Sungchun Kang Cc: "Seung-Woo Kim/Mobile S/W Platform Lab(DMC)/E4" Cc: Kyungmin Park Cc: Sylwester Nawrocki Signed-off-by: Mauro Carvalho Chehab -

Re: [GIT PATCHES FOR v3.7] V4L: Exynos5 SoC GScaler driver

2012-09-15 Thread Mauro Carvalho Chehab
Em Wed, 22 Aug 2012 17:31:51 +0200 Sylwester Nawrocki escreveu: > Hi Mauro, > > > The following changes since commit 01b0c11a1ba49ac96f58b7bc92772c2b469d6caa: > > [media] Kconfig: Fix b2c2 common code selection (2012-08-21 08:38:31 -0300) > > are available in the git repository at: > > g

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Ezequiel Garcia
Mauro, (Cc got messed up, so I'm sending this to you and media list) On Sat, Sep 15, 2012 at 10:37 AM, Mauro Carvalho Chehab wrote: > Em Sat, 15 Sep 2012 10:05:40 -0300 > Ezequiel Garcia escreveu: > >> On Sat, Sep 15, 2012 at 9:48 AM, Mauro Carvalho Chehab >> wrote: >> > Em 28-08-2012 14:23, E

Re: [GIT PULL] Initial i.MX5/CODA7 support for the CODA driver

2012-09-15 Thread Ezequiel Garcia
Hi Philipp, On Thu, Sep 13, 2012 at 1:40 PM, Philipp Zabel wrote: > Hi Mauro, > > please pull the following patches that fix a few issues in the coda driver and > add initial firmware loading and encoding support for the CODA7 series VPU > contained in i.MX51 and i.MX53 SoCs. > > > The following

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Ezequiel Garcia
On Sat, Sep 15, 2012 at 9:48 AM, Mauro Carvalho Chehab wrote: > Em 28-08-2012 14:23, Ezequiel Garcia escreveu: >> Hi Jon, >> >> Thanks for your answers, I really appreciate it. >> >> On Tue, Aug 28, 2012 at 1:55 PM, Jonathan Corbet wrote: >>> On Sun, 26 Aug 2012 19:59:40 -0300 >>> Ezequiel Garcia

Re: Strong pairing cam doesn't work with CT-3650 driver (ttusb2)

2012-09-15 Thread Hans Petter Selasky
On Friday 17 August 2012 22:59:21 Antti Palosaari wrote: > On 08/17/2012 10:35 PM, Hans Petter Selasky wrote: > > Hi, > > > > Have anyone out there tested the CT-3650 USB driver in the Linux kernel > > with a "strong pairing cam". > > Likely that means CI+ with some pairing features enabled. > >

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Mauro Carvalho Chehab
Em 28-08-2012 14:23, Ezequiel Garcia escreveu: > Hi Jon, > > Thanks for your answers, I really appreciate it. > > On Tue, Aug 28, 2012 at 1:55 PM, Jonathan Corbet wrote: >> On Sun, 26 Aug 2012 19:59:40 -0300 >> Ezequiel Garcia wrote: >> >>> 1. >>> Why do we need to check for all these condition

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Hans Verkuil
On Sat September 15 2012 12:37:58 Sakari Ailus wrote: > Hi Hans and Laurent, > > Hans Verkuil wrote: > > On Sat September 15 2012 11:31:29 Laurent Pinchart wrote: > >> Hi Hans, > >> > >> On Saturday 15 September 2012 09:41:59 Hans Verkuil wrote: > >>> On Fri September 14 2012 23:05:45 Sakari Ailus

Re: how to crop/scale in mono-subdev camera sensor driver?

2012-09-15 Thread Sakari Ailus
Hi Sylwester and Nicolas, Sylwester Nawrocki wrote: Hi, On 09/14/2012 05:00 PM, Nicolas THERY wrote: Hello, I'm studying how to support cropping and scaling (binning, skipping, digital scaling if any) for different models for camera sensor drivers. There seems to be (at least) two kinds of s

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Sakari Ailus
Hi Hans and Laurent, Hans Verkuil wrote: On Sat September 15 2012 11:31:29 Laurent Pinchart wrote: Hi Hans, On Saturday 15 September 2012 09:41:59 Hans Verkuil wrote: On Fri September 14 2012 23:05:45 Sakari Ailus wrote: Rémi Denis-Courmont wrote: Le vendredi 14 septembre 2012 23:25:01, Sak

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Sylwester Nawrocki
Hi, On 09/15/2012 11:31 AM, Laurent Pinchart wrote: > Hi Hans, > > On Saturday 15 September 2012 09:41:59 Hans Verkuil wrote: >> On Fri September 14 2012 23:05:45 Sakari Ailus wrote: >>> Rémi Denis-Courmont wrote: Le vendredi 14 septembre 2012 23:25:01, Sakari Ailus a écrit : > I had a q

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Hans Verkuil
On Sat September 15 2012 11:31:29 Laurent Pinchart wrote: > Hi Hans, > > On Saturday 15 September 2012 09:41:59 Hans Verkuil wrote: > > On Fri September 14 2012 23:05:45 Sakari Ailus wrote: > > > Rémi Denis-Courmont wrote: > > > > Le vendredi 14 septembre 2012 23:25:01, Sakari Ailus a écrit : > >

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Laurent Pinchart
Hi Hans, On Saturday 15 September 2012 09:41:59 Hans Verkuil wrote: > On Fri September 14 2012 23:05:45 Sakari Ailus wrote: > > Rémi Denis-Courmont wrote: > > > Le vendredi 14 septembre 2012 23:25:01, Sakari Ailus a écrit : > > >> I had a quick discussion with Laurent, and what he suggested was to

Re: [PATCH] [media] mem2mem_testdev: Make m2mtest_dev_release function static

2012-09-15 Thread Sachin Kamat
ping... On 24 August 2012 17:36, Sachin Kamat wrote: > Fixes the following warning: > drivers/media/platform/mem2mem_testdev.c:73:6: warning: > symbol 'm2mtest_dev_release' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > --- > drivers/media/platform/mem2mem_testdev.c |

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-15 Thread Hans Verkuil
On Fri September 14 2012 23:05:45 Sakari Ailus wrote: > Hi Rémi, > > Rémi Denis-Courmont wrote: > > Le vendredi 14 septembre 2012 23:25:01, Sakari Ailus a écrit : > >> I had a quick discussion with Laurent, and what he suggested was to use > >> the kernel version to figure out the type of the time

Re: [RFCv3 API PATCH 00/31] Full series of API fixes from the 2012 Media Workshop

2012-09-15 Thread Hans Verkuil
On Fri September 14 2012 23:26:45 Sakari Ailus wrote: > Hans Verkuil wrote: > > Hi all, > > > > This is the full patch series containing API fixes as discussed during the > > 2012 Media Workshop. > > > > Regarding the 'make ioctl const' patches: I've only done the easy ones in > > this patch series