Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-13 Thread Hans Verkuil
Hi Andrey! Thanks for posting this driver. One request for the future: please split this patch up in smaller pieces: one for each c source for example. That makes it easier to review. On Fri September 14 2012 00:40:11 Andrey Smirnov wrote: > This patch adds a core driver for Silicon Laboratories

Re: Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
Hi Mauro, thank you for your interest. On 13 September 2012 15:00, Mauro Carvalho Chehab wrote: > Hi Javier, > > I'm not too familiar with soc_camera and ov7670 drivers, so my comments > reflects my understanding of the question, without taking into account > drivers specifics. > > Em 13-09-2012

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2012 21:59, Mauro Carvalho Chehab escreveu: > Em Thu, 13 Sep 2012 20:23:42 -0300 > Mauro Carvalho Chehab escreveu: > >> Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: >>> Em Sat, 18 Aug 2012 11:48:52 -0400 >>> Steven Toth escreveu: >>> Mauro, please read below, a new set of p

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Sep 2012 20:23:42 -0300 Mauro Carvalho Chehab escreveu: > Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: > > Em Sat, 18 Aug 2012 11:48:52 -0400 > > Steven Toth escreveu: > > > >> Mauro, please read below, a new set of patches I'm submitting for merge. > >> > >> On Thu, Aug 16,

Re: dvb-apps scan files

2012-09-13 Thread Hernán Rossetto
Thank you Christoph! So is this (emailing you) the right way to get stuff added to the mercurial repo ? Please let me know so I know how to proceed in the future. Thanks again, Hernán.- On Thu, Sep 13, 2012 at 9:03 AM, Christoph Pfister wrote: > Done. > > [ actually you're lucky - my low-prior

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: > Em Sat, 18 Aug 2012 11:48:52 -0400 > Steven Toth escreveu: > >> Mauro, please read below, a new set of patches I'm submitting for merge. >> >> On Thu, Aug 16, 2012 at 2:49 PM, Hans Verkuil wrote: >>> On Thu August 16 2012 19:39:51 Steven Tot

[PATCH 2/3] Add a V4L2 driver for SI476X MFD

2012-09-13 Thread Andrey Smirnov
This commit adds a driver that exposes all the radio related functionality of the Si476x series of chips via the V4L2 subsystem. Signed-off-by: Andrey Smirnov --- drivers/media/radio/Kconfig| 17 + drivers/media/radio/radio-si476x.c | 1307 2 files

[PATCH 0/3] A driver for Si476x series of chips

2012-09-13 Thread Andrey Smirnov
This patchset contains a driver for a Silicon Laboratories 476x series of radio tuners. The driver itself is implemented as an MFD devices comprised of three parts: 1. Core device that provides all the other devices with basic functionality and locking scheme. 2. Radio device that translates bet

[PATCH 3/3] Add a codec driver for SI476X MFD

2012-09-13 Thread Andrey Smirnov
This commit add a sound codec driver for Silicon Laboratories 476x series of AM/FM radio chips. Signed-off-by: Andrey Smirnov --- sound/soc/codecs/Kconfig |4 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/si476x.c | 346 + 3 files change

Re: [PATCH] omap3isp: Use monotonic timestamps for statistics buffers

2012-09-13 Thread Sakari Ailus
Hi Laurent, Thanks for the patch! On Thu, Sep 13, 2012 at 09:53:23PM +0200, Laurent Pinchart wrote: > V4L2 buffers use the monotonic clock, while statistics buffers use wall > time. This makes it difficult to correlate video frames and statistics. > > Switch statistics buffers to the monotonic c

Re: ITE9135 on AMD SB700 - ehci_hcd bug

2012-09-13 Thread Malcolm Priestley
On Wed, 2012-09-12 at 08:32 +0200, Marx wrote: > Hello > I'm trying to use dual DVB-T tuner based on ITE9135 tuner. I use Debian > kernel 3.5-trunk-686-pae. My motherboard is AsRock E350M1 (no USB3 ports). > Tuner is detected ok, see log at the end of post. > > When I try to scan channels, bug ha

Re: [PATCH] [media] DocBook: Fix docbook compilation

2012-09-13 Thread Hans Verkuil
On Thu September 13 2012 22:11:40 Mauro Carvalho Chehab wrote: > changeset 1248c7cb66d734b60efed41be7c7b86909812c0e broke html compilation: > > Documentation/DocBook/v4l2.xml:584: parser error : Entity 'sub-subdev-g-edid' > not defined > Documentation/DocBook/v4l2.xml:626: parser error : chunk is

Re: [RFCv2 API PATCH 12/28] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-13 Thread Hans Verkuil
On Thu September 13 2012 22:50:32 Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 13 September 2012 23:38:14 Sakari Ailus wrote: > > On Fri, Sep 07, 2012 at 03:29:12PM +0200, Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Add a new flag that tells userspace that the monotonic cloc

Re: [RFCv2 API PATCH 12/28] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-13 Thread Laurent Pinchart
Hi Sakari, On Thursday 13 September 2012 23:38:14 Sakari Ailus wrote: > On Fri, Sep 07, 2012 at 03:29:12PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add a new flag that tells userspace that the monotonic clock is used > > for timestamps and update the documentation accordingly. >

Re: [RFCv2 API PATCH 12/28] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-13 Thread Sakari Ailus
Hi Hans, Thanks for the patch! On Fri, Sep 07, 2012 at 03:29:12PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add a new flag that tells userspace that the monotonic clock is used > for timestamps and update the documentation accordingly. > > We decided on this new flag during the 2012

[PATCH] [media] DocBook: Fix docbook compilation

2012-09-13 Thread Mauro Carvalho Chehab
changeset 1248c7cb66d734b60efed41be7c7b86909812c0e broke html compilation: Documentation/DocBook/v4l2.xml:584: parser error : Entity 'sub-subdev-g-edid' not defined Documentation/DocBook/v4l2.xml:626: parser error : chunk is not well balanced Documentation/DocBook/media_api.xml:74: parser error :

cron job: media_tree daily build: WARNINGS

2012-09-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Sep 13 19:00:21 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc (GC

[PATCH] omap3isp: Use monotonic timestamps for statistics buffers

2012-09-13 Thread Laurent Pinchart
V4L2 buffers use the monotonic clock, while statistics buffers use wall time. This makes it difficult to correlate video frames and statistics. Switch statistics buffers to the monotonic clock to fix this. Reported-by: Antoine Reversat Signed-off-by: Laurent Pinchart --- drivers/media/platform

Re: hdpvr and HD PVR 2 Gaming Edition from Haoppauge

2012-09-13 Thread Devin Heitmueller
On Thu, Sep 13, 2012 at 2:28 PM, Thomas Seilund wrote: > Do you know if anybody plans to make a driver? I have not heard of any such plans. It's a brand new device though, so it's possible that somebody will step up to do such (especially if the original HD-PVR stops being sold). > I would love

Re: [RFC 1/5] video: Add generic display panel core

2012-09-13 Thread Robert Schwebel
On Thu, Sep 13, 2012 at 01:29:54PM +0200, Sascha Hauer wrote: > > > You have seen my of videomode helper proposal. One result there > > > was that we want to have ranges for the margin/synclen fields. > > > Does it make sense to base this new panel framework on a more > > > sophisticated internal r

Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check

2012-09-13 Thread Andrew Morton
On Thu, 13 Sep 2012 10:40:57 +0800 Bob Liu wrote: > The addr parameter may not page aligned eg. when it's come from > vfb_mmap():vma->vm_start in video driver. > > This patch fix the check in remap_pfn_range() else some driver like v4l2 will > fail in this function while calling mmap() on nommu

Re: RFC: use of timestamp/sequence in v4l2_buffer

2012-09-13 Thread Sakari Ailus
Hi Hans, Thanks for the RFC! On Tue, Sep 04, 2012 at 12:38:06PM +0200, Hans Verkuil wrote: > Hi all, > > During the Media Workshop last week we discussed how the timestamp and > sequence fields in struct v4l2_buffer should be used. > > While trying to document the exact behavior I realized that

Re: hdpvr and HD PVR 2 Gaming Edition from Haoppauge

2012-09-13 Thread Thomas Seilund
On 12-09-2012 17:56, Devin Heitmueller wrote: On Wed, Sep 12, 2012 at 11:37 AM, Thomas Seilund wrote: Hi All, I just bought the HD PVR 2 Gaming Edition from Hauppauge. It there any change this device will be supported by the hdpvr kernel driver. (Or any other driver for that matter!) No. It

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: > On Thu, 13 Sep 2012 17:46:32 +0200 > > Federico Vaga wrote: > > > A few words explaining why this memory handling module is required > > > or > > > beneficial will definitely improve the commit :) > > > > ok, I will write

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> Well, there is some documentation here: > > https://lwn.net/Articles/447435/ I know this, I learned from this page :) What I'm saying is that I don't know what to write inside the code to make it clearer than now. I think is clear, because if you know the videobuf2, you know what I'm d

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:42:33 +0200 Federico Vaga wrote: > > The header and esp. the source could really do with more > > documentation. It is not at all clear from the code what the > > dma-streaming allocator does and how it differs from other > > allocators. > > The other allocators are not

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:46:32 +0200 Federico Vaga wrote: > > A few words explaining why this memory handling module is required or > > beneficial will definitely improve the commit :) > > ok, I will write some lines In general, all of these patches need *much* better changelogs (i.e. they need

[PATCH] bt8xx: Add video4linux control V4L2_CID_COLOR_KILLER.

2012-09-13 Thread Guilherme Herrmann Destefani
Added V4L2_CID_COLOR_KILLER control to the bt8xx driver. The control V4L2_CID_PRIVATE_CHROMA_AGC was changed too because with this change the bttv driver must touch two bits in the SC Loop Control Registers, for controls V4L2_CID_COLOR_KILLER and V4L2_CID_PRIVATE_CHROMA_AGC. --- Documentation/vide

[GIT PULL] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread Philipp Zabel
Hi Mauro, please pull the following patches that fix a few issues in the coda driver and add initial firmware loading and encoding support for the CODA7 series VPU contained in i.MX51 and i.MX53 SoCs. The following changes since commit 79e8c7bebb467bbc3f2514d75bba669a3f354324: Merge tag 'v3.6

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > A few words explaining why this memory handling module is required or > beneficial will definitely improve the commit :) ok, I will write some lines > > +static void *vb2_dma_streaming_cookie(voi

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> typo: steaming -> streaming :-) fixed > The header and esp. the source could really do with more > documentation. It is not at all clear from the code what the > dma-streaming allocator does and how it differs from other > allocators. The other allocators are not documented and to understand t

[PATCH] s5p-csis: Add transmission errors logging

2012-09-13 Thread Sylwester Nawrocki
Add hardware event/error counters which can be dumped into the kernel log through VIDIOC_LOG_STATUS ioctl. The counters are reset in each s_stream(1) call. Any errors are logged after streaming is turned off. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/plat

[PATCH] DocBook: Multistream support

2012-09-13 Thread CrazyCat
Multistream support for DVBAPI. If my english bad - please fix it somebody :) Signed-off-by: Evgeny Plehov diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml index d188be9..c7c14be 100644 --- a/Documentation/DocBook/media/dvb/dvbpropert

[PATCH] va1j5jf8007s: Multistream support

2012-09-13 Thread CrazyCat
Update multistream support. Signed-off-by: Evgeny Plehov diff --git a/drivers/media/pci/pt1/va1j5jf8007s.c b/drivers/media/pci/pt1/va1j5jf8007s.c index d980dfb..1b637b7 100644 --- a/drivers/media/pci/pt1/va1j5jf8007s.c +++ b/drivers/media/pci/pt1/va1j5jf8007s.c @@ -329,8 +329,8 @@ va1j5jf8007s_s

[PATCH] stv090x: Multistream support

2012-09-13 Thread CrazyCat
Multistream support for stv090x Signed-off-by: Evgeny Plehov diff --git a/drivers/media/dvb-frontends/stv090x.c b/drivers/media/dvb-frontends/stv090x.c index ea86a56..13caec0 100644 --- a/drivers/media/dvb-frontends/stv090x.c +++ b/drivers/media/dvb-frontends/stv090x.c @@ -3425,6 +3425,33 @@ err

[PATCH] dvb_frontend: Multistream support

2012-09-13 Thread CrazyCat
Multistream support for DVBAPI. Version increased to 5.8. Signed-off-by: Evgeny Plehov diff --git a/include/linux/dvb/frontend.h b/include/linux/dvb/frontend.h index bb51edf..a6a6839 100644 --- a/include/linux/dvb/frontend.h +++ b/include/linux/dvb/frontend.h @@ -62,6 +62,7 @@ typedef enum fe_cap

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 15:52:47 Federico Vaga wrote: > Signed-off-by: Federico Vaga > --- > drivers/media/v4l2-core/Kconfig | 5 + > drivers/media/v4l2-core/Makefile | 1 + > drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 > ++

RE: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Marek Szyprowski
Hello, On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > Signed-off-by: Federico Vaga A few words explaining why this memory handling module is required or beneficial will definitely improve the commit :) > --- > drivers/media/v4l2-core/Kconfig | 5 + > drive

[PATCH 4/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1235 ++- 2 file modificati, 411 inserzioni(+), 826 rimozioni(-) diff --git a/drivers/media/pci/sta2x11/Kconfig

[PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 24 +++ 4 fil

[PATCH 2/4] adv7180: remove {query/g_/s_}ctrl

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6 @@ sta

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-13 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

Re: Improving ov7670 sensor driver.

2012-09-13 Thread Mauro Carvalho Chehab
Hi Javier, I'm not too familiar with soc_camera and ov7670 drivers, so my comments reflects my understanding of the question, without taking into account drivers specifics. Em 13-09-2012 06:48, javier Martin escreveu: > Hi, > our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor > a

Re: pac7302-webcams and libv4lconvert interaction

2012-09-13 Thread Hans de Goede
Hi, On 09/12/2012 04:36 PM, Frank Schäfer wrote: And a negative side effect is, that unknown pac7302 devices (with no V4LCONTROL_ROTATED_90_JPEG entry in libv4lconvert) do not work. With a consistent API behavior, they would work fine (output a rotated image). Users would at least know that

Re: dvb-apps scan files

2012-09-13 Thread Christoph Pfister
Done. [ actually you're lucky - my low-priority RTT is in the range of months atm ... ] Christoph 2012/9/9 Hernán Rossetto : > It seems these were not added to the dvb-apps mercurial repo. > > Is this the way to submit these files ? > If not, please let me know and I'll follow the right procedu

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 13:43:36 Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Thursday 13 September 2012 06:45 AM, Laurent Pinchart wrote: > > Hi Prabhakar, > > > > Thanks for the patch. > > > > On Tuesday 11 September 2012 19:53:38 Prabhakar Lad wrote: > >> From: Lad,

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-13 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thursday 13 September 2012 06:45 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Tuesday 11 September 2012 19:53:38 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> Add a helper function to modify the menu, max and default va

Re: Improving ov7670 sensor driver.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 13:19:14 javier Martin wrote: > On 13 September 2012 13:00, Hans Verkuil wrote: > > On Thu 13 September 2012 12:47:53 javier Martin wrote: > >> >> 3.- Adjust vstart/vstop in order to remove an horizontal green line. > >> >> > >> >> Why? Currently, in the driver, for VGA, v

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
Hi Philipp, On 13 September 2012 13:24, Philipp Zabel wrote: > Am Donnerstag, den 13.09.2012, 09:51 +0200 schrieb javier Martin: >> If you want to speed up the process and you have you could send a pull >> request to Mauro. > > Should I include the four patches below in the pull request, or wait

Re: [RFC 1/5] video: Add generic display panel core

2012-09-13 Thread Sascha Hauer
On Thu, Sep 13, 2012 at 03:40:40AM +0200, Laurent Pinchart wrote: > Hi Sascha, > > > > +int panel_get_modes(struct panel *panel, const struct fb_videomode > > > **modes) > > > +{ > > > + if (!panel->ops || !panel->ops->get_modes) > > > + return 0; > > > + > > > + return panel->ops->get_mod

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread Philipp Zabel
Am Donnerstag, den 13.09.2012, 09:51 +0200 schrieb javier Martin: > If you want to speed up the process and you have you could send a pull > request to Mauro. Should I include the four patches below in the pull request, or wait for them to hit staging/for_v3.7 ? > But be careful with the followin

Re: Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
On 13 September 2012 13:00, Hans Verkuil wrote: > On Thu 13 September 2012 12:47:53 javier Martin wrote: >> Hi Hans, >> thank you for your response. >> >> On 13 September 2012 12:07, Hans Verkuil wrote: >> > On Thu 13 September 2012 11:48:17 javier Martin wrote: >> >> Hi, >> >> our new i.MX27 bas

[RFC PATCH v8] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-13 Thread Sangwook Lee
This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/bri

Re: Improving ov7670 sensor driver.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 12:47:53 javier Martin wrote: > Hi Hans, > thank you for your response. > > On 13 September 2012 12:07, Hans Verkuil wrote: > > On Thu 13 September 2012 11:48:17 javier Martin wrote: > >> Hi, > >> our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor > >> at

Re: [RFCv2 API PATCH 25/28] Set vfl_dir for all display or m2m drivers.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 04:37:27 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:25 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/pci/ivtv/ivtv-streams.c |3 +++ > > driv

Re: [RFCv2 API PATCH 24/28] v4l2-dev: add new VFL_DIR_ defines.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 04:36:27 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:24 Hans Verkuil wrote: > > From: Hans Verkuil > > > > These will be used by v4l2-dev.c to improve ioctl checking. > > I.e. ioctls for capture should return -ENOTT

Re: [RFCv2 API PATCH 14/28] DocBook: clarify that sequence is also set for output devices.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 04:28:41 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:14 Hans Verkuil wrote: > > From: Hans Verkuil > > > > It was not entirely obvious that the sequence count should also > > be set for output devices. Also made it

Re: Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
Hi Hans, thank you for your response. On 13 September 2012 12:07, Hans Verkuil wrote: > On Thu 13 September 2012 11:48:17 javier Martin wrote: >> Hi, >> our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor >> attached to the CSI interface. Apparently, this sensor is fully >> compat

Re: [RFCv2 API PATCH 10/28] Rename V4L2_(IN|OUT)_CAP_CUSTOM_TIMINGS.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 04:22:52 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:10 Hans Verkuil wrote: > > From: Hans Verkuil > > > > The 'custom' timings are no longer just for custom timings, but also for > > standard CEA/VESA timings. So r

Re: [RFCv2 API PATCH 06/28] v4l2-core: deprecate V4L2_BUF_TYPE_PRIVATE

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 04:21:14 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:06 Hans Verkuil wrote: > > From: Hans Verkuil > > > > This buffer type isn't used at all, and since it is effectively undefined > > what it should do it is deprec

Re: [RFCv2 API PATCH 05/28] DocBook: bus_info can no longer be empty.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 03:24:53 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 07 September 2012 15:29:05 Hans Verkuil wrote: > > From: Hans Verkuil > > > > During the 2012 Media Workshop it was decided that bus_info as returned > > by VIDIOC_QUERYCAP can no longer

Re: [Workshop-2011] Media summit/KS-2012 proposals

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 03:01:34 Laurent Pinchart wrote: > Hi Hans, > > On Wednesday 05 September 2012 10:28:30 Hans Verkuil wrote: > > On Wed 5 September 2012 10:04:41 Jun Nie wrote: > > > Is there any summary for this summit or presentation material? I am > > > looking forward for some idea on

Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

2012-09-13 Thread Wanlong Gao
On 09/13/2012 12:03 PM, Laurent Pinchart wrote: > Hi Wanlong, > > Thanks for the patch. > > On Monday 27 August 2012 15:23:15 Wanlong Gao wrote: >> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be >> translated as ENOTTY to user mode. >> >> Cc: Laurent Pinchart >> Cc: Mauro Carva

Re: [RFCv2 API PATCH 15/28] DocBook: Mark CROPCAP as optional instead of as compulsory.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:15 Hans Verkuil wrote: > From: Hans Verkuil > > While the documentation says that VIDIOC_CROPCAP is compulsory for > all video capture and output devices, in practice VIDIOC_CROPCAP is > only implemented for devices that can do cr

Re: [RFCv2 API PATCH 14/28] DocBook: clarify that sequence is also set for output devices.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:14 Hans Verkuil wrote: > From: Hans Verkuil > > It was not entirely obvious that the sequence count should also > be set for output devices. Also made it more explicit that this > sequence counter counts frames, not fields. > > S

Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

2012-09-13 Thread Laurent Pinchart
Hi Wanlong, Thanks for the patch. On Monday 27 August 2012 15:23:15 Wanlong Gao wrote: > At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be > translated as ENOTTY to user mode. > > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by:

Re: [RFCv2 API PATCH 25/28] Set vfl_dir for all display or m2m drivers.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:25 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/pci/ivtv/ivtv-streams.c |3 +++ > drivers/media/pci/zoran/zoran_card.c |4 > drivers/media/platform/

Re: [RFCv2 API PATCH 04/28] DocBook: make the G/S/TRY_FMT specification more strict.

2012-09-13 Thread Laurent Pinchart
On Friday 07 September 2012 15:29:04 Hans Verkuil wrote: > From: Hans Verkuil > > - S/TRY_FMT should always succeed, unless an invalid type field is passed > in. - TRY_FMT should give the same result as S_FMT, all other things being > equal. - ENUMFMT may return different formats for different in

Re: [RFCv2 API PATCH 06/28] v4l2-core: deprecate V4L2_BUF_TYPE_PRIVATE

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:06 Hans Verkuil wrote: > From: Hans Verkuil > > This buffer type isn't used at all, and since it is effectively undefined > what it should do it is deprecated. The define still exists, but any > internal support for such buffers i

Re: [RFCv2 API PATCH 05/28] DocBook: bus_info can no longer be empty.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:05 Hans Verkuil wrote: > From: Hans Verkuil > > During the 2012 Media Workshop it was decided that bus_info as returned > by VIDIOC_QUERYCAP can no longer be empty. It should be a unique identifier, > and empty strings are obvious

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-13 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Tuesday 11 September 2012 19:53:38 Prabhakar Lad wrote: > From: Lad, Prabhakar > > Add a helper function to modify the menu, max and default value > to set. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Hans Verkuil > Cc: Sak

Re: [PATCH v4] media: v4l2-ctrls: add control for dpcm predictor

2012-09-13 Thread Laurent Pinchart
Hi Sakari, On Friday 07 September 2012 21:46:44 Sakari Ailus wrote: > > Could you replace the above with this text (with appropriate indentation > etc.) while keeping the reference to Wikipedia? > > --8<-- > Differential pulse-code modulation (DPCM) compression can be used to > compress

Re: [Workshop-2011] Media summit/KS-2012 proposals

2012-09-13 Thread Laurent Pinchart
Hi Hans, On Wednesday 05 September 2012 10:28:30 Hans Verkuil wrote: > On Wed 5 September 2012 10:04:41 Jun Nie wrote: > > Is there any summary for this summit or presentation material? I am > > looking forward for some idea on CEC. It is really complex in > > functionality. > > Maybe other guys i

Re: [RFCv2 API PATCH 10/28] Rename V4L2_(IN|OUT)_CAP_CUSTOM_TIMINGS.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:10 Hans Verkuil wrote: > From: Hans Verkuil > > The 'custom' timings are no longer just for custom timings, but also for > standard CEA/VESA timings. So rename to V4L2_IN/OUT_CAP_DV_TIMINGS. > > The old define is still kept for b

Re: [PATCH v2] media: v4l2-ctrls: add control for test pattern

2012-09-13 Thread Laurent Pinchart
Hi Sakari, On Sunday 09 September 2012 10:40:17 Sakari Ailus wrote: > On Sat, Sep 08, 2012 at 01:11:04PM +0200, Hans Verkuil wrote: > > On Fri September 7 2012 20:20:51 Sakari Ailus wrote: > > > Prabhakar Lad wrote: > > > > From: Lad, Prabhakar > > > > > > > > add V4L2_CID_TEST_PATTERN of type m

Re: [RFCv2 API PATCH 03/28] DocBook: improve STREAMON/OFF documentation.

2012-09-13 Thread Laurent Pinchart
On Friday 07 September 2012 15:29:03 Hans Verkuil wrote: > From: Hans Verkuil > > Specify that STREAMON/OFF should return 0 if the stream is already > started/stopped. > > The spec never specified what the correct behavior is. This ambiguity > was resolved during the 2012 Media Workshop. > > Si

Re: [RFC 1/5] video: Add generic display panel core

2012-09-13 Thread Laurent Pinchart
Hi Sascha, On Tuesday 04 September 2012 11:24:46 Sascha Hauer wrote: > Hi Laurent, > > On Fri, Aug 17, 2012 at 02:49:39AM +0200, Laurent Pinchart wrote: > > +/** > > + * panel_get_modes - Get video modes supported by the panel > > + * @panel: The panel > > + * @modes: Pointer to an array of modes

Re: [RFCv2 API PATCH 13/28] Add V4L2_CAP_MONOTONIC_TS where applicable.

2012-09-13 Thread Laurent Pinchart
Hi Hans, On Friday 07 September 2012 15:29:13 Hans Verkuil wrote: > From: Hans Verkuil > > Add the new V4L2_CAP_MONOTONIC_TS capability to those drivers that > use monotomic timestamps instead of the system time. > > Signed-off-by: Hans Verkuil For uvcvideo, Acked-by: Laurent Pinchart --

Re: [RFCv2 API PATCH 12/28] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-13 Thread Laurent Pinchart
On Friday 07 September 2012 15:29:12 Hans Verkuil wrote: > From: Hans Verkuil > > Add a new flag that tells userspace that the monotonic clock is used > for timestamps and update the documentation accordingly. > > We decided on this new flag during the 2012 Media Workshop. > > Signed-off-by: Ha

Re: [RFCv2 API PATCH 24/28] v4l2-dev: add new VFL_DIR_ defines.

2012-09-13 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 September 2012 15:29:24 Hans Verkuil wrote: > From: Hans Verkuil > > These will be used by v4l2-dev.c to improve ioctl checking. > I.e. ioctls for capture should return -ENOTTY when called for > an output device. > > Signed-off-by: Hans Verkuil > --

Re: [RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-13 Thread Sangwook Lee
Hi Francesco On 12 September 2012 19:07, Francesco Lavra wrote: > Hi Sangwook, > two remarks from my review on September 9th haven't been addressed. Thanks for the review. I missed those, please let me correct them and send patch again. Regards Sangwook > I believe those remarks are correct,

Re: Improving ov7670 sensor driver.

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 11:48:17 javier Martin wrote: > Hi, > our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor > attached to the CSI interface. Apparently, this sensor is fully > compatible with the old ov7670. For this reason, it seems rather > sensible that they should share t

Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
Hi, our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor attached to the CSI interface. Apparently, this sensor is fully compatible with the old ov7670. For this reason, it seems rather sensible that they should share the same driver: ov7670.c One of the challenges we have to face is

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
If you want to speed up the process and you have you could send a pull request to Mauro. But be careful with the following patches that have been sent to the list after the initial support of the driver and before these series: http://patchwork.linuxtv.org/patch/14048/ https://patchwork.kernel.org

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
Hi Philipp, On 12 September 2012 17:02, Philipp Zabel wrote: > These patches contain initial firmware loading and encoding support for the > CODA7 series VPU contained in i.MX51 and i.MX53 SoCs, and fix some > multi-instance > issues. > > Changes since v4: > - Added Javier's Tested/Reviewed/Ack

Re: [PATCH v5 13/13] media: coda: set up buffers to be sized as negotiated with s_fmt

2012-09-13 Thread javier Martin
On 12 September 2012 17:02, Philipp Zabel wrote: > This fixes a failure in vb2_qbuf in user pointer mode where > __qbuf_userptr checks if the buffer queued by userspace is large > enough. The failure would happen if coda_queue_setup was called > with empty fmt (and thus set the expected buffer siz

Re: [PATCH v5 12/13] media: coda: add byte size slice limit control

2012-09-13 Thread javier Martin
Hi Philipp, it now works properly. On 12 September 2012 17:02, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > --- > Changes since v4: > - Fix menu_skip_mask for V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE v4l2_ctrl. Tested-by: Javier Martin > --- > drivers/media/platform/coda.c | 29 +