On Tue, Aug 28, 2012 at 12:53:47PM +0200, Philipp Zabel wrote:
> These patches contain initial firmware loading and encoding support for the
> CODA7 series VPU contained in i.MX51 and i.MX53 SoCs, and fix some
> multi-instance
> issues. The last two patches touching files in arch/arm/* are include
Hi Arun,
Please find my comments inline.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
> From: Arun Kumar K [mailto:arun...@samsung.com]
> Sent: 27 August 2012 04:58
[...]
> diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c
b/drivers/media/video/s5p-
> mfc/s5p_m
Hi Arun,
Please find my comments below.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
> From: Arun Kumar K [mailto:arun...@samsung.com]
> Sent: 27 August 2012 04:58
[...]
> diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_common.h
> b/drivers/media/video/s5p-mfc/
On Sunday 12 August 2012 05:06:49 Devin Heitmueller wrote:
> On Sat, Aug 11, 2012 at 10:15 PM, Mauro Carvalho Chehab
>
> wrote:
> > Devin/Antti,
> >
> > As Juergen mentioned your help on this patch, do you mind helping
> > reviewing and testing it?
>
> I guided Juergen through the creation of t
On Tue, Aug 28, 2012 at 10:09:55AM -0700, Ben Hutchings wrote:
> On Tue, 2012-08-28 at 12:44 +0100, Luis Henriques wrote:
> > On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote:
> > > ite_dev::rdev is currently initialised in ite_probe() after
> > > rc_register_device() returns. If a ne
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Tue Aug 28 19:00:18 CEST 2012
git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324
gcc version: i686-linux-gcc (GC
Hi Jon,
Thanks for your answers, I really appreciate it.
On Tue, Aug 28, 2012 at 1:55 PM, Jonathan Corbet wrote:
> On Sun, 26 Aug 2012 19:59:40 -0300
> Ezequiel Garcia wrote:
>
>> 1.
>> Why do we need to check for all these conditions in the first place?
>> There are many other functions relyin
The led is green, not yellow.
Signed-off-by: Sean Young
---
drivers/media/rc/ttusbir.c | 48 ++
1 file changed, 44 insertions(+), 4 deletions(-)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index 2151927..f0921b5 100644
--- a/d
On Tue, 2012-08-28 at 12:44 +0100, Luis Henriques wrote:
> On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote:
> > ite_dev::rdev is currently initialised in ite_probe() after
> > rc_register_device() returns. If a newly registered device is opened
> > quickly enough, we may enable inter
On Sun, 26 Aug 2012 19:59:40 -0300
Ezequiel Garcia wrote:
> 1.
> Why do we need to check for all these conditions in the first place?
> There are many other functions relying on "struct vb2_queue *q"
> not being null (almost all of them) and we don't check for it.
> What makes vb2_queue_init() so
Hi,
I have recently bought a TerraTec Cinergy T PCIe Dual for an HTPC.
It didn't work at first, with kernel 3.4 which already supported it.
After checking everything I find out that I have to manually change
the frontend of the second tuner to DVB-T and also tune some channel
with tzap before be
Hi All
I have geniatech satbox it's tm6000 device with dvbs and Analogue CVBS
A/V grabber
I know tm6000 module doesn't support dvb-s but can i use satbox for
video grabber
if I load tm6000 module it's recognized to generic and loaded with
XC2028 firmware
satbox doesn't have xc2028 tuner it comes w
Hi Guennadi,
On Fri, 24 Aug 2012 23:23:37 +0200 (CEST)
Guennadi Liakhovetski wrote:
...
> > Every time the sensor is reset, it resets this register. Without setting
> > the register after sensor reset to the needed value I only get garbage data
> > from the sensor. Since the possibility to reset
On Martes, 28 de agosto de 2012 04:19:07 Antti Palosaari escribió:
> Hello
> this is not final review, as there was more things to check I was first
> thinking. I have to look it tomorrow too. But few comments still.
>
> On 08/27/2012 01:25 AM, Jose Alberto Reguero wrote:
> > This patch add suppor
On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote:
> ite_dev::rdev is currently initialised in ite_probe() after
> rc_register_device() returns. If a newly registered device is opened
> quickly enough, we may enable interrupts and try to use ite_dev::rdev
> before it has been initialis
job_ready is supposed to signal whether a context is ready to be
added to the job queue, not whether the CODA is ready to run it
immediately.
Calling v4l2_m2m_job_finish at the end of coda_irq_handler already
guarantees that the coda is ready when v4l2-mem2mem eventually tries
to run the next queue
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Removed JPEG from the coda7_formats.
---
drivers/media/video/coda.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
index 86dae17..6ae5f0f 100644
--
Some codecs running on CODA need internal framebuffers for reference and
reconstructed frames. Allocate them separately, and do not use the input
vb2_buffers: those will be handed off to userspace regularly, and there
is no way to signal to the CODA which of the registered framebuffers are
off limi
Determining the next free instance just by incrementing and decrementing
an instance counter does not work: if there are two instances opened,
0 and 1, and instance 0 is released, the next call to coda_open will
create a new instance with index 1, but instance 1 is already in use.
Instead, scan a
VIDIOC_TRY_FMT would incorrectly return bytesperline * height,
instead of width * height * 3 / 2.
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
i
USERPTR buffer support is provided by the videobuf2 framework.
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
index a67a52a..3d47935 100644
--- a/driver
Add a 1 second timeout for each PIC_RUN command to the CODA. In
case it locks up, stop all queues and dequeue remaining buffers.
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/media/video/coda.c b/d
Signed-off-by: Philipp Zabel
---
arch/arm/boot/dts/imx51.dtsi |6 ++
arch/arm/boot/dts/imx53.dtsi |6 ++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index aba28dc..8f38d83 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++
While the CODA is running a PIC_RUN command, its registers are
not to be touched.
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video
Add support for loading a raw firmware with 16-bit chars ordered in
little-endian 64-bit words, corresponding to the memory access pattern
of CODA7 and above: When writing the boot code into the code download
register, the chars have to be reordered back.
Signed-off-by: Philipp Zabel
---
drivers
The hardware can also rotate in 90° steps, but there is no
corresponding V4L2_CID defined yet.
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c | 19 ++-
drivers/media/video/coda.h |9 +
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/drive
Signed-off-by: Philipp Zabel
---
drivers/media/video/coda.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
index 3123260..db11219 100644
--- a/drivers/media/video/coda.c
+++ b/drivers/med
Signed-off-by: Philipp Zabel
---
arch/arm/mach-imx/clk-imx51-imx53.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c
b/arch/arm/mach-imx/clk-imx51-imx53.c
index 4bdcaa9..64f9ceb 100644
--- a/arch/arm/mach-imx/clk-imx51-imx53.c
+++ b/
This uses the ARCH_MXC specific iram_alloc API to allocate a work
buffer in the SoC's on-chip SRAM and sets up the AXI_SRAM_USE
register. In the future, the allocation will be converted to use
the genalloc API.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Use iram_alloc/iram_free instead
These patches contain initial firmware loading and encoding support for the
CODA7 series VPU contained in i.MX51 and i.MX53 SoCs, and fix some
multi-instance
issues. The last two patches touching files in arch/arm/* are included for
illustration purposes.
Changes since v1:
- Use iram_alloc/iram_
You have to apply the following operation to the binary fw file
provided by Freescale.
We agreed with Fabio that they were going to submit that file with the
modification below to the linux-firmware repository soon.
#include
#include
#include
#include "vpu_codetable_mx27.h"
int main() {
FILE
On Mon, Aug 20, 2012 at 10:08:39AM +0200, javier Martin wrote:
> Hi,
>
> On 30 July 2012 17:33, Guennadi Liakhovetski wrote:
> > Hi Javier
> >
> > On Mon, 30 Jul 2012, javier Martin wrote:
> >
> >> Hi,
> >> thank you for yor ACKs.
> >>
> >> On 20 July 2012 13:31, Guennadi Liakhovetski wrote:
> >
On 28 August 2012 10:40, Philipp Zabel wrote:
> Hi Javier,
>
> Am Dienstag, den 28.08.2012, 09:50 +0200 schrieb javier Martin:
>> Hi Phillip,
>> I see you are trying a cleaner approach for reference and reconstructed
>> frames.
>> > -#define CODA_OUTPUT_BUFS 4
>> > -#define CODA_CAPTURE_BUF
On 28 August 2012 10:24, Philipp Zabel wrote:
> Hi Javier,
>
> thank you for the comments,
>
> Am Montag, den 27.08.2012, 10:59 +0200 schrieb javier Martin:
>> Hi Philipp,
>> thank you for your patch. Please, find some comments below.
>>
>> On 24 August 2012 18:17, Philipp Zabel wrote:
> [...]
>>
Hi Javier,
Am Dienstag, den 28.08.2012, 09:50 +0200 schrieb javier Martin:
> Hi Phillip,
> I see you are trying a cleaner approach for reference and reconstructed
> frames.
> > -#define CODA_OUTPUT_BUFS 4
> > -#define CODA_CAPTURE_BUFS 2
> > +#define CODA_MAX_FRAMEBUFFERS 2
>
> Accor
Hi Javier,
thank you for the comments,
Am Montag, den 27.08.2012, 10:59 +0200 schrieb javier Martin:
> Hi Philipp,
> thank you for your patch. Please, find some comments below.
>
> On 24 August 2012 18:17, Philipp Zabel wrote:
[...]
> > @@ -1854,6 +1886,25 @@ static int __devinit coda_probe(str
Hi Philipp,
in order to give you my ACK I need that patch 3 gets fixed and patches
3-10 are resent so that they can apply cleanly.
After that, we'll make some intensive testing for a week in i.MX27, if
everything works as expected I'll ACK the patches.
Regards.
On 24 August 2012 18:17, Philipp Za
On 28 August 2012 09:50, javier Martin wrote:
> Hi Phillip,
> I see you are trying a cleaner approach for reference and reconstructed
> frames.
>
> On 24 August 2012 18:17, Philipp Zabel wrote:
>> Some codecs running on CODA need internal framebuffers for reference and
>> reconstructed frames. A
Hi Phillip,
I see you are trying a cleaner approach for reference and reconstructed frames.
On 24 August 2012 18:17, Philipp Zabel wrote:
> Some codecs running on CODA need internal framebuffers for reference and
> reconstructed frames. Allocate them separately, and do not use the input
> vb2_buf
39 matches
Mail list logo
