Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread CrazyCat
Stream can be anything :) But for DVB standards this anyway DVBS transport stream 188 byte. Most media-bridges can handle only this stream. Specific generic-continous DVB-S2/T2/C2 streams require extended bus for passing frame-based stream, so this out of V4L DVB. Now MIS used often for distrib

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Manu Abraham
On Sat, Aug 11, 2012 at 6:37 AM, Antti Palosaari wrote: > On 08/11/2012 03:31 AM, Manu Abraham wrote: >> >> On Sat, Aug 11, 2012 at 5:44 AM, Antti Palosaari wrote: >>> >>> On 08/11/2012 01:12 AM, Mauro Carvalho Chehab wrote: Em 13-07-2012 20:15, CrazyCat escreveu: >>> >>> >>> >

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Antti Palosaari
On 08/11/2012 03:31 AM, Manu Abraham wrote: On Sat, Aug 11, 2012 at 5:44 AM, Antti Palosaari wrote: On 08/11/2012 01:12 AM, Mauro Carvalho Chehab wrote: Em 13-07-2012 20:15, CrazyCat escreveu: #define DTV_ISDBS_TS_ID 42 #define DTV_DVBT2_PLP_ID 43 +#define DTV_DV

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Manu Abraham
On Sat, Aug 11, 2012 at 5:44 AM, Antti Palosaari wrote: > On 08/11/2012 01:12 AM, Mauro Carvalho Chehab wrote: >> >> Em 13-07-2012 20:15, CrazyCat escreveu: > > >>> #define DTV_ISDBS_TS_ID 42 >>> >>> #define DTV_DVBT2_PLP_ID 43 >>> +#define DTV_DVBS2_MIS_ID 43 >> >> >>

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Antti Palosaari
On 08/11/2012 01:12 AM, Mauro Carvalho Chehab wrote: Em 13-07-2012 20:15, CrazyCat escreveu: #define DTV_ISDBS_TS_ID 42 #define DTV_DVBT2_PLP_ID 43 +#define DTV_DVBS2_MIS_ID 43 It would be better to define it as: #define DTV_DVBS2_MIS_IDDTV_DVBT2_PLP_ID

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Manu Abraham
On Sat, Aug 11, 2012 at 3:42 AM, Mauro Carvalho Chehab wrote: > Em 13-07-2012 20:15, CrazyCat escreveu: >> Now present DTV_DVBT2_PLP_ID property for DVB-T2, so i add alias >> DTV_DVBS2_MIS_ID (same feature for advanced DVB-S2). Now DVB-S2 multistream >> filtration supported for current STV090x d

Re: [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI)

2012-08-10 Thread Manu Abraham
Mauro, Please revert this patch. Patch is incorrect. There is the VP-20300, VP-20330, VP-2040, with differences in tuner types TDA10021, TDA10023, MK-I, MK-II and MK-III. I have detailed this issue in an earlier mail. Terratec Cinregy C is VP-2033 and not VP-2040. Thanks! On Sat, Aug 11, 2012 a

Re: [PATCH]Omicom S2 PCI support

2012-08-10 Thread Mauro Carvalho Chehab
Em 14-07-2012 18:40, CrazyCat escreveu: > Support for yet another SAA7146-based budget card (very similar to TT > S2-1600, but use LNBH23 instead ISL6423). > diff --git a/drivers/media/dvb/ttpci/budget.c > b/drivers/media/dvb/ttpci/budget.c ... WARNING: Prefer pr_err(... to printk(KERN_ERR, ...

Re: [PATCH] DVB-S2 multistream support

2012-08-10 Thread Mauro Carvalho Chehab
Em 13-07-2012 20:15, CrazyCat escreveu: > Now present DTV_DVBT2_PLP_ID property for DVB-T2, so i add alias > DTV_DVBS2_MIS_ID (same feature for advanced DVB-S2). Now DVB-S2 multistream > filtration supported for current STV090x demod cut 3.0, so i implement > support for stv090x demod driver. Ad

HVR 1600 - Analog goes south again

2012-08-10 Thread Bob Lightfoot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear Media List Members: I have been using my Hauppage HVR1600 on Centos 6 for some time and getting good analog reception. Now the other day for a reason I have not been able to determine the Analog quit working and I have not had success restori

cron job: media_tree daily build: WARNINGS

2012-08-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Aug 10 19:00:26 CEST 2012 git hash:3de5bffddbf5fa9d04f3d181dadcaedc1efa0158 gcc version: i686-linux-gcc (GC

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-10 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 04:57:52PM +0200, Maarten Lankhorst wrote: > A dma-fence can be attached to a buffer which is being filled or consumed > by hw, to allow userspace to pass the buffer without waiting to another > device. For example, userspace can call page_flip ioctl to display the > next f

Re: [PATCH 1/2] radio-shark: Only compile led support when CONFIG_LED_CLASS is set

2012-08-10 Thread Mauro Carvalho Chehab
Em 10-08-2012 16:58, Hans de Goede escreveu: > Reported-by: Dadiv Rientjes > Signed-off-by: Hans de Goede > --- > drivers/media/radio/radio-shark.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/radio/radio-shark.c > b/drivers

[PATCH 1/2] radio-shark: Only compile led support when CONFIG_LED_CLASS is set

2012-08-10 Thread Hans de Goede
Reported-by: Dadiv Rientjes Signed-off-by: Hans de Goede --- drivers/media/radio/radio-shark.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c index c2ead23..f746ed0 100644 ---

[PATCH 2/2] radio-shark2: Only compile led support when CONFIG_LED_CLASS is set

2012-08-10 Thread Hans de Goede
Reported-by: Dadiv Rientjes Signed-off-by: Hans de Goede --- drivers/media/radio/radio-shark2.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio-shark2.c index b9575de..e593d5a 100644

Re: [Linaro-mm-sig] [PATCH 3/4] dma-seqno-fence: Hardware dma-buf implementation of fencing (v2)

2012-08-10 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 04:57:58PM +0200, Maarten Lankhorst wrote: > This type of fence can be used with hardware synchronization for simple > hardware that can block execution until the condition > (dma_buf[offset] - value) >= 0 has been met. > > A software fallback still has to be provided in ca

Re: [Linaro-mm-sig] [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-08-10 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 04:57:43PM +0200, Maarten Lankhorst wrote: > Documentation says that code requiring dma-buf should add it to > select, so inline fallbacks are not going to be used. A link error > will make it obvious what went wrong, instead of silently doing > nothing at runtime. > > Sign

[PATCH 6/6] [staging] lirc: lirc_ene0100.h is not referenced anywhere

2012-08-10 Thread Sean Young
There is a proper ene0100 driver anyway. Signed-off-by: Sean Young --- drivers/staging/media/lirc/lirc_ene0100.h | 169 -- 1 file changed, 169 deletions(-) delete mode 100644 drivers/staging/media/lirc/lirc_ene0100.h diff --git a/drivers/staging/media/lirc/lirc_ene0

[PATCH 3/6] [media] rc: Add support for the TechnoTrend USB IR Receiver

2012-08-10 Thread Sean Young
This driver is loosely based on the lirc_ttusbir driver in the staging area, but adds more accurate sampling and led control. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/keymaps/rc-tt-1500.c | 2 +

[PATCH 4/6] [media] rc: do not wake up rc thread unless there is something to do

2012-08-10 Thread Sean Young
The TechnoTrend USB IR Receiver sends 125 ISO URBs per second, even when there is no IR activity. Reduce the number of wake ups from the other drivers too. This saves about 0.25ms per second on a 2.4GHz Core 2 according to powertop. Signed-off-by: Sean Young --- drivers/media/rc/fintek-cir.c |

[PATCH 5/6] [staging] lirc: remove lirc_ttusbir driver

2012-08-10 Thread Sean Young
We now have a proper driver which uses rc-core. Signed-off-by: Sean Young --- drivers/staging/media/lirc/Kconfig| 6 - drivers/staging/media/lirc/Makefile | 1 - drivers/staging/media/lirc/lirc_ttusbir.c | 376 -- 3 files changed, 383 deletions(-) d

[PATCH 2/6] [media] rc: transmit on device which does not support it should fail

2012-08-10 Thread Sean Young
Currently write() will return 0 if an IR device does not support sending. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 5faba2a..d2fd064

[PATCH 1/6] [media] iguanair: Fix return value on transmit

2012-08-10 Thread Sean Young
Transmit returned 0 after sending and failed to send anything if the amount exceeded its buffer size. Also fix some minor errors. Signed-off-by: Sean Young --- drivers/media/rc/iguanair.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/dri

Re: Philips saa7134 IR remote problem with linux kernel v2.6.35

2012-08-10 Thread Partha Guha Roy
Hi Sean, I am not an expert on the kernel. So please excuse me if I give the wrong answer somewhere. On Fri, Aug 10, 2012 at 3:47 PM, Sean Young wrote: > > Are you runnning the lircd user space process for input or relying on > the in-kernel decoders? For my testing, I booted the vanilla kernel

[Announcement] pcimax3000+ (RDS-transmitter) control tool

2012-08-10 Thread Konke Radlow
Hello, during the last weeks I've been working on a RDS (Radio Data System) decoding library (libv4l2rds) and a corresponding test and control tool (rds-ctl), that might make it into v4l soon. In the course of this process I created a command line tool for controlling the PCIMAX3000+ RDS-transmiss

[RFC PATCH] Add core TMC (Traffic Message Channel) support

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/include/libv4l2rds.h| 64 lib/libv4l2rds/libv4l2rds.c | 340 ++- utils/rds-ctl/rds-ctl.cpp | 31 +++- 3 files changed, 432 insertions(+), 3 deletions(-) diff --git a/lib/include/libv4l2rds.h b/lib/in

[RFC PATCH 0/1] Adding core TMC decoding support to RDS library

2012-08-10 Thread Konke Radlow
Hello, this patch adds the core of TMC decoding support to the RDS library. Single and multigroup TMC messages as well as TMC system messages are decoded into an easily accessable format and can be used as the basis for a complete TMC decoding implementation. The part that's missing from the code

[PATCH 4/4] dma-buf-mgr: multiple dma-buf synchronization (v3)

2012-08-10 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst dma-buf-mgr handles the case of reserving single or multiple dma-bufs while trying to prevent deadlocks from buffers being reserved simultaneously. For this to happen extra functions have been introduced: + dma_buf_reserve() + dma_buf_unreserve() + dma_buf_

[PATCH 3/4] dma-seqno-fence: Hardware dma-buf implementation of fencing (v2)

2012-08-10 Thread Maarten Lankhorst
This type of fence can be used with hardware synchronization for simple hardware that can block execution until the condition (dma_buf[offset] - value) >= 0 has been met. A software fallback still has to be provided in case the fence is used with a device that doesn't support this mechanism. It is

[PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-10 Thread Maarten Lankhorst
A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call page_flip ioctl to display the next frame of graphics after kicking the GPU but while the GPU is still rendering

[PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-08-10 Thread Maarten Lankhorst
Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it obvious what went wrong, instead of silently doing nothing at runtime. Signed-off-by: Maarten Lankhorst --- include/linux/dma-buf.h | 99 -

[PATCH v4 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-08-10 Thread Sangwook Lee
This driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/brightness/sharpness Signed-off-by: Sangwook Lee --- drivers/media/video/Kconfig|8 + drivers/media/video/Makef

[PATCH v4 1/2] v4l: Add factory register values form S5K4ECGX sensor

2012-08-10 Thread Sangwook Lee
Add preview default settings for S5K4ECGX sensor registers, which was copied from the reference code of Samsung S.LSI. Signed-off-by: Sangwook Lee --- drivers/media/video/s5k4ecgx_regs.h | 138 +++ 1 file changed, 138 insertions(+) create mode 100644 drivers/med

[PATCH v4 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-10 Thread Sangwook Lee
The following 2 patches add driver for S5K4ECGX sensor with embedded ISP SoC, and minor v4l2 control API enhancement. S5K4ECGX is 5M CMOS Image sensor from Samsung Changes since v3: - used request_firmware to configure initial settings - added parsing functions to read initial settings - updated

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-10 Thread Julia Lawall
From: Julia Lawall Using devm_kzalloc and devm_clk_get simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. Add missing return code initializations in the er

RE: [PATCH,RESEND] v4l/s5p-mfc: added support for end of stream handling in MFC encoder

2012-08-10 Thread Kamil Debski
Hi Andrzej, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > From: Andrzej Hajda [mailto:a.ha...@samsung.com] > Sent: 10 August 2012 14:47 > > s5p-mfc encoder after receiving V4L2_ENC_CMD_STOP command > will instruct MFC device to release a

[PATCHv2 1/2] Add libv4l2rds library

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac|2 + lib/include/libv4l2rds.h| 218 + lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 964 +++ lib/lib

[PATCHv2 2/2] Add rds-ctl tool

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 938 + 4 files changed, 946 insertions(+), 1 deletion(-) create mode 100644 utils

[PATCHv2 0/2] Add support for RDS decoding

2012-08-10 Thread Konke Radlow
Hello, after the positive feedback from the last RFC session, here now a patch including all minor changes that were proposed. embarrassingly, I missed a minor bug introduced by removing the version field from the v4l2_rds struct, hence the resend Regards, Konke -- To unsubscribe f

[PATCH 2/2] Add rds-ctl tool

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 938 + 4 files changed, 946 insertions(+), 1 deletion(-) create mode 100644 utils

[PATCH 1/2] Add libv4l2rds library

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac|2 + lib/include/libv4l2rds.h| 218 + lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 965 +++ lib/lib

[PATCH 0/2] Add support for RDS decoding

2012-08-10 Thread Konke Radlow
Hello, after the positive feedback from the last RFC session, here now a patch including all minor changes that were proposed. Regards, Konke -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH,RESEND] v4l/s5p-mfc: added support for end of stream handling in MFC encoder

2012-08-10 Thread Andrzej Hajda
s5p-mfc encoder after receiving V4L2_ENC_CMD_STOP command will instruct MFC device to release all encoded frames. After dequeuing last encoded frame driver will generate V4L2_EVENT_EOS event. Signed-off-by: Andrzej Hajda Signed-off-by: Kyungmin Park --- I have removed bank2 alignement fix from t

[PATCH 2/2] [media] s5p-tv: Use devm_* functions in sii9234_drv.c file

2012-08-10 Thread Sachin Kamat
devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-tv/sii9234_drv.c | 17 - 1 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/media/video/s5p-tv/sii

[PATCH 1/2] [media] s5p-tv: Use devm_regulator_get() in sdo_drv.c file

2012-08-10 Thread Sachin Kamat
devm_regulator_get() is a device managed function and makes the exit code a bit simpler and cleaner. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-tv/sdo_drv.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/video/s5p-tv/sdo_drv.c b/driv

[RFCv3 PATCH 8/8] ad9389b: driver for the Analog Devices AD9389B video encoder.

2012-08-10 Thread Hans Verkuil
Initial version of this driver. The full datasheets are available from the Analog Devices website: http://ez.analog.com/docs/DOC-1741 Not all features of the receiver are supported by this driver for various reasons. Most notably: - No CEC support (the CEC API needs a lot more discussion) - N

[RFCv3 PATCH 6/8] v4l2-common: add CVT and GTF detection functions.

2012-08-10 Thread Hans Verkuil
These two helper functions detect whether the analog video timings detected by the video receiver match the VESA CVT or GTF standards. They basically do the inverse of the CVT and GTF modeline calculations. This patch also adds a helper function that will determine the aspect ratio based on the p

[RFCv3 PATCH 4/8] v4l2-ctrls.c: add support for the new DV controls.

2012-08-10 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ctrls.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index b6a2ee7..6a34c30 100644 --- a/drivers/media/video/v4l2-ctrls.c +

[RFCv3 PATCH 2/8] V4L2 spec: document the new DV controls and ioctls.

2012-08-10 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/biblio.xml | 40 +++ Documentation/DocBook/media/v4l/controls.xml | 161 ++ Documentation/DocBook/media/v4l/v4l2.xml |1 + 3 files changed, 202 insertions(+) diff --git a/Documentation/DocBoo

[RFCv3 PATCH 5/8] v4l2-common: add v4l_match_dv_timings.

2012-08-10 Thread Hans Verkuil
Add the v4l_match_dv_timings function that can be used to compare two v4l2_dv_timings structs. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-common.c | 33 + include/media/v4l2-common.h |4 2 files changed, 37 insertions(+) diff --git

[RFCv3 PATCH 3/8] v4l2-subdev: add support for the new edid ioctls.

2012-08-10 Thread Hans Verkuil
Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-compat-ioctl32.c | 57 + drivers/media/video/v4l2-ioctl.c | 13 +++ drivers/media/video/v4l2-subdev.c |6 +++ include/media/v4l2-subdev.h |2 + 4 files changed, 78 i

[RFCv3 PATCH 1/8] v4l2 core: add the missing pieces to support DVI/HDMI/DisplayPort.

2012-08-10 Thread Hans Verkuil
These new controls and two new ioctls make it possible to properly support VGA, DVI-A/D/I, HDMI and DisplayPort connectors. All these controls and the ioctls are all at the sub-device level. They are meant for V4L2 bridge/platform drivers or to be accessed on embedded systems through /dev/v4l-subde

[RFCv3 PATCH 0/8] V4L2: add missing pieces to support HDMI et al and add adv7604/ad9389b drivers

2012-08-10 Thread Hans Verkuil
Hi all, This is the third version of this patch series. The second version can be found here: http://www.spinics.net/lists/linux-media/msg50413.html I made a pull request based on that and got some feedback: http://patchwork.linuxtv.org/patch/13442/ The feedback has been incorporated in this th

Re: [patch] [media] qt1010: signedness bug in qt1010_init_meas1()

2012-08-10 Thread Antti Palosaari
On 08/10/2012 12:25 PM, Dan Carpenter wrote: qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8. Signed-off-by: Dan Carpenter Acked-by: Antti Palosaari diff --git a/drivers/media/common/tuners/qt1010.c b/drivers

[PATCHv2 1/2] media: rc: Introduce RX51 IR transmitter driver

2012-08-10 Thread Timo Kokkonen
This is the driver for the IR transmitter diode found on the Nokia N900 (also known as RX51) device. The driver is mostly the same as found in the original 2.6.28 based kernel that comes with the device. The following modifications have been made compared to the original driver version: - Adopt t

[PATCHv2 2/2] ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data

2012-08-10 Thread Timo Kokkonen
The IR diode on the RX51 is connected to the GPT9. This data is needed for the IR driver to function. Signed-off-by: Timo Kokkonen --- arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-oma

[PATCH 0/2] Add Nokia N900 (RX51) IR diode support

2012-08-10 Thread Timo Kokkonen
These patches add the support for sending IR remote controller codes on the Nokia N900 phone. The code is taken from the public N900 kernel release and modified to work with today's kernel. The code has been tested with a real Nokia N900 device and confirmed to work. I can identify only one known

Re: Philips saa7134 IR remote problem with linux kernel v2.6.35

2012-08-10 Thread Sean Young
On Wed, Aug 08, 2012 at 12:23:46AM +0600, Partha Guha Roy wrote: > I have a saa7134 analog tv card (Avermedia PCI pure m135a) with an IR > remote. The IR remote is recognized by a standard keyboard and lirc > used to work fine with this. However, from kernel v2.6.35, the IR > remote does not work p

[patch] [media] qt1010: signedness bug in qt1010_init_meas1()

2012-08-10 Thread Dan Carpenter
qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8. Signed-off-by: Dan Carpenter diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c index 2d79b1f..bdc39e1 100644 --- a/drivers/media

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/10/2012 09:36 AM, Hans Verkuil wrote: On Fri 10 August 2012 09:16:34 Hans de Goede wrote: Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in config

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans Verkuil
On Fri 10 August 2012 09:16:34 Hans de Goede wrote: > Hi, > > On 08/09/2012 02:14 PM, Hans Verkuil wrote: > > On Thu August 9 2012 13:58:07 Hans de Goede wrote: > >> Hi Konke, > >> > >> As Gregor already mentioned there is no need to define libv4l2rdssubdir in > >> configure.ac , > >> so please d

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all thos

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 10:03 PM, David Rientjes wrote: On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be "depends on LEDS_CLASS" rather than select it if there is