[RFCv3 PATCH 22/33] vb2-core: refactor reqbufs/create_bufs.

From: Hans Verkuil Split off the memory and type validation. This is done both from reqbufs and create_bufs, and will also be done by vb2 helpers in a later patch. Signed-off-by: Hans Verkuil --- drivers/media/video/videobuf2-core.c | 145 ++ 1 file changed, 77

[RFCv3 PATCH 31/33] v4l2-dev.c: also add debug support for the fops.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-dev.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c index b827781..d13c47f 100644 --- a/drivers/media/vid

[RFCv3 PATCH 04/33] v4l2-ioctl.c: remove an unnecessary #ifdef.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 7a15f35..be89dad 100644 --- a/drivers/media/video/v4l2-ioctl.c +++ b/drivers/medi

[RFCv3 PATCH 11/33] v4l2-ioctl.c: use the new table for control ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 395 +++--- 1 file changed, 198 insertions(+), 197 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 1f75a6c..798ee42 100644

[RFCv3 PATCH 10/33] v4l2-ioctl.c: use the new table for queuing/parm ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 317 -- 1 file changed, 166 insertions(+), 151 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 4d2d0d6..1f75a6c 100644

[RFCv3 PATCH 15/33] v4l2-ioctl.c: use the new table for preset/timings ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 207 -- 1 file changed, 67 insertions(+), 140 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index ee11e08..fdceac8 100644 -

[RFCv3 PATCH 23/33] vb2-core: add support for count == 0 in create_bufs.

From: Hans Verkuil This also fixes incorrect error handling in create_bufs: the return code of __vb2_queue_alloc is the number of allocated buffers, and not a traditional error code. Signed-off-by: Hans Verkuil --- drivers/media/video/videobuf2-core.c | 10 ++ 1 file changed, 6 inser

[RFCv3 PATCH 33/33] pwc: v4l2-compliance fixes.

From: Hans Verkuil - add device_caps - set colorspace - s_parm should support a fps of 0 (== reset to nominal fps) Signed-off-by: Hans Verkuil --- drivers/media/video/pwc/pwc-v4l.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/media/vi

[RFCv3 PATCH 32/33] pwc: use the new vb2 helpers.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/pwc/pwc-if.c | 155 - drivers/media/video/pwc/pwc-v4l.c | 140 +++-- drivers/media/video/pwc/pwc.h |3 - 3 files changed, 24 insertions(+), 274 delet

[RFCv3 PATCH 21/33] cx18: don't mess with vfd->debug.

From: Hans Verkuil This is now controlled by sysfs. Signed-off-by: Hans Verkuil --- drivers/media/video/cx18/cx18-ioctl.c | 18 -- drivers/media/video/cx18/cx18-ioctl.h |2 -- drivers/media/video/cx18/cx18-streams.c |4 ++-- 3 files changed, 2 insertions(+), 22 de

[RFCv3 PATCH 18/33] v4l2-dev.c: add debug sysfs entry.

From: Hans Verkuil Since this could theoretically change the debug value while in the middle of v4l2-ioctl.c, we make a copy of vfd->debug to ensure consistent debug behavior. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-dev.c | 24 drivers/media/video/

[RFCv3 PATCH 09/33] v4l2-ioctl.c: use the new table for std/tuner/modulator ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 430 +++--- 1 file changed, 220 insertions(+), 210 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 78ff09f..4d2d0d6 100644

[RFCv3 PATCH 00/33] Core and vb2 enhancements

Hi all, This is the third version of this patch series. The first version is here: http://www.mail-archive.com/linux-media@vger.kernel.org/msg47558.html Changes since RFCv2: - Rebased to staging/for_v3.6. - Incorporated Laurent's review comments in patch 22: vb2-core: refactor reqbufs/create

[RFCv3 PATCH 25/33] v4l2-dev/ioctl.c: add vb2_queue support to video_device.

From: Hans Verkuil This prepares struct video_device for easier integration with vb2. It also introduces a new lock that protects the vb2_queue. It is up to the driver to use it or not. And the driver can associate an owner filehandle with the queue to check whether queuing requests are permitte

[RFCv3 PATCH 24/33] Spec: document CREATE_BUFS behavior if count == 0.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/vidioc-create-bufs.xml |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml b/Documentation/DocBook/media/v4l/vidioc-create-bufs.xm

[RFCv3 PATCH 17/33] v4l2-ioctl.c: finalize table conversion.

From: Hans Verkuil Implement the default case which finalizes the table conversion and allows us to remove the last part of the switch. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-)

[RFCv3 PATCH 03/33] v4l2-ioctl.c: v4l2-ioctl: add debug and callback/offset functionality.

From: Hans Verkuil Add the necessary plumbing to make it possible to replace the switch by a table driven implementation. The ioctls ops can either be called directly, or by calling a small function that does some additional work if needed. Signed-off-by: Hans Verkuil --- drivers/media/video/

[RFCv3 PATCH 14/33] v4l2-ioctl.c: use the new table for debug ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 139 -- 1 file changed, 89 insertions(+), 50 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 935fcbc..ee11e08 100644 --

[RFCv3 PATCH 20/33] ivtv: don't mess with vfd->debug.

From: Hans Verkuil This is now controlled by sysfs. Signed-off-by: Hans Verkuil --- drivers/media/video/ivtv/ivtv-ioctl.c | 12 drivers/media/video/ivtv/ivtv-ioctl.h |1 - drivers/media/video/ivtv/ivtv-streams.c |4 ++-- 3 files changed, 2 insertions(+), 15 deletions

[RFCv3 PATCH 26/33] videobuf2-core: add helper functions.

From: Hans Verkuil Add helper functions to make it easier to adapt drivers to vb2. These helpers take care of core locking and check if the filehandle is the owner of the queue. Signed-off-by: Hans Verkuil --- drivers/media/video/videobuf2-core.c | 227 ++ inc

[RFCv3 PATCH 30/33] vivi: add create_bufs/preparebuf support.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/vivi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index f6d7c6e..1e8c4f3 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/medi

[RFCv3 PATCH 19/33] v4l2-ioctl: remove v4l_(i2c_)print_ioctl

From: Hans Verkuil v4l_i2c_print_ioctl wasn't used and v4l_print_ioctl could be replaced by v4l_printk_ioctl. Signed-off-by: Hans Verkuil --- drivers/media/video/pvrusb2/pvrusb2-v4l2.c |4 ++-- drivers/media/video/sn9c102/sn9c102.h |2 +- drivers/media/video/uvc/uvc_v4l2.c

[RFCv3 PATCH 28/33] vivi: embed struct video_device instead of allocating it.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/vivi.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index e00efcf..1e4da5e 100644 --- a/drivers/media/video/vivi.c ++

[RFCv3 PATCH 12/33] v4l2-ioctl.c: use the new table for selection ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 262 ++ 1 file changed, 127 insertions(+), 135 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 798ee42..179b22c 100644

[RFCv3 PATCH 27/33] vivi: remove pointless g/s_std support

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/vivi.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 08c1024..e00efcf 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c

[RFCv3 PATCH 29/33] vivi: use vb2 helper functions.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/vivi.c | 150 1 file changed, 12 insertions(+), 138 deletions(-) diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 1e4da5e..f6d7c6e 100644 --- a/drivers

[RFCv3 PATCH 07/33] v4l2-ioctl.c: use the new table for format/framebuffer ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 692 +++--- 1 file changed, 346 insertions(+), 346 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 4029d12..25c0a8a 100644

[RFCv3 PATCH 13/33] v4l2-ioctl.c: use the new table for compression ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 123 ++ 1 file changed, 46 insertions(+), 77 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 179b22c..935fcbc 100644 --

[RFCv3 PATCH 16/33] v4l2-ioctl.c: use the new table for the remaining ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 278 +- 1 file changed, 154 insertions(+), 124 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index fdceac8..74fe6a2 100644

[RFCv3 PATCH 05/33] v4l2-ioctl.c: use the new table for querycap and i/o ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 328 -- 1 file changed, 133 insertions(+), 195 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index be89dad..7556678 100644

[RFCv3 PATCH 06/33] v4l2-ioctl.c: use the new table for priority ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 60 ++ 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 7556678..4029d12 100644 --

[RFCv3 PATCH 08/33] v4l2-ioctl.c: use the new table for overlay/streamon/off ioctls.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 47 -- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 25c0a8a..78ff09f 100644 --

[RFCv3 PATCH 01/33] v4l2-ioctl.c: move a block of code down, no other changes.

From: Hans Verkuil A block of code is moved down in the code to make later changes easier. Do just the move without other changes to keep the diff readable for the upcoming patch. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 288 +++--- 1

[RFCv3 PATCH 02/33] v4l2-ioctl.c: introduce INFO_FL_CLEAR to replace switch.

From: Hans Verkuil The switch statement that determines how much data should be copied from userspace is replaced by a table lookup. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-ioctl.c | 103 +++--- 1 file changed, 41 insertions(+), 62 deletions(-)

Re: [PATCH] omap_vout: Set DSS overlay_info only if paddr is non zero

On Mon, Mar 19, 2012 at 5:16 PM, Archit Taneja wrote: > On Monday 19 March 2012 02:15 PM, Hiremath, Vaibhav wrote: >> >> On Fri, Mar 16, 2012 at 16:41:27, Taneja, Archit wrote: >>> >>> Hi, >>> >>> On Friday 16 March 2012 03:46 PM, Archit Taneja wrote: On Monday 12 March 2012 03:34 PM, Hi

dib0700 can't enable debug messages

Hi all, I would like to see some debug messages from the dib0700 driver. I have tried to enable debug messages like this, following the instructions found here: http://www.linuxtv.org/wiki/index.php/Template:Making-it-work:dvb-usb-dib0700 # rmmod dvb_usb_dib0700 # insmod /lib/modules/3.3.7-1-AR

Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

Hey Peter, On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin wrote: > -                       no_signal = stv090x_chk_signal(state); > +                       (void) stv090x_chk_signal(state); Why are you casting return to void? I can't see there is a reason to it. Regards, Ezequiel. -- To

DVB core enhancements - comments please?

Here is my list of needed DVB core related changes. Feel free to comment - what are not needed or what you would like to see instead. I will try to implement what I can (and what I like most interesting :). general validly checking for demodulator callback input values

Re: [PATCH 7/8] soc-camera: Add and use soc_camera_power_[on|off]() helper functions

Hi Guennadi, Thanks for the review. On Thursday 21 June 2012 23:15:14 Guennadi Liakhovetski wrote: > On Wed, 23 May 2012, Laurent Pinchart wrote: > > Instead of forcing all soc-camera drivers to go through the mid-layer to > > handle power management, create soc_camera_power_[on|off]() functions

[PATCH] [V2] stv090x: variable 'no_signal' set but not used

Remove variable and ignore return value of stv090x_chk_signal(). Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- drivers/media/dvb/frontends/stv090x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/

Re: [PATCH 3/8] ov2640: Don't access the device in the g_mbus_fmt operation

Hi Guennadi, Thanks for the review. On Thursday 21 June 2012 14:28:04 Guennadi Liakhovetski wrote: > On Wed, 23 May 2012, Laurent Pinchart wrote: > > The g_mbus_fmt operation only needs to return the current mbus frame > > format and doesn't need to configure the hardware to do so. Fix it to > >

Re: dheitmueller/cx23885_fixes.git and mygica x8507

Hi El 27/06/12 01:52, Devin Heitmueller escribió: On Tue, Jun 26, 2012 at 11:40 PM, Alfredo Jesús Delaiti wrote: The problem was that tvtime was set to 768, by passing a resolution to 720 was solved. Sorry for not having tried before. With a resolution of 720 pixels the image looks good. My si

Re: [ 3960.758784] 1 lock held by motion/7776: [ 3960.758788] #0: (&queue->mutex){......}, at: [] uvc_queue_enable+0x32/0xc0

Monday, May 7, 2012, 3:28:36 PM, you wrote: > Hi, > On 05/07/2012 01:44 PM, Hans Verkuil wrote: >> On Monday 07 May 2012 13:06:01 Laurent Pinchart wrote: >>> Hi Sanser, >>> >>> On Sunday 06 May 2012 16:54:40 Sander Eikelenboom wrote: Hello Laurent / Mauro, I have updated to latest

Re: [PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

Hi Dima, On Tuesday 26 June 2012 13:53:34 Dima Zavin wrote: > On Tue, Jun 26, 2012 at 2:40 AM, Hans Verkuil wrote: > > On Tue 26 June 2012 11:11:06 Laurent Pinchart wrote: > >> On Tuesday 26 June 2012 10:40:44 Tomasz Stanislawski wrote: > >> > Hi Dima Zavin, > >> > Thank you for the patch and for

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Jun 27 19:00:22 CEST 2012 git hash:5472d3f17845c4398c6a510b46855820920c2181 gcc version: i686-linux-gcc (GC

[PATCH 2/9] cx23885: Remove useless struct i2c_algo_bit_data

The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with struct i2c_algorithm. Moreover, i2c_algo field is not used since i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus(). Therefore, it's safe to remove it. Tested by compilation only. Signed-off-by: Ezequiel Garcia

[PATCH 1/9] saa7164: Remove useless struct i2c_algo_bit_data

The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with struct i2c_algorithm. Moreover, i2c_algo field is not used since i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus(). Therefore, it's safe to remove it. Tested by compilation only. Signed-off-by: Ezequiel Garcia

[PATCH 9/9] cx25821: Replace struct memcpy with struct assignment

Copying structs by assignment is type safe. Plus, is shorter and easier to read. Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx25821/cx25821-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/cx25821/cx25821-i2c.c b/drivers/media/

[PATCH 6/9] saa7164: Replace struct memcpy with struct assignment

Copying structs by assignment is type safe. Plus, is shorter and easier to read. Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/

[PATCH 8/9] cx231xx: Replace struct memcpy with struct assignment

Copying structs by assignment is type safe. Plus, is shorter and easier to read. Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx231xx/cx231xx-i2c.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/v

[PATCH 7/9] cx23885: Replace struct memcpy with struct assignment

Copying structs by assignment is type safe. Plus, is shorter and easier to read. Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx23885/cx23885-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/

[PATCH 5/9] saa7164: Remove unused saa7164_call_i2c_clients()

This function has no users, so it's safe to remove it. Tested by compilation only. Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/me

[PATCH 4/9] cx25821: Remove useless struct i2c_algo_bit_data

The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with struct i2c_algorithm. Moreover, i2c_algo field is not used since i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus(). Therefore, it's safe to remove it. Tested by compilation only. Signed-off-by: Ezequiel Garcia

[PATCH 3/9] cx231xx: Remove useless struct i2c_algo_bit_data

The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with struct i2c_algorithm. Moreover, i2c_algo field is not used since i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus(). Therefore, it's safe to remove it. Tested by compilation only. Signed-off-by: Ezequiel Garcia

[PATCH v2 0/9] struct i2c_algo_bit_data cleanup on several drivers

Hi Mauro, This patchset cleans the i2c part of some drivers. This issue was recently reported by Dan Carpenter [1], and revealed wrong (and harmless) usage of struct i2c_algo_bit_data. This series consist in two kinds of patches: - remove one unused function - remove unused field i2c_algo - re

Re: [git:v4l-dvb/for_v3.6] [media] stv090x: variable 'no_signal' set but not used

Manu, On Wed, Jun 27, 2012 at 9:59 AM, Manu Abraham wrote: > Wonderful, instead of ignoring the return value, you ignored the whole > function > itself. Most of the demodulator registers are R-M-x registers. The patch > brings > in unwanted side-effects of R-M-x. Sorry for that. I'll send V2 of

[PATCH] [media] omap3isp: fix dqbuf description comment

Signed-off-by: Michael Jones --- drivers/media/video/omap3isp/ispqueue.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) This comment looks like it was a copy-paste from the description of qbuf. diff --git a/drivers/media/video/omap3isp/ispqueue.c b/drivers/media/video/omap

Re: [RFC/PATCH v3] media: Add stk1160 new driver

On 06/27/2012 04:40 PM, Ezequiel Garcia wrote: > Hi Sylwester, > > I'm OK with every comment you made. > > Except for the -ETIMEDOUT. > I'm still not 100% convinced, but I'll take your word for it. It looked most appropriate to me, however I didn't really analyse very deeply the whole driver to

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi Laurent, On Wed, 2012-06-27 at 16:42 +0200, Laurent Pinchart wrote: > Hi Ivan, > > On Wednesday 27 June 2012 17:30:32 Ivan T. Ivanov wrote: > > On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote: > > > On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote: > > > > On Tue, 2012-06-26

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi Ivan, On Wednesday 27 June 2012 17:30:32 Ivan T. Ivanov wrote: > On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote: > > On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote: > > > On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote: > > > > On Saturday 23 June 2012 11:22:37 Sak

Re: [RFC/PATCH v3] media: Add stk1160 new driver

On Mon, Jun 25, 2012 at 6:09 PM, Sylwester Nawrocki wrote: > Hi Ezequiel, > > a few minor comments below... Hi Sylwester, I'm OK with every comment you made. Except for the -ETIMEDOUT. I'm still not 100% convinced, but I'll take your word for it. Also, is there any other serious issue preventi

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi, On Wed, 2012-06-27 at 15:54 +0200, Laurent Pinchart wrote: > Hi Ivan, > > On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote: > > On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote: > > > On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote: > > > > On Mon, Jun 18, 2012 at 04:30

[PATCH] s5p-fimc: Remove V4L2_FL_LOCK_ALL_FOPS flag

This patch adds locking for open(), close(), poll() and mmap() file operations in the driver as a follow up to the changes done in commit 5126f2590bee412e3053de851cb07f531 "v4l2-dev: add flag to have the core lock all file operations". Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Par

[PATCH] s5p-fimc: Add missing FIMC-LITE file operations locking

commit 5126f2590bee412e3053de851cb07f531e4be36a "v4l2-dev: add flag to have the core lock all file operations" introduced an additional bit flag (V4L2_FL_LOCK_ALL_FOPS) that should be set by drivers that use the v4l2 core lock for all file operations. Since this driver has been merged at the same t

[PATCH] Revert "[media] V4L: JPEG class documentation corrections"

This reverts commit feed0258e11e04b7e0, as the same issues are already covered in another version of that patch that was also applied (579e92ffac65c717c9c8a50feb755a). Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Documentation/DocBook/media/v4l/controls.xml |

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi Sakari, On Tuesday 26 June 2012 22:01:14 Sakari Ailus wrote: > On Tue, Jun 26, 2012 at 03:30:09AM +0200, Laurent Pinchart wrote: > > On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote: > > > On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote: > > > > Rearrange the CFA interpolat

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi, On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote: > > On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote: > > > Rearrange the CFA interpolation coefficients table based on the Bayer > > > pattern.

Re: [PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

Hi Ivan, On Wednesday 27 June 2012 16:42:01 Ivan T. Ivanov wrote: > On Tue, 2012-06-26 at 03:30 +0200, Laurent Pinchart wrote: > > On Saturday 23 June 2012 11:22:37 Sakari Ailus wrote: > > > On Mon, Jun 18, 2012 at 04:30:53PM +0200, Laurent Pinchart wrote: > > > > Rearrange the CFA interpolation c

Re: [patch -resend] [media] az6007: precedence bug in az6007_i2c_xfer()

Em 27-06-2012 06:06, Dan Carpenter escreveu: > The intent here was to test that the flag was clear but the '!' has > higher precedence than the '&'. I2C_M_RD is 0x1 so the current code is > equivalent to "&& (!sgs[i].flags) ..." > > Signed-off-by: Dan Carpenter > --- > I sent this originally on

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

> Hi Federico, > > Any news on this? Not at the moment. I'll ask for detail :) -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: rtl28xxu - rtl2832 frontend attach

On 06/27/2012 07:21 AM, Thomas Mair wrote: > On 26.06.2012 19:17, poma wrote: >> On 05/28/2012 04:48 PM, Thomas Mair wrote: >>> On 28.05.2012 08:58, Thomas Mair wrote: On 26.05.2012 04:47, poma wrote: > On 05/20/2012 11:12 PM, Thomas Mair wrote: >> On 20.05.2012 22:08, Antti Palosaari

Re: [PATCH 1/6] omap3isp: video: Split format info bpp field into width and bpp

Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the review. > > On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote: >> Laurent Pinchart wrote: >>> The bpp field currently stores the sample width and is aligned to the >>> next multiple of 8 bits when computing data size in memory. This won'

Re: [PATCH 1/6] omap3isp: video: Split format info bpp field into width and bpp

On Wednesday 27 June 2012 13:54:30 Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the review. > > On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote: > > Laurent Pinchart wrote: > > > The bpp field currently stores the sample width and is aligned to the > > > next multiple of 8 bits when

Re: [PATCH 6/6] omap3isp: ccdc: Add YUV input formats support

Laurent Pinchart wrote: > Enable the bridge automatically when the input format is YUYV8 or UYVY8. > > Signed-off-by: Laurent Pinchart Thanks for the patch, Laurent! Acked-by: Sakari Ailus -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 1/6] omap3isp: video: Split format info bpp field into width and bpp

Hi Sakari, Thanks for the review. On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote: > Laurent Pinchart wrote: > > The bpp field currently stores the sample width and is aligned to the > > next multiple of 8 bits when computing data size in memory. This won't > > work anymore for YUYV8_2X8 fo

Re: [PATCH 5/6] omap3isp: ccdc: Remove ispccdc_syncif structure

Laurent Pinchart wrote: > The structure is only used to store configuration data and pass it to > CCDC configuration functions. Access the data directly from the > locations that need it. > > Signed-off-by: Laurent Pinchart Thanks!! Acked-by: Sakari Ailus -- Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH 4/6] omap3isp: ccdc: Remove support for interlaced data and master HS/VS mode

Laurent Pinchart wrote: > Those features are half-implemented and not used. Remove them. > > Signed-off-by: Laurent Pinchart Thanks! Acked-by: Sakari Ailus -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mes

Re: [PATCH 1/6] omap3isp: video: Split format info bpp field into width and bpp

Hi Laurent, Thanks for the patch. Laurent Pinchart wrote: > The bpp field currently stores the sample width and is aligned to the > next multiple of 8 bits when computing data size in memory. This won't > work anymore for YUYV8_2X8 formats. Split the bpp field into a sample > width and a bits per

Re: About s_std_output

On Wed 27 June 2012 12:14:34 Scott Jiang wrote: > 2012/6/27 Hans Verkuil : > > On Wed 27 June 2012 11:37:24 Scott Jiang wrote: > >> Hi Hans, > >> > >> I noticed there are two s_std ops in core and video for output. And > >> some drivers call video->s_std_out and then core->s_std in their S_STD > >>

Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

Hi Hans, On Wednesday 27 June 2012 12:38:54 Hans Verkuil wrote: > On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote: > > On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Since this could theoretically change the debug value while in the > > > middle of v

Re: [RFCv2 PATCH 23/34] vb2-core: refactor reqbufs/create_bufs.

On Wednesday 27 June 2012 12:37:21 Hans Verkuil wrote: > On Wed 27 June 2012 11:52:10 Laurent Pinchart wrote: > > On Friday 22 June 2012 14:21:17 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Split off the memory and type validation. This is done both from reqbufs > > > and create_bufs

Re: [RFCv2 PATCH 32/34] v4l2-dev.c: also add debug support for the fops.

On Wed 27 June 2012 11:59:06 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:26 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/v4l2-dev.c | 25 - > > 1 file

Re: [PATCH 0/2] Miscellaneous OMAP3 ISP fixes

Laurent Pinchart wrote: > Hi everybody, > > Not much to be said here. The first patch is needed by the second, which is > described in its commit message. I'd like to get this into v3.6. > > Laurent Pinchart (2): > omap3isp: Don't access ISP_CTRL directly in the statistics modules > omap3isp:

Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Since this could theoretically change the debug value while in the middle > > of v4l2-ioctl.c, we make a copy of vfd->

Re: [RFCv2 PATCH 23/34] vb2-core: refactor reqbufs/create_bufs.

On Wed 27 June 2012 11:52:10 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:17 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Split off the memory and type validation. This is done both from reqbufs and > > create_bufs, and will also be done by

Re: [RFCv2 PATCH 27/34] videobuf2-core: add helper functions.

On Wed 27 June 2012 11:42:31 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:21 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add helper functions to make it easier to adapt drivers to vb2. > > > > These helpers take care of core locking and c

Re: About s_std_output

2012/6/27 Hans Verkuil : > On Wed 27 June 2012 11:37:24 Scott Jiang wrote: >> Hi Hans, >> >> I noticed there are two s_std ops in core and video for output. And >> some drivers call video->s_std_out and then core->s_std in their S_STD >> iotcl. Could anyone share me the story why we have >> s_std_o

Re: [RFCv2 PATCH 32/34] v4l2-dev.c: also add debug support for the fops.

Hi Hans, Thanks for the patch. On Friday 22 June 2012 14:21:26 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-dev.c | 25 - > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/vi

Re: About s_std_output

On Wed 27 June 2012 11:37:24 Scott Jiang wrote: > Hi Hans, > > I noticed there are two s_std ops in core and video for output. And > some drivers call video->s_std_out and then core->s_std in their S_STD > iotcl. Could anyone share me the story why we have > s_std_output/g_std_output/g_tvnorms_out

Re: [RFCv2 PATCH 19/34] v4l2-dev.c: add debug sysfs entry.

Hi Hans, Thanks for the patch. On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > From: Hans Verkuil > > Since this could theoretically change the debug value while in the middle > of v4l2-ioctl.c, we make a copy of vfd->debug to ensure consistent debug > behavior. In my review of RFCv1, I

Re: [RFCv2 PATCH 23/34] vb2-core: refactor reqbufs/create_bufs.

Hi Hans, Thanks for the patch. On Friday 22 June 2012 14:21:17 Hans Verkuil wrote: > From: Hans Verkuil > > Split off the memory and type validation. This is done both from reqbufs and > create_bufs, and will also be done by vb2 helpers in a later patch. > > Signed-off-by: Hans Verkuil > ---

Re: [RFCv2 PATCH 27/34] videobuf2-core: add helper functions.

Hi Hans, Thanks for the patch. On Friday 22 June 2012 14:21:21 Hans Verkuil wrote: > From: Hans Verkuil > > Add helper functions to make it easier to adapt drivers to vb2. > > These helpers take care of core locking and check if the filehandle is the > owner of the queue. > > Signed-off-by: H

About s_std_output

Hi Hans, I noticed there are two s_std ops in core and video for output. And some drivers call video->s_std_out and then core->s_std in their S_STD iotcl. Could anyone share me the story why we have s_std_output/g_std_output/g_tvnorms_output ops in video instead of making use of s_std/g_std in cor

Re: hacking MT9P031 (LI-5M03) driver in Ubuntu 12.04 on BeagleBoard xM?

Hi Chris, On Thursday 21 June 2012 09:38:11 Chris MacGregor wrote: > Hi. I was redirected to this list by a response to my post (below) on > the BeagleBoard group. I'm happy to help/cooperate/etc. in whatever way > I reasonably can. > > Original Message > > Hello, all. > > I

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

On Mon 28 May 2012 13:47:43 Federico Vaga wrote: > > I didn't get any reply from Federico when I posted my concerns last > > week, so that makes me unhappy as well. > > > > I hope the author will fix these issues, but in the meantime this will > > move it to staging waiting for further development

[patch -resend] [media] az6007: precedence bug in az6007_i2c_xfer()

The intent here was to test that the flag was clear but the '!' has higher precedence than the '&'. I2C_M_RD is 0x1 so the current code is equivalent to "&& (!sgs[i].flags) ..." Signed-off-by: Dan Carpenter --- I sent this originally on Wed, 25 Jan 2012 and Emil Goode sent the same fix on Thu, M