Re: cron job: media_tree daily build: ERRORS: help needed

2012-06-18 Thread Hans Verkuil
Hi all, Yesterday I upgraded the gcc version I use to compile the daily build to 4.7.1. This causes very strange errors when compiling 2.6.39 - 3.3: FATAL: media_build/v4l/tuner: sizeof(struct i2c_device_id)=32 is not a modulo of the size of section __mod_i2c_device_table=18. Fix definition of

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread David Dillow
On Mon, 2012-06-18 at 10:36 -0400, Devin Heitmueller wrote: > On Mon, Jun 18, 2012 at 10:32 AM, David Dillow wrote: > > Hmm, it sounds like perhaps changing the standby call in the tuner core > > to asynchronously power down the tuner may be the way to go -- ie, when > > we tell it to standby, it

Re: [PATCH] Revert "[media] media: mx2_camera: Fix mbus format handling"

2012-06-18 Thread Mauro Carvalho Chehab
Em 18-06-2012 21:55, Fabio Estevam escreveu: > Hi Mauro, > > On Fri, May 25, 2012 at 7:06 PM, Guennadi Liakhovetski > wrote: >> This reverts commit d509835e32bd761a2b7b446034a273da568e5573. That commit >> breaks support for the generic pass-through mode in the driver for formats, >> not natively

Re: [PATCH] Revert "[media] media: mx2_camera: Fix mbus format handling"

2012-06-18 Thread Fabio Estevam
Hi Mauro, On Fri, May 25, 2012 at 7:06 PM, Guennadi Liakhovetski wrote: > This reverts commit d509835e32bd761a2b7b446034a273da568e5573. That commit > breaks support for the generic pass-through mode in the driver for formats, > not natively supported by it. Besides due to a merge conflict it also

Re: SoC i.mx35 userptr method failure while running capture-example utility

2012-06-18 Thread Laurent Pinchart
Hi, On Monday 18 June 2012 16:26:01 Prabhakar Lad wrote: > On Mon, Jun 18, 2012 at 4:05 PM, Laurent Pinchart wrote: > > On Monday 18 June 2012 12:28:44 Prabhakar Lad wrote: > >> On Wed, May 2, 2012 at 4:20 AM, Guennadi Liakhovetski wrote: > >> > On Tue, 1 May 2012, Alex Gershgorin wrote: > >> >> H

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-18 Thread Mauro Carvalho Chehab
Em 28-05-2012 07:46, Hans Verkuil escreveu: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > Acked-by: Hans de Goede > --- > include/linux/videodev2.h | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/include/linux/videodev2.h b/include/li

Re: [PATCH v3 5/9] video/uvc: use memweight()

2012-06-18 Thread Mauro Carvalho Chehab
Em 08-06-2012 21:50, Akinobu Mita escreveu: > Use memweight() to count the total number of bits set in memory area. > > Signed-off-by: Akinobu Mita > Acked-by: Laurent Pinchart > Cc: linux-media@vger.kernel.org Acked-by: Mauro Carvalho Chehab > --- > No changes from v1 > > drivers/media/vi

Re: [PATCH] make VIDEO_MEDIA depends on DVB_CORE only (removing depends VIDEO_DEV)

2012-06-18 Thread Mauro Carvalho Chehab
Em 07-06-2012 22:55, cheng renquan escreveu: > I think the root cause is VIDEO_MEDIA depending on VIDEO_DEV or DVB_CORE; > since MEDIA_TUNER is depending on VIDEO_MEDIA; > I have VIDEO_DEV but not DVB_CORE, hence should be no VIDEO_MEDIA, > > config MEDIA_TUNER > tristate > defau

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-06-18 Thread Laurent Pinchart
Hi Bhupesh, On Monday 18 June 2012 18:14:16 Bhupesh SHARMA wrote: > Hi Laurent, > > Can you please review this patch and let me know if any modifications > are required.. Done. I'm sorry for not having done this before, I've been really busy lately. I'll review 5/5 tomorrow. -- Regards, Laur

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-06-18 Thread Laurent Pinchart
Hi Bhupesh, Thanks for the patch. It looks quite good, please see below for various small comments. On Friday 01 June 2012 15:08:57 Bhupesh Sharma wrote: > This patch reworks the videobuffer management logic present in the UVC > webcam gadget and ports it to use the "more apt" videobuf2 framewor

Re: [PATCH] DVB: stb0899: speed up getting BER values

2012-06-18 Thread Mauro Carvalho Chehab
Em 02-06-2012 12:04, Klaus Schmidinger escreveu: > stb0899_read_ber() takes 500ms (half a second!) to deliver the current > BER value. Apparently it takes 5 subsequent readings, with a 100ms pause > between them (and even before the first one). This is a real performance > brake if an application f

Re: [v4l-utils] Add configure option to allow qv4l2 disable

2012-06-18 Thread Mauro Carvalho Chehab
Em 31-05-2012 13:29, Ezequiel Garcia escreveu: > Hi Gregor, > > On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny wrote: >> Hello, >> >> >> On 5/30/12 3:42 PM, Ezequiel Garcia wrote: >>> >>> This patch could ease the job of a few people, >>> by providing an option they actually need. >>> OpenWRT [1]

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Dan Carpenter
On Mon, Jun 18, 2012 at 06:00:52PM -0300, Ezequiel Garcia wrote: > On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter > wrote: > > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: > >> Hi Mauro, > >> > >> This patchset cleans the i2c part of some drivers. > >> This issue was recently

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Ezequiel Garcia
On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter wrote: > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: >> Hi Mauro, >> >> This patchset cleans the i2c part of some drivers. >> This issue was recently reported by Dan Carpenter [1], >> and revealed wrong (and harmless) usage of str

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Dan Carpenter
On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: > Hi Mauro, > > This patchset cleans the i2c part of some drivers. > This issue was recently reported by Dan Carpenter [1], > and revealed wrong (and harmless) usage of struct i2c_algo_bit. > How is this harmless? We are setting t

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Ezequiel Garcia
Hi Palash, On Mon, Jun 18, 2012 at 5:30 PM, Palash Bandyopadhyay wrote: > Thanks Ezequiel and Dan. The changes look ok. I'll have someone check out the > changes on the CX devices. > If you can have them tested, I think it would be great. Thanks for reviewing, Ezequiel. -- To unsubscribe from

RE: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Palash Bandyopadhyay
Thanks Ezequiel and Dan. The changes look ok. I'll have someone check out the changes on the CX devices. Rgds, Palash -Original Message- From: Ezequiel Garcia [mailto:elezegar...@gmail.com] Sent: Monday, June 18, 2012 12:23 PM To: Mauro Carvalho Chehab Cc: linux-media; Dan Carpenter; Pa

[PATCH] media: add Analog Devices ADV7393 video encoder driver

2012-06-18 Thread Benoît Thébaudeau
Add ADV7393 I²C-based video encoder driver. This driver has been tested on custom hardware. It has been tested for composite output. It is derived from the ADV7343 driver. Cc: Mauro Carvalho Chehab Cc: Signed-off-by: Benoît Thébaudeau --- .../drivers/media/video/Kconfig|

[PATCH 10/12] cx25821: Use i2c_rc properly to store i2c register status

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx25821/cx25821-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx25821/cx25821-i2c.c b/drivers/media/video/cx25821/cx25821-i2c.c index 6311180..398e0e6 100644 --- a/drivers/media/video/cx2

[PATCH 05/12] cx23885: Remove useless struct i2c_algo_bit_data

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx23885/cx23885-i2c.c |3 --- drivers/media/video/cx23885/cx23885.h |2 -- drivers/media/video/saa7164/saa7164.h |1 - 3 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-i2c.

[PATCH 12/12] cx25821: Replace struct memcpy with struct assignment

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx25821/cx25821-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/cx25821/cx25821-i2c.c b/drivers/media/video/cx25821/cx25821-i2c.c index 431fa7f..8a823b8 100644 --- a/drivers/media/vide

[PATCH 11/12] cx25821: Remove useless struct i2c_algo_bit_data usage

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx25821/cx25821-i2c.c |3 --- drivers/media/video/cx25821/cx25821.h |2 -- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/cx25821/cx25821-i2c.c b/drivers/media/video/cx25821/cx25821-i2c.c index

[PATCH 08/12] cx231xx: Remove useless struct i2c_algo_bit_data usage

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx231xx/cx231xx-i2c.c |2 -- drivers/media/video/cx231xx/cx231xx.h |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/video/cx231xx/cx231xx-i2c.c index

[PATCH 09/12] cx231xx: Replace struct memcpy with struct assignment

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx231xx/cx231xx-i2c.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/video/cx231xx/cx231xx-i2c.c index f5f4844..2b2e91e 100644 --- a/drivers/media/video

[PATCH 07/12] cx231xx: Use i2c_rc properly to store i2c register status

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx231xx/cx231xx-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/video/cx231xx/cx231xx-i2c.c index 925f3a0..8064119 100644 --- a/drivers/media/video/cx2

[PATCH 06/12] cx23885: Replace struct memcpy with struct assignment

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx23885/cx23885-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/video/cx23885/cx23885-i2c.c index 1404050..4c7941b 100644 --- a/drivers/media/vide

[PATCH 04/12] cx23885: Use i2c_rc properly to store i2c register status

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/cx23885/cx23885-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/video/cx23885/cx23885-i2c.c index be1e21d..7a93fc6 100644 --- a/drivers/media/video/cx2

[PATCH 03/12] saa7164: Replace struct memcpy with struct assignment

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c index 8df15ca..57849d6 100644 --- a/drivers/media/vide

[PATCH 02/12] saa7164: Remove useless struct i2c_algo_bit_data

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |4 drivers/media/video/saa7164/saa7164.h |1 - 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c index

[PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

2012-06-18 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c index 26148f7..536f7dc 100644 --- a/drivers/media/video/saa

[PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Ezequiel Garcia
Hi Mauro, This patchset cleans the i2c part of some drivers. This issue was recently reported by Dan Carpenter [1], and revealed wrong (and harmless) usage of struct i2c_algo_bit. Also, I properly assigned bus->i2c_rc (return code variable) and replaced struct memcpy with struct assignment. The l

[PATCH 3 of 3] media: gpio-ir-recv: switch to module_platform_driver

2012-06-18 Thread Benoît Thébaudeau
Cc: Mauro Carvalho Chehab Cc: Ravi Kumar V Cc: Signed-off-by: Benoît Thébaudeau --- .../drivers/media/rc/gpio-ir-recv.c| 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git linux-next-HEAD-6c86b58.orig/drivers/media/rc/gpio-ir-recv.c linux-next-HEAD

[PATCH 2 of 3] media: gpio-ir-recv: add map name

2012-06-18 Thread Benoît Thébaudeau
Make it possible for gpio-ir-recv users to choose a map name. Cc: Mauro Carvalho Chehab Cc: Ravi Kumar V Cc: Signed-off-by: Benoît Thébaudeau --- .../drivers/media/rc/gpio-ir-recv.c|2 +- .../include/media/gpio-ir-recv.h |1 + 2 files changed, 2 inser

[PATCH 0 of 3] media: gpio-ir-recv: several improvements

2012-06-18 Thread Benoît Thébaudeau
Hi all, This is a set of 3 small improvements for gpio-ir-recv. Regards, Benoît Thébaudeau -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1 of 3] media: gpio-ir-recv: fix missing udev by-path entry

2012-06-18 Thread Benoît Thébaudeau
Add missing information so that udev can create an entry for gpio-ir-recv under /dev/input/by-path/ . Cc: Mauro Carvalho Chehab Cc: Ravi Kumar V Cc: Signed-off-by: Benoît Thébaudeau --- .../drivers/media/rc/gpio-ir-recv.c|6 ++ 1 file changed, 6 insertions(+) diff --g

cron job: media_tree daily build: ERRORS

2012-06-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Jun 18 19:00:12 CEST 2012 git hash:5472d3f17845c4398c6a510b46855820920c2181 gcc version: i686-linux-gcc (GC

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread Devin Heitmueller
On Mon, Jun 18, 2012 at 10:32 AM, David Dillow wrote: > Hmm, it sounds like perhaps changing the standby call in the tuner core > to asynchronously power down the tuner may be the way to go -- ie, when > we tell it to standby, it will do a schedule_work for some 10 seconds > later to really pull i

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread David Dillow
On Mon, 2012-06-18 at 10:23 -0400, Devin Heitmueller wrote: > This isn't just the cx231xx driver. Almost all USB devices that have > tuners which support power management have this problem > (em28xx/au0828/cx231xx with Xceive or tda18271 tuners). Really the > tuner_core should be resending the se

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 16:15:40 David Dillow wrote: > On Mon, 2012-06-18 at 09:29 +0200, Hans Verkuil wrote: > > On Mon June 18 2012 06:49:58 David Dillow wrote: > > > What does the V4L2 API spec say about tuning frequency being persistent > > > when there are no users of a video capture device? Is My

[PATCH] omap3isp: preview: Add support for non-GRBG Bayer patterns

2012-06-18 Thread Laurent Pinchart
Rearrange the CFA interpolation coefficients table based on the Bayer pattern. Modifying the table during streaming isn't supported anymore, but didn't make sense in the first place anyway. Support for non-Bayer CFA patterns is dropped as they were not correctly supported, and have never been test

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread Devin Heitmueller
On Mon, Jun 18, 2012 at 10:15 AM, David Dillow wrote: >> Tuner standards and frequencies must be persistent. So cx231xx is wrong. >> Actually, all V4L2 settings must in general be persistent (there are >> some per-filehandle settings when dealing with low-level subdev setups or >> mem2mem devices)

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread David Dillow
On Mon, 2012-06-18 at 09:29 +0200, Hans Verkuil wrote: > On Mon June 18 2012 06:49:58 David Dillow wrote: > > What does the V4L2 API spec say about tuning frequency being persistent > > when there are no users of a video capture device? Is MythTV wrong to > > have that assumption, or is cx231xx wro

Re: [PATCH 1/1] [media] s5p-fimc: Add missing static storage class

2012-06-18 Thread Mauro Carvalho Chehab
Em 11-06-2012 01:27, Sachin Kamat escreveu: > On 28/05/2012, Sylwester Nawrocki wrote: >> On 05/26/2012 05:11 PM, Sachin Kamat wrote: >>> Fixes the following sparse warnings: >> >> Hi Sachin. Thanks, in case somebody else applies this patch >> before I do: >> Acked-by: Sylwester Nawrocki >> > >

Re: [RFCv1 PATCH 29/32] v4l2-dev.c: also add debug support for the fops.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 14:19:51 Laurent Pinchart wrote: > Hi Hans, > > On Monday 18 June 2012 13:40:24 Hans Verkuil wrote: > > On Mon June 18 2012 12:01:47 Laurent Pinchart wrote: > > > On Sunday 10 June 2012 12:25:51 Hans Verkuil wrote: > > > > From: Hans Verkuil > > > > > > > > Signed-off-by: Han

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 14:03:14 Mauro Carvalho Chehab wrote: > Em 18-06-2012 08:49, Hans Verkuil escreveu: > > On Mon June 18 2012 12:50:35 Mauro Carvalho Chehab wrote: > >> Em 18-06-2012 06:46, Laurent Pinchart escreveu: > >>> Hi Hans, > >>> > >>> Thanks for the patch. > >>> > >>> On Sunday 10 June 2

Re: [RFCv1 PATCH 25/32] create_bufs: handle count == 0.

2012-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 18 June 2012 13:43:22 Hans Verkuil wrote: > On Mon June 18 2012 12:11:27 Laurent Pinchart wrote: > > On Sunday 10 June 2012 12:25:47 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Signed-off-by: Hans Verkuil > > > --- > > > > > > Documentation/DocBook/media/v4l/vi

Re: [RFCv1 PATCH 29/32] v4l2-dev.c: also add debug support for the fops.

2012-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 18 June 2012 13:40:24 Hans Verkuil wrote: > On Mon June 18 2012 12:01:47 Laurent Pinchart wrote: > > On Sunday 10 June 2012 12:25:51 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Signed-off-by: Hans Verkuil > > > --- > > > > > > drivers/media/video/v4l2-dev.c |

Re: [RFCv1 PATCH 30/32] v4l2-ioctl.c: shorten the lines of the table.

2012-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 18 June 2012 13:34:33 Hans Verkuil wrote: > On Mon June 18 2012 11:57:24 Laurent Pinchart wrote: > > On Sunday 10 June 2012 12:25:52 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Use some macro magic to reduce the length of the lines in the table. > > > This makes i

Re: [PATCH 1/2] v4l: added V4L2_BUF_FLAG_EOS flag indicating the last frame in the stream

2012-06-18 Thread Mauro Carvalho Chehab
Em 18-06-2012 08:54, Andrzej Hajda escreveu: > On Mon, 2012-06-18 at 08:24 -0300, Mauro Carvalho Chehab wrote: >> Em 22-05-2012 12:33, Andrzej Hajda escreveu: >>> Some devices requires indicator if the buffer is the last one in the stream. >>> Applications and drivers can use this flag in such case

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Mauro Carvalho Chehab
Em 18-06-2012 08:49, Hans Verkuil escreveu: > On Mon June 18 2012 12:50:35 Mauro Carvalho Chehab wrote: >> Em 18-06-2012 06:46, Laurent Pinchart escreveu: >>> Hi Hans, >>> >>> Thanks for the patch. >>> >>> On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: From: Hans Verkuil Signed

Re: [PATCH 1/2] v4l: added V4L2_BUF_FLAG_EOS flag indicating the last frame in the stream

2012-06-18 Thread Andrzej Hajda
On Mon, 2012-06-18 at 08:24 -0300, Mauro Carvalho Chehab wrote: > Em 22-05-2012 12:33, Andrzej Hajda escreveu: > > Some devices requires indicator if the buffer is the last one in the stream. > > Applications and drivers can use this flag in such case. > > > > Signed-off-by: Andrzej Hajda > > Sig

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:50:35 Mauro Carvalho Chehab wrote: > Em 18-06-2012 06:46, Laurent Pinchart escreveu: > > Hi Hans, > > > > Thanks for the patch. > > > > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Signed-off-by: Hans Verkuil > >> --- > >> driver

Re: [RFCv1 PATCH 24/32] videobuf2-core: add helper functions.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:23:26 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:46 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add helper functions to make it easier to adapt drivers to vb2. > > What about moving those functions to videobuf2-io

Re: [RFCv1 PATCH 27/32] vivi: embed struct video_device instead of allocating it.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:13:38 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:49 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/vivi.c | 25 +++-- > > 1 file chan

Re: [RFCv1 PATCH 25/32] create_bufs: handle count == 0.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:11:27 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:47 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > Documentation/DocBook/media/v4l/vidioc-create-bufs.xml |8 +++- > >

Re: [RFCv1 PATCH 28/32] vivi: use vb2 helper functions.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:08:10 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:50 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/vivi.c | 160 ++---

Re: [RFCv1 PATCH 29/32] v4l2-dev.c: also add debug support for the fops.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 12:01:47 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:51 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/v4l2-dev.c | 41 ++---

Re: [RFCv1 PATCH 19/32] v4l2-dev.c: add debug sysfs entry.

2012-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 18 June 2012 13:30:18 Hans Verkuil wrote: > On Mon June 18 2012 11:48:45 Laurent Pinchart wrote: > > On Sunday 10 June 2012 12:25:41 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > Signed-off-by: Hans Verkuil > > > --- > > > > > > drivers/media/video/v4l2-dev.c |

Re: [RFCv1 PATCH 30/32] v4l2-ioctl.c: shorten the lines of the table.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 11:57:24 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:52 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Use some macro magic to reduce the length of the lines in the table. This > > makes it more readable. > > It indeed s

Re: [RFCv1 PATCH 20/32] v4l2-ioctl: remove v4l_(i2c_)print_ioctl

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 11:50:38 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:42 Hans Verkuil wrote: > > From: Hans Verkuil > > > > v4l_i2c_print_ioctl wasn't used and v4l_print_ioctl could be replaced by > > v4l_i2c_printk_ioctl. > > I suppose you

Re: [RFCv1 PATCH 19/32] v4l2-dev.c: add debug sysfs entry.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 11:48:45 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:41 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/v4l2-dev.c | 24 > > 1 file c

Re: [RFCv1 PATCH 04/32] v4l2-ioctl.c: v4l2-ioctl: add debug and callback/offset functionality.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 11:47:07 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:26 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add the necessary plumbing to make it possible to replace the switch by a > > table driven implementation. > > > > Si

Re: [PATCH 1/2] v4l: added V4L2_BUF_FLAG_EOS flag indicating the last frame in the stream

2012-06-18 Thread Mauro Carvalho Chehab
Em 22-05-2012 12:33, Andrzej Hajda escreveu: > Some devices requires indicator if the buffer is the last one in the stream. > Applications and drivers can use this flag in such case. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Kyungmin Park > --- > Documentation/DocBook/media/v4l/io.xml

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 11:46:57 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > --- > > drivers/media/video/v4l2-ioctl.c | 35 +--

Re: [PATCHv7 01/15] v4l: Add DMABUF as a memory type

2012-06-18 Thread Tomasz Stanislawski
Hi everyone, The automatic build system informed me that there is a shameful error in this patch. The declarations of fd fields in v4l2_plane32 and v4l2_buffer32 are missing. It breaks build process for 64-bit architectures. I am deeply sorry for posting a patch without testing it enough. The bui

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Laurent Pinchart
Hi Mauro, On Monday 18 June 2012 07:50:35 Mauro Carvalho Chehab wrote: > Em 18-06-2012 06:46, Laurent Pinchart escreveu: > > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Signed-off-by: Hans Verkuil > >> --- > >> > >> drivers/media/video/v4l2-ioctl.c |

Re: SoC i.mx35 userptr method failure while running capture-example utility

2012-06-18 Thread Prabhakar Lad
Hi Laurent, On Mon, Jun 18, 2012 at 4:05 PM, Laurent Pinchart wrote: > Hi, > > On Monday 18 June 2012 12:28:44 Prabhakar Lad wrote: >> On Wed, May 2, 2012 at 4:20 AM, Guennadi Liakhovetski wrote: >> > On Tue, 1 May 2012, Alex Gershgorin wrote: >> >> Hi everyone, >> >> >> >> I use user-space util

Re: [GIT PULL FOR 3.6] V4L2 API cleanups

2012-06-18 Thread Laurent Pinchart
Hi Sakari, On Sunday 17 June 2012 10:54:32 Sakari Ailus wrote: > On Sun, Jun 17, 2012 at 12:03:06AM +0200, Laurent Pinchart wrote: > > On Monday 11 June 2012 12:39:44 Sakari Ailus wrote: > > > On Mon, Jun 11, 2012 at 09:50:54AM +0200, Laurent Pinchart wrote: > > > > On Sunday 10 June 2012 23:22:59

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Mauro Carvalho Chehab
Em 18-06-2012 06:46, Laurent Pinchart escreveu: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: >> From: Hans Verkuil >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/video/v4l2-ioctl.c | 35 +-- >> 1 file

Re: uvcvideo issue with kernel 3.5-rc2 and 3

2012-06-18 Thread Laurent Pinchart
Hi Philipp, On Sunday 17 June 2012 13:35:07 Philipp Dreimann wrote: > Hello, > > my external webcam from Logitech (I guess it's a c910) stopped working > using kernel 3.5-rc3.( 3.4 worked fine.) > > uvcvideo: Found UVC 1.00 device (046d:0821) > input: UVC Camera (046d:0821) as > /devices/pci000

Re: SoC i.mx35 userptr method failure while running capture-example utility

2012-06-18 Thread Laurent Pinchart
Hi, On Monday 18 June 2012 12:28:44 Prabhakar Lad wrote: > On Wed, May 2, 2012 at 4:20 AM, Guennadi Liakhovetski wrote: > > On Tue, 1 May 2012, Alex Gershgorin wrote: > >> Hi everyone, > >> > >> I use user-space utility from > >> http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/contrib/test/captu

Re: [RFCv1 PATCH 24/32] videobuf2-core: add helper functions.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:46 Hans Verkuil wrote: > From: Hans Verkuil > > Add helper functions to make it easier to adapt drivers to vb2. What about moving those functions to videobuf2-ioctl.c ? The helper functions are based on top of an existing vb2 core th

RE: [PATCH 5/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2012-06-18 Thread Bhupesh SHARMA
Hi Laurent, Can you please review this patch and let me know if any modifications are required.. > -Original Message- > From: Bhupesh SHARMA > Sent: Friday, June 01, 2012 3:09 PM > To: laurent.pinch...@ideasonboard.com; linux-...@vger.kernel.org > Cc: ba...@ti.com; linux-media@vger.kerne

RE: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-06-18 Thread Bhupesh SHARMA
Hi Laurent, Can you please review this patch and let me know if any modifications are required.. > -Original Message- > From: Bhupesh SHARMA > Sent: Friday, June 01, 2012 3:09 PM > To: laurent.pinch...@ideasonboard.com; linux-...@vger.kernel.org > Cc: ba...@ti.com; linux-media@vger.kernel

Re: [RFCv1 PATCH 27/32] vivi: embed struct video_device instead of allocating it.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:49 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/vivi.c | 25 +++-- > 1 file changed, 7 insertions(+), 18 deletions(-) > > diff --git a/drivers/media/video

Re: [RFCv1 PATCH 25/32] create_bufs: handle count == 0.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:47 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > Documentation/DocBook/media/v4l/vidioc-create-bufs.xml |8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentat

Re: [RFCv1 PATCH 28/32] vivi: use vb2 helper functions.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:50 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/vivi.c | 160 ++--- > 1 file changed, 21 insertions(+), 139 deletions(-) > > diff --git a/d

Re: [RFCv1 PATCH 29/32] v4l2-dev.c: also add debug support for the fops.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:51 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-dev.c | 41 ++--- > 1 file changed, 29 insertions(+), 12 deletions(-) > > diff --git a/dr

Re: [RFCv1 PATCH 30/32] v4l2-ioctl.c: shorten the lines of the table.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:52 Hans Verkuil wrote: > From: Hans Verkuil > > Use some macro magic to reduce the length of the lines in the table. This > makes it more readable. It indeed shortens the lines, but to be honest I find the result less readable. > Si

Re: [RFCv1 PATCH 20/32] v4l2-ioctl: remove v4l_(i2c_)print_ioctl

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:42 Hans Verkuil wrote: > From: Hans Verkuil > > v4l_i2c_print_ioctl wasn't used and v4l_print_ioctl could be replaced by > v4l_i2c_printk_ioctl. I suppose you meant v4l_printk_ioctl herE. > > Signed-off-by: Hans Verkuil -- Regard

Re: [RFCv1 PATCH 19/32] v4l2-dev.c: add debug sysfs entry.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:41 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-dev.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/drivers/media/video/v4l2-dev.c b

Re: [RFCv1 PATCH 04/32] v4l2-ioctl.c: v4l2-ioctl: add debug and callback/offset functionality.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:26 Hans Verkuil wrote: > From: Hans Verkuil > > Add the necessary plumbing to make it possible to replace the switch by a > table driven implementation. > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-ioctl.c | 91

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.

2012-06-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/video/v4l2-ioctl.c | 35 +-- > 1 file changed, 13 insertions(+), 22 deletions(-) > > diff --git a/dri

[PATCH] s5p-fimc: Fix control creation function

2012-06-18 Thread Kamil Debski
Fixed the size of the V4L2_CID_COLORFX control cluster. Prior to this fix V4L2_CID_ROTATE was also icluded in the cluster preventing applications from enabling rotation. Reported-by: Marek Szyprowski Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/media/video/s5p-fimc/fimc

Re: [RFC] [media] cx231xx: restore tuner settings on first open

2012-06-18 Thread Hans Verkuil
On Mon June 18 2012 06:49:58 David Dillow wrote: > Without this patch, MythTV requires some workarounds to be able to > capture analog TV on my HVR-850. I need to keep the v4l device open via > 'sleep 365d < /dev/video0' or some other mechanism or there will be no > recording. Also, I need to run v