The __user macro is not strictly needed in videodev2.h, and it also prevents
using the header file as such in the user space. __user is already not used
in many of the interface structs containing pointers.
Stop using __user in videodev2.h.
Signed-off-by: Sakari Ailus
---
include/linux/videodev
Hi Ezequiel,
On 05/26/2012 07:50 PM, Hans Verkuil wrote:
>> +/*
>> + * IOCTL vidioc handling
>> + */
>> +static int vidioc_reqbufs(struct file *file, void *priv,
>> + struct v4l2_requestbuffers *p)
>> +{
>> +struct stk1160 *dev = video_drvdata(file);
>> +return vb2_req
Initialize the spinlock for each hardware time.
Signed-off-by: Sasha Levin
---
drivers/staging/media/lirc/lirc_serial.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_serial.c
b/drivers/staging/media/lirc/lirc_serial.c
index 3295ea6
Signed-off-by: Volokh Konstantin
---
drivers/media/video/bt8xx/bttv-driver.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/bt8xx/bttv-driver.c
b/drivers/media/video/bt8xx/bttv-driver.c
index e581b37..b4ee7de 100644
--- a/drivers/media/video/bt8
On Sat May 26 2012 20:38:00 Ezequiel Garcia wrote:
> Hi Hans,
>
> Thanks for your review (I'm a bit amazed at how fast you went through
> the code :).
> I'll address your excellent comments soon.
>
> I'm still unsure about a numbre of things. Two of them:
>
> 1. It seems to mee tracing is not to
Just a warning to avoid double work: I'll post a patch with all the needed
changes tomorrow (or Monday at the latest). That will also include changes
from my RFC on improving the hardware seek.
Regards,
Hans
On Sat May 26 2012 20:38:52 Hans de Goede wrote:
> Hi,
>
> On 05/26/2012 08:22
Hi,
On 05/26/2012 08:22 PM, Hans Verkuil wrote:
On Sat May 26 2012 20:09:53 Hans de Goede wrote:
Hi,
On 05/26/2012 06:40 PM, Hans Verkuil wrote:
On Sat May 26 2012 18:02:34 Hans de Goede wrote:
Hi,
On 05/24/2012 09:12 PM, Hans de Goede wrote:
Hi,
On 05/24/2012 05:00 PM, Hans Verkuil wrote
Hi Hans,
Thanks for your review (I'm a bit amazed at how fast you went through
the code :).
I'll address your excellent comments soon.
I'm still unsure about a numbre of things. Two of them:
1. It seems to mee tracing is not too nice and
I wasn't really sure how to handle it: dev_xxx, pr_xxx, v4
On Sat May 26 2012 20:09:53 Hans de Goede wrote:
> Hi,
>
> On 05/26/2012 06:40 PM, Hans Verkuil wrote:
> > On Sat May 26 2012 18:02:34 Hans de Goede wrote:
> >> Hi,
> >>
> >> On 05/24/2012 09:12 PM, Hans de Goede wrote:
> >>> Hi,
> >>>
> >>> On 05/24/2012 05:00 PM, Hans Verkuil wrote:
> > I th
Hi,
On 05/26/2012 06:40 PM, Hans Verkuil wrote:
On Sat May 26 2012 18:02:34 Hans de Goede wrote:
Hi,
On 05/24/2012 09:12 PM, Hans de Goede wrote:
Hi,
On 05/24/2012 05:00 PM, Hans Verkuil wrote:
I think / hope that covers everything we need. Suggestions ? Comments ?
Modulators. v4l2_modula
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Sat May 26 19:00:18 CEST 2012
git hash:5472d3f17845c4398c6a510b46855820920c2181
gcc version: i686-linux-gcc (GC
(Ezequiel, your original CC list was mangled, so I'm reposting this)
Thanks!
Here is a quick run through of the code.
Always test your driver using the v4l2-compliance test tool that it part of
v4l-utils! If it passes that, then your code will be in really good shape!
On Sat May 26 2012 18:41:0
On Sat May 26 2012 18:02:34 Hans de Goede wrote:
> Hi,
>
> On 05/24/2012 09:12 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 05/24/2012 05:00 PM, Hans Verkuil wrote:
> >>> I think / hope that covers everything we need. Suggestions ? Comments ?
> >>
> >> Modulators. v4l2_modulator needs a band field
The compose rectangles were printed incorrectly in my recent patch "Compose
rectangle support for libv4l2subdev" without parenthesis. Fix this.
Signed-off-by: Sakari Ailus
---
Hi Laurent,
Could you apply this simple fix to your tree? Currently the compose
rectangles are printed differently than
Hi,
On 05/24/2012 09:12 PM, Hans de Goede wrote:
Hi,
On 05/24/2012 05:00 PM, Hans Verkuil wrote:
I think / hope that covers everything we need. Suggestions ? Comments ?
Modulators. v4l2_modulator needs a band field as well. The capabilities are
already shared with v4l2_tuner, so that doesn't
Fixes the following sparse warnings:
drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
'flite_hw_set_out_order' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:183:5: warning: symbol
'__fimc_pipeline_shutdown' was not declared. Should it be st
Hi Sylwester,
On 26 May 2012 14:09, Sylwester Nawrocki wrote:
> Hi Sachin,
>
>
> On 05/25/2012 07:38 PM, Sachin Kamat wrote:
>>
>> Fixes the following sparse warning:
>> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
>> 'flite_hw_set_out_order' was not declared. Should it be
Hi Linus,
On 25 May 2012 22:14, Linus Torvalds wrote:
> On Fri, May 25, 2012 at 2:17 AM, Sumit Semwal wrote:
>>
>> I am really sorry - I goofed up in the git URL (sent the ssh URL
>> instead).
>
> I was going to send you an acerbic email asking for your private ssh
> key, but then noticed that y
Hi Mauro,
Here are a bunch of assorted fixes for 3.5. The v4l2-ioctl patch fixes a
warning from v4l2-compliance, the v4l2-dev.c patch fixes a regression,
also related to g_parm, that I introduced. The tuner-core patch fixes the
corner case where the tuner is set to radio mode, but you call g_tuner
Is there any reason RC-core .driver_name should be set as a module name
which registers remote?
http://lxr.free-electrons.com/source/drivers/media/rc/rc-main.c
I see .driver_name is passed to the hotplug:
if (dev->driver_name)
ADD_HOTPLUG_VAR("DRV_NAME=%s", dev->driver_name);
ir-keytable
Hi Sachin,
On 05/25/2012 07:38 PM, Sachin Kamat wrote:
Fixes the following sparse warning:
drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
'flite_hw_set_out_order' was not declared. Should it be static?
Thanks for the patches. However I'm inclined to squash this whole
serie
On Friday 25 May 2012, Linus Torvalds wrote:
> Please do something like
>
>gpg --keyserver pgp.mit.edu --send-keys 7126925D
>
> to actually make your public key public.
>
> Of course, if it isn't public, I assume it hasn't actually been signed
> by anybody, which makes it largely useless. Bu
Mauro,
This patch moves the sta2x11_vip driver to the staging directory. In my opinion
this driver is not ready for prime-time.
As I mentioned a week ago, I never saw this driver when it was posted as that
was during a period were I was unavoidably absent from the list. The problem
with this driv
23 matches
Mail list logo
