Re: [PATCH/RFC v4 12/12] V4L: Add camera auto focus controls

Hi Sylwester, Thanks for the patch, Sylwester Nawrocki wrote: > Add following auto focus controls: > > - V4L2_CID_AUTO_FOCUS_START - single-shot auto focus start > - V4L2_CID_AUTO_FOCUS_STOP - single-shot auto focus stop > - V4L2_CID_AUTO_FOCUS_STATUS - automatic focus status > - V4L2_CID_A

Re: [PATCH/RFC v4 10/12] V4L: Add auto focus targets to the selections API

Hi Sylwester, Thanks for the patch. Sylwester Nawrocki wrote: > The camera automatic focus algorithms may require setting up > a spot or rectangle coordinates or multiple such parameters. > > The automatic focus selection targets are introduced in order > to allow applications to query and set s

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

Hi Laurent, Laurent Pinchart wrote: > On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: ... >> The pixel format and the image size at the pad are clearly format >> (VIDIOC_SUBDEV_S_FMT) but the other things are related to pads but not >> format. >> >> I see them different kinds of properties of

[PATCH 3/3] make the other drivers take use of the new ts2020 driver

make the other drivers take use of the separate ts2020 driver Signed-off-by: Konstantin Dimitrov --- a/linux/drivers/media/dvb/frontends/ds3000.c2012-05-07 02:24:25.900920554 +0300 +++ b/linux/drivers/media/dvb/frontends/ds3000.c2012-05-07 02:26:01.728919348 +0300 @@ -27,6 +27,7

[PATCH] rtl28xxu: support Terratec Noxon DAB/DAB+ stick

Support for Terratec Noxon DAB/DAB+ USB stick in RTL28xxU driver. Requires FC0013 patch sent today. Additionally this patch makes the RTL28xxU driver compatible with the FC0012 tuner driver version 0.5 sent also earlier today (extra parameter in fc0012_attach call). Signed-off-by: Hans-Frieder Vo

[PATCH 2/3] ts2020: add ts2020 tuner driver

add separate ts2020 tuner driver Signed-off-by: Konstantin Dimitrov --- a/linux/drivers/media/dvb/frontends/Kconfig 2012-04-20 06:45:55.0 +0300 +++ b/linux/drivers/media/dvb/frontends/Kconfig 2012-05-07 00:58:26.888543350 +0300 @@ -221,6 +221,13 @@ help A DVB-S tuner mo

[PATCH 1/3] ds3000: remove ts2020 tuner related code

remove ts2020 tuner related code from ds3000 driver prepare ds3000 driver for using external tuner driver Signed-off-by: Konstantin Dimitrov --- a/linux/drivers/media/dvb/frontends/ds3000.h2011-02-27 06:45:21.0 +0200 +++ b/linux/drivers/media/dvb/frontends/ds3000.h2012-05

Re: How to toggle Cine CT V6 to DVB-T mode?

Hi, On Saturday 05 May 2012 16:39:42 Ludovic BOUE wrote: > Hello Oliver, > > I am facing an issue with my Cine CT V6 & DuoFlex CT cards. All tuners are > recognized in DVB-C mode and I don't know how to switch to DVB-T mode. > Could you tell me how to do that ? If you use an application which is

[PATCH 3/3] fc001x: tuner driver for FC0013

Support for tuner Fitipower FC0013 Signed-off-by: Hans-Frieder Vogt drivers/media/common/tuners/Kconfig |7 drivers/media/common/tuners/Makefile |1 drivers/media/common/tuners/fc0013-priv.h | 44 ++ drivers/media/common/tuners/fc0013.c | 562 +++

[PATCH 2/3] fc001x: tuner driver for FC0012, version 0.5

Support for tuner Fitipower FC0012 Signed-off-by: Hans-Frieder Vogt drivers/media/common/tuners/Kconfig |7 drivers/media/common/tuners/Makefile |1 drivers/media/common/tuners/fc0012-priv.h | 43 +++ drivers/media/common/tuners/fc0012.c | 397 ++

[PATCH 1/3] fc001x: common header file for FC0012 and FC0013

Common defines for the FC0012 (v0.5) and FC0013 tuner drivers Signed-off-by: Hans-Frieder Vogt drivers/media/common/tuners/fc001x-common.h | 39 1 file changed, 39 insertions(+) diff -up --new-file --recursive a/drivers/media/common/tuners/fc001x-common.h b/driv

[PATCH 0/3] fc001x: updated support for tuner FC0012 and initial support for FC0013

This patch set provides an updated driver for the tuner FC0012 (v0.5), which includes changes from Thomas Mair (thanks!) and further modifications to make it compatible with the newly introduced tuner driver for the FC0013, with which it has a lot in common. For FC0012, I had to introduce the ne

Re: [PATCH V4 4/5] Media: Update docs for V4L2 FM new features

On Sat May 5 2012 00:41:34 Hans Verkuil wrote: > > + > > + Radio Band Types > > + > > + &cs-str; > > + > > + > > + FM_BAND_TYPE_ALL  > > + All Bands from 65.8 MHz till 108 Mhz or 162.55 MHz > > if weather band. > > +

[PATCH v5 12/12] V4L: Add camera auto focus controls

Add following auto focus controls: - V4L2_CID_AUTO_FOCUS_START - single-shot auto focus start - V4L2_CID_AUTO_FOCUS_STOP - single-shot auto focus stop - V4L2_CID_AUTO_FOCUS_STATUS - automatic focus status - V4L2_CID_AUTO_FOCUS_AREA - automatic focus area selection - V4L2_CID_AUTO_FOCUS_RANGE

[PATCH v4 3/3] FC0012 tuner driver

This driver is based on the driver written by Hans-Frieder Vogt. The following modifications hav been made - added callback for UHF/VFH band selection in fc0012_set_params (needed by Cinergy T Stick Black) - modified some parameters when initialiting the tuner (maybe the initialization should be

[PATCH v4 2/3] RTL2832 demodulator driver

- currently only support for the FC0012 tuner is included - The driver uses a custom log2 function. Maybe it should be changed to use ilog2 or a similar function. Signed-off-by: Thomas Mair --- drivers/media/dvb/frontends/rtl2832.c | 1214 drivers/media/dvb/fro

[PATCH v4 1/3] Modified RTL28xxU driver to work with RTL2832

- added tuner probing with log output - added callback for tuners to change UHF/VHF band - moved and renamed tuner enums to own header file - supported devices: - Terratec Cinergy T Stick Black - G-Tek Electronics Group Lifeview LV5TDLX DVB-T [RTL2832U] Signed-off-by: Thomas Mair --- drivers

[PATCH v5 01/12] V4L: Add helper function for standard integer menu controls

This patch adds v4l2_ctrl_new_int_menu() helper function which can be used in drivers for creating standard integer menu control with driver-specific menu item list. It is similar to v4l2_ctrl_new_std_menu(), except it doesn't have a mask parameter and an additional qmenu parameter allows passing a

Re: gspca zc3xx - JPEG quality / frame overflow

On Sun, 06 May 2012 20:17:08 +0200 Hans de Goede wrote: > > - as it is (read the register 11 every 100 ms), the work queue is > >usefull when there is no polling of the snapshot button, because the > >frame overflow is reported as the bit 0 in the forth byte (data[3]) > >of the interr

Re: gspca zc3xx - JPEG quality / frame overflow

Hi, On 05/05/2012 08:54 PM, Jean-Francois Moine wrote: Hi Hans, I quickly looked at your patches about the changes for the JPEG quality, and I have some remarks. Indeed, as I don't have any zc3xx webcam nor a lot of documentation about the zc3xx bridge, my information come only from USB trace

Re: [RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

Hi, On 05/06/2012 05:51 PM, Hans Verkuil wrote: On Sun May 6 2012 17:25:55 Hans de Goede wrote: Notice that usb_lock is unlocked before video_unregister_device gets called, which means that any ioctl or other fops waiting for usb_lock can run before video_unregister_device runs, and thus be

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun May 6 19:00:16 CEST 2012 git hash:a1ac5dc28d2b4ca78e183229f7c595ffd725241c gcc version: i686-linux-gcc (GC

Re: [RFC] tuner callback name in RTL28xxu driver

On 06.05.2012 19:29, Hans-Frieder Vogt wrote: > Thomas, > > in your patch for the RTL28xxu you introduce a tuner callback (see below). > You > called the command FC0012_FE_CALLBACK_UHF_ENABLE. > Since the argument is currently defined to be true if the frequency is below > 300MHz, i.e. the argu

[RFC] tuner callback name in RTL28xxu driver

Thomas, in your patch for the RTL28xxu you introduce a tuner callback (see below). You called the command FC0012_FE_CALLBACK_UHF_ENABLE. Since the argument is currently defined to be true if the frequency is below 300MHz, i.e. the argument is true if the frequency is a VHF frequency. Therefore I

Re: [PATCH/RFC v4 01/12] V4L: Add helper function for standard integer menu controls

Hi Sakari, On 05/06/2012 12:12 PM, Sakari Ailus wrote: Hi Sylwester, Sylwester Nawrocki wrote: This patch adds v4l2_ctrl_new_std_int_menu() helper function which can be used in drivers for creating standard integer menu control. It is similar to v4l2_ctrl_new_std_menu(), except it doesn't have

Re: [PATCH v3 2/3] RTL2832 demodulator driver.

Thomas, I had a few problems with that patch. Please see below. Am Sonntag, 6. Mai 2012 schrieb Thomas Mair: > - currently only support for the FC0012 tuner is included > - The driver uses a custom log2 function. Maybe it should be changed > to use ilog2 or a similar function. > > Signed-off-by:

Re: [PATCH v3 3/3] FC0012 tuner driver.

This driver is based on the driver written by Hans-Frieder Vogt. The following modifications hav been made - added callback for UHF/VFH band selection in fc0012_set_params (needed by Cinergy T Stick Black) - modified some parameters when initialiting the tuner (maybe the initialization should be

Re: [PATCH v3 2/3] RTL2832 demodulator driver.

- currently only support for the FC0012 tuner is included - The driver uses a custom log2 function. Maybe it should be changed to use ilog2 or a similar function. Signed-off-by: Thomas Mair --- drivers/media/dvb/frontends/rtl2832.c | 1214 drivers/media/dvb/fr

Re: [PATCH v3 1/3] Modified RTL28xxU driver to work with RTL2832

On 06.05.2012 17:37, Hans-Frieder Vogt wrote: > > line wrapped. This prevents the patch to apply. Please switch off the > automatic > line wrap in your mailer! > Sorry. Now the issue should be resolved. - added tuner probing with log output - added callback for tuners to change UHF/VHF band -

Re: [RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

On Sun May 6 2012 17:25:55 Hans de Goede wrote: > Hi Hans, > > The entire series looks great, I do have a few remarks wrt this > patch, which I have fixed in my own tree (new version attached, > note untested sofar). > > On 05/06/2012 02:28 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > D

Re: [PATCH v3 1/3] Modified RTL28xxU driver to work with RTL2832

Am Sonntag, 6. Mai 2012 schrieb Hans-Frieder Vogt: > Am Sonntag, 6. Mai 2012 schrieben Sie: > > Hi everyone, > > > > this is the first complete version of the rtl2832 demod driver. I > > splitted the patches in three parts: > > 1. changes in the dvb-usb part (dvb_usb_rtl28xxu) > > 2. demod driver

Re: [PATCH v3 1/3] Modified RTL28xxU driver to work with RTL2832

Am Sonntag, 6. Mai 2012 schrieben Sie: > Hi everyone, > > this is the first complete version of the rtl2832 demod driver. I > splitted the patches in three parts: > 1. changes in the dvb-usb part (dvb_usb_rtl28xxu) > 2. demod driver (rtl2832) > 3. tuner driver (fc0012) > > - added tuner probing w

Re: [RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

Hi Hans, The entire series looks great, I do have a few remarks wrt this patch, which I have fixed in my own tree (new version attached, note untested sofar). On 05/06/2012 02:28 PM, Hans Verkuil wrote: From: Hans Verkuil Due to latency concerns the VIDIOC_QBUF, DQBUF and QUERYBUF do not use t

[GIT PULL FOR v3.5] update the pms driver to the latest V4L2 frameworks

Hi Mauro, This patch updates the pms driver to use the latest V4L2 frameworks. I could run v4l2-compliance to check that everything is working API-wise. Unfortunately I can no longer actually capture any video. The last time I tested it I had a very very old and very slow PC that I rescued from t

Re: [ 3960.758784] 1 lock held by motion/7776: [ 3960.758788] #0: (&queue->mutex){......}, at: [] uvc_queue_enable+0x32/0xc0

57129] == [ 96.257129] [ INFO: possible circular locking dependency detected ] [ 96.257129] 3.4.0-rc5-20120506+ #4 Not tainted [ 96.257129] --- [ 96.257129] motion/2289 is trying to acquire lock: [ 96.257129] (&dev->lock){+.+.+.}, at: [] v4

[PATCH v3 3/3] FC0012 tuner driver.

This driver is based on the driver written by Hans-Frieder Vogt. The following modifications hav been made - added callback for UHF/VFH band selection in fc0012_set_params (needed by Cinergy T Stick Black) - modified some parameters when initialiting the tuner (maybe the initialization should be do

[PATCH v3 2/3] RTL2832 demodulator driver.

- currently only support for the FC0012 tuner is included - The driver uses a custom log2 function. Maybe it should be changed to use ilog2 or a similar function. Signed-off-by: Thomas Mair --- drivers/media/dvb/frontends/rtl2832.c | 1214 drivers/media/dvb/fron

[PATCH v3 1/3] Modified RTL28xxU driver to work with RTL2832

Hi everyone, this is the first complete version of the rtl2832 demod driver. I splitted the patches in three parts: 1. changes in the dvb-usb part (dvb_usb_rtl28xxu) 2. demod driver (rtl2832) 3. tuner driver (fc0012) - added tuner probing with log output - added callback for tuners to change UHF/

Re: [PATCH/RFC v4 01/12] V4L: Add helper function for standard integer menu controls

Hi Sylwester, Sylwester Nawrocki wrote: > This patch adds v4l2_ctrl_new_std_int_menu() helper function which can > be used in drivers for creating standard integer menu control. It is > similar to v4l2_ctrl_new_std_menu(), except it doesn't have a mask > parameter and an additional qmenu parameter

[RFCv2 PATCH 01/17] v4l2-dev: make it possible to skip locking for selected ioctls.

From: Hans Verkuil Using the V4L2 core lock is a very robust method that is usually very good at doing the right thing. But some drivers, particularly USB drivers, may want to prevent the core from taking the lock for specific ioctls, particularly buffer queuing ioctls. The reason is that certai

[RFCv2 PATCH 10/17] gspca_zc3xx: Fix JPEG quality setting code

From: Hans de Goede The current code is using bits 0-1 of register 8 of the zc3xx controller to set the JPEG quality, but the correct bits are bits 1-2. Bit 0 selects between truncation or rounding in the quantization phase of the compression, since rounding generally gives better results it shou

[RFCv2 PATCH 11/17] gscpa_zc3xx: Always automatically adjust BRC as needed

From: Hans de Goede Always automatically adjust the Bit Rate Control setting as needed, independent of the sensor type. BRC is needed to not run out of bandwidth with higher quality settings independent of the sensor. Also only automatically adjust BRC, and don't adjust the JPEG quality control

[RFCv2 PATCH 07/17] gspca: fix querycap and incorrect return codes.

From: Hans Verkuil Add V4L2_CAP_DEVICE_CAPS support to querycap and replace -EINVAL by -ENOTTY whenever an ioctl is not supported. Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/gspca.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/driver

[RFCv2 PATCH 12/17] gscpa_zc3xx: Disable the highest quality setting as it is not usable

From: Hans de Goede Even with BRC the highest quality setting is not usable, BRC strips so much data from each MCU that the quality becomes worse then using a lower quality setting to begin with. Signed-off-by: Hans de Goede Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/zc3xx.c |

[RFCv2 PATCH 15/17] gcpca-sn9c20x: convert to the control framework.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/sn9c20x.c | 493 +++ 1 file changed, 210 insertions(+), 283 deletions(-) diff --git a/drivers/media/video/gspca/sn9c20x.c b/drivers/media/video/gspca/sn9c20x.c index 5285a51..81d75db

[RFCv2 PATCH 17/17] gspca-mars: convert to the control framework.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/mars.c | 292 -- 1 file changed, 126 insertions(+), 166 deletions(-) diff --git a/drivers/media/video/gspca/mars.c b/drivers/media/video/gspca/mars.c index b023146..b1a1fec 100644

[RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

From: Hans Verkuil Due to latency concerns the VIDIOC_QBUF, DQBUF and QUERYBUF do not use the core lock, instead they rely only on queue_lock. Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/gspca.c | 203 - 1 file changed, 41 insertions(+), 162 d

[RFCv2 PATCH 03/17] gspca: allow subdrivers to use the control framework.

From: Hans Verkuil Make the necessary changes to allow subdrivers to use the control framework. This does not add control event support, that comes later. It add a init_control cam_op that is called after init in probe that allows the subdriver to set up the controls. Signed-off-by: Hans Verkui

[RFCv2 PATCH 16/17] gspca-stv06xx: convert to the control framework.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/stv06xx/stv06xx.c| 24 +- drivers/media/video/gspca/stv06xx/stv06xx.h|4 + drivers/media/video/gspca/stv06xx/stv06xx_hdcs.c | 140 ++-- drivers/media/video/gspca/stv06xx/stv06xx_hdcs.h |

[RFCv2 PATCH 04/17] gspca: use video_drvdata(file) instead of file->private_data.

From: Hans Verkuil Prepare for control events: free up file->private_data by using video_drvdata(file) to get to the gspca_dev struct. Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/gspca.c | 64 ++--- 1 file changed, 31 insertions(+), 33 deletions(

[RFCv2 PATCH 06/17] gspca: add support for control events.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/gspca.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 1d76504..b2ddfc6 100644 --- a/drivers/media/video/gspca/gspca.c +++ b/driv

[RFCv2 PATCH 14/17] gspca-zc3xx: convert to the control framework.

From: Hans Verkuil The initial version was done by HV, corrections were made by HdG, and some final small changes again by HV. Signed-off-by: Hans Verkuil Signed-off-by: Hans de Goede --- drivers/media/video/gspca/zc3xx.c | 441 +++-- 1 file changed, 172 inser

[RFCv2 PATCH 05/17] gscpa: use v4l2_fh and add G/S_PRIORITY support.

From: Hans Verkuil In order to support control event gspca has to use struct v4l2_fh. As a bonus feature this also gives priority handling for free. Signed-off-by: Hans Verkuil --- drivers/media/video/gspca/gspca.c | 13 ++--- drivers/media/video/gspca/gspca.h |2 ++ 2 files chan

[RFCv2 PATCH 09/17] gspca_zc3xx: Fix setting of jpeg quality while streaming

From: Hans de Goede When the user changes the JPEG quality while the camera is streaming, the driver should not only change the JPEG headers send to userspace, but also actually tell the camera to use a different quantization table. Signed-off-by: Hans de Goede Signed-off-by: Hans Verkuil ---

[RFCv2 PATCH 02/17] v4l2-framework.txt: add paragraph on driver locking and the control framework.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- Documentation/video4linux/v4l2-framework.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/video4linux/v4l2-framework.txt b/Documentation/video4linux/v4l2-framework.txt index 4a313d8..2d7dd86 100644 --- a/Documen

[RFCv2 PATCH 08/17] gspca: fix locking issues related to suspend/resume.

From: Hans Verkuil There are two bugs here: first the calls to stop0 (in gspca_suspend) and gspca_init_transfer (in gspca_resume) need to be called with the usb_lock held. That's true for the other places they are called and it is what subdrivers expect. Quite a few will unlock the usb_lock in st

[RFCv2 PATCH 00/17] gspca: allow use of control framework and other fixes

Hi all, Here is my second version of this patch series. Thanks to Hans de Goede for his help. Changes since v1: - HdG provided some patches that fix zc3xx-related jpeg problems - controls are now initialized in a new cam_op: init_controls - converted the stv06xx and mars drivers as well - switc

Problems with USBTVTunner Gadmei UTV380New [id=1f71:3301]

Model = Gadmei UTV380New Vendor/ProductID = 1f71:3301 Test = - I follow instruction on link http://www.linuxtv.org/wiki/index.php?title=Gadmei_USB_TVBox_UTV380 - I change "SB_DEVICE(0xeb1a, 0x50a3)" with "SB_DEVICE(0x1f71, 0x3301)" - after i compile ("make distsclean", "make menuconfig", "make", a

[PATCH v2 3/3] gspca - ov534: Add Hue control

Signed-off-by: Antonio Ospite --- Changes since version 1: - Disabled the HUE control for SENSOR_OV767x drivers/media/video/gspca/ov534.c | 65 +++-- 1 file changed, 63 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/gspca/ov534.c b/drivers/

[PATCH v2 2/3] Input: move drivers/input/fixp-arith.h to include/linux

Move drivers/input/fixp-arith.h to include/linux so that the functions defined there can be used by other subsystems, for instance some video devices ISPs can control the output HUE value by setting registers for sin(HUE) and cos(HUE). Signed-off-by: Antonio Ospite Acked-by: Dmitry Torokhov ---

[PATCH v2 1/3] gspca - ov534: Add Saturation control

Also merge the "COLORS" control into it as it was V4L2_CID_SATURATION anyway. Signed-off-by: Antonio Ospite --- Changes since version 1: - Merged SATURATION and COLORS controls drivers/media/video/gspca/ov534.c | 83 - 1 file changed, 45 insertions(+),

[PATCH v2 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

Hi, I am sending a second version of this patchset, changes since version 1 are annotated per-patch. Just FYI I intend to work on porting ov534 to v4l2 framework too once these ones go in and the gspca core changes about that settle a bit. Thanks, Antonio Antonio Ospite (3): gspca - ov534: